Merge branch 'pm-freezer' into pm-sleep

* pm-freezer: (26 commits)
  Freezer / sunrpc / NFS: don't allow TASK_KILLABLE sleeps to block the freezer
  Freezer: fix more fallout from the thaw_process rename
  freezer: fix wait_event_freezable/__thaw_task races
  freezer: kill unused set_freezable_with_signal()
  dmatest: don't use set_freezable_with_signal()
  usb_storage: don't use set_freezable_with_signal()
  freezer: remove unused @sig_only from freeze_task()
  freezer: use lock_task_sighand() in fake_signal_wake_up()
  freezer: restructure __refrigerator()
  freezer: fix set_freezable[_with_signal]() race
  freezer: remove should_send_signal() and update frozen()
  freezer: remove now unused TIF_FREEZE
  freezer: make freezing() test freeze conditions in effect instead of TIF_FREEZE
  cgroup_freezer: prepare for removal of TIF_FREEZE
  freezer: clean up freeze_processes() failure path
  freezer: kill PF_FREEZING
  freezer: test freezable conditions while holding freezer_lock
  freezer: make freezing indicate freeze condition in effect
  freezer: use dedicated lock instead of task_lock() + memory barrier
  freezer: don't distinguish nosig tasks on thaw
  ...

7 files changed, 41 insertions, 41 deletions

diff --git a/drivers/bluetooth/btmrvl_main.c b/drivers/bluetooth/btmrvl_main.c
index a88a78c86162..6c3defa50845 100644
--- a/drivers/bluetooth/btmrvl_main.c
+++ b/drivers/bluetooth/btmrvl_main.c
@@ -475,8 +475,6 @@ static int btmrvl_service_main_thread(void *data)
 
         init_waitqueue_entry(&wait, current);
 
-        current->flags |= PF_NOFREEZE;
-
         for (;;) {
                 add_wait_queue(&thread->wait_q, &wait);
 
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index eb1d8641cf5c..2b8661b54eaf 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -214,9 +214,18 @@ static unsigned int dmatest_verify(u8 **bufs, unsigned int start,
         return error_count;
 }
 
-static void dmatest_callback(void *completion)
+/* poor man's completion - we want to use wait_event_freezable() on it */
+struct dmatest_done {
+        bool                    done;
+        wait_queue_head_t       *wait;
+};
+
+static void dmatest_callback(void *arg)
 {
-        complete(completion);
+        struct dmatest_done *done = arg;
+
+        done->done = true;
+        wake_up_all(done->wait);
 }
 
 /*
@@ -235,7 +244,9 @@ static void dmatest_callback(void *completion)
  */
 static int dmatest_func(void *data)
 {
+        DECLARE_WAIT_QUEUE_HEAD_ONSTACK(done_wait);
         struct dmatest_thread   *thread = data;
+        struct dmatest_done     done = { .wait = &done_wait };
         struct dma_chan         *chan;
         const char              *thread_name;
         unsigned int            src_off, dst_off, len;
@@ -252,7 +263,7 @@ static int dmatest_func(void *data)
         int                     i;
 
         thread_name = current->comm;
-        set_freezable_with_signal();
+        set_freezable();
 
         ret = -ENOMEM;
 
@@ -306,9 +317,6 @@ static int dmatest_func(void *data)
                 struct dma_async_tx_descriptor *tx = NULL;
                 dma_addr_t dma_srcs[src_cnt];
                 dma_addr_t dma_dsts[dst_cnt];
-                struct completion cmp;
-                unsigned long start, tmo, end = 0 /* compiler... */;
-                bool reload = true;
                 u8 align = 0;
 
                 total_tests++;
@@ -391,9 +399,9 @@ static int dmatest_func(void *data)
                         continue;
                 }
 
-                init_completion(&cmp);
+                done.done = false;
                 tx->callback = dmatest_callback;
-                tx->callback_param = &cmp;
+                tx->callback_param = &done;
                 cookie = tx->tx_submit(tx);
 
                 if (dma_submit_error(cookie)) {
@@ -407,20 +415,20 @@ static int dmatest_func(void *data)
                 }
                 dma_async_issue_pending(chan);
 
-                do {
-                        start = jiffies;
-                        if (reload)
-                                end = start + msecs_to_jiffies(timeout);
-                        else if (end <= start)
-                                end = start + 1;
-                        tmo = wait_for_completion_interruptible_timeout(&cmp,
-                                                                end - start);
-                        reload = try_to_freeze();
-                } while (tmo == -ERESTARTSYS);
+                wait_event_freezable_timeout(done_wait, done.done,
+                                             msecs_to_jiffies(timeout));
 
                 status = dma_async_is_tx_complete(chan, cookie, NULL, NULL);
 
-                if (tmo == 0) {
+                if (!done.done) {
+                        /*
+                         * We're leaving the timed out dma operation with
+                         * dangling pointer to done_wait.  To make this
+                         * correct, we'll need to allocate wait_done for
+                         * each test iteration and perform "who's gonna
+                         * free it this time?" dancing.  For now, just
+                         * leave it dangling.
+                         */
                         pr_warning("%s: #%u: test timed out\n",
                                    thread_name, total_tests - 1);
                         failed_tests++;
diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c
index 3eee45ffb096..c6b456ad7342 100644
--- a/drivers/mfd/twl6030-irq.c
+++ b/drivers/mfd/twl6030-irq.c
@@ -138,8 +138,6 @@ static int twl6030_irq_thread(void *data)
         static const unsigned max_i2c_errors = 100;
         int ret;
 
-        current->flags |= PF_NOFREEZE;
-
         while (!kthread_should_stop()) {
                 int i;
                 union {
diff --git a/drivers/net/irda/stir4200.c b/drivers/net/irda/stir4200.c
index 41c96b3d8152..e880c79d7bd8 100644
--- a/drivers/net/irda/stir4200.c
+++ b/drivers/net/irda/stir4200.c
@@ -750,7 +750,7 @@ static int stir_transmit_thread(void *arg)
 
                         write_reg(stir, REG_CTRL1, CTRL1_TXPWD|CTRL1_RXPWD);
 
-                        refrigerator();
+                        try_to_freeze();
 
                         if (change_speed(stir, stir->speed))
                                 break;
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 7b828680b21d..4b11fc91fa7d 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -2456,8 +2456,9 @@ static int hotkey_kthread(void *data)
         u32 poll_mask, event_mask;
         unsigned int si, so;
         unsigned long t;
-        unsigned int change_detector, must_reset;
+        unsigned int change_detector;
         unsigned int poll_freq;
+        bool was_frozen;
 
         mutex_lock(&hotkey_thread_mutex);
 
@@ -2488,14 +2489,14 @@ static int hotkey_kthread(void *data)
                                 t = 100;        /* should never happen... */
                 }
                 t = msleep_interruptible(t);
-                if (unlikely(kthread_should_stop()))
+                if (unlikely(kthread_freezable_should_stop(&was_frozen)))
                         break;
-                must_reset = try_to_freeze();
-                if (t > 0 && !must_reset)
+
+                if (t > 0 && !was_frozen)
                         continue;
 
                 mutex_lock(&hotkey_thread_data_mutex);
-                if (must_reset || hotkey_config_change != change_detector) {
+                if (was_frozen || hotkey_config_change != change_detector) {
                         /* forget old state on thaw or config change */
                         si = so;
                         t = 0;
@@ -2528,10 +2529,6 @@ exit:
 static void hotkey_poll_stop_sync(void)
 {
         if (tpacpi_hotkey_task) {
-                if (frozen(tpacpi_hotkey_task) ||
-                    freezing(tpacpi_hotkey_task))
-                        thaw_process(tpacpi_hotkey_task);
-
                 kthread_stop(tpacpi_hotkey_task);
                 tpacpi_hotkey_task = NULL;
                 mutex_lock(&hotkey_thread_mutex);
diff --git a/drivers/staging/rts_pstor/rtsx.c b/drivers/staging/rts_pstor/rtsx.c
index 480b0ed2e4de..8a7803cf88d2 100644
--- a/drivers/staging/rts_pstor/rtsx.c
+++ b/drivers/staging/rts_pstor/rtsx.c
@@ -466,8 +466,6 @@ static int rtsx_control_thread(void *__dev)
         struct rtsx_chip *chip = dev->chip;
         struct Scsi_Host *host = rtsx_to_host(dev);
 
-        current->flags |= PF_NOFREEZE;
-
         for (;;) {
                 if (wait_for_completion_interruptible(&dev->cmnd_ready))
                         break;
diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
index c325e69415a1..aa84b3d77274 100644
--- a/drivers/usb/storage/usb.c
+++ b/drivers/usb/storage/usb.c
@@ -831,7 +831,8 @@ static int usb_stor_scan_thread(void * __us)
 
         dev_dbg(dev, "device found\n");
 
-        set_freezable_with_signal();
+        set_freezable();
+
         /*
          * Wait for the timeout to expire or for a disconnect
          *
@@ -839,16 +840,16 @@ static int usb_stor_scan_thread(void * __us)
          * fail to freeze, but we can't be non-freezable either. Nor can
          * khubd freeze while waiting for scanning to complete as it may
          * hold the device lock, causing a hang when suspending devices.
-         * So we request a fake signal when freezing and use
-         * interruptible sleep to kick us out of our wait early when
-         * freezing happens.
+         * So instead of using wait_event_freezable(), explicitly test
+         * for (DONT_SCAN || freezing) in interruptible wait and proceed
+         * if any of DONT_SCAN, freezing or timeout has happened.
          */
         if (delay_use > 0) {
                 dev_dbg(dev, "waiting for device to settle "
                                 "before scanning\n");
                 wait_event_interruptible_timeout(us->delay_wait,
-                                test_bit(US_FLIDX_DONT_SCAN, &us->dflags),
-                                delay_use * HZ);
+                                test_bit(US_FLIDX_DONT_SCAN, &us->dflags) ||
+                                freezing(current), delay_use * HZ);
         }
 
         /* If the device is still connected, perform the scanning */