diff options
author | Matthew Wilcox <matthew@wil.cx> | 2007-09-25 12:42:01 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.localdomain> | 2007-10-12 14:52:04 -0400 |
commit | cce99c6925b8d6a59cf584411277c1c20c330334 (patch) | |
tree | 513504b6a22be6cc9b7d6689cccb2a48ee6dd4cd /drivers | |
parent | 1d0c7c8dcf289557f13b6b0f6d71b6a03b12b747 (diff) |
[SCSI] Fix mistaken uses of ->done
All these drivers meant to call ->scsi_done() but got confused.
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/scsi/NCR5380.c | 8 | ||||
-rw-r--r-- | drivers/scsi/NCR53C9x.c | 2 | ||||
-rw-r--r-- | drivers/scsi/atari_NCR5380.c | 4 | ||||
-rw-r--r-- | drivers/scsi/sun3_NCR5380.c | 4 |
4 files changed, 9 insertions, 9 deletions
diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c index f8e449a98d29..5b27966d37f0 100644 --- a/drivers/scsi/NCR5380.c +++ b/drivers/scsi/NCR5380.c | |||
@@ -2133,7 +2133,7 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance) { | |||
2133 | sink = 1; | 2133 | sink = 1; |
2134 | do_abort(instance); | 2134 | do_abort(instance); |
2135 | cmd->result = DID_ERROR << 16; | 2135 | cmd->result = DID_ERROR << 16; |
2136 | cmd->done(cmd); | 2136 | cmd->scsi_done(cmd); |
2137 | return; | 2137 | return; |
2138 | #endif | 2138 | #endif |
2139 | /* | 2139 | /* |
@@ -2196,7 +2196,7 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance) { | |||
2196 | sink = 1; | 2196 | sink = 1; |
2197 | do_abort(instance); | 2197 | do_abort(instance); |
2198 | cmd->result = DID_ERROR << 16; | 2198 | cmd->result = DID_ERROR << 16; |
2199 | cmd->done(cmd); | 2199 | cmd->scsi_done(cmd); |
2200 | /* XXX - need to source or sink data here, as appropriate */ | 2200 | /* XXX - need to source or sink data here, as appropriate */ |
2201 | } else | 2201 | } else |
2202 | cmd->SCp.this_residual -= transfersize - len; | 2202 | cmd->SCp.this_residual -= transfersize - len; |
@@ -2740,7 +2740,7 @@ static int NCR5380_abort(Scsi_Cmnd * cmd) { | |||
2740 | tmp->host_scribble = NULL; | 2740 | tmp->host_scribble = NULL; |
2741 | tmp->result = DID_ABORT << 16; | 2741 | tmp->result = DID_ABORT << 16; |
2742 | dprintk(NDEBUG_ABORT, ("scsi%d : abort removed command from issue queue.\n", instance->host_no)); | 2742 | dprintk(NDEBUG_ABORT, ("scsi%d : abort removed command from issue queue.\n", instance->host_no)); |
2743 | tmp->done(tmp); | 2743 | tmp->scsi_done(tmp); |
2744 | return SUCCESS; | 2744 | return SUCCESS; |
2745 | } | 2745 | } |
2746 | #if (NDEBUG & NDEBUG_ABORT) | 2746 | #if (NDEBUG & NDEBUG_ABORT) |
@@ -2805,7 +2805,7 @@ static int NCR5380_abort(Scsi_Cmnd * cmd) { | |||
2805 | *prev = (Scsi_Cmnd *) tmp->host_scribble; | 2805 | *prev = (Scsi_Cmnd *) tmp->host_scribble; |
2806 | tmp->host_scribble = NULL; | 2806 | tmp->host_scribble = NULL; |
2807 | tmp->result = DID_ABORT << 16; | 2807 | tmp->result = DID_ABORT << 16; |
2808 | tmp->done(tmp); | 2808 | tmp->scsi_done(tmp); |
2809 | return SUCCESS; | 2809 | return SUCCESS; |
2810 | } | 2810 | } |
2811 | } | 2811 | } |
diff --git a/drivers/scsi/NCR53C9x.c b/drivers/scsi/NCR53C9x.c index 79b4df158140..96e8e29aa05d 100644 --- a/drivers/scsi/NCR53C9x.c +++ b/drivers/scsi/NCR53C9x.c | |||
@@ -1385,7 +1385,7 @@ int esp_abort(Scsi_Cmnd *SCptr) | |||
1385 | this->host_scribble = NULL; | 1385 | this->host_scribble = NULL; |
1386 | esp_release_dmabufs(esp, this); | 1386 | esp_release_dmabufs(esp, this); |
1387 | this->result = DID_ABORT << 16; | 1387 | this->result = DID_ABORT << 16; |
1388 | this->done(this); | 1388 | this->scsi_done(this); |
1389 | if(don) | 1389 | if(don) |
1390 | esp->dma_ints_on(esp); | 1390 | esp->dma_ints_on(esp); |
1391 | return SUCCESS; | 1391 | return SUCCESS; |
diff --git a/drivers/scsi/atari_NCR5380.c b/drivers/scsi/atari_NCR5380.c index 03dbe60c264a..743df4c20cf4 100644 --- a/drivers/scsi/atari_NCR5380.c +++ b/drivers/scsi/atari_NCR5380.c | |||
@@ -2041,7 +2041,7 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance) | |||
2041 | sink = 1; | 2041 | sink = 1; |
2042 | do_abort(instance); | 2042 | do_abort(instance); |
2043 | cmd->result = DID_ERROR << 16; | 2043 | cmd->result = DID_ERROR << 16; |
2044 | cmd->done(cmd); | 2044 | cmd->scsi_done(cmd); |
2045 | return; | 2045 | return; |
2046 | #endif | 2046 | #endif |
2047 | case PHASE_DATAIN: | 2047 | case PHASE_DATAIN: |
@@ -2100,7 +2100,7 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance) | |||
2100 | sink = 1; | 2100 | sink = 1; |
2101 | do_abort(instance); | 2101 | do_abort(instance); |
2102 | cmd->result = DID_ERROR << 16; | 2102 | cmd->result = DID_ERROR << 16; |
2103 | cmd->done(cmd); | 2103 | cmd->scsi_done(cmd); |
2104 | /* XXX - need to source or sink data here, as appropriate */ | 2104 | /* XXX - need to source or sink data here, as appropriate */ |
2105 | } else { | 2105 | } else { |
2106 | #ifdef REAL_DMA | 2106 | #ifdef REAL_DMA |
diff --git a/drivers/scsi/sun3_NCR5380.c b/drivers/scsi/sun3_NCR5380.c index 98e3fe10c1dc..376953776ea3 100644 --- a/drivers/scsi/sun3_NCR5380.c +++ b/drivers/scsi/sun3_NCR5380.c | |||
@@ -2055,7 +2055,7 @@ static void NCR5380_information_transfer (struct Scsi_Host *instance) | |||
2055 | sink = 1; | 2055 | sink = 1; |
2056 | do_abort(instance); | 2056 | do_abort(instance); |
2057 | cmd->result = DID_ERROR << 16; | 2057 | cmd->result = DID_ERROR << 16; |
2058 | cmd->done(cmd); | 2058 | cmd->scsi_done(cmd); |
2059 | return; | 2059 | return; |
2060 | #endif | 2060 | #endif |
2061 | case PHASE_DATAIN: | 2061 | case PHASE_DATAIN: |
@@ -2115,7 +2115,7 @@ static void NCR5380_information_transfer (struct Scsi_Host *instance) | |||
2115 | sink = 1; | 2115 | sink = 1; |
2116 | do_abort(instance); | 2116 | do_abort(instance); |
2117 | cmd->result = DID_ERROR << 16; | 2117 | cmd->result = DID_ERROR << 16; |
2118 | cmd->done(cmd); | 2118 | cmd->scsi_done(cmd); |
2119 | /* XXX - need to source or sink data here, as appropriate */ | 2119 | /* XXX - need to source or sink data here, as appropriate */ |
2120 | } else { | 2120 | } else { |
2121 | #ifdef REAL_DMA | 2121 | #ifdef REAL_DMA |