diff options
author | Timur Tabi <timur@freescale.com> | 2011-09-15 17:44:56 -0400 |
---|---|---|
committer | Florian Tobias Schandinat <FlorianSchandinat@gmx.de> | 2011-09-18 16:08:57 -0400 |
commit | 3f78bbd1a256e04dfb486dbee0430e0ecad6d960 (patch) | |
tree | 7e9846f54d59389f0a8afb4c331ae81ce14c6a88 /drivers | |
parent | 589c797193547b12c34f80048440bc1cac242fec (diff) |
drivers/video: fsl-diu-fb: use a normal for-loop to uninstall framebuffers
Uninstalling the framebuffers in reverse order is unnecessary and makes
the for-loop awkward.
Signed-off-by: Timur Tabi <timur@freescale.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/video/fsl-diu-fb.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c index c66f6ed57886..5137fbb6295f 100644 --- a/drivers/video/fsl-diu-fb.c +++ b/drivers/video/fsl-diu-fb.c | |||
@@ -1543,9 +1543,9 @@ static int __devinit fsl_diu_probe(struct platform_device *pdev) | |||
1543 | return 0; | 1543 | return 0; |
1544 | 1544 | ||
1545 | error: | 1545 | error: |
1546 | for (i = ARRAY_SIZE(machine_data->fsl_diu_info); | 1546 | for (i = 0; i < ARRAY_SIZE(machine_data->fsl_diu_info); i++) |
1547 | i > 0; i--) | 1547 | uninstall_fb(machine_data->fsl_diu_info[i]); |
1548 | uninstall_fb(machine_data->fsl_diu_info[i - 1]); | 1548 | |
1549 | if (pool.ad.vaddr) | 1549 | if (pool.ad.vaddr) |
1550 | free_buf(&pdev->dev, &pool.ad, | 1550 | free_buf(&pdev->dev, &pool.ad, |
1551 | sizeof(struct diu_ad) * FSL_AOI_NUM, 8); | 1551 | sizeof(struct diu_ad) * FSL_AOI_NUM, 8); |
@@ -1575,8 +1575,8 @@ static int fsl_diu_remove(struct platform_device *pdev) | |||
1575 | machine_data = dev_get_drvdata(&pdev->dev); | 1575 | machine_data = dev_get_drvdata(&pdev->dev); |
1576 | disable_lcdc(machine_data->fsl_diu_info[0]); | 1576 | disable_lcdc(machine_data->fsl_diu_info[0]); |
1577 | free_irq_local(machine_data->irq); | 1577 | free_irq_local(machine_data->irq); |
1578 | for (i = ARRAY_SIZE(machine_data->fsl_diu_info); i > 0; i--) | 1578 | for (i = 0; i < ARRAY_SIZE(machine_data->fsl_diu_info); i++) |
1579 | uninstall_fb(machine_data->fsl_diu_info[i - 1]); | 1579 | uninstall_fb(machine_data->fsl_diu_info[i]); |
1580 | if (pool.ad.vaddr) | 1580 | if (pool.ad.vaddr) |
1581 | free_buf(&pdev->dev, &pool.ad, | 1581 | free_buf(&pdev->dev, &pool.ad, |
1582 | sizeof(struct diu_ad) * FSL_AOI_NUM, 8); | 1582 | sizeof(struct diu_ad) * FSL_AOI_NUM, 8); |