diff options
author | Brad Campbell <brad@wasp.net.au> | 2005-05-12 15:07:47 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2005-05-12 15:07:47 -0400 |
commit | 6f2f38128170814e151cfedf79532e19cd179567 (patch) | |
tree | 6728b987c6d4199c4d03335407f5b55859b34a86 /drivers | |
parent | 88d7bd8cb9eb8d64bf7997600b0d64f7834047c5 (diff) |
[PATCH] libata basic detection and errata for PATA->SATA bridges
This patch works around an issue with WD drives (and possibly others)
over SiL PATA->SATA Bridges on SATA controllers locking up with
transfers > 200 sectors.
Signed-off-by: Brad Campbell <brad@wasp.net.au>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/scsi/libata-core.c | 35 |
1 files changed, 33 insertions, 2 deletions
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c index 0b5d3a5b7eda..8b5a3f00083d 100644 --- a/drivers/scsi/libata-core.c +++ b/drivers/scsi/libata-core.c | |||
@@ -1186,6 +1186,37 @@ err_out: | |||
1186 | DPRINTK("EXIT, err\n"); | 1186 | DPRINTK("EXIT, err\n"); |
1187 | } | 1187 | } |
1188 | 1188 | ||
1189 | |||
1190 | static inline u8 ata_dev_knobble(struct ata_port *ap) | ||
1191 | { | ||
1192 | return ((ap->cbl == ATA_CBL_SATA) && (!ata_id_is_sata(ap->device->id))); | ||
1193 | } | ||
1194 | |||
1195 | /** | ||
1196 | * ata_dev_config - Run device specific handlers and check for | ||
1197 | * SATA->PATA bridges | ||
1198 | * @ap: Bus | ||
1199 | * @i: Device | ||
1200 | * | ||
1201 | * LOCKING: | ||
1202 | */ | ||
1203 | |||
1204 | void ata_dev_config(struct ata_port *ap, unsigned int i) | ||
1205 | { | ||
1206 | /* limit bridge transfers to udma5, 200 sectors */ | ||
1207 | if (ata_dev_knobble(ap)) { | ||
1208 | printk(KERN_INFO "ata%u(%u): applying bridge limits\n", | ||
1209 | ap->id, ap->device->devno); | ||
1210 | ap->udma_mask &= ATA_UDMA5; | ||
1211 | ap->host->max_sectors = ATA_MAX_SECTORS; | ||
1212 | ap->host->hostt->max_sectors = ATA_MAX_SECTORS; | ||
1213 | ap->device->flags |= ATA_DFLAG_LOCK_SECTORS; | ||
1214 | } | ||
1215 | |||
1216 | if (ap->ops->dev_config) | ||
1217 | ap->ops->dev_config(ap, &ap->device[i]); | ||
1218 | } | ||
1219 | |||
1189 | /** | 1220 | /** |
1190 | * ata_bus_probe - Reset and probe ATA bus | 1221 | * ata_bus_probe - Reset and probe ATA bus |
1191 | * @ap: Bus to probe | 1222 | * @ap: Bus to probe |
@@ -1208,8 +1239,7 @@ static int ata_bus_probe(struct ata_port *ap) | |||
1208 | ata_dev_identify(ap, i); | 1239 | ata_dev_identify(ap, i); |
1209 | if (ata_dev_present(&ap->device[i])) { | 1240 | if (ata_dev_present(&ap->device[i])) { |
1210 | found = 1; | 1241 | found = 1; |
1211 | if (ap->ops->dev_config) | 1242 | ata_dev_config(ap,i); |
1212 | ap->ops->dev_config(ap, &ap->device[i]); | ||
1213 | } | 1243 | } |
1214 | } | 1244 | } |
1215 | 1245 | ||
@@ -4014,6 +4044,7 @@ EXPORT_SYMBOL_GPL(ata_scsi_release); | |||
4014 | EXPORT_SYMBOL_GPL(ata_host_intr); | 4044 | EXPORT_SYMBOL_GPL(ata_host_intr); |
4015 | EXPORT_SYMBOL_GPL(ata_dev_classify); | 4045 | EXPORT_SYMBOL_GPL(ata_dev_classify); |
4016 | EXPORT_SYMBOL_GPL(ata_dev_id_string); | 4046 | EXPORT_SYMBOL_GPL(ata_dev_id_string); |
4047 | EXPORT_SYMBOL_GPL(ata_dev_config); | ||
4017 | EXPORT_SYMBOL_GPL(ata_scsi_simulate); | 4048 | EXPORT_SYMBOL_GPL(ata_scsi_simulate); |
4018 | 4049 | ||
4019 | #ifdef CONFIG_PCI | 4050 | #ifdef CONFIG_PCI |