aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorAndrew Morton <akpm@linux-foundation.org>2010-10-01 07:17:12 -0400
committerDavid S. Miller <davem@davemloft.net>2010-10-04 00:59:39 -0400
commitf009627b71eacfeede3d63b00a25afdf5e3e24bb (patch)
treef33811de741c906840b856d49cb2b92e2cce3180 /drivers
parenta8cb16dd9cb571c45bb479a1e4721ce11220a216 (diff)
drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes
ERROR: trailing statements should be on next line #23: FILE: drivers/net/tulip/de4x5.c:5477: + if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT; total: 1 errors, 0 warnings, 8 lines checked ./patches/drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Dan Rosenberg <dan.j.rosenberg@gmail.com> Cc: Grant Grundler <grundler@parisc-linux.org> Cc: Jeff Mahoney <jeffm@suse.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/tulip/de4x5.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/tulip/de4x5.c b/drivers/net/tulip/de4x5.c
index 251c6ce15aea..4dbd493b996b 100644
--- a/drivers/net/tulip/de4x5.c
+++ b/drivers/net/tulip/de4x5.c
@@ -5474,7 +5474,8 @@ de4x5_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
5474 tmp.lval[6] = inl(DE4X5_STRR); j+=4; 5474 tmp.lval[6] = inl(DE4X5_STRR); j+=4;
5475 tmp.lval[7] = inl(DE4X5_SIGR); j+=4; 5475 tmp.lval[7] = inl(DE4X5_SIGR); j+=4;
5476 ioc->len = j; 5476 ioc->len = j;
5477 if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT; 5477 if (copy_to_user(ioc->data, tmp.lval, ioc->len))
5478 return -EFAULT;
5478 break; 5479 break;
5479 5480
5480#define DE4X5_DUMP 0x0f /* Dump the DE4X5 Status */ 5481#define DE4X5_DUMP 0x0f /* Dump the DE4X5 Status */