diff options
author | Tobias Klauser <tklauser@distanz.ch> | 2009-09-18 03:14:46 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-10-09 16:52:07 -0400 |
commit | d86a83f4acbded4095a632e861183d117ec7405a (patch) | |
tree | 2c0bb415c03edcb9452e04b094c3b6f820a50a74 /drivers | |
parent | 2f13612a86dd785d581e29aed4db2fb98ba507ca (diff) |
USB: gadget: imx_udc: Use resource size
Use the resource_size function instead of manually calculating the
resource size. This reduces the chance of introducing off-by-one errors.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/usb/gadget/imx_udc.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/usb/gadget/imx_udc.c b/drivers/usb/gadget/imx_udc.c index c52a681f376c..01ee0b9bc957 100644 --- a/drivers/usb/gadget/imx_udc.c +++ b/drivers/usb/gadget/imx_udc.c | |||
@@ -1402,7 +1402,8 @@ static int __init imx_udc_probe(struct platform_device *pdev) | |||
1402 | struct clk *clk; | 1402 | struct clk *clk; |
1403 | void __iomem *base; | 1403 | void __iomem *base; |
1404 | int ret = 0; | 1404 | int ret = 0; |
1405 | int i, res_size; | 1405 | int i; |
1406 | resource_size_t res_size; | ||
1406 | 1407 | ||
1407 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); | 1408 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
1408 | if (!res) { | 1409 | if (!res) { |
@@ -1416,7 +1417,7 @@ static int __init imx_udc_probe(struct platform_device *pdev) | |||
1416 | return -ENODEV; | 1417 | return -ENODEV; |
1417 | } | 1418 | } |
1418 | 1419 | ||
1419 | res_size = res->end - res->start + 1; | 1420 | res_size = resource_size(res); |
1420 | if (!request_mem_region(res->start, res_size, res->name)) { | 1421 | if (!request_mem_region(res->start, res_size, res->name)) { |
1421 | dev_err(&pdev->dev, "can't allocate %d bytes at %d address\n", | 1422 | dev_err(&pdev->dev, "can't allocate %d bytes at %d address\n", |
1422 | res_size, res->start); | 1423 | res_size, res->start); |
@@ -1527,8 +1528,7 @@ static int __exit imx_udc_remove(struct platform_device *pdev) | |||
1527 | clk_disable(imx_usb->clk); | 1528 | clk_disable(imx_usb->clk); |
1528 | iounmap(imx_usb->base); | 1529 | iounmap(imx_usb->base); |
1529 | 1530 | ||
1530 | release_mem_region(imx_usb->res->start, | 1531 | release_mem_region(imx_usb->res->start, resource_size(imx_usb->res)); |
1531 | imx_usb->res->end - imx_usb->res->start + 1); | ||
1532 | 1532 | ||
1533 | if (pdata->exit) | 1533 | if (pdata->exit) |
1534 | pdata->exit(&pdev->dev); | 1534 | pdata->exit(&pdev->dev); |