diff options
author | Tejun Heo <tj@kernel.org> | 2011-04-21 14:54:46 -0400 |
---|---|---|
committer | Jens Axboe <jaxboe@fusionio.com> | 2011-04-21 14:54:46 -0400 |
commit | d4dc210f69bcb0b4bef5a83b1c323817be89bad1 (patch) | |
tree | 58774a27fa6faff1260a416a86d2c121f0013431 /drivers | |
parent | 1196f8b814f32cd04df334abf47648c2a9fd8324 (diff) |
block: don't block events on excl write for non-optical devices
Disk event code automatically blocks events on excl write. This is
primarily to avoid issuing polling commands while burning is in
progress. This behavior doesn't fit other types of devices with
removeable media where polling commands don't have adverse side
effects and door locking usually doesn't exist.
This patch introduces new genhd flag which controls the auto-blocking
behavior and uses it to enable auto-blocking only on optical devices.
Note for stable: 2.6.38 and later only
Cc: stable@kernel.org
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/block/paride/pcd.c | 1 | ||||
-rw-r--r-- | drivers/cdrom/viocd.c | 3 | ||||
-rw-r--r-- | drivers/ide/ide-cd.c | 2 | ||||
-rw-r--r-- | drivers/scsi/sr.c | 2 |
4 files changed, 5 insertions, 3 deletions
diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c index 2f2ccf686251..a0aabd904a51 100644 --- a/drivers/block/paride/pcd.c +++ b/drivers/block/paride/pcd.c | |||
@@ -320,6 +320,7 @@ static void pcd_init_units(void) | |||
320 | disk->first_minor = unit; | 320 | disk->first_minor = unit; |
321 | strcpy(disk->disk_name, cd->name); /* umm... */ | 321 | strcpy(disk->disk_name, cd->name); /* umm... */ |
322 | disk->fops = &pcd_bdops; | 322 | disk->fops = &pcd_bdops; |
323 | disk->flags = GENHD_FL_BLOCK_EVENTS_ON_EXCL_WRITE; | ||
323 | disk->events = DISK_EVENT_MEDIA_CHANGE; | 324 | disk->events = DISK_EVENT_MEDIA_CHANGE; |
324 | } | 325 | } |
325 | } | 326 | } |
diff --git a/drivers/cdrom/viocd.c b/drivers/cdrom/viocd.c index 4e874c5fa605..ae15a4ddaa9b 100644 --- a/drivers/cdrom/viocd.c +++ b/drivers/cdrom/viocd.c | |||
@@ -625,7 +625,8 @@ static int viocd_probe(struct vio_dev *vdev, const struct vio_device_id *id) | |||
625 | blk_queue_max_hw_sectors(q, 4096 / 512); | 625 | blk_queue_max_hw_sectors(q, 4096 / 512); |
626 | gendisk->queue = q; | 626 | gendisk->queue = q; |
627 | gendisk->fops = &viocd_fops; | 627 | gendisk->fops = &viocd_fops; |
628 | gendisk->flags = GENHD_FL_CD|GENHD_FL_REMOVABLE; | 628 | gendisk->flags = GENHD_FL_CD | GENHD_FL_REMOVABLE | |
629 | GENHD_FL_BLOCK_EVENTS_ON_EXCL_WRITE; | ||
629 | gendisk->events = DISK_EVENT_MEDIA_CHANGE; | 630 | gendisk->events = DISK_EVENT_MEDIA_CHANGE; |
630 | set_capacity(gendisk, 0); | 631 | set_capacity(gendisk, 0); |
631 | gendisk->private_data = d; | 632 | gendisk->private_data = d; |
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index fd1e11799137..6e5123b1d341 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c | |||
@@ -1781,7 +1781,7 @@ static int ide_cd_probe(ide_drive_t *drive) | |||
1781 | 1781 | ||
1782 | ide_cd_read_toc(drive, &sense); | 1782 | ide_cd_read_toc(drive, &sense); |
1783 | g->fops = &idecd_ops; | 1783 | g->fops = &idecd_ops; |
1784 | g->flags |= GENHD_FL_REMOVABLE; | 1784 | g->flags |= GENHD_FL_REMOVABLE | GENHD_FL_BLOCK_EVENTS_ON_EXCL_WRITE; |
1785 | g->events = DISK_EVENT_MEDIA_CHANGE; | 1785 | g->events = DISK_EVENT_MEDIA_CHANGE; |
1786 | add_disk(g); | 1786 | add_disk(g); |
1787 | return 0; | 1787 | return 0; |
diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c index 95019c747cc1..4778e2707168 100644 --- a/drivers/scsi/sr.c +++ b/drivers/scsi/sr.c | |||
@@ -636,7 +636,7 @@ static int sr_probe(struct device *dev) | |||
636 | disk->first_minor = minor; | 636 | disk->first_minor = minor; |
637 | sprintf(disk->disk_name, "sr%d", minor); | 637 | sprintf(disk->disk_name, "sr%d", minor); |
638 | disk->fops = &sr_bdops; | 638 | disk->fops = &sr_bdops; |
639 | disk->flags = GENHD_FL_CD; | 639 | disk->flags = GENHD_FL_CD | GENHD_FL_BLOCK_EVENTS_ON_EXCL_WRITE; |
640 | disk->events = DISK_EVENT_MEDIA_CHANGE | DISK_EVENT_EJECT_REQUEST; | 640 | disk->events = DISK_EVENT_MEDIA_CHANGE | DISK_EVENT_EJECT_REQUEST; |
641 | 641 | ||
642 | blk_queue_rq_timeout(sdev->request_queue, SR_TIMEOUT); | 642 | blk_queue_rq_timeout(sdev->request_queue, SR_TIMEOUT); |