aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorHeiko Carstens <heiko.carstens@de.ibm.com>2011-05-12 14:45:05 -0400
committerDavid S. Miller <davem@davemloft.net>2011-05-13 14:55:20 -0400
commit424f73b3ecc41367336ce75cc489c1e373c421fc (patch)
treecb9cc78e535f48295dce34cf0aa1de4e29c6e002 /drivers
parent38ed18ff5ed170a68f334c2362735c1268cec81b (diff)
lcs: get rid of compile warning
-Wunused-but-set-variable generates a compile warning for lcs' tasklet function. Invoked functions contain already error handling; thus additional return code checking is not needed here. Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/s390/net/lcs.c10
1 files changed, 3 insertions, 7 deletions
diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c
index 49d1cfc3217e..c3b8064a102d 100644
--- a/drivers/s390/net/lcs.c
+++ b/drivers/s390/net/lcs.c
@@ -1483,7 +1483,6 @@ lcs_tasklet(unsigned long data)
1483 struct lcs_channel *channel; 1483 struct lcs_channel *channel;
1484 struct lcs_buffer *iob; 1484 struct lcs_buffer *iob;
1485 int buf_idx; 1485 int buf_idx;
1486 int rc;
1487 1486
1488 channel = (struct lcs_channel *) data; 1487 channel = (struct lcs_channel *) data;
1489 LCS_DBF_TEXT_(5, trace, "tlet%s", dev_name(&channel->ccwdev->dev)); 1488 LCS_DBF_TEXT_(5, trace, "tlet%s", dev_name(&channel->ccwdev->dev));
@@ -1500,14 +1499,11 @@ lcs_tasklet(unsigned long data)
1500 channel->buf_idx = buf_idx; 1499 channel->buf_idx = buf_idx;
1501 1500
1502 if (channel->state == LCS_CH_STATE_STOPPED) 1501 if (channel->state == LCS_CH_STATE_STOPPED)
1503 // FIXME: what if rc != 0 ?? 1502 lcs_start_channel(channel);
1504 rc = lcs_start_channel(channel);
1505 spin_lock_irqsave(get_ccwdev_lock(channel->ccwdev), flags); 1503 spin_lock_irqsave(get_ccwdev_lock(channel->ccwdev), flags);
1506 if (channel->state == LCS_CH_STATE_SUSPENDED && 1504 if (channel->state == LCS_CH_STATE_SUSPENDED &&
1507 channel->iob[channel->io_idx].state == LCS_BUF_STATE_READY) { 1505 channel->iob[channel->io_idx].state == LCS_BUF_STATE_READY)
1508 // FIXME: what if rc != 0 ?? 1506 __lcs_resume_channel(channel);
1509 rc = __lcs_resume_channel(channel);
1510 }
1511 spin_unlock_irqrestore(get_ccwdev_lock(channel->ccwdev), flags); 1507 spin_unlock_irqrestore(get_ccwdev_lock(channel->ccwdev), flags);
1512 1508
1513 /* Something happened on the channel. Wake up waiters. */ 1509 /* Something happened on the channel. Wake up waiters. */