diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2009-04-30 17:43:31 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-06-16 00:30:26 -0400 |
commit | fcb5207723919ad85178420633d55efea80b652d (patch) | |
tree | e5d8ce9a35dfcdfa247a233f3efe38feb3a109f1 /drivers | |
parent | d961450da5e16dae8da276c0a234764872b2307b (diff) |
ide: remove driver_data direct access of struct device
In the near future, the driver core is going to not allow direct access
to the driver_data pointer in struct device. Instead, the functions
dev_get_drvdata() and dev_set_drvdata() should be used. These functions
have been around since the beginning, so are backwards compatible with
all older kernel versions.
Cc: linux-ide@vger.kernel.org
Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/ide/ide-pm.c | 6 | ||||
-rw-r--r-- | drivers/ide/ide-probe.c | 4 | ||||
-rw-r--r-- | drivers/ide/ide_platform.c | 2 |
3 files changed, 7 insertions, 5 deletions
diff --git a/drivers/ide/ide-pm.c b/drivers/ide/ide-pm.c index ba1488bd8430..c14ca144cffe 100644 --- a/drivers/ide/ide-pm.c +++ b/drivers/ide/ide-pm.c | |||
@@ -3,7 +3,8 @@ | |||
3 | 3 | ||
4 | int generic_ide_suspend(struct device *dev, pm_message_t mesg) | 4 | int generic_ide_suspend(struct device *dev, pm_message_t mesg) |
5 | { | 5 | { |
6 | ide_drive_t *drive = dev->driver_data, *pair = ide_get_pair_dev(drive); | 6 | ide_drive_t *drive = dev_get_drvdata(dev); |
7 | ide_drive_t *pair = ide_get_pair_dev(drive); | ||
7 | ide_hwif_t *hwif = drive->hwif; | 8 | ide_hwif_t *hwif = drive->hwif; |
8 | struct request *rq; | 9 | struct request *rq; |
9 | struct request_pm_state rqpm; | 10 | struct request_pm_state rqpm; |
@@ -34,7 +35,8 @@ int generic_ide_suspend(struct device *dev, pm_message_t mesg) | |||
34 | 35 | ||
35 | int generic_ide_resume(struct device *dev) | 36 | int generic_ide_resume(struct device *dev) |
36 | { | 37 | { |
37 | ide_drive_t *drive = dev->driver_data, *pair = ide_get_pair_dev(drive); | 38 | ide_drive_t *drive = dev_get_drvdata(dev); |
39 | ide_drive_t *pair = ide_get_pair_dev(drive); | ||
38 | ide_hwif_t *hwif = drive->hwif; | 40 | ide_hwif_t *hwif = drive->hwif; |
39 | struct request *rq; | 41 | struct request *rq; |
40 | struct request_pm_state rqpm; | 42 | struct request_pm_state rqpm; |
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c index f371b0de314f..79e0af3fd158 100644 --- a/drivers/ide/ide-probe.c +++ b/drivers/ide/ide-probe.c | |||
@@ -535,7 +535,7 @@ static int ide_register_port(ide_hwif_t *hwif) | |||
535 | 535 | ||
536 | /* register with global device tree */ | 536 | /* register with global device tree */ |
537 | dev_set_name(&hwif->gendev, hwif->name); | 537 | dev_set_name(&hwif->gendev, hwif->name); |
538 | hwif->gendev.driver_data = hwif; | 538 | dev_set_drvdata(&hwif->gendev, hwif); |
539 | if (hwif->gendev.parent == NULL) | 539 | if (hwif->gendev.parent == NULL) |
540 | hwif->gendev.parent = hwif->dev; | 540 | hwif->gendev.parent = hwif->dev; |
541 | hwif->gendev.release = hwif_release_dev; | 541 | hwif->gendev.release = hwif_release_dev; |
@@ -987,9 +987,9 @@ static void hwif_register_devices(ide_hwif_t *hwif) | |||
987 | int ret; | 987 | int ret; |
988 | 988 | ||
989 | dev_set_name(dev, "%u.%u", hwif->index, i); | 989 | dev_set_name(dev, "%u.%u", hwif->index, i); |
990 | dev_set_drvdata(dev, drive); | ||
990 | dev->parent = &hwif->gendev; | 991 | dev->parent = &hwif->gendev; |
991 | dev->bus = &ide_bus_type; | 992 | dev->bus = &ide_bus_type; |
992 | dev->driver_data = drive; | ||
993 | dev->release = drive_release_dev; | 993 | dev->release = drive_release_dev; |
994 | 994 | ||
995 | ret = device_register(dev); | 995 | ret = device_register(dev); |
diff --git a/drivers/ide/ide_platform.c b/drivers/ide/ide_platform.c index ee9b55ecc62b..b579fbe88370 100644 --- a/drivers/ide/ide_platform.c +++ b/drivers/ide/ide_platform.c | |||
@@ -112,7 +112,7 @@ out: | |||
112 | 112 | ||
113 | static int __devexit plat_ide_remove(struct platform_device *pdev) | 113 | static int __devexit plat_ide_remove(struct platform_device *pdev) |
114 | { | 114 | { |
115 | struct ide_host *host = pdev->dev.driver_data; | 115 | struct ide_host *host = dev_get_drvdata(&pdev->dev); |
116 | 116 | ||
117 | ide_host_remove(host); | 117 | ide_host_remove(host); |
118 | 118 | ||