aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorSebastian Siewior <sebastian@breakpoint.cc>2008-07-17 14:09:29 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2008-08-13 20:32:55 -0400
commit7839b5162d7d6c100f70a036be1e1f2b072857bc (patch)
treebd86bdb8152c2724b01ee92790b4230e2684cf73 /drivers
parent3f02a957d5eb0eeb01207a799086f2b347077f71 (diff)
usb: isp1760: don't be noisy about short packets.
According to Alan Stern, short packets are quite normal under certain circumstances. This printk was triggered by usb to serial converters on every packet and some usb sticks triggered a few of those while plugging the stick. This printks are now hidden unless USB debug mode is activated. Cc: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Sebastian Siewior <sebastian@breakpoint.cc> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/usb/host/isp1760-hcd.c6
-rw-r--r--drivers/usb/host/isp1760-hcd.h3
2 files changed, 6 insertions, 3 deletions
diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c
index e209b3b709d6..d22a84f86a33 100644
--- a/drivers/usb/host/isp1760-hcd.c
+++ b/drivers/usb/host/isp1760-hcd.c
@@ -1128,11 +1128,11 @@ static void do_atl_int(struct usb_hcd *usb_hcd)
1128 } else if (usb_pipebulk(urb->pipe) && (length < qtd->length)) { 1128 } else if (usb_pipebulk(urb->pipe) && (length < qtd->length)) {
1129 /* short BULK received */ 1129 /* short BULK received */
1130 1130
1131 printk(KERN_ERR "short bulk, %d instead %zu\n", length,
1132 qtd->length);
1133 if (urb->transfer_flags & URB_SHORT_NOT_OK) { 1131 if (urb->transfer_flags & URB_SHORT_NOT_OK) {
1134 urb->status = -EREMOTEIO; 1132 urb->status = -EREMOTEIO;
1135 printk(KERN_ERR "not okey\n"); 1133 isp1760_dbg(priv, "short bulk, %d instead %zu "
1134 "with URB_SHORT_NOT_OK flag.\n",
1135 length, qtd->length);
1136 } 1136 }
1137 1137
1138 if (urb->status == -EINPROGRESS) 1138 if (urb->status == -EINPROGRESS)
diff --git a/drivers/usb/host/isp1760-hcd.h b/drivers/usb/host/isp1760-hcd.h
index 3c61cd51cbb8..4377277667d9 100644
--- a/drivers/usb/host/isp1760-hcd.h
+++ b/drivers/usb/host/isp1760-hcd.h
@@ -121,6 +121,9 @@ struct inter_packet_info {
121typedef void (packet_enqueue)(struct usb_hcd *hcd, struct isp1760_qh *qh, 121typedef void (packet_enqueue)(struct usb_hcd *hcd, struct isp1760_qh *qh,
122 struct isp1760_qtd *qtd); 122 struct isp1760_qtd *qtd);
123 123
124#define isp1760_dbg(priv, fmt, args...) \
125 dev_dbg(priv_to_hcd(priv)->self.controller, fmt, ##args)
126
124#define isp1760_info(priv, fmt, args...) \ 127#define isp1760_info(priv, fmt, args...) \
125 dev_info(priv_to_hcd(priv)->self.controller, fmt, ##args) 128 dev_info(priv_to_hcd(priv)->self.controller, fmt, ##args)
126 129