diff options
author | Philipp Zabel <p.zabel@pengutronix.de> | 2014-06-03 05:35:53 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-07-21 23:51:24 -0400 |
commit | d131e54b686049f90a34f195a7d276083ef68aa0 (patch) | |
tree | cf7e6d5774ba0e19848f504a731ab07beaf9d956 /drivers | |
parent | f17bc3f4707eb87bdb80b895911c551cdd606fbd (diff) |
[media] mt9v032: do not clear reserved bits in read mode register
The read mode register bits 8 and 9 are set and marked as reserved.
Don't clear them.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/media/i2c/mt9v032.c | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c index d481ed1452f4..edbe80ce2132 100644 --- a/drivers/media/i2c/mt9v032.c +++ b/drivers/media/i2c/mt9v032.c | |||
@@ -87,6 +87,7 @@ | |||
87 | #define MT9V032_READ_MODE_COLUMN_FLIP (1 << 5) | 87 | #define MT9V032_READ_MODE_COLUMN_FLIP (1 << 5) |
88 | #define MT9V032_READ_MODE_DARK_COLUMNS (1 << 6) | 88 | #define MT9V032_READ_MODE_DARK_COLUMNS (1 << 6) |
89 | #define MT9V032_READ_MODE_DARK_ROWS (1 << 7) | 89 | #define MT9V032_READ_MODE_DARK_ROWS (1 << 7) |
90 | #define MT9V032_READ_MODE_RESERVED 0x0300 | ||
90 | #define MT9V032_PIXEL_OPERATION_MODE 0x0f | 91 | #define MT9V032_PIXEL_OPERATION_MODE 0x0f |
91 | #define MT9V034_PIXEL_OPERATION_MODE_HDR (1 << 0) | 92 | #define MT9V034_PIXEL_OPERATION_MODE_HDR (1 << 0) |
92 | #define MT9V034_PIXEL_OPERATION_MODE_COLOR (1 << 1) | 93 | #define MT9V034_PIXEL_OPERATION_MODE_COLOR (1 << 1) |
@@ -414,6 +415,7 @@ static int mt9v032_s_stream(struct v4l2_subdev *subdev, int enable) | |||
414 | struct i2c_client *client = v4l2_get_subdevdata(subdev); | 415 | struct i2c_client *client = v4l2_get_subdevdata(subdev); |
415 | struct mt9v032 *mt9v032 = to_mt9v032(subdev); | 416 | struct mt9v032 *mt9v032 = to_mt9v032(subdev); |
416 | struct v4l2_rect *crop = &mt9v032->crop; | 417 | struct v4l2_rect *crop = &mt9v032->crop; |
418 | unsigned int read_mode; | ||
417 | unsigned int hbin; | 419 | unsigned int hbin; |
418 | unsigned int vbin; | 420 | unsigned int vbin; |
419 | int ret; | 421 | int ret; |
@@ -424,9 +426,13 @@ static int mt9v032_s_stream(struct v4l2_subdev *subdev, int enable) | |||
424 | /* Configure the window size and row/column bin */ | 426 | /* Configure the window size and row/column bin */ |
425 | hbin = fls(mt9v032->hratio) - 1; | 427 | hbin = fls(mt9v032->hratio) - 1; |
426 | vbin = fls(mt9v032->vratio) - 1; | 428 | vbin = fls(mt9v032->vratio) - 1; |
427 | ret = mt9v032_write(client, MT9V032_READ_MODE, | 429 | read_mode = mt9v032_read(client, MT9V032_READ_MODE); |
428 | hbin << MT9V032_READ_MODE_COLUMN_BIN_SHIFT | | 430 | if (read_mode < 0) |
429 | vbin << MT9V032_READ_MODE_ROW_BIN_SHIFT); | 431 | return read_mode; |
432 | read_mode &= MT9V032_READ_MODE_RESERVED; | ||
433 | read_mode |= hbin << MT9V032_READ_MODE_COLUMN_BIN_SHIFT | | ||
434 | vbin << MT9V032_READ_MODE_ROW_BIN_SHIFT; | ||
435 | ret = mt9v032_write(client, MT9V032_READ_MODE, read_mode); | ||
430 | if (ret < 0) | 436 | if (ret < 0) |
431 | return ret; | 437 | return ret; |
432 | 438 | ||