aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorBen Hutchings <bhutchings@solarflare.com>2012-02-24 16:29:40 -0500
committerBen Hutchings <bhutchings@solarflare.com>2012-03-06 13:14:13 -0500
commitbdca71ede7356e4a5838724a0a40be63ac549641 (patch)
tree12a98c870fae5f15cc233551c01db023edb46024 /drivers
parent2c61c8a787fc3382edefd8c7ad3e0f74c81e5302 (diff)
sfc: Remove redundant function efx_nic_has_mc()
This function is now used in only one place, where it always returns true. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/ethernet/sfc/nic.h4
-rw-r--r--drivers/net/ethernet/sfc/siena.c3
2 files changed, 1 insertions, 6 deletions
diff --git a/drivers/net/ethernet/sfc/nic.h b/drivers/net/ethernet/sfc/nic.h
index 246c4140453c..ac12f7f7f35b 100644
--- a/drivers/net/ethernet/sfc/nic.h
+++ b/drivers/net/ethernet/sfc/nic.h
@@ -35,10 +35,6 @@ static inline int efx_nic_rev(struct efx_nic *efx)
35 35
36extern u32 efx_nic_fpga_ver(struct efx_nic *efx); 36extern u32 efx_nic_fpga_ver(struct efx_nic *efx);
37 37
38static inline bool efx_nic_has_mc(struct efx_nic *efx)
39{
40 return efx_nic_rev(efx) >= EFX_REV_SIENA_A0;
41}
42/* NIC has two interlinked PCI functions for the same port. */ 38/* NIC has two interlinked PCI functions for the same port. */
43static inline bool efx_nic_is_dual_func(struct efx_nic *efx) 39static inline bool efx_nic_is_dual_func(struct efx_nic *efx)
44{ 40{
diff --git a/drivers/net/ethernet/sfc/siena.c b/drivers/net/ethernet/sfc/siena.c
index 7bea79017a05..9f8d7cea3967 100644
--- a/drivers/net/ethernet/sfc/siena.c
+++ b/drivers/net/ethernet/sfc/siena.c
@@ -409,8 +409,7 @@ static void siena_remove_nic(struct efx_nic *efx)
409 siena_reset_hw(efx, RESET_TYPE_ALL); 409 siena_reset_hw(efx, RESET_TYPE_ALL);
410 410
411 /* Relinquish the device back to the BMC */ 411 /* Relinquish the device back to the BMC */
412 if (efx_nic_has_mc(efx)) 412 efx_mcdi_drv_attach(efx, false, NULL);
413 efx_mcdi_drv_attach(efx, false, NULL);
414 413
415 /* Tear down the private nic state */ 414 /* Tear down the private nic state */
416 kfree(efx->nic_data); 415 kfree(efx->nic_data);