vt: remove uneeded retval check before tty->ops->open inside tty_open

The current check is uneeded, since !retval will always returns true,
as retval returned from tty_add_file is checked earlier and tty_open
exits if it's not zero.

Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1 files changed, 4 insertions, 6 deletions

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index d7d50b48287e..188632e4734d 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -1902,12 +1902,10 @@ got_driver:
 #ifdef TTY_DEBUG_HANGUP
         printk(KERN_DEBUG "opening %s...", tty->name);
 #endif
-        if (!retval) {
-                if (tty->ops->open)
-                        retval = tty->ops->open(tty, filp);
-                else
-                        retval = -ENODEV;
-        }
+        if (tty->ops->open)
+                retval = tty->ops->open(tty, filp);
+        else
+                retval = -ENODEV;
         filp->f_flags = saved_flags;
 
         if (!retval && test_bit(TTY_EXCLUSIVE, &tty->flags) &&