diff options
author | Alexey Dobriyan <adobriyan@gmail.com> | 2008-04-29 04:01:44 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-29 11:06:18 -0400 |
commit | c74c120a21d87b0b6925ada5830d8cac21e852d9 (patch) | |
tree | 79558a29ecadc7b71eeb5bdf0945680f0560b2ed /drivers | |
parent | 928b4d8c8963e75bdb133f562b03b07f9aa4844a (diff) |
proc: remove proc_root from drivers
Remove proc_root export. Creation and removal works well if parent PDE is
supplied as NULL -- it worked always that way.
So, one useless export removed and consistency added, some drivers created
PDEs with &proc_root as parent but removed them as NULL and so on.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/char/ip2/ip2main.c | 4 | ||||
-rw-r--r-- | drivers/mca/mca-proc.c | 2 | ||||
-rw-r--r-- | drivers/misc/hdpuftrs/hdpu_cpustate.c | 2 | ||||
-rw-r--r-- | drivers/misc/hdpuftrs/hdpu_nexus.c | 12 | ||||
-rw-r--r-- | drivers/s390/block/dasd_proc.c | 6 | ||||
-rw-r--r-- | drivers/s390/char/tape_proc.c | 4 | ||||
-rw-r--r-- | drivers/s390/cio/blacklist.c | 2 | ||||
-rw-r--r-- | drivers/s390/cio/qdio.c | 4 | ||||
-rw-r--r-- | drivers/scsi/megaraid.c | 6 | ||||
-rw-r--r-- | drivers/video/clps711xfb.c | 2 |
10 files changed, 22 insertions, 22 deletions
diff --git a/drivers/char/ip2/ip2main.c b/drivers/char/ip2/ip2main.c index b1d6cad84282..a784f5e22ee9 100644 --- a/drivers/char/ip2/ip2main.c +++ b/drivers/char/ip2/ip2main.c | |||
@@ -423,7 +423,7 @@ cleanup_module(void) | |||
423 | } | 423 | } |
424 | put_tty_driver(ip2_tty_driver); | 424 | put_tty_driver(ip2_tty_driver); |
425 | unregister_chrdev(IP2_IPL_MAJOR, pcIpl); | 425 | unregister_chrdev(IP2_IPL_MAJOR, pcIpl); |
426 | remove_proc_entry("ip2mem", &proc_root); | 426 | remove_proc_entry("ip2mem", NULL); |
427 | 427 | ||
428 | // free memory | 428 | // free memory |
429 | for (i = 0; i < IP2_MAX_BOARDS; i++) { | 429 | for (i = 0; i < IP2_MAX_BOARDS; i++) { |
@@ -695,7 +695,7 @@ ip2_loadmain(int *iop, int *irqp, unsigned char *firmware, int firmsize) | |||
695 | } | 695 | } |
696 | } | 696 | } |
697 | /* Register the read_procmem thing */ | 697 | /* Register the read_procmem thing */ |
698 | if (!create_proc_info_entry("ip2mem",0,&proc_root,ip2_read_procmem)) { | 698 | if (!create_proc_info_entry("ip2mem",0,NULL,ip2_read_procmem)) { |
699 | printk(KERN_ERR "IP2: failed to register read_procmem\n"); | 699 | printk(KERN_ERR "IP2: failed to register read_procmem\n"); |
700 | } else { | 700 | } else { |
701 | 701 | ||
diff --git a/drivers/mca/mca-proc.c b/drivers/mca/mca-proc.c index 33d5e0820cc5..81ea0d377bf4 100644 --- a/drivers/mca/mca-proc.c +++ b/drivers/mca/mca-proc.c | |||
@@ -183,7 +183,7 @@ void __init mca_do_proc_init(void) | |||
183 | struct proc_dir_entry* node = NULL; | 183 | struct proc_dir_entry* node = NULL; |
184 | struct mca_device *mca_dev; | 184 | struct mca_device *mca_dev; |
185 | 185 | ||
186 | proc_mca = proc_mkdir("mca", &proc_root); | 186 | proc_mca = proc_mkdir("mca", NULL); |
187 | create_proc_read_entry("pos",0,proc_mca,get_mca_info,NULL); | 187 | create_proc_read_entry("pos",0,proc_mca,get_mca_info,NULL); |
188 | create_proc_read_entry("machine",0,proc_mca,get_mca_machine_info,NULL); | 188 | create_proc_read_entry("machine",0,proc_mca,get_mca_machine_info,NULL); |
189 | 189 | ||
diff --git a/drivers/misc/hdpuftrs/hdpu_cpustate.c b/drivers/misc/hdpuftrs/hdpu_cpustate.c index 302e92418bbe..154155c9b638 100644 --- a/drivers/misc/hdpuftrs/hdpu_cpustate.c +++ b/drivers/misc/hdpuftrs/hdpu_cpustate.c | |||
@@ -210,7 +210,7 @@ static int hdpu_cpustate_probe(struct platform_device *pdev) | |||
210 | return ret; | 210 | return ret; |
211 | } | 211 | } |
212 | 212 | ||
213 | proc_de = create_proc_entry("sky_cpustate", 0666, &proc_root); | 213 | proc_de = create_proc_entry("sky_cpustate", 0666, NULL); |
214 | if (!proc_de) { | 214 | if (!proc_de) { |
215 | printk(KERN_WARNING "sky_cpustate: " | 215 | printk(KERN_WARNING "sky_cpustate: " |
216 | "Unable to create proc entry\n"); | 216 | "Unable to create proc entry\n"); |
diff --git a/drivers/misc/hdpuftrs/hdpu_nexus.c b/drivers/misc/hdpuftrs/hdpu_nexus.c index 2fa36f7a6eb3..e92b7efccc72 100644 --- a/drivers/misc/hdpuftrs/hdpu_nexus.c +++ b/drivers/misc/hdpuftrs/hdpu_nexus.c | |||
@@ -102,8 +102,8 @@ static int hdpu_nexus_probe(struct platform_device *pdev) | |||
102 | printk(KERN_ERR "sky_nexus: Could not map slot id\n"); | 102 | printk(KERN_ERR "sky_nexus: Could not map slot id\n"); |
103 | } | 103 | } |
104 | 104 | ||
105 | hdpu_slot_id = create_proc_entry("sky_slot_id", 0666, &proc_root); | 105 | hdpu_slot_id = create_proc_entry("sky_slot_id", 0666, NULL); |
106 | if (!hdpu_slot_id) { | 106 | if (!hdpu_slot_id) |
107 | printk(KERN_WARNING "sky_nexus: " | 107 | printk(KERN_WARNING "sky_nexus: " |
108 | "Unable to create proc dir entry: sky_slot_id\n"); | 108 | "Unable to create proc dir entry: sky_slot_id\n"); |
109 | } else { | 109 | } else { |
@@ -111,8 +111,8 @@ static int hdpu_nexus_probe(struct platform_device *pdev) | |||
111 | hdpu_slot_id->owner = THIS_MODULE; | 111 | hdpu_slot_id->owner = THIS_MODULE; |
112 | } | 112 | } |
113 | 113 | ||
114 | hdpu_chassis_id = create_proc_entry("sky_chassis_id", 0666, &proc_root); | 114 | hdpu_chassis_id = create_proc_entry("sky_chassis_id", 0666, NULL); |
115 | if (!hdpu_chassis_id) { | 115 | if (!hdpu_chassis_id) |
116 | printk(KERN_WARNING "sky_nexus: " | 116 | printk(KERN_WARNING "sky_nexus: " |
117 | "Unable to create proc dir entry: sky_chassis_id\n"); | 117 | "Unable to create proc dir entry: sky_chassis_id\n"); |
118 | } else { | 118 | } else { |
@@ -128,8 +128,8 @@ static int hdpu_nexus_remove(struct platform_device *pdev) | |||
128 | slot_id = -1; | 128 | slot_id = -1; |
129 | chassis_id = -1; | 129 | chassis_id = -1; |
130 | 130 | ||
131 | remove_proc_entry("sky_slot_id", &proc_root); | 131 | remove_proc_entry("sky_slot_id", NULL); |
132 | remove_proc_entry("sky_chassis_id", &proc_root); | 132 | remove_proc_entry("sky_chassis_id", NULL); |
133 | 133 | ||
134 | hdpu_slot_id = 0; | 134 | hdpu_slot_id = 0; |
135 | hdpu_chassis_id = 0; | 135 | hdpu_chassis_id = 0; |
diff --git a/drivers/s390/block/dasd_proc.c b/drivers/s390/block/dasd_proc.c index 556063e8f7a9..8ae9406b10ad 100644 --- a/drivers/s390/block/dasd_proc.c +++ b/drivers/s390/block/dasd_proc.c | |||
@@ -311,7 +311,7 @@ out_error: | |||
311 | int | 311 | int |
312 | dasd_proc_init(void) | 312 | dasd_proc_init(void) |
313 | { | 313 | { |
314 | dasd_proc_root_entry = proc_mkdir("dasd", &proc_root); | 314 | dasd_proc_root_entry = proc_mkdir("dasd", NULL); |
315 | if (!dasd_proc_root_entry) | 315 | if (!dasd_proc_root_entry) |
316 | goto out_nodasd; | 316 | goto out_nodasd; |
317 | dasd_proc_root_entry->owner = THIS_MODULE; | 317 | dasd_proc_root_entry->owner = THIS_MODULE; |
@@ -335,7 +335,7 @@ dasd_proc_init(void) | |||
335 | out_nostatistics: | 335 | out_nostatistics: |
336 | remove_proc_entry("devices", dasd_proc_root_entry); | 336 | remove_proc_entry("devices", dasd_proc_root_entry); |
337 | out_nodevices: | 337 | out_nodevices: |
338 | remove_proc_entry("dasd", &proc_root); | 338 | remove_proc_entry("dasd", NULL); |
339 | out_nodasd: | 339 | out_nodasd: |
340 | return -ENOENT; | 340 | return -ENOENT; |
341 | } | 341 | } |
@@ -345,5 +345,5 @@ dasd_proc_exit(void) | |||
345 | { | 345 | { |
346 | remove_proc_entry("devices", dasd_proc_root_entry); | 346 | remove_proc_entry("devices", dasd_proc_root_entry); |
347 | remove_proc_entry("statistics", dasd_proc_root_entry); | 347 | remove_proc_entry("statistics", dasd_proc_root_entry); |
348 | remove_proc_entry("dasd", &proc_root); | 348 | remove_proc_entry("dasd", NULL); |
349 | } | 349 | } |
diff --git a/drivers/s390/char/tape_proc.c b/drivers/s390/char/tape_proc.c index c9b96d51b28f..0c39636b2174 100644 --- a/drivers/s390/char/tape_proc.c +++ b/drivers/s390/char/tape_proc.c | |||
@@ -125,7 +125,7 @@ tape_proc_init(void) | |||
125 | { | 125 | { |
126 | tape_proc_devices = | 126 | tape_proc_devices = |
127 | create_proc_entry ("tapedevices", S_IFREG | S_IRUGO | S_IWUSR, | 127 | create_proc_entry ("tapedevices", S_IFREG | S_IRUGO | S_IWUSR, |
128 | &proc_root); | 128 | NULL); |
129 | if (tape_proc_devices == NULL) { | 129 | if (tape_proc_devices == NULL) { |
130 | PRINT_WARN("tape: Cannot register procfs entry tapedevices\n"); | 130 | PRINT_WARN("tape: Cannot register procfs entry tapedevices\n"); |
131 | return; | 131 | return; |
@@ -141,5 +141,5 @@ void | |||
141 | tape_proc_cleanup(void) | 141 | tape_proc_cleanup(void) |
142 | { | 142 | { |
143 | if (tape_proc_devices != NULL) | 143 | if (tape_proc_devices != NULL) |
144 | remove_proc_entry ("tapedevices", &proc_root); | 144 | remove_proc_entry ("tapedevices", NULL); |
145 | } | 145 | } |
diff --git a/drivers/s390/cio/blacklist.c b/drivers/s390/cio/blacklist.c index e8597ec92247..ef33d5df2229 100644 --- a/drivers/s390/cio/blacklist.c +++ b/drivers/s390/cio/blacklist.c | |||
@@ -375,7 +375,7 @@ cio_ignore_proc_init (void) | |||
375 | struct proc_dir_entry *entry; | 375 | struct proc_dir_entry *entry; |
376 | 376 | ||
377 | entry = create_proc_entry ("cio_ignore", S_IFREG | S_IRUGO | S_IWUSR, | 377 | entry = create_proc_entry ("cio_ignore", S_IFREG | S_IRUGO | S_IWUSR, |
378 | &proc_root); | 378 | NULL); |
379 | if (!entry) | 379 | if (!entry) |
380 | return -ENOENT; | 380 | return -ENOENT; |
381 | 381 | ||
diff --git a/drivers/s390/cio/qdio.c b/drivers/s390/cio/qdio.c index 10aa1e780801..43876e287370 100644 --- a/drivers/s390/cio/qdio.c +++ b/drivers/s390/cio/qdio.c | |||
@@ -3632,7 +3632,7 @@ qdio_add_procfs_entry(void) | |||
3632 | { | 3632 | { |
3633 | proc_perf_file_registration=0; | 3633 | proc_perf_file_registration=0; |
3634 | qdio_perf_proc_file=create_proc_entry(QDIO_PERF, | 3634 | qdio_perf_proc_file=create_proc_entry(QDIO_PERF, |
3635 | S_IFREG|0444,&proc_root); | 3635 | S_IFREG|0444,NULL); |
3636 | if (qdio_perf_proc_file) { | 3636 | if (qdio_perf_proc_file) { |
3637 | qdio_perf_proc_file->read_proc=&qdio_perf_procfile_read; | 3637 | qdio_perf_proc_file->read_proc=&qdio_perf_procfile_read; |
3638 | } else proc_perf_file_registration=-1; | 3638 | } else proc_perf_file_registration=-1; |
@@ -3647,7 +3647,7 @@ static void | |||
3647 | qdio_remove_procfs_entry(void) | 3647 | qdio_remove_procfs_entry(void) |
3648 | { | 3648 | { |
3649 | if (!proc_perf_file_registration) /* means if it went ok earlier */ | 3649 | if (!proc_perf_file_registration) /* means if it went ok earlier */ |
3650 | remove_proc_entry(QDIO_PERF,&proc_root); | 3650 | remove_proc_entry(QDIO_PERF,NULL); |
3651 | } | 3651 | } |
3652 | 3652 | ||
3653 | /** | 3653 | /** |
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c index b135a1ed4b2c..18551aaf5e09 100644 --- a/drivers/scsi/megaraid.c +++ b/drivers/scsi/megaraid.c | |||
@@ -4996,7 +4996,7 @@ static int __init megaraid_init(void) | |||
4996 | max_mbox_busy_wait = MBOX_BUSY_WAIT; | 4996 | max_mbox_busy_wait = MBOX_BUSY_WAIT; |
4997 | 4997 | ||
4998 | #ifdef CONFIG_PROC_FS | 4998 | #ifdef CONFIG_PROC_FS |
4999 | mega_proc_dir_entry = proc_mkdir("megaraid", &proc_root); | 4999 | mega_proc_dir_entry = proc_mkdir("megaraid", NULL); |
5000 | if (!mega_proc_dir_entry) { | 5000 | if (!mega_proc_dir_entry) { |
5001 | printk(KERN_WARNING | 5001 | printk(KERN_WARNING |
5002 | "megaraid: failed to create megaraid root\n"); | 5002 | "megaraid: failed to create megaraid root\n"); |
@@ -5005,7 +5005,7 @@ static int __init megaraid_init(void) | |||
5005 | error = pci_register_driver(&megaraid_pci_driver); | 5005 | error = pci_register_driver(&megaraid_pci_driver); |
5006 | if (error) { | 5006 | if (error) { |
5007 | #ifdef CONFIG_PROC_FS | 5007 | #ifdef CONFIG_PROC_FS |
5008 | remove_proc_entry("megaraid", &proc_root); | 5008 | remove_proc_entry("megaraid", NULL); |
5009 | #endif | 5009 | #endif |
5010 | return error; | 5010 | return error; |
5011 | } | 5011 | } |
@@ -5035,7 +5035,7 @@ static void __exit megaraid_exit(void) | |||
5035 | pci_unregister_driver(&megaraid_pci_driver); | 5035 | pci_unregister_driver(&megaraid_pci_driver); |
5036 | 5036 | ||
5037 | #ifdef CONFIG_PROC_FS | 5037 | #ifdef CONFIG_PROC_FS |
5038 | remove_proc_entry("megaraid", &proc_root); | 5038 | remove_proc_entry("megaraid", NULL); |
5039 | #endif | 5039 | #endif |
5040 | } | 5040 | } |
5041 | 5041 | ||
diff --git a/drivers/video/clps711xfb.c b/drivers/video/clps711xfb.c index 17b5267f44d7..9f8a389dc7ae 100644 --- a/drivers/video/clps711xfb.c +++ b/drivers/video/clps711xfb.c | |||
@@ -381,7 +381,7 @@ int __init clps711xfb_init(void) | |||
381 | 381 | ||
382 | /* Register the /proc entries. */ | 382 | /* Register the /proc entries. */ |
383 | clps7111fb_backlight_proc_entry = create_proc_entry("backlight", 0444, | 383 | clps7111fb_backlight_proc_entry = create_proc_entry("backlight", 0444, |
384 | &proc_root); | 384 | NULL); |
385 | if (clps7111fb_backlight_proc_entry == NULL) { | 385 | if (clps7111fb_backlight_proc_entry == NULL) { |
386 | printk("Couldn't create the /proc entry for the backlight.\n"); | 386 | printk("Couldn't create the /proc entry for the backlight.\n"); |
387 | return -EINVAL; | 387 | return -EINVAL; |