Merge master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6

4 files changed, 92 insertions, 30 deletions

diff --git a/drivers/net/shaper.c b/drivers/net/shaper.c
index 20edeb345792..3ad0b6751f6f 100644
--- a/drivers/net/shaper.c
+++ b/drivers/net/shaper.c
@@ -135,10 +135,8 @@ static int shaper_start_xmit(struct sk_buff *skb, struct net_device *dev)
 {
         struct shaper *shaper = dev->priv;
         struct sk_buff *ptr;
-   
-        if (down_trylock(&shaper->sem))
-                return -1;
-
+  
+        spin_lock(&shaper->lock);
         ptr=shaper->sendq.prev;
         
         /*
@@ -232,7 +230,7 @@ static int shaper_start_xmit(struct sk_buff *skb, struct net_device *dev)
                 shaper->stats.collisions++;
         }
         shaper_kick(shaper);
-        up(&shaper->sem);
+        spin_unlock(&shaper->lock);
         return 0;
 }
 
@@ -271,11 +269,9 @@ static void shaper_timer(unsigned long data)
 {
         struct shaper *shaper = (struct shaper *)data;
 
-        if (!down_trylock(&shaper->sem)) {
-                shaper_kick(shaper);
-                up(&shaper->sem);
-        } else
-                mod_timer(&shaper->timer, jiffies);
+        spin_lock(&shaper->lock);
+        shaper_kick(shaper);
+        spin_unlock(&shaper->lock);
 }
 
 /*
@@ -332,21 +328,6 @@ static void shaper_kick(struct shaper *shaper)
 
 
 /*
- *      Flush the shaper queues on a closedown
- */
- 
-static void shaper_flush(struct shaper *shaper)
-{
-        struct sk_buff *skb;
-
-        down(&shaper->sem);
-        while((skb=skb_dequeue(&shaper->sendq))!=NULL)
-                dev_kfree_skb(skb);
-        shaper_kick(shaper);
-        up(&shaper->sem);
-}
-
-/*
  *      Bring the interface up. We just disallow this until a 
  *      bind.
  */
@@ -375,7 +356,15 @@ static int shaper_open(struct net_device *dev)
 static int shaper_close(struct net_device *dev)
 {
         struct shaper *shaper=dev->priv;
-        shaper_flush(shaper);
+        struct sk_buff *skb;
+
+        while ((skb = skb_dequeue(&shaper->sendq)) != NULL)
+                dev_kfree_skb(skb);
+
+        spin_lock_bh(&shaper->lock);
+        shaper_kick(shaper);
+        spin_unlock_bh(&shaper->lock);
+
         del_timer_sync(&shaper->timer);
         return 0;
 }
@@ -576,6 +565,7 @@ static void shaper_init_priv(struct net_device *dev)
         init_timer(&sh->timer);
         sh->timer.function=shaper_timer;
         sh->timer.data=(unsigned long)sh;
+        spin_lock_init(&sh->lock);
 }
 
 /*
diff --git a/drivers/net/skge.h b/drivers/net/skge.h
index 14d0cc01fb9a..fced3d2bc072 100644
--- a/drivers/net/skge.h
+++ b/drivers/net/skge.h
@@ -7,6 +7,7 @@
 /* PCI config registers */
 #define PCI_DEV_REG1    0x40
 #define PCI_DEV_REG2    0x44
+#define  PCI_REV_DESC    0x4
 
 #define PCI_STATUS_ERROR_BITS (PCI_STATUS_DETECTED_PARITY | \
                                PCI_STATUS_SIG_SYSTEM_ERROR | \
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 7e371b1209a1..54640686e983 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -66,8 +66,8 @@
 
 #define DRV_MODULE_NAME         "tg3"
 #define PFX DRV_MODULE_NAME     ": "
-#define DRV_MODULE_VERSION      "3.32"
-#define DRV_MODULE_RELDATE      "June 24, 2005"
+#define DRV_MODULE_VERSION      "3.33"
+#define DRV_MODULE_RELDATE      "July 5, 2005"
 
 #define TG3_DEF_MAC_MODE        0
 #define TG3_DEF_RX_MODE         0
@@ -5117,7 +5117,7 @@ static void tg3_set_bdinfo(struct tg3 *tp, u32 bdinfo_addr,
 }
 
 static void __tg3_set_rx_mode(struct net_device *);
-static void tg3_set_coalesce(struct tg3 *tp, struct ethtool_coalesce *ec)
+static void __tg3_set_coalesce(struct tg3 *tp, struct ethtool_coalesce *ec)
 {
         tw32(HOSTCC_RXCOL_TICKS, ec->rx_coalesce_usecs);
         tw32(HOSTCC_TXCOL_TICKS, ec->tx_coalesce_usecs);
@@ -5460,7 +5460,7 @@ static int tg3_reset_hw(struct tg3 *tp)
                 udelay(10);
         }
 
-        tg3_set_coalesce(tp, &tp->coal);
+        __tg3_set_coalesce(tp, &tp->coal);
 
         /* set status block DMA address */
         tw32(HOSTCC_STATUS_BLK_HOST_ADDR + TG3_64BIT_REG_HIGH,
@@ -7821,6 +7821,60 @@ static int tg3_get_coalesce(struct net_device *dev, struct ethtool_coalesce *ec)
         return 0;
 }
 
+static int tg3_set_coalesce(struct net_device *dev, struct ethtool_coalesce *ec)
+{
+        struct tg3 *tp = netdev_priv(dev);
+        u32 max_rxcoal_tick_int = 0, max_txcoal_tick_int = 0;
+        u32 max_stat_coal_ticks = 0, min_stat_coal_ticks = 0;
+
+        if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS)) {
+                max_rxcoal_tick_int = MAX_RXCOAL_TICK_INT;
+                max_txcoal_tick_int = MAX_TXCOAL_TICK_INT;
+                max_stat_coal_ticks = MAX_STAT_COAL_TICKS;
+                min_stat_coal_ticks = MIN_STAT_COAL_TICKS;
+        }
+
+        if ((ec->rx_coalesce_usecs > MAX_RXCOL_TICKS) ||
+            (ec->tx_coalesce_usecs > MAX_TXCOL_TICKS) ||
+            (ec->rx_max_coalesced_frames > MAX_RXMAX_FRAMES) ||
+            (ec->tx_max_coalesced_frames > MAX_TXMAX_FRAMES) ||
+            (ec->rx_coalesce_usecs_irq > max_rxcoal_tick_int) ||
+            (ec->tx_coalesce_usecs_irq > max_txcoal_tick_int) ||
+            (ec->rx_max_coalesced_frames_irq > MAX_RXCOAL_MAXF_INT) ||
+            (ec->tx_max_coalesced_frames_irq > MAX_TXCOAL_MAXF_INT) ||
+            (ec->stats_block_coalesce_usecs > max_stat_coal_ticks) ||
+            (ec->stats_block_coalesce_usecs < min_stat_coal_ticks))
+                return -EINVAL;
+
+        /* No rx interrupts will be generated if both are zero */
+        if ((ec->rx_coalesce_usecs == 0) &&
+            (ec->rx_max_coalesced_frames == 0))
+                return -EINVAL;
+
+        /* No tx interrupts will be generated if both are zero */
+        if ((ec->tx_coalesce_usecs == 0) &&
+            (ec->tx_max_coalesced_frames == 0))
+                return -EINVAL;
+
+        /* Only copy relevant parameters, ignore all others. */
+        tp->coal.rx_coalesce_usecs = ec->rx_coalesce_usecs;
+        tp->coal.tx_coalesce_usecs = ec->tx_coalesce_usecs;
+        tp->coal.rx_max_coalesced_frames = ec->rx_max_coalesced_frames;
+        tp->coal.tx_max_coalesced_frames = ec->tx_max_coalesced_frames;
+        tp->coal.rx_coalesce_usecs_irq = ec->rx_coalesce_usecs_irq;
+        tp->coal.tx_coalesce_usecs_irq = ec->tx_coalesce_usecs_irq;
+        tp->coal.rx_max_coalesced_frames_irq = ec->rx_max_coalesced_frames_irq;
+        tp->coal.tx_max_coalesced_frames_irq = ec->tx_max_coalesced_frames_irq;
+        tp->coal.stats_block_coalesce_usecs = ec->stats_block_coalesce_usecs;
+
+        if (netif_running(dev)) {
+                tg3_full_lock(tp, 0);
+                __tg3_set_coalesce(tp, &tp->coal);
+                tg3_full_unlock(tp);
+        }
+        return 0;
+}
+
 static struct ethtool_ops tg3_ethtool_ops = {
         .get_settings           = tg3_get_settings,
         .set_settings           = tg3_set_settings,
@@ -7856,6 +7910,7 @@ static struct ethtool_ops tg3_ethtool_ops = {
         .get_stats_count        = tg3_get_stats_count,
         .get_ethtool_stats      = tg3_get_ethtool_stats,
         .get_coalesce           = tg3_get_coalesce,
+        .set_coalesce           = tg3_set_coalesce,
 };
 
 static void __devinit tg3_get_eeprom_size(struct tg3 *tp)
@@ -9800,6 +9855,12 @@ static void __devinit tg3_init_coal(struct tg3 *tp)
                 ec->tx_coalesce_usecs = LOW_TXCOL_TICKS_CLRTCKS;
                 ec->tx_coalesce_usecs_irq = DEFAULT_TXCOAL_TICK_INT_CLRTCKS;
         }
+
+        if (tp->tg3_flags2 & TG3_FLG2_5705_PLUS) {
+                ec->rx_coalesce_usecs_irq = 0;
+                ec->tx_coalesce_usecs_irq = 0;
+                ec->stats_block_coalesce_usecs = 0;
+        }
 }
 
 static int __devinit tg3_init_one(struct pci_dev *pdev,
diff --git a/drivers/net/tg3.h b/drivers/net/tg3.h
index 99c5f9675a56..70ad450733e6 100644
--- a/drivers/net/tg3.h
+++ b/drivers/net/tg3.h
@@ -879,31 +879,41 @@
 #define  LOW_RXCOL_TICKS_CLRTCKS         0x00000014
 #define  DEFAULT_RXCOL_TICKS             0x00000048
 #define  HIGH_RXCOL_TICKS                0x00000096
+#define  MAX_RXCOL_TICKS                 0x000003ff
 #define HOSTCC_TXCOL_TICKS              0x00003c0c
 #define  LOW_TXCOL_TICKS                 0x00000096
 #define  LOW_TXCOL_TICKS_CLRTCKS         0x00000048
 #define  DEFAULT_TXCOL_TICKS             0x0000012c
 #define  HIGH_TXCOL_TICKS                0x00000145
+#define  MAX_TXCOL_TICKS                 0x000003ff
 #define HOSTCC_RXMAX_FRAMES             0x00003c10
 #define  LOW_RXMAX_FRAMES                0x00000005
 #define  DEFAULT_RXMAX_FRAMES            0x00000008
 #define  HIGH_RXMAX_FRAMES               0x00000012
+#define  MAX_RXMAX_FRAMES                0x000000ff
 #define HOSTCC_TXMAX_FRAMES             0x00003c14
 #define  LOW_TXMAX_FRAMES                0x00000035
 #define  DEFAULT_TXMAX_FRAMES            0x0000004b
 #define  HIGH_TXMAX_FRAMES               0x00000052
+#define  MAX_TXMAX_FRAMES                0x000000ff
 #define HOSTCC_RXCOAL_TICK_INT          0x00003c18
 #define  DEFAULT_RXCOAL_TICK_INT         0x00000019
 #define  DEFAULT_RXCOAL_TICK_INT_CLRTCKS 0x00000014
+#define  MAX_RXCOAL_TICK_INT             0x000003ff
 #define HOSTCC_TXCOAL_TICK_INT          0x00003c1c
 #define  DEFAULT_TXCOAL_TICK_INT         0x00000019
 #define  DEFAULT_TXCOAL_TICK_INT_CLRTCKS 0x00000014
+#define  MAX_TXCOAL_TICK_INT             0x000003ff
 #define HOSTCC_RXCOAL_MAXF_INT          0x00003c20
 #define  DEFAULT_RXCOAL_MAXF_INT         0x00000005
+#define  MAX_RXCOAL_MAXF_INT             0x000000ff
 #define HOSTCC_TXCOAL_MAXF_INT          0x00003c24
 #define  DEFAULT_TXCOAL_MAXF_INT         0x00000005
+#define  MAX_TXCOAL_MAXF_INT             0x000000ff
 #define HOSTCC_STAT_COAL_TICKS          0x00003c28
 #define  DEFAULT_STAT_COAL_TICKS         0x000f4240
+#define  MAX_STAT_COAL_TICKS             0xd693d400
+#define  MIN_STAT_COAL_TICKS             0x00000064
 /* 0x3c2c --> 0x3c30 unused */
 #define HOSTCC_STATS_BLK_HOST_ADDR      0x00003c30 /* 64-bit */
 #define HOSTCC_STATUS_BLK_HOST_ADDR     0x00003c38 /* 64-bit */