diff options
| author | nikolay@redhat.com <nikolay@redhat.com> | 2012-10-31 00:42:51 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-11-01 11:53:43 -0400 |
| commit | eb6e98a1b25fb0f347fece9814257a9e1cb537c8 (patch) | |
| tree | 8189b62ba509887a42df4fcc873bb8d4637772cb /drivers | |
| parent | 477864ddd36510e9802c2adb6d9445c2d7783fe5 (diff) | |
bonding: fix off-by-one error
Fix off-by-one error because IFNAMSIZ == 16 and when this
code gets executed we stick a NULL byte where we should not.
How to reproduce:
with CONFIG_CC_STACKPROTECTOR=y (otherwise it may pass by silently)
modprobe bonding; echo 1 > /sys/class/net/bond0/bonding/mode;
echo "AAAAAAAAAAAAAAAA" > /sys/class/net/bond0/bonding/primary;
Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/bonding/bond_sysfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c index dc15d248443f..238d9b3e2252 100644 --- a/drivers/net/bonding/bond_sysfs.c +++ b/drivers/net/bonding/bond_sysfs.c | |||
| @@ -1060,7 +1060,7 @@ static ssize_t bonding_store_primary(struct device *d, | |||
| 1060 | goto out; | 1060 | goto out; |
| 1061 | } | 1061 | } |
| 1062 | 1062 | ||
| 1063 | sscanf(buf, "%16s", ifname); /* IFNAMSIZ */ | 1063 | sscanf(buf, "%15s", ifname); /* IFNAMSIZ */ |
| 1064 | 1064 | ||
| 1065 | /* check to see if we are clearing primary */ | 1065 | /* check to see if we are clearing primary */ |
| 1066 | if (!strlen(ifname) || buf[0] == '\n') { | 1066 | if (!strlen(ifname) || buf[0] == '\n') { |