[PATCH] powerpc: Remove device_node addrs/n_addr

The pre-parsed addrs/n_addrs fields in struct device_node are finally
gone. Remove the dodgy heuristics that did that parsing at boot and
remove the fields themselves since we now have a good replacement with
the new OF parsing code. This patch also fixes a bunch of drivers to use
the new code instead, so that at least pmac32, pseries, iseries and g5
defconfigs build.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>

13 files changed, 239 insertions, 224 deletions

diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
index af7cb2bfd670..01f042f6f1c4 100644
--- a/drivers/block/swim3.c
+++ b/drivers/block/swim3.c
@@ -1083,23 +1083,33 @@ static int swim3_add_device(struct device_node *swim)
 {
         struct device_node *mediabay;
         struct floppy_state *fs = &floppy_states[floppy_count];
+        struct resource res_reg, res_dma;
 
-        if (swim->n_addrs < 2)
-        {
-                printk(KERN_INFO "swim3: expecting 2 addrs (n_addrs:%d, n_intrs:%d)\n",
-                       swim->n_addrs, swim->n_intrs);
+        if (of_address_to_resource(swim, 0, &res_reg) ||
+            of_address_to_resource(swim, 1, &res_dma)) {
+                printk(KERN_ERR "swim3: Can't get addresses\n");
                 return -EINVAL;
         }
-
-        if (swim->n_intrs < 2)
-        {
-                printk(KERN_INFO "swim3: expecting 2 intrs (n_addrs:%d, n_intrs:%d)\n",
-                       swim->n_addrs, swim->n_intrs);
+        if (request_mem_region(res_reg.start, res_reg.end - res_reg.start + 1,
+                               " (reg)") == NULL) {
+                printk(KERN_ERR "swim3: Can't request register space\n");
+                return -EINVAL;
+        }
+        if (request_mem_region(res_dma.start, res_dma.end - res_dma.start + 1,
+                               " (dma)") == NULL) {
+                release_mem_region(res_reg.start,
+                                   res_reg.end - res_reg.start + 1);
+                printk(KERN_ERR "swim3: Can't request DMA space\n");
                 return -EINVAL;
         }
 
-        if (!request_OF_resource(swim, 0, NULL)) {
-                printk(KERN_INFO "swim3: can't request IO resource !\n");
+        if (swim->n_intrs < 2) {
+                printk(KERN_INFO "swim3: expecting 2 intrs (n_intrs:%d)\n",
+                       swim->n_intrs);
+                release_mem_region(res_reg.start,
+                                   res_reg.end - res_reg.start + 1);
+                release_mem_region(res_dma.start,
+                                   res_dma.end - res_dma.start + 1);
                 return -EINVAL;
         }
 
@@ -1110,10 +1120,8 @@ static int swim3_add_device(struct device_node *swim)
         memset(fs, 0, sizeof(*fs));
         spin_lock_init(&fs->lock);
         fs->state = idle;
-        fs->swim3 = (struct swim3 __iomem *)
-                ioremap(swim->addrs[0].address, 0x200);
-        fs->dma = (struct dbdma_regs __iomem *)
-                ioremap(swim->addrs[1].address, 0x200);
+        fs->swim3 = (struct swim3 __iomem *)ioremap(res_reg.start, 0x200);
+        fs->dma = (struct dbdma_regs __iomem *)ioremap(res_dma.start, 0x200);
         fs->swim3_intr = swim->intrs[0].line;
         fs->dma_intr = swim->intrs[1].line;
         fs->cur_cyl = -1;
diff --git a/drivers/ide/ppc/pmac.c b/drivers/ide/ppc/pmac.c
index 16b28357885b..a8d3bc0a9c5c 100644
--- a/drivers/ide/ppc/pmac.c
+++ b/drivers/ide/ppc/pmac.c
@@ -1271,7 +1271,7 @@ static int
 pmac_ide_setup_device(pmac_ide_hwif_t *pmif, ide_hwif_t *hwif)
 {
         struct device_node *np = pmif->node;
-        int *bidp, i;
+        int *bidp;
 
         pmif->cable_80 = 0;
         pmif->broken_dma = pmif->broken_dma_warn = 0;
@@ -1430,7 +1430,7 @@ pmac_ide_macio_attach(struct macio_dev *mdev, const struct of_device_id *match)
         pmif = &pmac_ide[i];
         hwif = &ide_hwifs[i];
 
-        if (mdev->ofdev.node->n_addrs == 0) {
+        if (macio_resource_count(mdev) == 0) {
                 printk(KERN_WARNING "ide%d: no address for %s\n",
                        i, mdev->ofdev.node->full_name);
                 return -ENXIO;
diff --git a/drivers/macintosh/macio_asic.c b/drivers/macintosh/macio_asic.c
index 0137ff239f13..2a545ceb523b 100644
--- a/drivers/macintosh/macio_asic.c
+++ b/drivers/macintosh/macio_asic.c
@@ -256,42 +256,42 @@ static int macio_resource_quirks(struct device_node *np, struct resource *res,
 {
         if (res->flags & IORESOURCE_MEM) {
                 /* Grand Central has too large resource 0 on some machines */
-                if (index == 0 && !strcmp(np->name, "gc")) {
-                        np->addrs[0].size = 0x20000;
+                if (index == 0 && !strcmp(np->name, "gc"))
                         res->end = res->start + 0x1ffff;
-                }
+
                 /* Airport has bogus resource 2 */
                 if (index >= 2 && !strcmp(np->name, "radio"))
                         return 1;
+
+#ifndef CONFIG_PPC64
                 /* DBDMAs may have bogus sizes */
-                if ((res->start & 0x0001f000) == 0x00008000) {
-                        np->addrs[index].size = 0x100;
+                if ((res->start & 0x0001f000) == 0x00008000)
                         res->end = res->start + 0xff;
-                }
+#endif /* CONFIG_PPC64 */
+
                 /* ESCC parent eats child resources. We could have added a
                  * level of hierarchy, but I don't really feel the need
                  * for it
                  */
                 if (!strcmp(np->name, "escc"))
                         return 1;
+
                 /* ESCC has bogus resources >= 3 */
                 if (index >= 3 && !(strcmp(np->name, "ch-a") &&
                                     strcmp(np->name, "ch-b")))
                         return 1;
+
                 /* Media bay has too many resources, keep only first one */
                 if (index > 0 && !strcmp(np->name, "media-bay"))
                         return 1;
+
                 /* Some older IDE resources have bogus sizes */
                 if (!(strcmp(np->name, "IDE") && strcmp(np->name, "ATA") &&
                       strcmp(np->type, "ide") && strcmp(np->type, "ata"))) {
-                        if (index == 0 && np->addrs[0].size > 0x1000) {
-                                np->addrs[0].size = 0x1000;
+                        if (index == 0 && (res->end - res->start) > 0xfff)
                                 res->end = res->start + 0xfff;
-                        }
-                        if (index == 1 && np->addrs[1].size > 0x100) {
-                                np->addrs[1].size = 0x100;
+                        if (index == 1 && (res->end - res->start) > 0xff)
                                 res->end = res->start + 0xff;
-                        }
                 }
         }
         return 0;
@@ -349,7 +349,7 @@ static void macio_setup_resources(struct macio_dev *dev,
                 /* Currently, we consider failure as harmless, this may
                  * change in the future, once I've found all the device
                  * tree bugs in older machines & worked around them
-l                */
+                 */
                 if (insert_resource(parent_res, res)) {
                         printk(KERN_WARNING "Can't request resource "
                                "%d for MacIO device %s\n",
diff --git a/drivers/macintosh/mediabay.c b/drivers/macintosh/mediabay.c
index b856bb67169c..8dbf2852bae0 100644
--- a/drivers/macintosh/mediabay.c
+++ b/drivers/macintosh/mediabay.c
@@ -647,6 +647,7 @@ static int __devinit media_bay_attach(struct macio_dev *mdev, const struct of_de
         struct media_bay_info* bay;
         u32 __iomem *regbase;
         struct device_node *ofnode;
+        unsigned long base;
         int i;
 
         ofnode = mdev->ofdev.node;
@@ -656,10 +657,11 @@ static int __devinit media_bay_attach(struct macio_dev *mdev, const struct of_de
         if (macio_request_resources(mdev, "media-bay"))
                 return -EBUSY;
         /* Media bay registers are located at the beginning of the
-         * mac-io chip, we get the parent address for now (hrm...)
+         * mac-io chip, for now, we trick and align down the first
+         * resource passed in
          */
-        regbase = (u32 __iomem *)
-                ioremap(ofnode->parent->addrs[0].address, 0x100);
+        base = macio_resource_start(mdev, 0) & 0xffff0000u;
+        regbase = (u32 __iomem *)ioremap(base, 0x100);
         if (regbase == NULL) {
                 macio_release_resources(mdev);
                 return -ENOMEM;
diff --git a/drivers/macintosh/via-cuda.c b/drivers/macintosh/via-cuda.c
index 18ff770ea668..2d9d79150403 100644
--- a/drivers/macintosh/via-cuda.c
+++ b/drivers/macintosh/via-cuda.c
@@ -193,10 +193,6 @@ static int __init via_cuda_start(void)
     if (via == NULL)
         return -ENODEV;
 
-#ifdef CONFIG_PPC
-    request_OF_resource(vias, 0, NULL);
-#endif
-
     if (request_irq(CUDA_IRQ, cuda_interrupt, 0, "ADB", cuda_interrupt)) {
         printk(KERN_ERR "cuda_init: can't get irq %d\n", CUDA_IRQ);
         return -EAGAIN;
diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index d6dabee55f2f..79c7b44a94ee 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -298,7 +298,7 @@ static struct backlight_controller pmu_backlight_controller = {
 
 int __init find_via_pmu(void)
 {
-        phys_addr_t taddr;
+        u64 taddr;
         u32 *reg;
 
         if (via != 0)
@@ -337,7 +337,7 @@ int __init find_via_pmu(void)
         else if (device_is_compatible(vias->parent, "Keylargo")
                  || device_is_compatible(vias->parent, "K2-Keylargo")) {
                 struct device_node *gpiop;
-                phys_addr_t gaddr = 0;
+                u64 gaddr = OF_BAD_ADDR;
 
                 pmu_kind = PMU_KEYLARGO_BASED;
                 pmu_has_adb = (find_type_devices("adb") != NULL);
@@ -352,7 +352,7 @@ int __init find_via_pmu(void)
                         reg = (u32 *)get_property(gpiop, "reg", NULL);
                         if (reg)
                                 gaddr = of_translate_address(gpiop, reg);
-                        if (gaddr != 0)
+                        if (gaddr != OF_BAD_ADDR)
                                 gpio_reg = ioremap(gaddr, 0x10);
                 }
                 if (gpio_reg == NULL)
@@ -479,9 +479,6 @@ static int __init via_pmu_dev_init(void)
         if (vias == NULL)
                 return -ENODEV;
 
-#ifndef CONFIG_PPC64
-        request_OF_resource(vias, 0, NULL);
-#endif
 #ifdef CONFIG_PMAC_BACKLIGHT
         /* Enable backlight */
         register_backlight_controller(&pmu_backlight_controller, NULL, "pmu");
diff --git a/drivers/scsi/mac53c94.c b/drivers/scsi/mac53c94.c
index 932dcf0366eb..311a4122bd70 100644
--- a/drivers/scsi/mac53c94.c
+++ b/drivers/scsi/mac53c94.c
@@ -432,11 +432,12 @@ static int mac53c94_probe(struct macio_dev *mdev, const struct of_device_id *mat
         struct Scsi_Host *host;
         void *dma_cmd_space;
         unsigned char *clkprop;
-        int proplen;
+        int proplen, rc = -ENODEV;
 
         if (macio_resource_count(mdev) != 2 || macio_irq_count(mdev) != 2) {
-                printk(KERN_ERR "mac53c94: expected 2 addrs and intrs (got %d/%d)\n",
-                       node->n_addrs, node->n_intrs);
+                printk(KERN_ERR "mac53c94: expected 2 addrs and intrs"
+                       " (got %d/%d)\n",
+                       macio_resource_count(mdev), macio_irq_count(mdev));
                 return -ENODEV;
         }
 
@@ -448,6 +449,7 @@ static int mac53c94_probe(struct macio_dev *mdev, const struct of_device_id *mat
         host = scsi_host_alloc(&mac53c94_template, sizeof(struct fsc_state));
         if (host == NULL) {
                 printk(KERN_ERR "mac53c94: couldn't register host");
+                rc = -ENOMEM;
                 goto out_release;
         }
 
@@ -486,6 +488,7 @@ static int mac53c94_probe(struct macio_dev *mdev, const struct of_device_id *mat
         if (dma_cmd_space == 0) {
                 printk(KERN_ERR "mac53c94: couldn't allocate dma "
                        "command space for %s\n", node->full_name);
+                rc = -ENOMEM;
                 goto out_free;
         }
         state->dma_cmds = (struct dbdma_cmd *)DBDMA_ALIGN(dma_cmd_space);
@@ -495,18 +498,21 @@ static int mac53c94_probe(struct macio_dev *mdev, const struct of_device_id *mat
 
         mac53c94_init(state);
 
-        if (request_irq(state->intr, do_mac53c94_interrupt, 0, "53C94", state)) {
+        if (request_irq(state->intr, do_mac53c94_interrupt, 0, "53C94",state)) {
                 printk(KERN_ERR "mac53C94: can't get irq %d for %s\n",
                        state->intr, node->full_name);
                 goto out_free_dma;
         }
 
-        /* XXX FIXME: handle failure */
-        scsi_add_host(host, &mdev->ofdev.dev);
-        scsi_scan_host(host);
+        rc = scsi_add_host(host, &mdev->ofdev.dev);
+        if (rc != 0)
+                goto out_release_irq;
 
+        scsi_scan_host(host);
         return 0;
 
+ out_release_irq:
+        free_irq(state->intr, state);
  out_free_dma:
         kfree(state->dma_cmd_space);
  out_free:
@@ -518,7 +524,7 @@ static int mac53c94_probe(struct macio_dev *mdev, const struct of_device_id *mat
  out_release:
         macio_release_resources(mdev);
 
-        return  -ENODEV;
+        return rc;
 }
 
 static int mac53c94_remove(struct macio_dev *mdev)
diff --git a/drivers/scsi/mesh.c b/drivers/scsi/mesh.c
index bdccf73cf9fe..d6d2125f9044 100644
--- a/drivers/scsi/mesh.c
+++ b/drivers/scsi/mesh.c
@@ -1869,7 +1869,8 @@ static int mesh_probe(struct macio_dev *mdev, const struct of_device_id *match)
 
         if (macio_resource_count(mdev) != 2 || macio_irq_count(mdev) != 2) {
                 printk(KERN_ERR "mesh: expected 2 addrs and 2 intrs"
-                       " (got %d,%d)\n", mesh->n_addrs, mesh->n_intrs);
+                       " (got %d,%d)\n", macio_resource_count(mdev),
+                       macio_irq_count(mdev));
                 return -ENODEV;
         }
 
diff --git a/drivers/serial/pmac_zilog.c b/drivers/serial/pmac_zilog.c
index 5ddd8ab1f108..ea24129eb6b9 100644
--- a/drivers/serial/pmac_zilog.c
+++ b/drivers/serial/pmac_zilog.c
@@ -1431,11 +1431,14 @@ static int __init pmz_init_port(struct uart_pmac_port *uap)
                 char    name[1];
         } *slots;
         int len;
+        struct resource r_ports, r_rxdma, r_txdma;
 
         /*
          * Request & map chip registers
          */
-        uap->port.mapbase = np->addrs[0].address;
+        if (of_address_to_resource(np, 0, &r_ports))
+                return -ENODEV;
+        uap->port.mapbase = r_ports.start;
         uap->port.membase = ioremap(uap->port.mapbase, 0x1000);
       
         uap->control_reg = uap->port.membase;
@@ -1445,16 +1448,20 @@ static int __init pmz_init_port(struct uart_pmac_port *uap)
          * Request & map DBDMA registers
          */
 #ifdef HAS_DBDMA
-        if (np->n_addrs >= 3 && np->n_intrs >= 3)
+        if (of_address_to_resource(np, 1, &r_txdma) == 0 &&
+            of_address_to_resource(np, 2, &r_rxdma) == 0)
                 uap->flags |= PMACZILOG_FLAG_HAS_DMA;
+#else
+        memset(&r_txdma, 0, sizeof(struct resource));
+        memset(&r_rxdma, 0, sizeof(struct resource));
 #endif  
         if (ZS_HAS_DMA(uap)) {
-                uap->tx_dma_regs = ioremap(np->addrs[np->n_addrs - 2].address, 0x1000);
+                uap->tx_dma_regs = ioremap(r_txdma.start, 0x100);
                 if (uap->tx_dma_regs == NULL) { 
                         uap->flags &= ~PMACZILOG_FLAG_HAS_DMA;
                         goto no_dma;
                 }
-                uap->rx_dma_regs = ioremap(np->addrs[np->n_addrs - 1].address, 0x1000);
+                uap->rx_dma_regs = ioremap(r_rxdma.start, 0x100);
                 if (uap->rx_dma_regs == NULL) { 
                         iounmap(uap->tx_dma_regs);
                         uap->tx_dma_regs = NULL;
diff --git a/drivers/video/controlfb.c b/drivers/video/controlfb.c
index 403d17377f8d..03798e9c882d 100644
--- a/drivers/video/controlfb.c
+++ b/drivers/video/controlfb.c
@@ -133,12 +133,6 @@ static int controlfb_mmap(struct fb_info *info, struct file *file,
 static int controlfb_set_par (struct fb_info *info);
 static int controlfb_check_var (struct fb_var_screeninfo *var, struct fb_info *info);
 
-/*
- * inititialization
- */
-int control_init(void);
-void control_setup(char *);
-
 /******************** Prototypes for internal functions **********************/
 
 static void set_control_clock(unsigned char *params);
@@ -550,9 +544,46 @@ static void control_set_hardware(struct fb_info_control *p, struct fb_par_contro
 
 
 /*
- * Called from fbmem.c for probing & initializing
+ * Parse user speficied options (`video=controlfb:')
  */
-int __init control_init(void)
+static void __init control_setup(char *options)
+{
+        char *this_opt;
+
+        if (!options || !*options)
+                return;
+
+        while ((this_opt = strsep(&options, ",")) != NULL) {
+                if (!strncmp(this_opt, "vmode:", 6)) {
+                        int vmode = simple_strtoul(this_opt+6, NULL, 0);
+                        if (vmode > 0 && vmode <= VMODE_MAX &&
+                            control_mac_modes[vmode - 1].m[1] >= 0)
+                                default_vmode = vmode;
+                } else if (!strncmp(this_opt, "cmode:", 6)) {
+                        int depth = simple_strtoul(this_opt+6, NULL, 0);
+                        switch (depth) {
+                         case CMODE_8:
+                         case CMODE_16:
+                         case CMODE_32:
+                                default_cmode = depth;
+                                break;
+                         case 8:
+                                default_cmode = CMODE_8;
+                                break;
+                         case 15:
+                         case 16:
+                                default_cmode = CMODE_16;
+                                break;
+                         case 24:
+                         case 32:
+                                default_cmode = CMODE_32;
+                                break;
+                        }
+                }
+        }
+}
+
+static int __init control_init(void)
 {
         struct device_node *dp;
         char *option = NULL;
@@ -651,15 +682,16 @@ static void __init find_vram_size(struct fb_info_control *p)
 static int __init control_of_init(struct device_node *dp)
 {
         struct fb_info_control  *p;
-        unsigned long           addr;
-        int                     i;
+        struct resource         fb_res, reg_res;
 
         if (control_fb) {
                 printk(KERN_ERR "controlfb: only one control is supported\n");
                 return -ENXIO;
         }
-        if(dp->n_addrs != 2) {
-                printk(KERN_ERR "expecting 2 address for control (got %d)", dp->n_addrs);
+
+        if (of_pci_address_to_resource(dp, 2, &fb_res) ||
+            of_pci_address_to_resource(dp, 1, &reg_res)) {
+                printk(KERN_ERR "can't get 2 addresses for control\n");
                 return -ENXIO;
         }
         p = kmalloc(sizeof(*p), GFP_KERNEL);
@@ -669,18 +701,12 @@ static int __init control_of_init(struct device_node *dp)
         memset(p, 0, sizeof(*p));
 
         /* Map in frame buffer and registers */
-        for (i = 0; i < dp->n_addrs; ++i) {
-                addr = dp->addrs[i].address;
-                if (dp->addrs[i].size >= 0x800000) {
-                        p->fb_orig_base = addr;
-                        p->fb_orig_size = dp->addrs[i].size;
-                        /* use the big-endian aperture (??) */
-                        p->frame_buffer_phys = addr + 0x800000;
-                } else {
-                        p->control_regs_phys = addr;
-                        p->control_regs_size = dp->addrs[i].size;
-                }
-        }
+        p->fb_orig_base = fb_res.start;
+        p->fb_orig_size = fb_res.end - fb_res.start + 1;
+        /* use the big-endian aperture (??) */
+        p->frame_buffer_phys = fb_res.start + 0x800000;
+        p->control_regs_phys = reg_res.start;
+        p->control_regs_size = reg_res.end - reg_res.start + 1;
 
         if (!p->fb_orig_base ||
             !request_mem_region(p->fb_orig_base,p->fb_orig_size,"controlfb")) {
@@ -1059,43 +1085,3 @@ static void control_cleanup(void)
 }
 
 
-/*
- * Parse user speficied options (`video=controlfb:')
- */
-void __init control_setup(char *options)
-{
-        char *this_opt;
-
-        if (!options || !*options)
-                return;
-
-        while ((this_opt = strsep(&options, ",")) != NULL) {
-                if (!strncmp(this_opt, "vmode:", 6)) {
-                        int vmode = simple_strtoul(this_opt+6, NULL, 0);
-                        if (vmode > 0 && vmode <= VMODE_MAX &&
-                            control_mac_modes[vmode - 1].m[1] >= 0)
-                                default_vmode = vmode;
-                } else if (!strncmp(this_opt, "cmode:", 6)) {
-                        int depth = simple_strtoul(this_opt+6, NULL, 0);
-                        switch (depth) {
-                         case CMODE_8:
-                         case CMODE_16:
-                         case CMODE_32:
-                                default_cmode = depth;
-                                break;
-                         case 8:
-                                default_cmode = CMODE_8;
-                                break;
-                         case 15:
-                         case 16:
-                                default_cmode = CMODE_16;
-                                break;
-                         case 24:
-                         case 32:
-                                default_cmode = CMODE_32;
-                                break;
-                        }
-                }
-        }
-}
-
diff --git a/drivers/video/offb.c b/drivers/video/offb.c
index 00d87f5bb7be..ad1434e3f227 100644
--- a/drivers/video/offb.c
+++ b/drivers/video/offb.c
@@ -223,6 +223,7 @@ static int offb_blank(int blank, struct fb_info *info)
 int __init offb_init(void)
 {
         struct device_node *dp = NULL, *boot_disp = NULL;
+
 #if defined(CONFIG_BOOTX_TEXT) && defined(CONFIG_PPC32)
         struct device_node *macos_display = NULL;
 #endif
@@ -234,60 +235,54 @@ int __init offb_init(void)
         if (boot_infos != 0) {
                 unsigned long addr =
                     (unsigned long) boot_infos->dispDeviceBase;
+                u32 *addrp;
+                u64 daddr, dsize;
+                unsigned int flags;
+
                 /* find the device node corresponding to the macos display */
                 while ((dp = of_find_node_by_type(dp, "display"))) {
                         int i;
-                        /*
-                         * Grrr...  It looks like the MacOS ATI driver
-                         * munges the assigned-addresses property (but
-                         * the AAPL,address value is OK).
-                         */
-                        if (strncmp(dp->name, "ATY,", 4) == 0
-                            && dp->n_addrs == 1) {
-                                unsigned int *ap =
-                                    (unsigned int *) get_property(dp,
-                                                                  "AAPL,address",
-                                                                  NULL);
-                                if (ap != NULL) {
-                                        dp->addrs[0].address = *ap;
-                                        dp->addrs[0].size = 0x01000000;
-                                }
-                        }
 
                         /*
-                         * The LTPro on the Lombard powerbook has no addresses
-                         * on the display nodes, they are on their parent.
+                         * Look for an AAPL,address property first.
                          */
-                        if (dp->n_addrs == 0
-                            && device_is_compatible(dp, "ATY,264LTPro")) {
-                                int na;
-                                unsigned int *ap = (unsigned int *)
-                                    get_property(dp, "AAPL,address", &na);
-                                if (ap != 0)
-                                        for (na /= sizeof(unsigned int);
-                                             na > 0; --na, ++ap)
-                                                if (*ap <= addr
-                                                    && addr <
-                                                    *ap + 0x1000000)
-                                                        goto foundit;
+                        unsigned int na;
+                        unsigned int *ap =
+                                (unsigned int *)get_property(dp, "AAPL,address",
+                                                             &na);
+                        if (ap != 0) {
+                                for (na /= sizeof(unsigned int); na > 0;
+                                     --na, ++ap)
+                                        if (*ap <= addr &&
+                                            addr < *ap + 0x1000000) {
+                                                macos_display = dp;
+                                                goto foundit;
+                                        }
                         }
 
                         /*
                          * See if the display address is in one of the address
                          * ranges for this display.
                          */
-                        for (i = 0; i < dp->n_addrs; ++i) {
-                                if (dp->addrs[i].address <= addr
-                                    && addr <
-                                    dp->addrs[i].address +
-                                    dp->addrs[i].size)
+                        i = 0;
+                        for (;;) {
+                                addrp = of_get_address(dp, i++, &dsize, &flags);
+                                if (addrp == NULL)
                                         break;
+                                if (!(flags & IORESOURCE_MEM))
+                                        continue;
+                                daddr = of_translate_address(dp, addrp);
+                                if (daddr == OF_BAD_ADDR)
+                                        continue;
+                                if (daddr <= addr && addr < (daddr + dsize)) {
+                                        macos_display = dp;
+                                        goto foundit;
+                                }
                         }
-                        if (i < dp->n_addrs) {
-                              foundit:
+                foundit:
+                        if (macos_display) {
                                 printk(KERN_INFO "MacOS display is %s\n",
                                        dp->full_name);
-                                macos_display = dp;
                                 break;
                         }
                 }
@@ -326,8 +321,10 @@ static void __init offb_init_nodriver(struct device_node *dp)
         int *pp, i;
         unsigned int len;
         int width = 640, height = 480, depth = 8, pitch;
-        unsigned int rsize, *up;
-        unsigned long address = 0;
+        unsigned int flags, rsize, *up;
+        u64 address = OF_BAD_ADDR;
+        u32 *addrp;
+        u64 asize;
 
         if ((pp = (int *) get_property(dp, "depth", &len)) != NULL
             && len == sizeof(int))
@@ -363,7 +360,7 @@ static void __init offb_init_nodriver(struct device_node *dp)
                                break;
                }
                if (pdev) {
-                       for (i = 0; i < 6 && address == 0; i++) {
+                       for (i = 0; i < 6 && address == OF_BAD_ADDR; i++) {
                                if ((pci_resource_flags(pdev, i) &
                                     IORESOURCE_MEM) &&
                                    (pci_resource_len(pdev, i) >= rsize))
@@ -374,27 +371,33 @@ static void __init offb_init_nodriver(struct device_node *dp)
         }
 #endif /* CONFIG_PCI */
 
-        if (address == 0 &&
-            (up = (unsigned *) get_property(dp, "address", &len)) != NULL &&
-            len == sizeof(unsigned))
-                address = (u_long) * up;
-        if (address == 0) {
-                for (i = 0; i < dp->n_addrs; ++i)
-                        if (dp->addrs[i].size >=
-                            pitch * height * depth / 8)
-                                break;
-                if (i >= dp->n_addrs) {
+       /* This one is dodgy, we may drop it ... */
+       if (address == OF_BAD_ADDR &&
+           (up = (unsigned *) get_property(dp, "address", &len)) != NULL &&
+           len == sizeof(unsigned int))
+               address = (u64) * up;
+
+       if (address == OF_BAD_ADDR) {
+               for (i = 0; (addrp = of_get_address(dp, i, &asize, &flags))
+                            != NULL; i++) {
+                       if (!(flags & IORESOURCE_MEM))
+                               continue;
+                       if (asize >= pitch * height * depth / 8)
+                               break;
+               }
+                if (addrp == NULL) {
                         printk(KERN_ERR
                                "no framebuffer address found for %s\n",
                                dp->full_name);
                         return;
                 }
-
-                address = (u_long) dp->addrs[i].address;
-
-#ifdef CONFIG_PPC64
-                address += ((struct pci_dn *)dp->data)->phb->pci_mem_offset;
-#endif
+                address = of_translate_address(dp, addrp);
+                if (address == OF_BAD_ADDR) {
+                        printk(KERN_ERR
+                               "can't translate framebuffer address for %s\n",
+                               dp->full_name);
+                        return;
+                }
 
                 /* kludge for valkyrie */
                 if (strcmp(dp->name, "valkyrie") == 0)
@@ -459,7 +462,9 @@ static void __init offb_init_fb(const char *name, const char *full_name,
 
         par->cmap_type = cmap_unknown;
         if (depth == 8) {
-                /* XXX kludge for ati */
+
+                /* Palette hacks disabled for now */
+#if 0
                 if (dp && !strncmp(name, "ATY,Rage128", 11)) {
                         unsigned long regbase = dp->addrs[2].address;
                         par->cmap_adr = ioremap(regbase, 0x1FFF);
@@ -490,6 +495,7 @@ static void __init offb_init_fb(const char *name, const char *full_name,
                         par->cmap_adr = ioremap(regbase + 0x6000, 0x1000);
                         par->cmap_type = cmap_gxt2000;
                 }
+#endif
                 fix->visual = par->cmap_adr ? FB_VISUAL_PSEUDOCOLOR
                     : FB_VISUAL_STATIC_PSEUDOCOLOR;
         } else
diff --git a/drivers/video/platinumfb.c b/drivers/video/platinumfb.c
index ba0af1b66bb6..335e37465559 100644
--- a/drivers/video/platinumfb.c
+++ b/drivers/video/platinumfb.c
@@ -69,6 +69,8 @@ struct fb_info_platinum {
         unsigned long                   total_vram;
         int                             clktype;
         int                             dactype;
+
+        struct resource                 rsrc_fb, rsrc_reg;
 };
 
 /*
@@ -97,9 +99,6 @@ static int platinum_var_to_par(struct fb_var_screeninfo *var,
  * Interface used by the world
  */
 
-int platinumfb_init(void);
-int platinumfb_setup(char*);
-
 static struct fb_ops platinumfb_ops = {
         .owner =        THIS_MODULE,
         .fb_check_var   = platinumfb_check_var,
@@ -485,7 +484,7 @@ static int platinum_var_to_par(struct fb_var_screeninfo *var,
 /* 
  * Parse user speficied options (`video=platinumfb:')
  */
-int __init platinumfb_setup(char *options)
+static int __init platinumfb_setup(char *options)
 {
         char *this_opt;
 
@@ -526,19 +525,15 @@ int __init platinumfb_setup(char *options)
 #define invalidate_cache(addr)
 #endif
 
-static int __devinit platinumfb_probe(struct of_device* odev, const struct of_device_id *match)
+static int __devinit platinumfb_probe(struct of_device* odev,
+                                      const struct of_device_id *match)
 {
         struct device_node      *dp = odev->node;
         struct fb_info          *info;
         struct fb_info_platinum *pinfo;
-        unsigned long           addr, size;
         volatile __u8           *fbuffer;
-        int                     i, bank0, bank1, bank2, bank3, rc;
+        int                     bank0, bank1, bank2, bank3, rc;
 
-        if (dp->n_addrs != 2) {
-                printk(KERN_ERR "expecting 2 address for platinum (got %d)", dp->n_addrs);
-                return -ENXIO;
-        }
         printk(KERN_INFO "platinumfb: Found Apple Platinum video hardware\n");
 
         info = framebuffer_alloc(sizeof(*pinfo), &odev->dev);
@@ -546,26 +541,39 @@ static int __devinit platinumfb_probe(struct of_device* odev, const struct of_de
                 return -ENOMEM;
         pinfo = info->par;
 
-        /* Map in frame buffer and registers */
-        for (i = 0; i < dp->n_addrs; ++i) {
-                addr = dp->addrs[i].address;
-                size = dp->addrs[i].size;
-                /* Let's assume we can request either all or nothing */
-                if (!request_mem_region(addr, size, "platinumfb")) {
-                        framebuffer_release(info);
-                        return -ENXIO;
-                }
-                if (size >= 0x400000) {
-                        /* frame buffer - map only 4MB */
-                        pinfo->frame_buffer_phys = addr;
-                        pinfo->frame_buffer = __ioremap(addr, 0x400000, _PAGE_WRITETHRU);
-                        pinfo->base_frame_buffer = pinfo->frame_buffer;
-                } else {
-                        /* registers */
-                        pinfo->platinum_regs_phys = addr;
-                        pinfo->platinum_regs = ioremap(addr, size);
-                }
+        if (of_address_to_resource(dp, 0, &pinfo->rsrc_reg) ||
+            of_address_to_resource(dp, 1, &pinfo->rsrc_fb)) {
+                printk(KERN_ERR "platinumfb: Can't get resources\n");
+                framebuffer_release(info);
+                return -ENXIO;
         }
+        if (!request_mem_region(pinfo->rsrc_reg.start,
+                                pinfo->rsrc_reg.start -
+                                pinfo->rsrc_reg.end + 1,
+                                "platinumfb registers")) {
+                framebuffer_release(info);
+                return -ENXIO;
+        }
+        if (!request_mem_region(pinfo->rsrc_fb.start,
+                                pinfo->rsrc_fb.start
+                                - pinfo->rsrc_fb.end + 1,
+                                "platinumfb framebuffer")) {
+                release_mem_region(pinfo->rsrc_reg.start,
+                                   pinfo->rsrc_reg.end -
+                                   pinfo->rsrc_reg.start + 1);
+                framebuffer_release(info);
+                return -ENXIO;
+        }
+
+        /* frame buffer - map only 4MB */
+        pinfo->frame_buffer_phys = pinfo->rsrc_fb.start;
+        pinfo->frame_buffer = __ioremap(pinfo->rsrc_fb.start, 0x400000,
+                                        _PAGE_WRITETHRU);
+        pinfo->base_frame_buffer = pinfo->frame_buffer;
+
+        /* registers */
+        pinfo->platinum_regs_phys = pinfo->rsrc_reg.start;
+        pinfo->platinum_regs = ioremap(pinfo->rsrc_reg.start, 0x1000);
 
         pinfo->cmap_regs_phys = 0xf301b000;     /* XXX not in prom? */
         request_mem_region(pinfo->cmap_regs_phys, 0x1000, "platinumfb cmap");
@@ -628,18 +636,16 @@ static int __devexit platinumfb_remove(struct of_device* odev)
 {
         struct fb_info          *info = dev_get_drvdata(&odev->dev);
         struct fb_info_platinum *pinfo = info->par;
-        struct device_node *dp = odev->node;
-        unsigned long addr, size;
-        int i;
         
         unregister_framebuffer (info);
         
         /* Unmap frame buffer and registers */
-        for (i = 0; i < dp->n_addrs; ++i) {
-                addr = dp->addrs[i].address;
-                size = dp->addrs[i].size;
-                release_mem_region(addr, size);
-        }
+        release_mem_region(pinfo->rsrc_fb.start,
+                           pinfo->rsrc_fb.end -
+                           pinfo->rsrc_fb.start + 1);
+        release_mem_region(pinfo->rsrc_reg.start,
+                           pinfo->rsrc_reg.end -
+                           pinfo->rsrc_reg.start + 1);
         iounmap(pinfo->frame_buffer);
         iounmap(pinfo->platinum_regs);
         release_mem_region(pinfo->cmap_regs_phys, 0x1000);
@@ -666,7 +672,7 @@ static struct of_platform_driver platinum_driver =
         .remove         = platinumfb_remove,
 };
 
-int __init platinumfb_init(void)
+static int __init platinumfb_init(void)
 {
 #ifndef MODULE
         char *option = NULL;
@@ -680,7 +686,7 @@ int __init platinumfb_init(void)
         return 0;
 }
 
-void __exit platinumfb_exit(void)
+static void __exit platinumfb_exit(void)
 {
         of_unregister_driver(&platinum_driver); 
 }
diff --git a/drivers/video/valkyriefb.c b/drivers/video/valkyriefb.c
index ce97ec8eae97..2bdeb4baa952 100644
--- a/drivers/video/valkyriefb.c
+++ b/drivers/video/valkyriefb.c
@@ -342,19 +342,19 @@ int __init valkyriefb_init(void)
 #else /* ppc (!CONFIG_MAC) */
         {
                 struct device_node *dp;
+                struct resource r;
 
-                dp = find_devices("valkyrie");
+                dp = of_find_node_by_name(NULL, "valkyrie");
                 if (dp == 0)
                         return 0;
 
-                if (dp->n_addrs != 1) {
-                        printk(KERN_ERR "expecting 1 address for valkyrie (got %d)\n",
-                               dp->n_addrs);
+                if (of_address_to_resource(dp, 0, &r)) {
+                        printk(KERN_ERR "can't find address for valkyrie\n");
                         return 0;
                 }
 
-                frame_buffer_phys = dp->addrs[0].address;
-                cmap_regs_phys = dp->addrs[0].address+0x304000;
+                frame_buffer_phys = r.start;
+                cmap_regs_phys = r.start + 0x304000;
                 flags = _PAGE_WRITETHRU;
         }
 #endif /* ppc (!CONFIG_MAC) */