diff options
author | Andi Kleen <ak@linux.intel.com> | 2008-07-17 19:42:20 -0400 |
---|---|---|
committer | Andi Kleen <ak@linux.intel.com> | 2008-07-17 19:42:20 -0400 |
commit | b1d77fae0c429d1be84ca0c9e627d9ab0e2a6d0b (patch) | |
tree | 0a518b0163e2f1e9a5f20ae25580fc5998b30147 /drivers | |
parent | 5b664cb235e97afbf34db9c4d77f08ebd725335e (diff) |
Revert "Fix FADT parsing"
This reverts commit 01a5bba576b9364b33f61f0cd9fa70c2cf5535e2.
There seem to be some FADTs around with bogus information
in the v2 fields. Revert this patch for now until
this can be properly resolved.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/acpi/tables/tbfadt.c | 17 |
1 files changed, 6 insertions, 11 deletions
diff --git a/drivers/acpi/tables/tbfadt.c b/drivers/acpi/tables/tbfadt.c index ccb5b64bbef3..a4a41ba2484b 100644 --- a/drivers/acpi/tables/tbfadt.c +++ b/drivers/acpi/tables/tbfadt.c | |||
@@ -124,7 +124,7 @@ static struct acpi_fadt_info fadt_info_table[] = { | |||
124 | 124 | ||
125 | static void inline | 125 | static void inline |
126 | acpi_tb_init_generic_address(struct acpi_generic_address *generic_address, | 126 | acpi_tb_init_generic_address(struct acpi_generic_address *generic_address, |
127 | u8 byte_width, u64 address) | 127 | u8 bit_width, u64 address) |
128 | { | 128 | { |
129 | 129 | ||
130 | /* | 130 | /* |
@@ -136,7 +136,7 @@ acpi_tb_init_generic_address(struct acpi_generic_address *generic_address, | |||
136 | /* All other fields are byte-wide */ | 136 | /* All other fields are byte-wide */ |
137 | 137 | ||
138 | generic_address->space_id = ACPI_ADR_SPACE_SYSTEM_IO; | 138 | generic_address->space_id = ACPI_ADR_SPACE_SYSTEM_IO; |
139 | generic_address->bit_width = byte_width << 3; | 139 | generic_address->bit_width = bit_width; |
140 | generic_address->bit_offset = 0; | 140 | generic_address->bit_offset = 0; |
141 | generic_address->access_width = 0; | 141 | generic_address->access_width = 0; |
142 | } | 142 | } |
@@ -343,11 +343,9 @@ static void acpi_tb_convert_fadt(void) | |||
343 | * | 343 | * |
344 | * The PM event blocks are split into two register blocks, first is the | 344 | * The PM event blocks are split into two register blocks, first is the |
345 | * PM Status Register block, followed immediately by the PM Enable Register | 345 | * PM Status Register block, followed immediately by the PM Enable Register |
346 | * block. Each is of length (xpm1x_event_block.bit_width/2) | 346 | * block. Each is of length (pm1_event_length/2) |
347 | */ | 347 | */ |
348 | WARN_ON(ACPI_MOD_16(acpi_gbl_FADT.xpm1a_event_block.bit_width)); | 348 | pm1_register_length = (u8) ACPI_DIV_2(acpi_gbl_FADT.pm1_event_length); |
349 | pm1_register_length = (u8) ACPI_DIV_16(acpi_gbl_FADT | ||
350 | .xpm1a_event_block.bit_width); | ||
351 | 349 | ||
352 | /* The PM1A register block is required */ | 350 | /* The PM1A register block is required */ |
353 | 351 | ||
@@ -362,17 +360,14 @@ static void acpi_tb_convert_fadt(void) | |||
362 | /* The PM1B register block is optional, ignore if not present */ | 360 | /* The PM1B register block is optional, ignore if not present */ |
363 | 361 | ||
364 | if (acpi_gbl_FADT.xpm1b_event_block.address) { | 362 | if (acpi_gbl_FADT.xpm1b_event_block.address) { |
365 | WARN_ON(ACPI_MOD_16(acpi_gbl_FADT.xpm1b_event_block.bit_width)); | ||
366 | pm1_register_length = (u8) ACPI_DIV_16(acpi_gbl_FADT | ||
367 | .xpm1b_event_block | ||
368 | .bit_width); | ||
369 | acpi_tb_init_generic_address(&acpi_gbl_xpm1b_enable, | 363 | acpi_tb_init_generic_address(&acpi_gbl_xpm1b_enable, |
370 | pm1_register_length, | 364 | pm1_register_length, |
371 | (acpi_gbl_FADT.xpm1b_event_block. | 365 | (acpi_gbl_FADT.xpm1b_event_block. |
372 | address + pm1_register_length)); | 366 | address + pm1_register_length)); |
373 | /* Don't forget to copy space_id of the GAS */ | 367 | /* Don't forget to copy space_id of the GAS */ |
374 | acpi_gbl_xpm1b_enable.space_id = | 368 | acpi_gbl_xpm1b_enable.space_id = |
375 | acpi_gbl_FADT.xpm1b_event_block.space_id; | 369 | acpi_gbl_FADT.xpm1a_event_block.space_id; |
370 | |||
376 | } | 371 | } |
377 | } | 372 | } |
378 | 373 | ||