diff options
author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2005-11-19 21:35:22 -0500 |
---|---|---|
committer | Jody McIntyre <scjody@modernduck.com> | 2005-11-19 21:35:22 -0500 |
commit | 977545e35289b13981614a57fd6c9b82d55e3b4a (patch) | |
tree | fcc58ffce6aadf392004c6e0bbbb0d4276c6116d /drivers | |
parent | e4cda1654e5c0be4b68e29011e8dc04977286df9 (diff) |
sbp2: slimmer interface to scsi_mod
- sbp2scsi_reset does not need to take host_lock
- sbp2scsi_reset, as our device reset handler, does not need to stand in as
bus reset or host reset handler
- let scsi_mod use scsi_host_template.name instead of .info
(sbp2 is not an emulation anway)
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Jody McIntyre <scjody@modernduck.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/ieee1394/sbp2.c | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c index 84875cd5a70d..f0763b797238 100644 --- a/drivers/ieee1394/sbp2.c +++ b/drivers/ieee1394/sbp2.c | |||
@@ -2609,27 +2609,17 @@ static int sbp2scsi_reset(struct scsi_cmnd *SCpnt) | |||
2609 | { | 2609 | { |
2610 | struct scsi_id_instance_data *scsi_id = | 2610 | struct scsi_id_instance_data *scsi_id = |
2611 | (struct scsi_id_instance_data *)SCpnt->device->host->hostdata[0]; | 2611 | (struct scsi_id_instance_data *)SCpnt->device->host->hostdata[0]; |
2612 | unsigned long flags; | ||
2613 | 2612 | ||
2614 | SBP2_ERR("reset requested"); | 2613 | SBP2_ERR("reset requested"); |
2615 | 2614 | ||
2616 | spin_lock_irqsave(SCpnt->device->host->host_lock, flags); | ||
2617 | |||
2618 | if (sbp2util_node_is_available(scsi_id)) { | 2615 | if (sbp2util_node_is_available(scsi_id)) { |
2619 | SBP2_ERR("Generating sbp2 fetch agent reset"); | 2616 | SBP2_ERR("Generating sbp2 fetch agent reset"); |
2620 | sbp2_agent_reset(scsi_id, 0); | 2617 | sbp2_agent_reset(scsi_id, 0); |
2621 | } | 2618 | } |
2622 | 2619 | ||
2623 | spin_unlock_irqrestore(SCpnt->device->host->host_lock, flags); | ||
2624 | |||
2625 | return SUCCESS; | 2620 | return SUCCESS; |
2626 | } | 2621 | } |
2627 | 2622 | ||
2628 | static const char *sbp2scsi_info(struct Scsi_Host *host) | ||
2629 | { | ||
2630 | return "SCSI emulation for IEEE-1394 SBP-2 Devices"; | ||
2631 | } | ||
2632 | |||
2633 | static ssize_t sbp2_sysfs_ieee1394_id_show(struct device *dev, | 2623 | static ssize_t sbp2_sysfs_ieee1394_id_show(struct device *dev, |
2634 | struct device_attribute *attr, | 2624 | struct device_attribute *attr, |
2635 | char *buf) | 2625 | char *buf) |
@@ -2666,12 +2656,9 @@ static struct scsi_host_template scsi_driver_template = { | |||
2666 | .module = THIS_MODULE, | 2656 | .module = THIS_MODULE, |
2667 | .name = "SBP-2 IEEE-1394", | 2657 | .name = "SBP-2 IEEE-1394", |
2668 | .proc_name = SBP2_DEVICE_NAME, | 2658 | .proc_name = SBP2_DEVICE_NAME, |
2669 | .info = sbp2scsi_info, | ||
2670 | .queuecommand = sbp2scsi_queuecommand, | 2659 | .queuecommand = sbp2scsi_queuecommand, |
2671 | .eh_abort_handler = sbp2scsi_abort, | 2660 | .eh_abort_handler = sbp2scsi_abort, |
2672 | .eh_device_reset_handler = sbp2scsi_reset, | 2661 | .eh_device_reset_handler = sbp2scsi_reset, |
2673 | .eh_bus_reset_handler = sbp2scsi_reset, | ||
2674 | .eh_host_reset_handler = sbp2scsi_reset, | ||
2675 | .slave_alloc = sbp2scsi_slave_alloc, | 2662 | .slave_alloc = sbp2scsi_slave_alloc, |
2676 | .slave_configure = sbp2scsi_slave_configure, | 2663 | .slave_configure = sbp2scsi_slave_configure, |
2677 | .slave_destroy = sbp2scsi_slave_destroy, | 2664 | .slave_destroy = sbp2scsi_slave_destroy, |