ide: remove obsoleted "idex=base[,ctl[,irq]]" kernel parameters (take 2)

* Remove obsoleted "idex=base[,ctl[,irq]]" kernel parameters
  and update Documentation/ide/ide.txt.

* Remove no longer needed ide_forced chipset type.

v2:
* is_chipset_set[] -> is_chipset_set in ide.c.

* Documentation/ide/ide.txt fix.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

6 files changed, 15 insertions, 48 deletions

diff --git a/drivers/ide/ide-generic.c b/drivers/ide/ide-generic.c
index 387574fe4b2b..bae41459192d 100644
--- a/drivers/ide/ide-generic.c
+++ b/drivers/ide/ide-generic.c
@@ -93,8 +93,7 @@ static int __init ide_generic_init(void)
                 ide_hwif_t *hwif = &ide_hwifs[i];
 
                 if (hwif->io_ports[IDE_DATA_OFFSET] &&
-                    (hwif->chipset == ide_unknown ||
-                     hwif->chipset == ide_forced))
+                    hwif->chipset == ide_unknown)
                         idx[i] = i;
                 else
                         idx[i] = 0xff;
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
index 8ef5194f6d47..33cb5e5a249b 100644
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -1519,8 +1519,7 @@ int ide_device_add_all(u8 *idx, const struct ide_port_info *d)
                 hwif = &ide_hwifs[idx[i]];
 
                 if (hwif->present) {
-                        if (hwif->chipset == ide_unknown ||
-                            hwif->chipset == ide_forced)
+                        if (hwif->chipset == ide_unknown)
                                 hwif->chipset = ide_generic;
                         hwif_register_devices(hwif);
                 }
diff --git a/drivers/ide/ide-proc.c b/drivers/ide/ide-proc.c
index 77025d1057b5..edd7f186dc4d 100644
--- a/drivers/ide/ide-proc.c
+++ b/drivers/ide/ide-proc.c
@@ -46,9 +46,6 @@ static int proc_ide_read_imodel
         int             len;
         const char      *name;
 
-        /*
-         * Neither ide_unknown nor ide_forced should be set at this point.
-         */
         switch (hwif->chipset) {
                 case ide_generic:       name = "generic";       break;
                 case ide_pci:           name = "pci";           break;
diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
index 96126b3b12e9..7e789c97a8b8 100644
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -1170,7 +1170,7 @@ extern int probe_ht6560b;
 extern int probe_qd65xx;
 extern int cmd640_vlb;
 
-static int __initdata is_chipset_set[MAX_HWIFS];
+static int __initdata is_chipset_set;
 
 /*
  * ide_setup() gets called VERY EARLY during initialization,
@@ -1328,8 +1328,6 @@ static int __init ide_setup(char *s)
                         "minus10", "four", "qd65xx", "ht6560b", "cmd640_vlb",
                         "dtc2278", "umc8672", "ali14xx", NULL };
 
-                hw_regs_t hwregs;
-
                 hw = s[3] - '0';
                 hwif = &ide_hwifs[hw];
                 i = match_parm(&s[4], ide_words, vals, 3);
@@ -1338,19 +1336,14 @@ static int __init ide_setup(char *s)
                  * Cryptic check to ensure chipset not already set for hwif.
                  * Note: we can't depend on hwif->chipset here.
                  */
-                if ((i >= -18 && i <= -11) || (i > 0 && i <= 3)) {
+                if (i >= -18 && i <= -11) {
                         /* chipset already specified */
-                        if (is_chipset_set[hw])
+                        if (is_chipset_set)
                                 goto bad_option;
-                        if (i > -18 && i <= -11) {
-                                /* these drivers are for "ide0=" only */
-                                if (hw != 0)
-                                        goto bad_hwif;
-                                /* chipset already specified for 2nd port */
-                                if (is_chipset_set[hw+1])
-                                        goto bad_option;
-                        }
-                        is_chipset_set[hw] = 1;
+                        /* these drivers are for "ide0=" only */
+                        if (hw != 0)
+                                goto bad_hwif;
+                        is_chipset_set = 1;
                         printk("\n");
                 }
 
@@ -1430,21 +1423,11 @@ static int __init ide_setup(char *s)
                         case -1: /* "noprobe" */
                                 hwif->noprobe = 1;
                                 goto obsolete_option;
-
-                        case 1: /* base */
-                                vals[1] = vals[0] + 0x206; /* default ctl */
-                        case 2: /* base,ctl */
-                                vals[2] = 0;    /* default irq = probe for it */
-                        case 3: /* base,ctl,irq */
-                                memset(&hwregs, 0, sizeof(hwregs));
-                                ide_init_hwif_ports(&hwregs, vals[0], vals[1], &hwif->irq);
-                                memcpy(hwif->io_ports, hwregs.io_ports, sizeof(hwif->io_ports));
-                                hwif->irq      = vals[2];
-                                hwif->noprobe  = 0;
-                                hwif->chipset  = ide_forced;
-                                goto obsolete_option;
-
-                        case 0: goto bad_option;
+                        case 0:
+                        case 1:
+                        case 2:
+                        case 3:
+                                goto bad_option;
                         default:
                                 printk(" -- SUPPORT NOT CONFIGURED IN THIS KERNEL\n");
                                 return 1;
diff --git a/drivers/ide/pci/cmd640.c b/drivers/ide/pci/cmd640.c
index 29fbc5ead03b..58a95f62e383 100644
--- a/drivers/ide/pci/cmd640.c
+++ b/drivers/ide/pci/cmd640.c
@@ -415,7 +415,7 @@ static void __init setup_device_ptrs (void)
         cmd_hwif1 = &ide_hwifs[1]; /* default, if not found below */
         for (i = 0; i < MAX_HWIFS; i++) {
                 ide_hwif_t *hwif = &ide_hwifs[i];
-                if (hwif->chipset == ide_unknown || hwif->chipset == ide_forced) {
+                if (hwif->chipset == ide_unknown) {
                         if (hwif->io_ports[IDE_DATA_OFFSET] == 0x1f0)
                                 cmd_hwif0 = hwif;
                         else if (hwif->io_ports[IDE_DATA_OFFSET] == 0x170)
diff --git a/drivers/ide/setup-pci.c b/drivers/ide/setup-pci.c
index 634e3f6a9608..ea66c996e4ec 100644
--- a/drivers/ide/setup-pci.c
+++ b/drivers/ide/setup-pci.c
@@ -41,17 +41,6 @@ static ide_hwif_t *ide_match_hwif(unsigned long io_base, u8 bootable, const char
         ide_hwif_t *hwif;
 
         /*
-         * Look for a hwif with matching io_base specified using
-         * parameters to ide_setup().
-         */
-        for (h = 0; h < MAX_HWIFS; ++h) {
-                hwif = &ide_hwifs[h];
-                if (hwif->io_ports[IDE_DATA_OFFSET] == io_base) {
-                        if (hwif->chipset == ide_forced)
-                                return hwif; /* a perfect match */
-                }
-        }
-        /*
          * Look for a hwif with matching io_base default value.
          * If chipset is "ide_unknown", then claim that hwif slot.
          * Otherwise, some other chipset has already claimed it..  :(