diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-10-10 16:39:30 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-10-10 16:39:30 -0400 |
commit | 4b58f17d7c45a8e5f4acda641bec388398b9c0fa (patch) | |
tree | 60ff1975dea044c3f268818f69001df5ac10eb42 /drivers | |
parent | 1a4e4d4d2cceb72be70526a485914abd638c7de1 (diff) |
ide: ide_id_has_flush_cache() -> ata_id_flush_enabled()
* Add ata_id_flush_enabled() inline helper to <linux/ata.h>.
* ide_id_has_flush_cache() -> ata_id_flush_enabled()
The latter one also checks if the command is marked as
supported in word 83 and validity of words 83 & 86.
Cc: Jeff Garzik <jgarzik@pobox.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/ide/ide-disk.c | 6 | ||||
-rw-r--r-- | drivers/ide/ide-io.c | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c index 8f49bc0ecbf8..7b24dff17460 100644 --- a/drivers/ide/ide-disk.c +++ b/drivers/ide/ide-disk.c | |||
@@ -651,7 +651,7 @@ static void update_ordered(ide_drive_t *drive) | |||
651 | * not available so we don't need to recheck that. | 651 | * not available so we don't need to recheck that. |
652 | */ | 652 | */ |
653 | capacity = idedisk_capacity(drive); | 653 | capacity = idedisk_capacity(drive); |
654 | barrier = ide_id_has_flush_cache(id) && !drive->noflush && | 654 | barrier = ata_id_flush_enabled(id) && !drive->noflush && |
655 | (drive->addressing == 0 || capacity <= (1ULL << 28) || | 655 | (drive->addressing == 0 || capacity <= (1ULL << 28) || |
656 | ide_id_has_flush_cache_ext(id)); | 656 | ide_id_has_flush_cache_ext(id)); |
657 | 657 | ||
@@ -678,7 +678,7 @@ static int set_wcache(ide_drive_t *drive, int arg) | |||
678 | if (arg < 0 || arg > 1) | 678 | if (arg < 0 || arg > 1) |
679 | return -EINVAL; | 679 | return -EINVAL; |
680 | 680 | ||
681 | if (ide_id_has_flush_cache(drive->id)) { | 681 | if (ata_id_flush_enabled(drive->id)) { |
682 | memset(&args, 0, sizeof(ide_task_t)); | 682 | memset(&args, 0, sizeof(ide_task_t)); |
683 | args.tf.feature = arg ? | 683 | args.tf.feature = arg ? |
684 | SETFEATURES_WC_ON : SETFEATURES_WC_OFF; | 684 | SETFEATURES_WC_ON : SETFEATURES_WC_OFF; |
@@ -886,7 +886,7 @@ static void idedisk_setup(ide_drive_t *drive) | |||
886 | 886 | ||
887 | static void ide_cacheflush_p(ide_drive_t *drive) | 887 | static void ide_cacheflush_p(ide_drive_t *drive) |
888 | { | 888 | { |
889 | if (!drive->wcache || !ide_id_has_flush_cache(drive->id)) | 889 | if (!drive->wcache || ata_id_flush_enabled(drive->id) == 0) |
890 | return; | 890 | return; |
891 | 891 | ||
892 | if (do_idedisk_flushcache(drive)) | 892 | if (do_idedisk_flushcache(drive)) |
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c index 99e0bbca3ace..c1596178fcae 100644 --- a/drivers/ide/ide-io.c +++ b/drivers/ide/ide-io.c | |||
@@ -184,7 +184,7 @@ static ide_startstop_t ide_start_power_step(ide_drive_t *drive, struct request * | |||
184 | if (drive->media != ide_disk) | 184 | if (drive->media != ide_disk) |
185 | break; | 185 | break; |
186 | /* Not supported? Switch to next step now. */ | 186 | /* Not supported? Switch to next step now. */ |
187 | if (!drive->wcache || !ide_id_has_flush_cache(drive->id)) { | 187 | if (!drive->wcache || ata_id_flush_enabled(drive->id) == 0) { |
188 | ide_complete_power_step(drive, rq, 0, 0); | 188 | ide_complete_power_step(drive, rq, 0, 0); |
189 | return ide_stopped; | 189 | return ide_stopped; |
190 | } | 190 | } |