diff options
author | Dominik Brodowski <linux@dominikbrodowski.net> | 2005-06-27 19:28:15 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-06-27 21:03:08 -0400 |
commit | e94e15f70559962f60915a09d44658b73a453fe2 (patch) | |
tree | 0ce8fb08e276cfc93a65b82ded38c4c1a1c9169b /drivers | |
parent | daa9517d9eccc3598b2b0cdfa0b016ae4a4fcdce (diff) |
[PATCH] pcmcia: cleanups
From: Adrian Bunk <bunk@stusta.de>
This patch contains the following cleanups:
- make needlessly global code static
- remove the following unneeded EXPORT_SYMBOL's:
- ds.c: pcmcia_report_error
- ds.c: pcmcia_bus_type
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/pcmcia/ds.c | 10 | ||||
-rw-r--r-- | drivers/pcmcia/rsrc_nonstatic.c | 6 |
2 files changed, 8 insertions, 8 deletions
diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c index 5c88ff8e7d7e..0de0f2300457 100644 --- a/drivers/pcmcia/ds.c +++ b/drivers/pcmcia/ds.c | |||
@@ -60,7 +60,7 @@ MODULE_DESCRIPTION("PCMCIA Driver Services"); | |||
60 | MODULE_LICENSE("GPL"); | 60 | MODULE_LICENSE("GPL"); |
61 | 61 | ||
62 | #ifdef DEBUG | 62 | #ifdef DEBUG |
63 | int ds_pc_debug; | 63 | static int ds_pc_debug; |
64 | 64 | ||
65 | module_param_named(pc_debug, ds_pc_debug, int, 0644); | 65 | module_param_named(pc_debug, ds_pc_debug, int, 0644); |
66 | 66 | ||
@@ -108,6 +108,8 @@ struct pcmcia_bus_socket { | |||
108 | }; | 108 | }; |
109 | static spinlock_t pcmcia_dev_list_lock; | 109 | static spinlock_t pcmcia_dev_list_lock; |
110 | 110 | ||
111 | static struct bus_type pcmcia_bus_type; | ||
112 | |||
111 | #define DS_SOCKET_PRESENT 0x01 | 113 | #define DS_SOCKET_PRESENT 0x01 |
112 | #define DS_SOCKET_BUSY 0x02 | 114 | #define DS_SOCKET_BUSY 0x02 |
113 | #define DS_SOCKET_REMOVAL_PENDING 0x10 | 115 | #define DS_SOCKET_REMOVAL_PENDING 0x10 |
@@ -218,7 +220,7 @@ static const lookup_t service_table[] = { | |||
218 | }; | 220 | }; |
219 | 221 | ||
220 | 222 | ||
221 | int pcmcia_report_error(client_handle_t handle, error_info_t *err) | 223 | static int pcmcia_report_error(client_handle_t handle, error_info_t *err) |
222 | { | 224 | { |
223 | int i; | 225 | int i; |
224 | char *serv; | 226 | char *serv; |
@@ -248,7 +250,6 @@ int pcmcia_report_error(client_handle_t handle, error_info_t *err) | |||
248 | 250 | ||
249 | return CS_SUCCESS; | 251 | return CS_SUCCESS; |
250 | } /* report_error */ | 252 | } /* report_error */ |
251 | EXPORT_SYMBOL(pcmcia_report_error); | ||
252 | 253 | ||
253 | /* end of code which was in cs.c before */ | 254 | /* end of code which was in cs.c before */ |
254 | 255 | ||
@@ -1901,13 +1902,12 @@ static struct class_interface pcmcia_bus_interface = { | |||
1901 | }; | 1902 | }; |
1902 | 1903 | ||
1903 | 1904 | ||
1904 | struct bus_type pcmcia_bus_type = { | 1905 | static struct bus_type pcmcia_bus_type = { |
1905 | .name = "pcmcia", | 1906 | .name = "pcmcia", |
1906 | .hotplug = pcmcia_bus_hotplug, | 1907 | .hotplug = pcmcia_bus_hotplug, |
1907 | .match = pcmcia_bus_match, | 1908 | .match = pcmcia_bus_match, |
1908 | .dev_attrs = pcmcia_dev_attrs, | 1909 | .dev_attrs = pcmcia_dev_attrs, |
1909 | }; | 1910 | }; |
1910 | EXPORT_SYMBOL(pcmcia_bus_type); | ||
1911 | 1911 | ||
1912 | 1912 | ||
1913 | static int __init init_pcmcia_bus(void) | 1913 | static int __init init_pcmcia_bus(void) |
diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c index 5876bab7c14c..9a0b835d612b 100644 --- a/drivers/pcmcia/rsrc_nonstatic.c +++ b/drivers/pcmcia/rsrc_nonstatic.c | |||
@@ -601,7 +601,7 @@ static int nonstatic_adjust_io_region(struct resource *res, unsigned long r_star | |||
601 | 601 | ||
602 | ======================================================================*/ | 602 | ======================================================================*/ |
603 | 603 | ||
604 | struct resource *nonstatic_find_io_region(unsigned long base, int num, | 604 | static struct resource *nonstatic_find_io_region(unsigned long base, int num, |
605 | unsigned long align, struct pcmcia_socket *s) | 605 | unsigned long align, struct pcmcia_socket *s) |
606 | { | 606 | { |
607 | struct resource *res = make_resource(0, num, IORESOURCE_IO, s->dev.class_id); | 607 | struct resource *res = make_resource(0, num, IORESOURCE_IO, s->dev.class_id); |
@@ -635,8 +635,8 @@ struct resource *nonstatic_find_io_region(unsigned long base, int num, | |||
635 | return res; | 635 | return res; |
636 | } | 636 | } |
637 | 637 | ||
638 | struct resource * nonstatic_find_mem_region(u_long base, u_long num, u_long align, | 638 | static struct resource * nonstatic_find_mem_region(u_long base, u_long num, |
639 | int low, struct pcmcia_socket *s) | 639 | u_long align, int low, struct pcmcia_socket *s) |
640 | { | 640 | { |
641 | struct resource *res = make_resource(0, num, IORESOURCE_MEM, s->dev.class_id); | 641 | struct resource *res = make_resource(0, num, IORESOURCE_MEM, s->dev.class_id); |
642 | struct socket_data *s_data = s->resource_data; | 642 | struct socket_data *s_data = s->resource_data; |