diff options
author | Ishizaki Kou <kou.ishizaki@toshiba.co.jp> | 2007-05-31 05:30:33 -0400 |
---|---|---|
committer | Paul Mackerras <paulus@samba.org> | 2007-07-10 07:53:41 -0400 |
commit | 1558f9b44e1c6b5eba46f58214851fd24285641f (patch) | |
tree | 786887334b5c0d38970e7dad1e22d7a6702c44fc /drivers | |
parent | f716a425c15ebadf60286cd4fb60d1d6f46e3cf9 (diff) |
[POWERPC] of_serial: Ignore unknown serial port
Current of_serial driver assumes unknown serial port to be 8250. But
this behavior may cause fatal problems when the serial port is not
8250. This corrects probe routine to ignore unknown serial port.
Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/serial/of_serial.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/serial/of_serial.c b/drivers/serial/of_serial.c index 7ffdaeaf0545..d7752af1c7ec 100644 --- a/drivers/serial/of_serial.c +++ b/drivers/serial/of_serial.c | |||
@@ -75,15 +75,13 @@ static int __devinit of_platform_serial_probe(struct of_device *ofdev, | |||
75 | goto out; | 75 | goto out; |
76 | 76 | ||
77 | switch (port_type) { | 77 | switch (port_type) { |
78 | case PORT_UNKNOWN: | ||
79 | dev_info(&ofdev->dev, "Unknown serial port found, " | ||
80 | "attempting to use 8250 driver\n"); | ||
81 | /* fallthrough */ | ||
82 | case PORT_8250 ... PORT_MAX_8250: | 78 | case PORT_8250 ... PORT_MAX_8250: |
83 | ret = serial8250_register_port(&port); | 79 | ret = serial8250_register_port(&port); |
84 | break; | 80 | break; |
85 | default: | 81 | default: |
86 | /* need to add code for these */ | 82 | /* need to add code for these */ |
83 | case PORT_UNKNOWN: | ||
84 | dev_info(&ofdev->dev, "Unknown serial port found, ignored\n"); | ||
87 | ret = -ENODEV; | 85 | ret = -ENODEV; |
88 | break; | 86 | break; |
89 | } | 87 | } |