diff options
| author | Matt Mackall <mpm@selenic.com> | 2010-01-29 03:50:36 -0500 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2010-02-01 14:50:23 -0500 |
| commit | a996996dd75a9086b12d1cb4010f26e1748993f0 (patch) | |
| tree | 3a65c1d6636f24e3edc175b54fabfdfd1fed91ef /drivers | |
| parent | 92dcffb916d309aa01778bf8963a6932e4014d07 (diff) | |
random: drop weird m_time/a_time manipulation
No other driver does anything remotely like this that I know of except
for the tty drivers, and I can't see any reason for random/urandom to do
it. In fact, it's a (trivial, harmless) timing information leak. And
obviously, it generates power- and flash-cycle wasting I/O, especially
if combined with something like hwrngd. Also, it breaks ubifs's
expectations.
Signed-off-by: Matt Mackall <mpm@selenic.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/char/random.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/char/random.c b/drivers/char/random.c index 8258982b49ec..3495d6486b71 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c | |||
| @@ -1051,12 +1051,6 @@ random_read(struct file *file, char __user *buf, size_t nbytes, loff_t *ppos) | |||
| 1051 | /* like a named pipe */ | 1051 | /* like a named pipe */ |
| 1052 | } | 1052 | } |
| 1053 | 1053 | ||
| 1054 | /* | ||
| 1055 | * If we gave the user some bytes, update the access time. | ||
| 1056 | */ | ||
| 1057 | if (count) | ||
| 1058 | file_accessed(file); | ||
| 1059 | |||
| 1060 | return (count ? count : retval); | 1054 | return (count ? count : retval); |
| 1061 | } | 1055 | } |
| 1062 | 1056 | ||
| @@ -1116,8 +1110,6 @@ static ssize_t random_write(struct file *file, const char __user *buffer, | |||
| 1116 | if (ret) | 1110 | if (ret) |
| 1117 | return ret; | 1111 | return ret; |
| 1118 | 1112 | ||
| 1119 | inode->i_mtime = current_fs_time(inode->i_sb); | ||
| 1120 | mark_inode_dirty(inode); | ||
| 1121 | return (ssize_t)count; | 1113 | return (ssize_t)count; |
| 1122 | } | 1114 | } |
| 1123 | 1115 | ||
