diff options
author | unsik Kim <donari75@gmail.com> | 2009-07-28 02:52:07 -0400 |
---|---|---|
committer | Jens Axboe <jens.axboe@oracle.com> | 2009-07-28 02:52:07 -0400 |
commit | eb32baec15c38ae6f06cb898a9f791578c5f8c79 (patch) | |
tree | ecc439936edd9cb629a24e473a67241a4d2a586c /drivers | |
parent | 48f5690d45b79ffeedc5ab24243b576056f1d2ff (diff) |
mg_disk: fix reading invalid status when use polling driver
When using polling driver, little delay is required to access
status register. Without this, host might read invalid status.
Signed-off-by: unsik Kim <donari75@gmail.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/block/mg_disk.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/drivers/block/mg_disk.c b/drivers/block/mg_disk.c index 5b120eab2baa..6440d5945414 100644 --- a/drivers/block/mg_disk.c +++ b/drivers/block/mg_disk.c | |||
@@ -219,6 +219,16 @@ static unsigned int mg_wait(struct mg_host *host, u32 expect, u32 msec) | |||
219 | host->error = MG_ERR_NONE; | 219 | host->error = MG_ERR_NONE; |
220 | expire = jiffies + msecs_to_jiffies(msec); | 220 | expire = jiffies + msecs_to_jiffies(msec); |
221 | 221 | ||
222 | /* These 2 times dummy status read prevents reading invalid | ||
223 | * status. A very little time (3 times of mflash operating clk) | ||
224 | * is required for busy bit is set. Use dummy read instead of | ||
225 | * busy wait, because mflash's PLL is machine dependent. | ||
226 | */ | ||
227 | if (prv_data->use_polling) { | ||
228 | status = inb((unsigned long)host->dev_base + MG_REG_STATUS); | ||
229 | status = inb((unsigned long)host->dev_base + MG_REG_STATUS); | ||
230 | } | ||
231 | |||
222 | status = inb((unsigned long)host->dev_base + MG_REG_STATUS); | 232 | status = inb((unsigned long)host->dev_base + MG_REG_STATUS); |
223 | 233 | ||
224 | do { | 234 | do { |