diff options
author | Linus Torvalds <torvalds@g5.osdl.org> | 2006-03-25 11:41:09 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-03-25 11:41:09 -0500 |
commit | 1e8c573933fd7975679766850252ad08667e5ca4 (patch) | |
tree | 9600d0c7ee5ea8925f3c4dc30680c819e0363805 /drivers | |
parent | d71eecf3b8e893757cc3dec560c96a32ac090890 (diff) | |
parent | 232443e2c90cc2930624dec89df327615b002c55 (diff) |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/bunk/trivial
* git://git.kernel.org/pub/scm/linux/kernel/git/bunk/trivial: (21 commits)
BUG_ON() Conversion in drivers/video/
BUG_ON() Conversion in drivers/parisc/
BUG_ON() Conversion in drivers/block/
BUG_ON() Conversion in sound/sparc/cs4231.c
BUG_ON() Conversion in drivers/s390/block/dasd.c
BUG_ON() Conversion in lib/swiotlb.c
BUG_ON() Conversion in kernel/cpu.c
BUG_ON() Conversion in ipc/msg.c
BUG_ON() Conversion in block/elevator.c
BUG_ON() Conversion in fs/coda/
BUG_ON() Conversion in fs/binfmt_elf_fdpic.c
BUG_ON() Conversion in input/serio/hil_mlc.c
BUG_ON() Conversion in md/dm-hw-handler.c
BUG_ON() Conversion in md/bitmap.c
The comment describing how MS_ASYNC works in msync.c is confusing
rcu: undeclared variable used in documentation
fix typos "wich" -> "which"
typo patch for fs/ufs/super.c
Fix simple typos
tabify drivers/char/Makefile
...
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/acpi/Kconfig | 3 | ||||
-rw-r--r-- | drivers/block/DAC960.c | 3 | ||||
-rw-r--r-- | drivers/block/cciss.c | 3 | ||||
-rw-r--r-- | drivers/block/cciss_scsi.c | 2 | ||||
-rw-r--r-- | drivers/block/cpqarray.c | 3 | ||||
-rw-r--r-- | drivers/char/Makefile | 87 | ||||
-rw-r--r-- | drivers/input/serio/hil_mlc.c | 2 | ||||
-rw-r--r-- | drivers/isdn/i4l/isdn_x25iface.c | 2 | ||||
-rw-r--r-- | drivers/md/bitmap.c | 2 | ||||
-rw-r--r-- | drivers/md/dm-hw-handler.c | 3 | ||||
-rw-r--r-- | drivers/parisc/sba_iommu.c | 10 | ||||
-rw-r--r-- | drivers/parisc/superio.c | 7 | ||||
-rw-r--r-- | drivers/s390/block/dasd.c | 10 | ||||
-rw-r--r-- | drivers/serial/mpc52xx_uart.c | 2 | ||||
-rw-r--r-- | drivers/usb/serial/option.c | 2 | ||||
-rw-r--r-- | drivers/video/bw2.c | 3 | ||||
-rw-r--r-- | drivers/video/ffb.c | 3 | ||||
-rw-r--r-- | drivers/video/sstfb.c | 2 | ||||
-rw-r--r-- | drivers/w1/masters/matrox_w1.c | 2 |
19 files changed, 70 insertions, 81 deletions
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 82710ae39228..5cb96300eb0f 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig | |||
@@ -256,7 +256,8 @@ config ACPI_CUSTOM_DSDT_FILE | |||
256 | depends on ACPI_CUSTOM_DSDT | 256 | depends on ACPI_CUSTOM_DSDT |
257 | default "" | 257 | default "" |
258 | help | 258 | help |
259 | Enter the full path name to the file wich includes the AmlCode declaration. | 259 | Enter the full path name to the file which includes the AmlCode |
260 | declaration. | ||
260 | 261 | ||
261 | config ACPI_BLACKLIST_YEAR | 262 | config ACPI_BLACKLIST_YEAR |
262 | int "Disable ACPI for systems before Jan 1st this year" if X86_32 | 263 | int "Disable ACPI for systems before Jan 1st this year" if X86_32 |
diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c index 37b8cda3e8bc..9bdea2a5cf0e 100644 --- a/drivers/block/DAC960.c +++ b/drivers/block/DAC960.c | |||
@@ -228,8 +228,7 @@ static void *slice_dma_loaf(struct dma_loaf *loaf, size_t len, | |||
228 | void *cpu_end = loaf->cpu_free + len; | 228 | void *cpu_end = loaf->cpu_free + len; |
229 | void *cpu_addr = loaf->cpu_free; | 229 | void *cpu_addr = loaf->cpu_free; |
230 | 230 | ||
231 | if (cpu_end > loaf->cpu_base + loaf->length) | 231 | BUG_ON(cpu_end > loaf->cpu_base + loaf->length); |
232 | BUG(); | ||
233 | *dma_handle = loaf->dma_free; | 232 | *dma_handle = loaf->dma_free; |
234 | loaf->cpu_free = cpu_end; | 233 | loaf->cpu_free = cpu_end; |
235 | loaf->dma_free += len; | 234 | loaf->dma_free += len; |
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 1f2890989b56..71ec9e664383 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c | |||
@@ -2361,8 +2361,7 @@ queue: | |||
2361 | if (!creq) | 2361 | if (!creq) |
2362 | goto startio; | 2362 | goto startio; |
2363 | 2363 | ||
2364 | if (creq->nr_phys_segments > MAXSGENTRIES) | 2364 | BUG_ON(creq->nr_phys_segments > MAXSGENTRIES); |
2365 | BUG(); | ||
2366 | 2365 | ||
2367 | if (( c = cmd_alloc(h, 1)) == NULL) | 2366 | if (( c = cmd_alloc(h, 1)) == NULL) |
2368 | goto full; | 2367 | goto full; |
diff --git a/drivers/block/cciss_scsi.c b/drivers/block/cciss_scsi.c index 9e35de05d5c5..0e66e904bd8c 100644 --- a/drivers/block/cciss_scsi.c +++ b/drivers/block/cciss_scsi.c | |||
@@ -1316,7 +1316,7 @@ cciss_scsi_queue_command (struct scsi_cmnd *cmd, void (* done)(struct scsi_cmnd | |||
1316 | 1316 | ||
1317 | cp->Request.Timeout = 0; | 1317 | cp->Request.Timeout = 0; |
1318 | memset(cp->Request.CDB, 0, sizeof(cp->Request.CDB)); | 1318 | memset(cp->Request.CDB, 0, sizeof(cp->Request.CDB)); |
1319 | if (cmd->cmd_len > sizeof(cp->Request.CDB)) BUG(); | 1319 | BUG_ON(cmd->cmd_len > sizeof(cp->Request.CDB)); |
1320 | cp->Request.CDBLen = cmd->cmd_len; | 1320 | cp->Request.CDBLen = cmd->cmd_len; |
1321 | memcpy(cp->Request.CDB, cmd->cmnd, cmd->cmd_len); | 1321 | memcpy(cp->Request.CDB, cmd->cmnd, cmd->cmd_len); |
1322 | cp->Request.Type.Type = TYPE_CMD; | 1322 | cp->Request.Type.Type = TYPE_CMD; |
diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c index 862b9abac0ae..b6ea2f0c7276 100644 --- a/drivers/block/cpqarray.c +++ b/drivers/block/cpqarray.c | |||
@@ -906,8 +906,7 @@ queue_next: | |||
906 | if (!creq) | 906 | if (!creq) |
907 | goto startio; | 907 | goto startio; |
908 | 908 | ||
909 | if (creq->nr_phys_segments > SG_MAX) | 909 | BUG_ON(creq->nr_phys_segments > SG_MAX); |
910 | BUG(); | ||
911 | 910 | ||
912 | if ((c = cmd_alloc(h,1)) == NULL) | 911 | if ((c = cmd_alloc(h,1)) == NULL) |
913 | goto startio; | 912 | goto startio; |
diff --git a/drivers/char/Makefile b/drivers/char/Makefile index 090d154098bb..b2a11245fa95 100644 --- a/drivers/char/Makefile +++ b/drivers/char/Makefile | |||
@@ -45,56 +45,57 @@ obj-$(CONFIG_HVC_CONSOLE) += hvc_console.o hvc_vio.o hvsi.o | |||
45 | obj-$(CONFIG_RAW_DRIVER) += raw.o | 45 | obj-$(CONFIG_RAW_DRIVER) += raw.o |
46 | obj-$(CONFIG_SGI_SNSC) += snsc.o snsc_event.o | 46 | obj-$(CONFIG_SGI_SNSC) += snsc.o snsc_event.o |
47 | obj-$(CONFIG_MMTIMER) += mmtimer.o | 47 | obj-$(CONFIG_MMTIMER) += mmtimer.o |
48 | obj-$(CONFIG_VIOCONS) += viocons.o | 48 | obj-$(CONFIG_VIOCONS) += viocons.o |
49 | obj-$(CONFIG_VIOTAPE) += viotape.o | 49 | obj-$(CONFIG_VIOTAPE) += viotape.o |
50 | obj-$(CONFIG_HVCS) += hvcs.o | 50 | obj-$(CONFIG_HVCS) += hvcs.o |
51 | obj-$(CONFIG_SGI_MBCS) += mbcs.o | 51 | obj-$(CONFIG_SGI_MBCS) += mbcs.o |
52 | 52 | ||
53 | obj-$(CONFIG_PRINTER) += lp.o | 53 | obj-$(CONFIG_PRINTER) += lp.o |
54 | obj-$(CONFIG_TIPAR) += tipar.o | 54 | obj-$(CONFIG_TIPAR) += tipar.o |
55 | 55 | ||
56 | obj-$(CONFIG_DTLK) += dtlk.o | 56 | obj-$(CONFIG_DTLK) += dtlk.o |
57 | obj-$(CONFIG_R3964) += n_r3964.o | 57 | obj-$(CONFIG_R3964) += n_r3964.o |
58 | obj-$(CONFIG_APPLICOM) += applicom.o | 58 | obj-$(CONFIG_APPLICOM) += applicom.o |
59 | obj-$(CONFIG_SONYPI) += sonypi.o | 59 | obj-$(CONFIG_SONYPI) += sonypi.o |
60 | obj-$(CONFIG_RTC) += rtc.o | 60 | obj-$(CONFIG_RTC) += rtc.o |
61 | obj-$(CONFIG_HPET) += hpet.o | 61 | obj-$(CONFIG_HPET) += hpet.o |
62 | obj-$(CONFIG_GEN_RTC) += genrtc.o | 62 | obj-$(CONFIG_GEN_RTC) += genrtc.o |
63 | obj-$(CONFIG_EFI_RTC) += efirtc.o | 63 | obj-$(CONFIG_EFI_RTC) += efirtc.o |
64 | obj-$(CONFIG_SGI_DS1286) += ds1286.o | 64 | obj-$(CONFIG_SGI_DS1286) += ds1286.o |
65 | obj-$(CONFIG_SGI_IP27_RTC) += ip27-rtc.o | 65 | obj-$(CONFIG_SGI_IP27_RTC) += ip27-rtc.o |
66 | obj-$(CONFIG_DS1302) += ds1302.o | 66 | obj-$(CONFIG_DS1302) += ds1302.o |
67 | obj-$(CONFIG_S3C2410_RTC) += s3c2410-rtc.o | 67 | obj-$(CONFIG_S3C2410_RTC) += s3c2410-rtc.o |
68 | obj-$(CONFIG_RTC_VR41XX) += vr41xx_rtc.o | 68 | obj-$(CONFIG_RTC_VR41XX) += vr41xx_rtc.o |
69 | ifeq ($(CONFIG_GENERIC_NVRAM),y) | 69 | ifeq ($(CONFIG_GENERIC_NVRAM),y) |
70 | obj-$(CONFIG_NVRAM) += generic_nvram.o | 70 | obj-$(CONFIG_NVRAM) += generic_nvram.o |
71 | else | 71 | else |
72 | obj-$(CONFIG_NVRAM) += nvram.o | 72 | obj-$(CONFIG_NVRAM) += nvram.o |
73 | endif | 73 | endif |
74 | obj-$(CONFIG_TOSHIBA) += toshiba.o | 74 | obj-$(CONFIG_TOSHIBA) += toshiba.o |
75 | obj-$(CONFIG_I8K) += i8k.o | 75 | obj-$(CONFIG_I8K) += i8k.o |
76 | obj-$(CONFIG_DS1620) += ds1620.o | 76 | obj-$(CONFIG_DS1620) += ds1620.o |
77 | obj-$(CONFIG_HW_RANDOM) += hw_random.o | 77 | obj-$(CONFIG_HW_RANDOM) += hw_random.o |
78 | obj-$(CONFIG_FTAPE) += ftape/ | 78 | obj-$(CONFIG_FTAPE) += ftape/ |
79 | obj-$(CONFIG_COBALT_LCD) += lcd.o | 79 | obj-$(CONFIG_COBALT_LCD) += lcd.o |
80 | obj-$(CONFIG_PPDEV) += ppdev.o | 80 | obj-$(CONFIG_PPDEV) += ppdev.o |
81 | obj-$(CONFIG_NWBUTTON) += nwbutton.o | 81 | obj-$(CONFIG_NWBUTTON) += nwbutton.o |
82 | obj-$(CONFIG_NWFLASH) += nwflash.o | 82 | obj-$(CONFIG_NWFLASH) += nwflash.o |
83 | obj-$(CONFIG_SCx200_GPIO) += scx200_gpio.o | 83 | obj-$(CONFIG_SCx200_GPIO) += scx200_gpio.o |
84 | obj-$(CONFIG_CS5535_GPIO) += cs5535_gpio.o | 84 | obj-$(CONFIG_CS5535_GPIO) += cs5535_gpio.o |
85 | obj-$(CONFIG_GPIO_VR41XX) += vr41xx_giu.o | 85 | obj-$(CONFIG_GPIO_VR41XX) += vr41xx_giu.o |
86 | obj-$(CONFIG_TANBAC_TB0219) += tb0219.o | 86 | obj-$(CONFIG_TANBAC_TB0219) += tb0219.o |
87 | obj-$(CONFIG_TELCLOCK) += tlclk.o | 87 | obj-$(CONFIG_TELCLOCK) += tlclk.o |
88 | 88 | ||
89 | obj-$(CONFIG_WATCHDOG) += watchdog/ | 89 | obj-$(CONFIG_WATCHDOG) += watchdog/ |
90 | obj-$(CONFIG_MWAVE) += mwave/ | 90 | obj-$(CONFIG_MWAVE) += mwave/ |
91 | obj-$(CONFIG_AGP) += agp/ | 91 | obj-$(CONFIG_AGP) += agp/ |
92 | obj-$(CONFIG_DRM) += drm/ | 92 | obj-$(CONFIG_DRM) += drm/ |
93 | obj-$(CONFIG_PCMCIA) += pcmcia/ | 93 | obj-$(CONFIG_PCMCIA) += pcmcia/ |
94 | obj-$(CONFIG_IPMI_HANDLER) += ipmi/ | 94 | obj-$(CONFIG_IPMI_HANDLER) += ipmi/ |
95 | 95 | ||
96 | obj-$(CONFIG_HANGCHECK_TIMER) += hangcheck-timer.o | 96 | obj-$(CONFIG_HANGCHECK_TIMER) += hangcheck-timer.o |
97 | obj-$(CONFIG_TCG_TPM) += tpm/ | 97 | obj-$(CONFIG_TCG_TPM) += tpm/ |
98 | |||
98 | # Files generated that shall be removed upon make clean | 99 | # Files generated that shall be removed upon make clean |
99 | clean-files := consolemap_deftbl.c defkeymap.c qtronixmap.c | 100 | clean-files := consolemap_deftbl.c defkeymap.c qtronixmap.c |
100 | 101 | ||
diff --git a/drivers/input/serio/hil_mlc.c b/drivers/input/serio/hil_mlc.c index 5704204964a3..ea499783fb12 100644 --- a/drivers/input/serio/hil_mlc.c +++ b/drivers/input/serio/hil_mlc.c | |||
@@ -556,7 +556,7 @@ static inline void hilse_setup_input(hil_mlc *mlc, struct hilse_node *node) { | |||
556 | do_gettimeofday(&(mlc->instart)); | 556 | do_gettimeofday(&(mlc->instart)); |
557 | mlc->icount = 15; | 557 | mlc->icount = 15; |
558 | memset(mlc->ipacket, 0, 16 * sizeof(hil_packet)); | 558 | memset(mlc->ipacket, 0, 16 * sizeof(hil_packet)); |
559 | if (down_trylock(&(mlc->isem))) BUG(); | 559 | BUG_ON(down_trylock(&(mlc->isem))); |
560 | 560 | ||
561 | return; | 561 | return; |
562 | } | 562 | } |
diff --git a/drivers/isdn/i4l/isdn_x25iface.c b/drivers/isdn/i4l/isdn_x25iface.c index edf14a2aa3c8..743ac4077f35 100644 --- a/drivers/isdn/i4l/isdn_x25iface.c +++ b/drivers/isdn/i4l/isdn_x25iface.c | |||
@@ -7,7 +7,7 @@ | |||
7 | * | 7 | * |
8 | * stuff needed to support the Linux X.25 PLP code on top of devices that | 8 | * stuff needed to support the Linux X.25 PLP code on top of devices that |
9 | * can provide a lab_b service using the concap_proto mechanism. | 9 | * can provide a lab_b service using the concap_proto mechanism. |
10 | * This module supports a network interface wich provides lapb_sematics | 10 | * This module supports a network interface which provides lapb_sematics |
11 | * -- as defined in Documentation/networking/x25-iface.txt -- to | 11 | * -- as defined in Documentation/networking/x25-iface.txt -- to |
12 | * the upper layer and assumes that the lower layer provides a reliable | 12 | * the upper layer and assumes that the lower layer provides a reliable |
13 | * data link service by means of the concap_device_ops callbacks. | 13 | * data link service by means of the concap_device_ops callbacks. |
diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c index 670eb01a5a23..e1c18aa1d712 100644 --- a/drivers/md/bitmap.c +++ b/drivers/md/bitmap.c | |||
@@ -1309,7 +1309,7 @@ int bitmap_startwrite(struct bitmap *bitmap, sector_t offset, unsigned long sect | |||
1309 | case 1: | 1309 | case 1: |
1310 | *bmc = 2; | 1310 | *bmc = 2; |
1311 | } | 1311 | } |
1312 | if ((*bmc & COUNTER_MAX) == COUNTER_MAX) BUG(); | 1312 | BUG_ON((*bmc & COUNTER_MAX) == COUNTER_MAX); |
1313 | (*bmc)++; | 1313 | (*bmc)++; |
1314 | 1314 | ||
1315 | spin_unlock_irq(&bitmap->lock); | 1315 | spin_unlock_irq(&bitmap->lock); |
diff --git a/drivers/md/dm-hw-handler.c b/drivers/md/dm-hw-handler.c index 4cc0010e0156..baafaaba4d4b 100644 --- a/drivers/md/dm-hw-handler.c +++ b/drivers/md/dm-hw-handler.c | |||
@@ -83,8 +83,7 @@ void dm_put_hw_handler(struct hw_handler_type *hwht) | |||
83 | if (--hwhi->use == 0) | 83 | if (--hwhi->use == 0) |
84 | module_put(hwhi->hwht.module); | 84 | module_put(hwhi->hwht.module); |
85 | 85 | ||
86 | if (hwhi->use < 0) | 86 | BUG_ON(hwhi->use < 0); |
87 | BUG(); | ||
88 | 87 | ||
89 | out: | 88 | out: |
90 | up_read(&_hwh_lock); | 89 | up_read(&_hwh_lock); |
diff --git a/drivers/parisc/sba_iommu.c b/drivers/parisc/sba_iommu.c index 5d47c5965c51..0821747e44cf 100644 --- a/drivers/parisc/sba_iommu.c +++ b/drivers/parisc/sba_iommu.c | |||
@@ -1724,9 +1724,7 @@ printk("sba_hw_init(): mem_boot 0x%x 0x%x 0x%x 0x%x\n", PAGE0->mem_boot.hpa, | |||
1724 | sba_dev->chip_resv.start = PCI_F_EXTEND | 0xfef00000UL; | 1724 | sba_dev->chip_resv.start = PCI_F_EXTEND | 0xfef00000UL; |
1725 | sba_dev->chip_resv.end = PCI_F_EXTEND | (0xff000000UL - 1) ; | 1725 | sba_dev->chip_resv.end = PCI_F_EXTEND | (0xff000000UL - 1) ; |
1726 | err = request_resource(&iomem_resource, &(sba_dev->chip_resv)); | 1726 | err = request_resource(&iomem_resource, &(sba_dev->chip_resv)); |
1727 | if (err < 0) { | 1727 | BUG_ON(err < 0); |
1728 | BUG(); | ||
1729 | } | ||
1730 | 1728 | ||
1731 | } else if (IS_PLUTO(sba_dev->iodc)) { | 1729 | } else if (IS_PLUTO(sba_dev->iodc)) { |
1732 | int err; | 1730 | int err; |
@@ -2185,8 +2183,7 @@ void sba_directed_lmmio(struct parisc_device *pci_hba, struct resource *r) | |||
2185 | int i; | 2183 | int i; |
2186 | int rope = (pci_hba->hw_path & (ROPES_PER_IOC-1)); /* rope # */ | 2184 | int rope = (pci_hba->hw_path & (ROPES_PER_IOC-1)); /* rope # */ |
2187 | 2185 | ||
2188 | if ((t!=HPHW_IOA) && (t!=HPHW_BCPORT)) | 2186 | BUG_ON((t!=HPHW_IOA) && (t!=HPHW_BCPORT)); |
2189 | BUG(); | ||
2190 | 2187 | ||
2191 | r->start = r->end = 0; | 2188 | r->start = r->end = 0; |
2192 | 2189 | ||
@@ -2228,8 +2225,7 @@ void sba_distributed_lmmio(struct parisc_device *pci_hba, struct resource *r ) | |||
2228 | int base, size; | 2225 | int base, size; |
2229 | int rope = (pci_hba->hw_path & (ROPES_PER_IOC-1)); /* rope # */ | 2226 | int rope = (pci_hba->hw_path & (ROPES_PER_IOC-1)); /* rope # */ |
2230 | 2227 | ||
2231 | if ((t!=HPHW_IOA) && (t!=HPHW_BCPORT)) | 2228 | BUG_ON((t!=HPHW_IOA) && (t!=HPHW_BCPORT)); |
2232 | BUG(); | ||
2233 | 2229 | ||
2234 | r->start = r->end = 0; | 2230 | r->start = r->end = 0; |
2235 | 2231 | ||
diff --git a/drivers/parisc/superio.c b/drivers/parisc/superio.c index ba971fecd0d8..ad6d3b28a3a6 100644 --- a/drivers/parisc/superio.c +++ b/drivers/parisc/superio.c | |||
@@ -157,8 +157,8 @@ superio_init(struct pci_dev *pcidev) | |||
157 | if (sio->suckyio_irq_enabled) | 157 | if (sio->suckyio_irq_enabled) |
158 | return; | 158 | return; |
159 | 159 | ||
160 | if (!pdev) BUG(); | 160 | BUG_ON(!pdev); |
161 | if (!sio->usb_pdev) BUG(); | 161 | BUG_ON(!sio->usb_pdev); |
162 | 162 | ||
163 | /* use the IRQ iosapic found for USB INT D... */ | 163 | /* use the IRQ iosapic found for USB INT D... */ |
164 | pdev->irq = sio->usb_pdev->irq; | 164 | pdev->irq = sio->usb_pdev->irq; |
@@ -474,8 +474,7 @@ superio_probe(struct pci_dev *dev, const struct pci_device_id *id) | |||
474 | dev->subsystem_vendor, dev->subsystem_device, | 474 | dev->subsystem_vendor, dev->subsystem_device, |
475 | dev->class); | 475 | dev->class); |
476 | 476 | ||
477 | if (!sio->suckyio_irq_enabled) | 477 | BUG_ON(!sio->suckyio_irq_enabled); /* Enabled by PCI_FIXUP_FINAL */ |
478 | BUG(); /* Enabled by PCI_FIXUP_FINAL */ | ||
479 | 478 | ||
480 | if (dev->device == PCI_DEVICE_ID_NS_87560_LIO) { /* Function 1 */ | 479 | if (dev->device == PCI_DEVICE_ID_NS_87560_LIO) { /* Function 1 */ |
481 | superio_parport_init(); | 480 | superio_parport_init(); |
diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c index 7967916bda18..0a9f12c4e911 100644 --- a/drivers/s390/block/dasd.c +++ b/drivers/s390/block/dasd.c | |||
@@ -541,9 +541,8 @@ dasd_kmalloc_request(char *magic, int cplength, int datasize, | |||
541 | struct dasd_ccw_req *cqr; | 541 | struct dasd_ccw_req *cqr; |
542 | 542 | ||
543 | /* Sanity checks */ | 543 | /* Sanity checks */ |
544 | if ( magic == NULL || datasize > PAGE_SIZE || | 544 | BUG_ON( magic == NULL || datasize > PAGE_SIZE || |
545 | (cplength*sizeof(struct ccw1)) > PAGE_SIZE) | 545 | (cplength*sizeof(struct ccw1)) > PAGE_SIZE); |
546 | BUG(); | ||
547 | 546 | ||
548 | cqr = kzalloc(sizeof(struct dasd_ccw_req), GFP_ATOMIC); | 547 | cqr = kzalloc(sizeof(struct dasd_ccw_req), GFP_ATOMIC); |
549 | if (cqr == NULL) | 548 | if (cqr == NULL) |
@@ -583,9 +582,8 @@ dasd_smalloc_request(char *magic, int cplength, int datasize, | |||
583 | int size; | 582 | int size; |
584 | 583 | ||
585 | /* Sanity checks */ | 584 | /* Sanity checks */ |
586 | if ( magic == NULL || datasize > PAGE_SIZE || | 585 | BUG_ON( magic == NULL || datasize > PAGE_SIZE || |
587 | (cplength*sizeof(struct ccw1)) > PAGE_SIZE) | 586 | (cplength*sizeof(struct ccw1)) > PAGE_SIZE); |
588 | BUG(); | ||
589 | 587 | ||
590 | size = (sizeof(struct dasd_ccw_req) + 7L) & -8L; | 588 | size = (sizeof(struct dasd_ccw_req) + 7L) & -8L; |
591 | if (cplength > 0) | 589 | if (cplength > 0) |
diff --git a/drivers/serial/mpc52xx_uart.c b/drivers/serial/mpc52xx_uart.c index 928e6cf12dca..6459edc7f5c5 100644 --- a/drivers/serial/mpc52xx_uart.c +++ b/drivers/serial/mpc52xx_uart.c | |||
@@ -40,7 +40,7 @@ | |||
40 | * and so on). So the PSC1 is mapped to /dev/ttyPSC0, PSC2 to /dev/ttyPSC1 and | 40 | * and so on). So the PSC1 is mapped to /dev/ttyPSC0, PSC2 to /dev/ttyPSC1 and |
41 | * so on. But be warned, it's an ABSOLUTE REQUIREMENT ! This is needed mainly | 41 | * so on. But be warned, it's an ABSOLUTE REQUIREMENT ! This is needed mainly |
42 | * fpr the console code : without this 1:1 mapping, at early boot time, when we | 42 | * fpr the console code : without this 1:1 mapping, at early boot time, when we |
43 | * are parsing the kernel args console=ttyPSC?, we wouldn't know wich PSC it | 43 | * are parsing the kernel args console=ttyPSC?, we wouldn't know which PSC it |
44 | * will be mapped to. | 44 | * will be mapped to. |
45 | */ | 45 | */ |
46 | 46 | ||
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index a8455c9e79dd..495db5755df9 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c | |||
@@ -102,7 +102,7 @@ static struct usb_driver option_driver = { | |||
102 | .no_dynamic_id = 1, | 102 | .no_dynamic_id = 1, |
103 | }; | 103 | }; |
104 | 104 | ||
105 | /* The card has three separate interfaces, wich the serial driver | 105 | /* The card has three separate interfaces, which the serial driver |
106 | * recognizes separately, thus num_port=1. | 106 | * recognizes separately, thus num_port=1. |
107 | */ | 107 | */ |
108 | static struct usb_serial_driver option_3port_device = { | 108 | static struct usb_serial_driver option_3port_device = { |
diff --git a/drivers/video/bw2.c b/drivers/video/bw2.c index c029db4646f6..6577fdfdfc16 100644 --- a/drivers/video/bw2.c +++ b/drivers/video/bw2.c | |||
@@ -327,8 +327,7 @@ static void bw2_init_one(struct sbus_dev *sdev) | |||
327 | } else | 327 | } else |
328 | #else | 328 | #else |
329 | { | 329 | { |
330 | if (!sdev) | 330 | BUG_ON(!sdev); |
331 | BUG(); | ||
332 | all->par.physbase = sdev->reg_addrs[0].phys_addr; | 331 | all->par.physbase = sdev->reg_addrs[0].phys_addr; |
333 | resp = &sdev->resource[0]; | 332 | resp = &sdev->resource[0]; |
334 | sbusfb_fill_var(&all->info.var, (sdev ? sdev->prom_node : 0), 1); | 333 | sbusfb_fill_var(&all->info.var, (sdev ? sdev->prom_node : 0), 1); |
diff --git a/drivers/video/ffb.c b/drivers/video/ffb.c index 9c9b21d469a1..7633e41adda1 100644 --- a/drivers/video/ffb.c +++ b/drivers/video/ffb.c | |||
@@ -466,8 +466,7 @@ static void ffb_fillrect(struct fb_info *info, const struct fb_fillrect *rect) | |||
466 | unsigned long flags; | 466 | unsigned long flags; |
467 | u32 fg; | 467 | u32 fg; |
468 | 468 | ||
469 | if (rect->rop != ROP_COPY && rect->rop != ROP_XOR) | 469 | BUG_ON(rect->rop != ROP_COPY && rect->rop != ROP_XOR); |
470 | BUG(); | ||
471 | 470 | ||
472 | fg = ((u32 *)info->pseudo_palette)[rect->color]; | 471 | fg = ((u32 *)info->pseudo_palette)[rect->color]; |
473 | 472 | ||
diff --git a/drivers/video/sstfb.c b/drivers/video/sstfb.c index 99921df35474..8c1a8b5135c6 100644 --- a/drivers/video/sstfb.c +++ b/drivers/video/sstfb.c | |||
@@ -32,7 +32,7 @@ | |||
32 | 32 | ||
33 | -TODO: at one time or another test that the mode is acceptable by the monitor | 33 | -TODO: at one time or another test that the mode is acceptable by the monitor |
34 | -ASK: Can I choose different ordering for the color bitfields (rgba argb ...) | 34 | -ASK: Can I choose different ordering for the color bitfields (rgba argb ...) |
35 | wich one should i use ? is there any preferred one ? It seems ARGB is | 35 | which one should i use ? is there any preferred one ? It seems ARGB is |
36 | the one ... | 36 | the one ... |
37 | -TODO: in set_var check the validity of timings (hsync vsync)... | 37 | -TODO: in set_var check the validity of timings (hsync vsync)... |
38 | -TODO: check and recheck the use of sst_wait_idle : we don't flush the fifo via | 38 | -TODO: check and recheck the use of sst_wait_idle : we don't flush the fifo via |
diff --git a/drivers/w1/masters/matrox_w1.c b/drivers/w1/masters/matrox_w1.c index 591809cbbb97..2788b8ca9bb1 100644 --- a/drivers/w1/masters/matrox_w1.c +++ b/drivers/w1/masters/matrox_w1.c | |||
@@ -98,7 +98,7 @@ static void matrox_w1_write_ddc_bit(void *, u8); | |||
98 | * | 98 | * |
99 | * Using tristate pins, since i can't find any open-drain pin in whole motherboard. | 99 | * Using tristate pins, since i can't find any open-drain pin in whole motherboard. |
100 | * Unfortunately we can't connect to Intel's 82801xx IO controller | 100 | * Unfortunately we can't connect to Intel's 82801xx IO controller |
101 | * since we don't know motherboard schema, wich has pretty unused(may be not) GPIO. | 101 | * since we don't know motherboard schema, which has pretty unused(may be not) GPIO. |
102 | * | 102 | * |
103 | * I've heard that PIIX also has open drain pin. | 103 | * I've heard that PIIX also has open drain pin. |
104 | * | 104 | * |