diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2009-12-01 13:41:40 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-12-01 13:41:40 -0500 |
commit | 2127816366e0ffbc1426fa69e7b9b2bebd2e2288 (patch) | |
tree | 51e8f498aa05d57ca8fec01347d89c6c44c5565e /drivers | |
parent | e272a186435e747b25b01afb38d172853219fbda (diff) | |
parent | fb08808ca252a76519d3b17fc3b6cfc6b2806e55 (diff) |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6
* git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6:
Staging: update TODO files
Staging: hv: Fix some missing author names
Staging: hv: Fix vmbus event handler bug
Staging: hv: Fix argument order in incorrect memset invocations in hyperv driver.
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/staging/hv/BlkVsc.c | 1 | ||||
-rw-r--r-- | drivers/staging/hv/Channel.c | 16 | ||||
-rw-r--r-- | drivers/staging/hv/ChannelMgmt.c | 2 | ||||
-rw-r--r-- | drivers/staging/hv/NetVsc.c | 1 | ||||
-rw-r--r-- | drivers/staging/hv/NetVsc.h | 1 | ||||
-rw-r--r-- | drivers/staging/hv/StorVsc.c | 10 | ||||
-rw-r--r-- | drivers/staging/hv/blkvsc_drv.c | 1 | ||||
-rw-r--r-- | drivers/staging/hv/netvsc_drv.c | 1 | ||||
-rw-r--r-- | drivers/staging/rtl8187se/TODO | 3 | ||||
-rw-r--r-- | drivers/staging/rtl8192su/TODO | 3 | ||||
-rw-r--r-- | drivers/staging/vt6655/TODO | 5 | ||||
-rw-r--r-- | drivers/staging/vt6656/TODO | 5 |
12 files changed, 21 insertions, 28 deletions
diff --git a/drivers/staging/hv/BlkVsc.c b/drivers/staging/hv/BlkVsc.c index 51aa861292fc..a48ee3a12646 100644 --- a/drivers/staging/hv/BlkVsc.c +++ b/drivers/staging/hv/BlkVsc.c | |||
@@ -16,6 +16,7 @@ | |||
16 | * Place - Suite 330, Boston, MA 02111-1307 USA. | 16 | * Place - Suite 330, Boston, MA 02111-1307 USA. |
17 | * | 17 | * |
18 | * Authors: | 18 | * Authors: |
19 | * Haiyang Zhang <haiyangz@microsoft.com> | ||
19 | * Hank Janssen <hjanssen@microsoft.com> | 20 | * Hank Janssen <hjanssen@microsoft.com> |
20 | * | 21 | * |
21 | */ | 22 | */ |
diff --git a/drivers/staging/hv/Channel.c b/drivers/staging/hv/Channel.c index d649ee169d95..746370e82115 100644 --- a/drivers/staging/hv/Channel.c +++ b/drivers/staging/hv/Channel.c | |||
@@ -611,7 +611,7 @@ void VmbusChannelClose(struct vmbus_channel *Channel) | |||
611 | 611 | ||
612 | /* Stop callback and cancel the timer asap */ | 612 | /* Stop callback and cancel the timer asap */ |
613 | Channel->OnChannelCallback = NULL; | 613 | Channel->OnChannelCallback = NULL; |
614 | del_timer(&Channel->poll_timer); | 614 | del_timer_sync(&Channel->poll_timer); |
615 | 615 | ||
616 | /* Send a closing message */ | 616 | /* Send a closing message */ |
617 | info = kmalloc(sizeof(*info) + | 617 | info = kmalloc(sizeof(*info) + |
@@ -978,14 +978,10 @@ void VmbusChannelOnChannelEvent(struct vmbus_channel *Channel) | |||
978 | { | 978 | { |
979 | DumpVmbusChannel(Channel); | 979 | DumpVmbusChannel(Channel); |
980 | ASSERT(Channel->OnChannelCallback); | 980 | ASSERT(Channel->OnChannelCallback); |
981 | #ifdef ENABLE_POLLING | 981 | |
982 | del_timer(&Channel->poll_timer); | ||
983 | Channel->OnChannelCallback(Channel->ChannelCallbackContext); | ||
984 | channel->poll_timer.expires(jiffies + usecs_to_jiffies(100); | ||
985 | add_timer(&channel->poll_timer); | ||
986 | #else | ||
987 | Channel->OnChannelCallback(Channel->ChannelCallbackContext); | 982 | Channel->OnChannelCallback(Channel->ChannelCallbackContext); |
988 | #endif | 983 | |
984 | mod_timer(&Channel->poll_timer, jiffies + usecs_to_jiffies(100)); | ||
989 | } | 985 | } |
990 | 986 | ||
991 | /** | 987 | /** |
@@ -997,10 +993,6 @@ void VmbusChannelOnTimer(unsigned long data) | |||
997 | 993 | ||
998 | if (channel->OnChannelCallback) { | 994 | if (channel->OnChannelCallback) { |
999 | channel->OnChannelCallback(channel->ChannelCallbackContext); | 995 | channel->OnChannelCallback(channel->ChannelCallbackContext); |
1000 | #ifdef ENABLE_POLLING | ||
1001 | channel->poll_timer.expires(jiffies + usecs_to_jiffies(100); | ||
1002 | add_timer(&channel->poll_timer); | ||
1003 | #endif | ||
1004 | } | 996 | } |
1005 | } | 997 | } |
1006 | 998 | ||
diff --git a/drivers/staging/hv/ChannelMgmt.c b/drivers/staging/hv/ChannelMgmt.c index 3db62caedcff..ef38467ed4e2 100644 --- a/drivers/staging/hv/ChannelMgmt.c +++ b/drivers/staging/hv/ChannelMgmt.c | |||
@@ -119,7 +119,7 @@ static inline void ReleaseVmbusChannel(void *context) | |||
119 | */ | 119 | */ |
120 | void FreeVmbusChannel(struct vmbus_channel *Channel) | 120 | void FreeVmbusChannel(struct vmbus_channel *Channel) |
121 | { | 121 | { |
122 | del_timer(&Channel->poll_timer); | 122 | del_timer_sync(&Channel->poll_timer); |
123 | 123 | ||
124 | /* | 124 | /* |
125 | * We have to release the channel's workqueue/thread in the vmbus's | 125 | * We have to release the channel's workqueue/thread in the vmbus's |
diff --git a/drivers/staging/hv/NetVsc.c b/drivers/staging/hv/NetVsc.c index d384c0ddf069..1c717f9a554e 100644 --- a/drivers/staging/hv/NetVsc.c +++ b/drivers/staging/hv/NetVsc.c | |||
@@ -15,6 +15,7 @@ | |||
15 | * Place - Suite 330, Boston, MA 02111-1307 USA. | 15 | * Place - Suite 330, Boston, MA 02111-1307 USA. |
16 | * | 16 | * |
17 | * Authors: | 17 | * Authors: |
18 | * Haiyang Zhang <haiyangz@microsoft.com> | ||
18 | * Hank Janssen <hjanssen@microsoft.com> | 19 | * Hank Janssen <hjanssen@microsoft.com> |
19 | */ | 20 | */ |
20 | #include <linux/kernel.h> | 21 | #include <linux/kernel.h> |
diff --git a/drivers/staging/hv/NetVsc.h b/drivers/staging/hv/NetVsc.h index 3e7112f7c755..6e0e03494126 100644 --- a/drivers/staging/hv/NetVsc.h +++ b/drivers/staging/hv/NetVsc.h | |||
@@ -16,6 +16,7 @@ | |||
16 | * Place - Suite 330, Boston, MA 02111-1307 USA. | 16 | * Place - Suite 330, Boston, MA 02111-1307 USA. |
17 | * | 17 | * |
18 | * Authors: | 18 | * Authors: |
19 | * Haiyang Zhang <haiyangz@microsoft.com> | ||
19 | * Hank Janssen <hjanssen@microsoft.com> | 20 | * Hank Janssen <hjanssen@microsoft.com> |
20 | * | 21 | * |
21 | */ | 22 | */ |
diff --git a/drivers/staging/hv/StorVsc.c b/drivers/staging/hv/StorVsc.c index 14015c927940..2f7c425896f7 100644 --- a/drivers/staging/hv/StorVsc.c +++ b/drivers/staging/hv/StorVsc.c | |||
@@ -196,7 +196,7 @@ static int StorVscChannelInit(struct hv_device *Device) | |||
196 | * Now, initiate the vsc/vsp initialization protocol on the open | 196 | * Now, initiate the vsc/vsp initialization protocol on the open |
197 | * channel | 197 | * channel |
198 | */ | 198 | */ |
199 | memset(request, sizeof(struct storvsc_request_extension), 0); | 199 | memset(request, 0, sizeof(struct storvsc_request_extension)); |
200 | request->WaitEvent = osd_WaitEventCreate(); | 200 | request->WaitEvent = osd_WaitEventCreate(); |
201 | 201 | ||
202 | vstorPacket->Operation = VStorOperationBeginInitialization; | 202 | vstorPacket->Operation = VStorOperationBeginInitialization; |
@@ -233,7 +233,7 @@ static int StorVscChannelInit(struct hv_device *Device) | |||
233 | DPRINT_INFO(STORVSC, "QUERY_PROTOCOL_VERSION_OPERATION..."); | 233 | DPRINT_INFO(STORVSC, "QUERY_PROTOCOL_VERSION_OPERATION..."); |
234 | 234 | ||
235 | /* reuse the packet for version range supported */ | 235 | /* reuse the packet for version range supported */ |
236 | memset(vstorPacket, sizeof(struct vstor_packet), 0); | 236 | memset(vstorPacket, 0, sizeof(struct vstor_packet)); |
237 | vstorPacket->Operation = VStorOperationQueryProtocolVersion; | 237 | vstorPacket->Operation = VStorOperationQueryProtocolVersion; |
238 | vstorPacket->Flags = REQUEST_COMPLETION_FLAG; | 238 | vstorPacket->Flags = REQUEST_COMPLETION_FLAG; |
239 | 239 | ||
@@ -266,7 +266,7 @@ static int StorVscChannelInit(struct hv_device *Device) | |||
266 | /* Query channel properties */ | 266 | /* Query channel properties */ |
267 | DPRINT_INFO(STORVSC, "QUERY_PROPERTIES_OPERATION..."); | 267 | DPRINT_INFO(STORVSC, "QUERY_PROPERTIES_OPERATION..."); |
268 | 268 | ||
269 | memset(vstorPacket, sizeof(struct vstor_packet), 0); | 269 | memset(vstorPacket, 0, sizeof(struct vstor_packet)); |
270 | vstorPacket->Operation = VStorOperationQueryProperties; | 270 | vstorPacket->Operation = VStorOperationQueryProperties; |
271 | vstorPacket->Flags = REQUEST_COMPLETION_FLAG; | 271 | vstorPacket->Flags = REQUEST_COMPLETION_FLAG; |
272 | vstorPacket->StorageChannelProperties.PortNumber = | 272 | vstorPacket->StorageChannelProperties.PortNumber = |
@@ -305,7 +305,7 @@ static int StorVscChannelInit(struct hv_device *Device) | |||
305 | 305 | ||
306 | DPRINT_INFO(STORVSC, "END_INITIALIZATION_OPERATION..."); | 306 | DPRINT_INFO(STORVSC, "END_INITIALIZATION_OPERATION..."); |
307 | 307 | ||
308 | memset(vstorPacket, sizeof(struct vstor_packet), 0); | 308 | memset(vstorPacket, 0, sizeof(struct vstor_packet)); |
309 | vstorPacket->Operation = VStorOperationEndInitialization; | 309 | vstorPacket->Operation = VStorOperationEndInitialization; |
310 | vstorPacket->Flags = REQUEST_COMPLETION_FLAG; | 310 | vstorPacket->Flags = REQUEST_COMPLETION_FLAG; |
311 | 311 | ||
@@ -508,7 +508,7 @@ static int StorVscConnectToVsp(struct hv_device *Device) | |||
508 | int ret; | 508 | int ret; |
509 | 509 | ||
510 | storDriver = (struct storvsc_driver_object *)Device->Driver; | 510 | storDriver = (struct storvsc_driver_object *)Device->Driver; |
511 | memset(&props, sizeof(struct vmstorage_channel_properties), 0); | 511 | memset(&props, 0, sizeof(struct vmstorage_channel_properties)); |
512 | 512 | ||
513 | /* Open the channel */ | 513 | /* Open the channel */ |
514 | ret = Device->Driver->VmbusChannelInterface.Open(Device, | 514 | ret = Device->Driver->VmbusChannelInterface.Open(Device, |
diff --git a/drivers/staging/hv/blkvsc_drv.c b/drivers/staging/hv/blkvsc_drv.c index 99c49261a8b4..62b282844a53 100644 --- a/drivers/staging/hv/blkvsc_drv.c +++ b/drivers/staging/hv/blkvsc_drv.c | |||
@@ -15,6 +15,7 @@ | |||
15 | * Place - Suite 330, Boston, MA 02111-1307 USA. | 15 | * Place - Suite 330, Boston, MA 02111-1307 USA. |
16 | * | 16 | * |
17 | * Authors: | 17 | * Authors: |
18 | * Haiyang Zhang <haiyangz@microsoft.com> | ||
18 | * Hank Janssen <hjanssen@microsoft.com> | 19 | * Hank Janssen <hjanssen@microsoft.com> |
19 | */ | 20 | */ |
20 | #include <linux/init.h> | 21 | #include <linux/init.h> |
diff --git a/drivers/staging/hv/netvsc_drv.c b/drivers/staging/hv/netvsc_drv.c index 3192d50f7251..0d7459e2d036 100644 --- a/drivers/staging/hv/netvsc_drv.c +++ b/drivers/staging/hv/netvsc_drv.c | |||
@@ -15,6 +15,7 @@ | |||
15 | * Place - Suite 330, Boston, MA 02111-1307 USA. | 15 | * Place - Suite 330, Boston, MA 02111-1307 USA. |
16 | * | 16 | * |
17 | * Authors: | 17 | * Authors: |
18 | * Haiyang Zhang <haiyangz@microsoft.com> | ||
18 | * Hank Janssen <hjanssen@microsoft.com> | 19 | * Hank Janssen <hjanssen@microsoft.com> |
19 | */ | 20 | */ |
20 | #include <linux/init.h> | 21 | #include <linux/init.h> |
diff --git a/drivers/staging/rtl8187se/TODO b/drivers/staging/rtl8187se/TODO index c09a9160739d..a762e79873e9 100644 --- a/drivers/staging/rtl8187se/TODO +++ b/drivers/staging/rtl8187se/TODO | |||
@@ -11,5 +11,4 @@ TODO: | |||
11 | - sparse fixes | 11 | - sparse fixes |
12 | - integrate with drivers/net/wireless/rtl818x | 12 | - integrate with drivers/net/wireless/rtl818x |
13 | 13 | ||
14 | Please send any patches to Greg Kroah-Hartman <greg@kroah.com> and | 14 | Please send any patches to Greg Kroah-Hartman <greg@kroah.com>. |
15 | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>. | ||
diff --git a/drivers/staging/rtl8192su/TODO b/drivers/staging/rtl8192su/TODO index b13be9edb278..f11eec700030 100644 --- a/drivers/staging/rtl8192su/TODO +++ b/drivers/staging/rtl8192su/TODO | |||
@@ -14,5 +14,4 @@ TODO: | |||
14 | - sparse fixes | 14 | - sparse fixes |
15 | - integrate with drivers/net/wireless/rtl818x | 15 | - integrate with drivers/net/wireless/rtl818x |
16 | 16 | ||
17 | Please send any patches to Greg Kroah-Hartman <greg@kroah.com> and | 17 | Please send any patches to Greg Kroah-Hartman <greg@kroah.com>. |
18 | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>. | ||
diff --git a/drivers/staging/vt6655/TODO b/drivers/staging/vt6655/TODO index 8462cd17eb61..cb04aaafc46f 100644 --- a/drivers/staging/vt6655/TODO +++ b/drivers/staging/vt6655/TODO | |||
@@ -16,6 +16,5 @@ TODO: | |||
16 | - sparse fixes | 16 | - sparse fixes |
17 | - integrate with drivers/net/wireless | 17 | - integrate with drivers/net/wireless |
18 | 18 | ||
19 | Please send any patches to Greg Kroah-Hartman <greg@kroah.com>, | 19 | Please send any patches to Greg Kroah-Hartman <greg@kroah.com> |
20 | Forest Bond <forest@alittletooquiet.net> and Bartlomiej Zolnierkiewicz | 20 | and Forest Bond <forest@alittletooquiet.net>. |
21 | <bzolnier@gmail.com>. | ||
diff --git a/drivers/staging/vt6656/TODO b/drivers/staging/vt6656/TODO index 17cf50c6735e..a318995ba07f 100644 --- a/drivers/staging/vt6656/TODO +++ b/drivers/staging/vt6656/TODO | |||
@@ -15,6 +15,5 @@ TODO: | |||
15 | - sparse fixes | 15 | - sparse fixes |
16 | - integrate with drivers/net/wireless | 16 | - integrate with drivers/net/wireless |
17 | 17 | ||
18 | Please send any patches to Greg Kroah-Hartman <greg@kroah.com>, | 18 | Please send any patches to Greg Kroah-Hartman <greg@kroah.com> |
19 | Forest Bond <forest@alittletooquiet.net> and Bartlomiej Zolnierkiewicz | 19 | and Forest Bond <forest@alittletooquiet.net>. |
20 | <bzolnier@gmail.com>. | ||