aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorDavid Lamparter <equinox@diac24.net>2010-09-16 23:22:19 -0400
committerDavid S. Miller <davem@davemloft.net>2010-09-17 19:46:04 -0400
commit3b27e105550f7c4a79ecb6d6a9c49c651c59ae9b (patch)
tree5603f5c9322f40d40a63efe5519c0a9bf164b972 /drivers
parentb71c7aaa1e2a9858f0c469026098fbd6e046d7bb (diff)
netns: keep vlan slaves on master netns move
previously, if a vlan master device was moved from one network namespace to another, all 802.1q and macvlan slaves were deleted. we can use dev->reg_state to figure out whether dev_change_net_namespace is happening, since that won't set dev->reg_state NETREG_UNREGISTERING. so, this changes 8021q and macvlan to ignore NETDEV_UNREGISTER when reg_state is not NETREG_UNREGISTERING. Signed-off-by: David Lamparter <equinox@diac24.net> Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com> Acked-by: Daniel Lezcano <daniel.lezcano@free.fr> Acked-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/macvlan.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 0ef0eb0db945..0fc9dc7f20db 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -788,6 +788,10 @@ static int macvlan_device_event(struct notifier_block *unused,
788 } 788 }
789 break; 789 break;
790 case NETDEV_UNREGISTER: 790 case NETDEV_UNREGISTER:
791 /* twiddle thumbs on netns device moves */
792 if (dev->reg_state != NETREG_UNREGISTERING)
793 break;
794
791 list_for_each_entry_safe(vlan, next, &port->vlans, list) 795 list_for_each_entry_safe(vlan, next, &port->vlans, list)
792 vlan->dev->rtnl_link_ops->dellink(vlan->dev, NULL); 796 vlan->dev->rtnl_link_ops->dellink(vlan->dev, NULL);
793 break; 797 break;