aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorDan Williams <dan.j.williams@intel.com>2011-05-12 07:10:41 -0400
committerDan Williams <dan.j.williams@intel.com>2011-07-03 07:04:48 -0400
commit35b317bec511b4a5f87a637bf78b6d1d635c617d (patch)
treec088233ba1207f11bc4a6989a8e5889b1c207f80 /drivers
parent0cf36fa9f1197e669ac6f5efc51d0587bcc95e6e (diff)
isci: remove phy destruct handlers
Unused infrastructure. Reported-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/scsi/isci/phy.c28
-rw-r--r--drivers/scsi/isci/phy.h6
2 files changed, 0 insertions, 34 deletions
diff --git a/drivers/scsi/isci/phy.c b/drivers/scsi/isci/phy.c
index b606e2f317d5..8beea40697da 100644
--- a/drivers/scsi/isci/phy.c
+++ b/drivers/scsi/isci/phy.c
@@ -1268,12 +1268,6 @@ static enum sci_status default_phy_handler(struct scic_sds_phy *sci_phy,
1268} 1268}
1269 1269
1270static enum sci_status 1270static enum sci_status
1271scic_sds_phy_default_destroy_handler(struct scic_sds_phy *sci_phy)
1272{
1273 return default_phy_handler(sci_phy, __func__);
1274}
1275
1276static enum sci_status
1277scic_sds_phy_default_frame_handler(struct scic_sds_phy *sci_phy, 1271scic_sds_phy_default_frame_handler(struct scic_sds_phy *sci_phy,
1278 u32 frame_index) 1272 u32 frame_index)
1279{ 1273{
@@ -1298,12 +1292,6 @@ scic_sds_phy_default_consume_power_handler(struct scic_sds_phy *sci_phy)
1298 return default_phy_handler(sci_phy, __func__); 1292 return default_phy_handler(sci_phy, __func__);
1299} 1293}
1300 1294
1301static enum sci_status
1302scic_sds_phy_stopped_state_destroy_handler(struct scic_sds_phy *sci_phy)
1303{
1304 return SCI_SUCCESS;
1305}
1306
1307/** 1295/**
1308 * scic_sds_phy_ready_state_event_handler - 1296 * scic_sds_phy_ready_state_event_handler -
1309 * @phy: This is the struct scic_sds_phy object which has received the event. 1297 * @phy: This is the struct scic_sds_phy object which has received the event.
@@ -1379,97 +1367,81 @@ static enum sci_status scic_sds_phy_resetting_state_event_handler(struct scic_sd
1379 1367
1380static const struct scic_sds_phy_state_handler scic_sds_phy_state_handler_table[] = { 1368static const struct scic_sds_phy_state_handler scic_sds_phy_state_handler_table[] = {
1381 [SCI_BASE_PHY_STATE_INITIAL] = { 1369 [SCI_BASE_PHY_STATE_INITIAL] = {
1382 .destruct_handler = scic_sds_phy_default_destroy_handler,
1383 .frame_handler = scic_sds_phy_default_frame_handler, 1370 .frame_handler = scic_sds_phy_default_frame_handler,
1384 .event_handler = scic_sds_phy_default_event_handler, 1371 .event_handler = scic_sds_phy_default_event_handler,
1385 .consume_power_handler = scic_sds_phy_default_consume_power_handler 1372 .consume_power_handler = scic_sds_phy_default_consume_power_handler
1386 }, 1373 },
1387 [SCI_BASE_PHY_STATE_STOPPED] = { 1374 [SCI_BASE_PHY_STATE_STOPPED] = {
1388 .destruct_handler = scic_sds_phy_stopped_state_destroy_handler,
1389 .frame_handler = scic_sds_phy_default_frame_handler, 1375 .frame_handler = scic_sds_phy_default_frame_handler,
1390 .event_handler = scic_sds_phy_default_event_handler, 1376 .event_handler = scic_sds_phy_default_event_handler,
1391 .consume_power_handler = scic_sds_phy_default_consume_power_handler 1377 .consume_power_handler = scic_sds_phy_default_consume_power_handler
1392 }, 1378 },
1393 [SCI_BASE_PHY_STATE_STARTING] = { 1379 [SCI_BASE_PHY_STATE_STARTING] = {
1394 .destruct_handler = scic_sds_phy_default_destroy_handler,
1395 .frame_handler = scic_sds_phy_default_frame_handler, 1380 .frame_handler = scic_sds_phy_default_frame_handler,
1396 .event_handler = scic_sds_phy_default_event_handler, 1381 .event_handler = scic_sds_phy_default_event_handler,
1397 .consume_power_handler = scic_sds_phy_default_consume_power_handler 1382 .consume_power_handler = scic_sds_phy_default_consume_power_handler
1398 }, 1383 },
1399 [SCIC_SDS_PHY_STARTING_SUBSTATE_INITIAL] = { 1384 [SCIC_SDS_PHY_STARTING_SUBSTATE_INITIAL] = {
1400 .destruct_handler = scic_sds_phy_default_destroy_handler,
1401 .frame_handler = scic_sds_phy_default_frame_handler, 1385 .frame_handler = scic_sds_phy_default_frame_handler,
1402 .event_handler = scic_sds_phy_default_event_handler, 1386 .event_handler = scic_sds_phy_default_event_handler,
1403 .consume_power_handler = scic_sds_phy_default_consume_power_handler 1387 .consume_power_handler = scic_sds_phy_default_consume_power_handler
1404 }, 1388 },
1405 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_OSSP_EN] = { 1389 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_OSSP_EN] = {
1406 .destruct_handler = scic_sds_phy_default_destroy_handler,
1407 .frame_handler = scic_sds_phy_default_frame_handler, 1390 .frame_handler = scic_sds_phy_default_frame_handler,
1408 .event_handler = scic_sds_phy_starting_substate_await_ossp_event_handler, 1391 .event_handler = scic_sds_phy_starting_substate_await_ossp_event_handler,
1409 .consume_power_handler = scic_sds_phy_default_consume_power_handler 1392 .consume_power_handler = scic_sds_phy_default_consume_power_handler
1410 }, 1393 },
1411 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SAS_SPEED_EN] = { 1394 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SAS_SPEED_EN] = {
1412 .destruct_handler = scic_sds_phy_default_destroy_handler,
1413 .frame_handler = scic_sds_phy_default_frame_handler, 1395 .frame_handler = scic_sds_phy_default_frame_handler,
1414 .event_handler = scic_sds_phy_starting_substate_await_sas_phy_speed_event_handler, 1396 .event_handler = scic_sds_phy_starting_substate_await_sas_phy_speed_event_handler,
1415 .consume_power_handler = scic_sds_phy_default_consume_power_handler 1397 .consume_power_handler = scic_sds_phy_default_consume_power_handler
1416 }, 1398 },
1417 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_IAF_UF] = { 1399 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_IAF_UF] = {
1418 .destruct_handler = scic_sds_phy_default_destroy_handler,
1419 .frame_handler = scic_sds_phy_starting_substate_await_iaf_uf_frame_handler, 1400 .frame_handler = scic_sds_phy_starting_substate_await_iaf_uf_frame_handler,
1420 .event_handler = scic_sds_phy_starting_substate_await_iaf_uf_event_handler, 1401 .event_handler = scic_sds_phy_starting_substate_await_iaf_uf_event_handler,
1421 .consume_power_handler = scic_sds_phy_default_consume_power_handler 1402 .consume_power_handler = scic_sds_phy_default_consume_power_handler
1422 }, 1403 },
1423 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SAS_POWER] = { 1404 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SAS_POWER] = {
1424 .destruct_handler = scic_sds_phy_default_destroy_handler,
1425 .frame_handler = scic_sds_phy_default_frame_handler, 1405 .frame_handler = scic_sds_phy_default_frame_handler,
1426 .event_handler = scic_sds_phy_starting_substate_await_sas_power_event_handler, 1406 .event_handler = scic_sds_phy_starting_substate_await_sas_power_event_handler,
1427 .consume_power_handler = scic_sds_phy_starting_substate_await_sas_power_consume_power_handler 1407 .consume_power_handler = scic_sds_phy_starting_substate_await_sas_power_consume_power_handler
1428 }, 1408 },
1429 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SATA_POWER] = { 1409 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SATA_POWER] = {
1430 .destruct_handler = scic_sds_phy_default_destroy_handler,
1431 .frame_handler = scic_sds_phy_default_frame_handler, 1410 .frame_handler = scic_sds_phy_default_frame_handler,
1432 .event_handler = scic_sds_phy_starting_substate_await_sata_power_event_handler, 1411 .event_handler = scic_sds_phy_starting_substate_await_sata_power_event_handler,
1433 .consume_power_handler = scic_sds_phy_starting_substate_await_sata_power_consume_power_handler 1412 .consume_power_handler = scic_sds_phy_starting_substate_await_sata_power_consume_power_handler
1434 }, 1413 },
1435 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SATA_PHY_EN] = { 1414 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SATA_PHY_EN] = {
1436 .destruct_handler = scic_sds_phy_default_destroy_handler,
1437 .frame_handler = scic_sds_phy_default_frame_handler, 1415 .frame_handler = scic_sds_phy_default_frame_handler,
1438 .event_handler = scic_sds_phy_starting_substate_await_sata_phy_event_handler, 1416 .event_handler = scic_sds_phy_starting_substate_await_sata_phy_event_handler,
1439 .consume_power_handler = scic_sds_phy_default_consume_power_handler 1417 .consume_power_handler = scic_sds_phy_default_consume_power_handler
1440 }, 1418 },
1441 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SATA_SPEED_EN] = { 1419 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SATA_SPEED_EN] = {
1442 .destruct_handler = scic_sds_phy_default_destroy_handler,
1443 .frame_handler = scic_sds_phy_default_frame_handler, 1420 .frame_handler = scic_sds_phy_default_frame_handler,
1444 .event_handler = scic_sds_phy_starting_substate_await_sata_speed_event_handler, 1421 .event_handler = scic_sds_phy_starting_substate_await_sata_speed_event_handler,
1445 .consume_power_handler = scic_sds_phy_default_consume_power_handler 1422 .consume_power_handler = scic_sds_phy_default_consume_power_handler
1446 }, 1423 },
1447 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SIG_FIS_UF] = { 1424 [SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SIG_FIS_UF] = {
1448 .destruct_handler = scic_sds_phy_default_destroy_handler,
1449 .frame_handler = scic_sds_phy_starting_substate_await_sig_fis_frame_handler, 1425 .frame_handler = scic_sds_phy_starting_substate_await_sig_fis_frame_handler,
1450 .event_handler = scic_sds_phy_starting_substate_await_sig_fis_event_handler, 1426 .event_handler = scic_sds_phy_starting_substate_await_sig_fis_event_handler,
1451 .consume_power_handler = scic_sds_phy_default_consume_power_handler 1427 .consume_power_handler = scic_sds_phy_default_consume_power_handler
1452 }, 1428 },
1453 [SCIC_SDS_PHY_STARTING_SUBSTATE_FINAL] = { 1429 [SCIC_SDS_PHY_STARTING_SUBSTATE_FINAL] = {
1454 .destruct_handler = scic_sds_phy_default_destroy_handler,
1455 .frame_handler = scic_sds_phy_default_frame_handler, 1430 .frame_handler = scic_sds_phy_default_frame_handler,
1456 .event_handler = scic_sds_phy_default_event_handler, 1431 .event_handler = scic_sds_phy_default_event_handler,
1457 .consume_power_handler = scic_sds_phy_default_consume_power_handler 1432 .consume_power_handler = scic_sds_phy_default_consume_power_handler
1458 }, 1433 },
1459 [SCI_BASE_PHY_STATE_READY] = { 1434 [SCI_BASE_PHY_STATE_READY] = {
1460 .destruct_handler = scic_sds_phy_default_destroy_handler,
1461 .frame_handler = scic_sds_phy_default_frame_handler, 1435 .frame_handler = scic_sds_phy_default_frame_handler,
1462 .event_handler = scic_sds_phy_ready_state_event_handler, 1436 .event_handler = scic_sds_phy_ready_state_event_handler,
1463 .consume_power_handler = scic_sds_phy_default_consume_power_handler 1437 .consume_power_handler = scic_sds_phy_default_consume_power_handler
1464 }, 1438 },
1465 [SCI_BASE_PHY_STATE_RESETTING] = { 1439 [SCI_BASE_PHY_STATE_RESETTING] = {
1466 .destruct_handler = scic_sds_phy_default_destroy_handler,
1467 .frame_handler = scic_sds_phy_default_frame_handler, 1440 .frame_handler = scic_sds_phy_default_frame_handler,
1468 .event_handler = scic_sds_phy_resetting_state_event_handler, 1441 .event_handler = scic_sds_phy_resetting_state_event_handler,
1469 .consume_power_handler = scic_sds_phy_default_consume_power_handler 1442 .consume_power_handler = scic_sds_phy_default_consume_power_handler
1470 }, 1443 },
1471 [SCI_BASE_PHY_STATE_FINAL] = { 1444 [SCI_BASE_PHY_STATE_FINAL] = {
1472 .destruct_handler = scic_sds_phy_default_destroy_handler,
1473 .frame_handler = scic_sds_phy_default_frame_handler, 1445 .frame_handler = scic_sds_phy_default_frame_handler,
1474 .event_handler = scic_sds_phy_default_event_handler, 1446 .event_handler = scic_sds_phy_default_event_handler,
1475 .consume_power_handler = scic_sds_phy_default_consume_power_handler 1447 .consume_power_handler = scic_sds_phy_default_consume_power_handler
diff --git a/drivers/scsi/isci/phy.h b/drivers/scsi/isci/phy.h
index 56474333dfca..24536d6eef81 100644
--- a/drivers/scsi/isci/phy.h
+++ b/drivers/scsi/isci/phy.h
@@ -512,12 +512,6 @@ typedef enum sci_status (*scic_sds_phy_power_handler_t)(struct scic_sds_phy *);
512 512
513struct scic_sds_phy_state_handler { 513struct scic_sds_phy_state_handler {
514 /** 514 /**
515 * The destruct_handler specifies the method invoked when attempting to
516 * destruct a phy.
517 */
518 scic_sds_phy_handler_t destruct_handler;
519
520 /**
521 * The state handler for unsolicited frames received from the SCU hardware. 515 * The state handler for unsolicited frames received from the SCU hardware.
522 */ 516 */
523 scic_sds_phy_frame_handler_t frame_handler; 517 scic_sds_phy_frame_handler_t frame_handler;