diff options
author | Lendacky, Thomas <Thomas.Lendacky@amd.com> | 2015-01-16 13:46:24 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-01-16 22:24:19 -0500 |
commit | 1d67d7f6e925af985345e2a93ddc6aeaec3bc354 (patch) | |
tree | 72704c00db8f9b5431c206f1346144226d93764e /drivers | |
parent | 919d9db9521862d01712d9be25cd6ebfcc353eed (diff) |
amd-xgbe: Checkpatch fixes
This set of patches resolves some checks reported by the checkpatch
tool.
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c b/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c index 76479d04b903..2c063b60db4b 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c | |||
@@ -328,7 +328,7 @@ void xgbe_debugfs_init(struct xgbe_prv_data *pdata) | |||
328 | 328 | ||
329 | buf = kasprintf(GFP_KERNEL, "amd-xgbe-%s", pdata->netdev->name); | 329 | buf = kasprintf(GFP_KERNEL, "amd-xgbe-%s", pdata->netdev->name); |
330 | pdata->xgbe_debugfs = debugfs_create_dir(buf, NULL); | 330 | pdata->xgbe_debugfs = debugfs_create_dir(buf, NULL); |
331 | if (pdata->xgbe_debugfs == NULL) { | 331 | if (!pdata->xgbe_debugfs) { |
332 | netdev_err(pdata->netdev, "debugfs_create_dir failed\n"); | 332 | netdev_err(pdata->netdev, "debugfs_create_dir failed\n"); |
333 | return; | 333 | return; |
334 | } | 334 | } |
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c index 2ba1dd22ad64..e2e921768185 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c | |||
@@ -692,7 +692,7 @@ static void xgbe_adjust_link(struct net_device *netdev) | |||
692 | struct phy_device *phydev = pdata->phydev; | 692 | struct phy_device *phydev = pdata->phydev; |
693 | int new_state = 0; | 693 | int new_state = 0; |
694 | 694 | ||
695 | if (phydev == NULL) | 695 | if (!phydev) |
696 | return; | 696 | return; |
697 | 697 | ||
698 | if (phydev->link) { | 698 | if (phydev->link) { |
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c index 363b210560f3..7eeb03d271e2 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | |||
@@ -220,7 +220,7 @@ int xgbe_mdio_register(struct xgbe_prv_data *pdata) | |||
220 | } | 220 | } |
221 | 221 | ||
222 | mii = mdiobus_alloc(); | 222 | mii = mdiobus_alloc(); |
223 | if (mii == NULL) { | 223 | if (!mii) { |
224 | dev_err(pdata->dev, "mdiobus_alloc failed\n"); | 224 | dev_err(pdata->dev, "mdiobus_alloc failed\n"); |
225 | ret = -ENOMEM; | 225 | ret = -ENOMEM; |
226 | goto err_node_get; | 226 | goto err_node_get; |