diff options
author | Alan Stern <stern@rowland.harvard.edu> | 2008-07-21 10:25:52 -0400 |
---|---|---|
committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2008-07-26 15:14:56 -0400 |
commit | 12265709ac6e197f4d40d9ec1fd3af97b4196a35 (patch) | |
tree | 479b48c2082e374b20f1767fef7768b6ea696f84 /drivers | |
parent | af55ff675a8461da6a632320710b050af4366e0c (diff) |
[SCSI] scsi_eh_prep_cmnd should save scmd->underflow
This patch (as1116) fixes a bug in scsi_eh_prep_cmnd() and
scsi_eh_restore_cmnd(). These routines are supposed to save any
values they change and restore them later, but someone forgot to
save & restore scmd->underflow.
This fixes part of the problem reported in Bugzilla #9638.
[jejb: fix up rejections around DIF/DIX]
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/scsi/scsi_error.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index fc4b2d05f2e1..171b82d748cf 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c | |||
@@ -667,6 +667,7 @@ void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd, struct scsi_eh_save *ses, | |||
667 | ses->sdb = scmd->sdb; | 667 | ses->sdb = scmd->sdb; |
668 | ses->next_rq = scmd->request->next_rq; | 668 | ses->next_rq = scmd->request->next_rq; |
669 | ses->result = scmd->result; | 669 | ses->result = scmd->result; |
670 | ses->underflow = scmd->underflow; | ||
670 | ses->prot_op = scmd->prot_op; | 671 | ses->prot_op = scmd->prot_op; |
671 | 672 | ||
672 | scmd->prot_op = SCSI_PROT_NORMAL; | 673 | scmd->prot_op = SCSI_PROT_NORMAL; |
@@ -727,6 +728,7 @@ void scsi_eh_restore_cmnd(struct scsi_cmnd* scmd, struct scsi_eh_save *ses) | |||
727 | scmd->sdb = ses->sdb; | 728 | scmd->sdb = ses->sdb; |
728 | scmd->request->next_rq = ses->next_rq; | 729 | scmd->request->next_rq = ses->next_rq; |
729 | scmd->result = ses->result; | 730 | scmd->result = ses->result; |
731 | scmd->underflow = ses->underflow; | ||
730 | scmd->prot_op = ses->prot_op; | 732 | scmd->prot_op = ses->prot_op; |
731 | } | 733 | } |
732 | EXPORT_SYMBOL(scsi_eh_restore_cmnd); | 734 | EXPORT_SYMBOL(scsi_eh_restore_cmnd); |