diff options
author | Ravi Anand <ravi.anand@qlogic.com> | 2007-09-20 17:07:40 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.localdomain> | 2007-10-12 14:50:02 -0400 |
commit | 63a8651f2548c6bb5132c0b4e7dad4f57a9274db (patch) | |
tree | 721db8f23a2a9ea20fd029dde2e2ed5bb23d6792 /drivers | |
parent | b58369273956775c3e8b7bbbe152593d52762099 (diff) |
[SCSI] qla2xxx: Correct infinite-login-retry issue.
Where the DPC logic would get jammed into continuously
reloging-into a port.
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/scsi/qla2xxx/qla_os.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index a8ab2d3447ba..4314f94bd477 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c | |||
@@ -2437,7 +2437,6 @@ qla2x00_do_dpc(void *data) | |||
2437 | if (atomic_read(&fcport->state) != FCS_ONLINE && | 2437 | if (atomic_read(&fcport->state) != FCS_ONLINE && |
2438 | fcport->login_retry) { | 2438 | fcport->login_retry) { |
2439 | 2439 | ||
2440 | fcport->login_retry--; | ||
2441 | if (fcport->flags & FCF_FABRIC_DEVICE) { | 2440 | if (fcport->flags & FCF_FABRIC_DEVICE) { |
2442 | if (fcport->flags & | 2441 | if (fcport->flags & |
2443 | FCF_TAPE_PRESENT) | 2442 | FCF_TAPE_PRESENT) |
@@ -2453,6 +2452,7 @@ qla2x00_do_dpc(void *data) | |||
2453 | qla2x00_local_device_login( | 2452 | qla2x00_local_device_login( |
2454 | ha, fcport); | 2453 | ha, fcport); |
2455 | 2454 | ||
2455 | fcport->login_retry--; | ||
2456 | if (status == QLA_SUCCESS) { | 2456 | if (status == QLA_SUCCESS) { |
2457 | fcport->old_loop_id = fcport->loop_id; | 2457 | fcport->old_loop_id = fcport->loop_id; |
2458 | 2458 | ||
@@ -2470,6 +2470,8 @@ qla2x00_do_dpc(void *data) | |||
2470 | } else { | 2470 | } else { |
2471 | fcport->login_retry = 0; | 2471 | fcport->login_retry = 0; |
2472 | } | 2472 | } |
2473 | if (fcport->login_retry == 0) | ||
2474 | fcport->loop_id = FC_NO_LOOP_ID; | ||
2473 | } | 2475 | } |
2474 | if (test_bit(LOOP_RESYNC_NEEDED, &ha->dpc_flags)) | 2476 | if (test_bit(LOOP_RESYNC_NEEDED, &ha->dpc_flags)) |
2475 | break; | 2477 | break; |