diff options
author | Atsushi Nemoto <anemo@mba.ocn.ne.jp> | 2007-04-30 11:27:39 -0400 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2007-05-08 01:23:08 -0400 |
commit | f0e93c10faf08e8840a0b7a44abccb520ead12df (patch) | |
tree | 13d6853664cebdfa065492e0818cf0c9dc4458a4 /drivers | |
parent | a4d542b9fcae220a067156927e29a34cba605339 (diff) |
ne: Misc fixes for platform driver.
Miscellaneous fixes to make ne platform driver work properly.
* Make ioaddr 'unsigned long'.
* Move a printk down to show dev->name assigned in register_netdev.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/net/ne.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/drivers/net/ne.c b/drivers/net/ne.c index aef470d6b9ab..32ae91b0b611 100644 --- a/drivers/net/ne.c +++ b/drivers/net/ne.c | |||
@@ -147,7 +147,7 @@ bad_clone_list[] __initdata = { | |||
147 | # define DCR_VAL 0x49 | 147 | # define DCR_VAL 0x49 |
148 | #endif | 148 | #endif |
149 | 149 | ||
150 | static int ne_probe1(struct net_device *dev, int ioaddr); | 150 | static int ne_probe1(struct net_device *dev, unsigned long ioaddr); |
151 | static int ne_probe_isapnp(struct net_device *dev); | 151 | static int ne_probe_isapnp(struct net_device *dev); |
152 | 152 | ||
153 | static int ne_open(struct net_device *dev); | 153 | static int ne_open(struct net_device *dev); |
@@ -185,7 +185,7 @@ static void ne_block_output(struct net_device *dev, const int count, | |||
185 | 185 | ||
186 | static int __init do_ne_probe(struct net_device *dev) | 186 | static int __init do_ne_probe(struct net_device *dev) |
187 | { | 187 | { |
188 | unsigned int base_addr = dev->base_addr; | 188 | unsigned long base_addr = dev->base_addr; |
189 | #ifndef MODULE | 189 | #ifndef MODULE |
190 | int orig_irq = dev->irq; | 190 | int orig_irq = dev->irq; |
191 | #endif | 191 | #endif |
@@ -286,7 +286,7 @@ static int __init ne_probe_isapnp(struct net_device *dev) | |||
286 | return -ENODEV; | 286 | return -ENODEV; |
287 | } | 287 | } |
288 | 288 | ||
289 | static int __init ne_probe1(struct net_device *dev, int ioaddr) | 289 | static int __init ne_probe1(struct net_device *dev, unsigned long ioaddr) |
290 | { | 290 | { |
291 | int i; | 291 | int i; |
292 | unsigned char SA_prom[32]; | 292 | unsigned char SA_prom[32]; |
@@ -325,7 +325,7 @@ static int __init ne_probe1(struct net_device *dev, int ioaddr) | |||
325 | if (ei_debug && version_printed++ == 0) | 325 | if (ei_debug && version_printed++ == 0) |
326 | printk(KERN_INFO "%s" KERN_INFO "%s", version1, version2); | 326 | printk(KERN_INFO "%s" KERN_INFO "%s", version1, version2); |
327 | 327 | ||
328 | printk(KERN_INFO "NE*000 ethercard probe at %#3x:", ioaddr); | 328 | printk(KERN_INFO "NE*000 ethercard probe at %#3lx:", ioaddr); |
329 | 329 | ||
330 | /* A user with a poor card that fails to ack the reset, or that | 330 | /* A user with a poor card that fails to ack the reset, or that |
331 | does not have a valid 0x57,0x57 signature can still use this | 331 | does not have a valid 0x57,0x57 signature can still use this |
@@ -517,8 +517,7 @@ static int __init ne_probe1(struct net_device *dev, int ioaddr) | |||
517 | } | 517 | } |
518 | #endif | 518 | #endif |
519 | 519 | ||
520 | printk("\n%s: %s found at %#x, using IRQ %d.\n", | 520 | printk("\n"); |
521 | dev->name, name, ioaddr, dev->irq); | ||
522 | 521 | ||
523 | ei_status.name = name; | 522 | ei_status.name = name; |
524 | ei_status.tx_start_page = start_page; | 523 | ei_status.tx_start_page = start_page; |
@@ -548,6 +547,8 @@ static int __init ne_probe1(struct net_device *dev, int ioaddr) | |||
548 | ret = register_netdev(dev); | 547 | ret = register_netdev(dev); |
549 | if (ret) | 548 | if (ret) |
550 | goto out_irq; | 549 | goto out_irq; |
550 | printk(KERN_INFO "%s: %s found at %#lx, using IRQ %d.\n", | ||
551 | dev->name, name, ioaddr, dev->irq); | ||
551 | return 0; | 552 | return 0; |
552 | 553 | ||
553 | out_irq: | 554 | out_irq: |