[PATCH] PCI: fix-pci-mmap-on-ppc-and-ppc64.patch

This is an updated version of Ben's fix-pci-mmap-on-ppc-and-ppc64.patch
which is in 2.6.12-rc4-mm1.

It fixes the patch to work on PPC iSeries, removes some debug printks
at Ben's request, and incorporates your
fix-pci-mmap-on-ppc-and-ppc64-fix.patch also.

Originally from Benjamin Herrenschmidt <benh@kernel.crashing.org>

This patch was discussed at length on linux-pci and so far, the last
iteration of it didn't raise any comment.  It's effect is a nop on
architecture that don't define the new pci_resource_to_user() callback
anyway.  It allows architecture like ppc who put weird things inside of
PCI resource structures to convert to some different value for user
visible ones.  It also fixes mmap'ing of IO space on those archs.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

2 files changed, 31 insertions, 9 deletions

diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index a15f94072a6f..cc9d65388e62 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -60,15 +60,18 @@ resource_show(struct device * dev, struct device_attribute *attr, char * buf)
         char * str = buf;
         int i;
         int max = 7;
+        u64 start, end;
 
         if (pci_dev->subordinate)
                 max = DEVICE_COUNT_RESOURCE;
 
         for (i = 0; i < max; i++) {
-                str += sprintf(str,"0x%016lx 0x%016lx 0x%016lx\n",
-                               pci_resource_start(pci_dev,i),
-                               pci_resource_end(pci_dev,i),
-                               pci_resource_flags(pci_dev,i));
+                struct resource *res =  &pci_dev->resource[i];
+                pci_resource_to_user(pci_dev, i, res, &start, &end);
+                str += sprintf(str,"0x%016llx 0x%016llx 0x%016llx\n",
+                               (unsigned long long)start,
+                               (unsigned long long)end,
+                               (unsigned long long)res->flags);
         }
         return (str - buf);
 }
@@ -313,8 +316,21 @@ pci_mmap_resource(struct kobject *kobj, struct bin_attribute *attr,
                                                        struct device, kobj));
         struct resource *res = (struct resource *)attr->private;
         enum pci_mmap_state mmap_type;
+        u64 start, end;
+        int i;
 
-        vma->vm_pgoff += res->start >> PAGE_SHIFT;
+        for (i = 0; i < PCI_ROM_RESOURCE; i++)
+                if (res == &pdev->resource[i])
+                        break;
+        if (i >= PCI_ROM_RESOURCE)
+                return -ENODEV;
+
+        /* pci_mmap_page_range() expects the same kind of entry as coming
+         * from /proc/bus/pci/ which is a "user visible" value. If this is
+         * different from the resource itself, arch will do necessary fixup.
+         */
+        pci_resource_to_user(pdev, i, res, &start, &end);
+        vma->vm_pgoff += start >> PAGE_SHIFT;
         mmap_type = res->flags & IORESOURCE_MEM ? pci_mmap_mem : pci_mmap_io;
 
         return pci_mmap_page_range(pdev, vma, mmap_type, 0);
diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c
index e68bbfb1e7c3..7988fc8df3fd 100644
--- a/drivers/pci/proc.c
+++ b/drivers/pci/proc.c
@@ -355,14 +355,20 @@ static int show_device(struct seq_file *m, void *v)
                         dev->device,
                         dev->irq);
         /* Here should be 7 and not PCI_NUM_RESOURCES as we need to preserve compatibility */
-        for(i=0; i<7; i++)
+        for (i=0; i<7; i++) {
+                u64 start, end;
+                pci_resource_to_user(dev, i, &dev->resource[i], &start, &end);
                 seq_printf(m, LONG_FORMAT,
-                        dev->resource[i].start |
+                        ((unsigned long)start) |
                         (dev->resource[i].flags & PCI_REGION_FLAG_MASK));
-        for(i=0; i<7; i++)
+        }
+        for (i=0; i<7; i++) {
+                u64 start, end;
+                pci_resource_to_user(dev, i, &dev->resource[i], &start, &end);
                 seq_printf(m, LONG_FORMAT,
                         dev->resource[i].start < dev->resource[i].end ?
-                        dev->resource[i].end - dev->resource[i].start + 1 : 0);
+                        (unsigned long)(end - start) + 1 : 0);
+        }
         seq_putc(m, '\t');
         if (drv)
                 seq_printf(m, "%s", drv->name);