diff options
author | Roel Kluin <12o3l@tiscali.nl> | 2008-04-23 17:44:03 -0400 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2008-04-28 16:24:44 -0400 |
commit | 62783679540fbdfd74e10fbe9478d978141ba45f (patch) | |
tree | 621e7aa66ffbd0296b3d76cc48f8d2ca837a36e8 /drivers | |
parent | 26eed9a5c61edd93d88e147188d4feae6770174e (diff) |
[ARM] am79c961a: platform_get_irq() may return signed unnoticed
dev->irq is unsigned, platform_get_irq() may return signed unnoticed
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/net/arm/am79c961a.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/drivers/net/arm/am79c961a.c b/drivers/net/arm/am79c961a.c index ba6bd03a015f..a637910b02dd 100644 --- a/drivers/net/arm/am79c961a.c +++ b/drivers/net/arm/am79c961a.c | |||
@@ -693,11 +693,15 @@ static int __init am79c961_probe(struct platform_device *pdev) | |||
693 | * done by the ether bootp loader. | 693 | * done by the ether bootp loader. |
694 | */ | 694 | */ |
695 | dev->base_addr = res->start; | 695 | dev->base_addr = res->start; |
696 | dev->irq = platform_get_irq(pdev, 0); | 696 | ret = platform_get_irq(pdev, 0); |
697 | 697 | ||
698 | ret = -ENODEV; | 698 | if (ret < 0) { |
699 | if (dev->irq < 0) | 699 | ret = -ENODEV; |
700 | goto nodev; | 700 | goto nodev; |
701 | } | ||
702 | dev->irq = ret; | ||
703 | |||
704 | ret = -ENODEV; | ||
701 | if (!request_region(dev->base_addr, 0x18, dev->name)) | 705 | if (!request_region(dev->base_addr, 0x18, dev->name)) |
702 | goto nodev; | 706 | goto nodev; |
703 | 707 | ||