diff options
author | Satyam Sharma <satyam@infradead.org> | 2007-08-10 18:28:10 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-10-10 19:48:02 -0400 |
commit | d133ccbdc30c7f86459519cec1126d6473762b10 (patch) | |
tree | 37f41671ddba891149a7aec6c3ab349c81a9a7c1 /drivers | |
parent | d39badf05b52f99169b22ce324fd31c8b44a0473 (diff) |
[NET] netconsole: Remove bogus check
Based upon initial work by Keiichi Kii <k-keiichi@bx.jp.nec.com>.
The (!np.dev) check in write_msg() is bogus (always false), because: np.dev is
set by netpoll_setup(), which is called by init_netconsole() before
register_console(), so write_msg() cannot be triggered unless netpoll_setup()
successfully set np.dev. Also np.dev cannot go away from under us, because
netpoll_setup() grabs us reference on it. So let's remove the bogus check.
Signed-off-by: Satyam Sharma <satyam@infradead.org>
Acked-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
Acked-by: Matt Mackall <mpm@selenic.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/net/netconsole.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index f1c2a2defd70..2c2aef1ae8eb 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c | |||
@@ -67,9 +67,6 @@ static void write_msg(struct console *con, const char *msg, unsigned int len) | |||
67 | int frag, left; | 67 | int frag, left; |
68 | unsigned long flags; | 68 | unsigned long flags; |
69 | 69 | ||
70 | if (!np.dev) | ||
71 | return; | ||
72 | |||
73 | local_irq_save(flags); | 70 | local_irq_save(flags); |
74 | 71 | ||
75 | for (left = len; left;) { | 72 | for (left = len; left;) { |