diff options
author | Michael Hanselmann <linux-kernel@hansmi.ch> | 2006-06-28 07:26:55 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-06-28 17:59:06 -0400 |
commit | cab267c65f44337974e4f1eae490b21dce0e9811 (patch) | |
tree | d752bda111449ae7e9b7c85988f2993a9a068128 /drivers | |
parent | 96febe9fb7b04f2a078882d08bd6a997dee7cfa3 (diff) |
[PATCH] powermac backlight fixes
Fix a erroneous calculation of the legacy brightness values as reported by
Paul Collins. Additionally, it moves the calculation of the negative value
in the radeonfb driver after the value check.
Signed-off-by: Michael Hanselmann <linux-kernel@hansmi.ch>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Paul Collins <paul@briny.ondioline.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/video/aty/radeon_backlight.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/video/aty/radeon_backlight.c b/drivers/video/aty/radeon_backlight.c index 7de66b855d4e..1755dddf1899 100644 --- a/drivers/video/aty/radeon_backlight.c +++ b/drivers/video/aty/radeon_backlight.c | |||
@@ -40,14 +40,14 @@ static int radeon_bl_get_level_brightness(struct radeon_bl_privdata *pdata, | |||
40 | 40 | ||
41 | mutex_unlock(&info->bl_mutex); | 41 | mutex_unlock(&info->bl_mutex); |
42 | 42 | ||
43 | if (pdata->negative) | ||
44 | rlevel = MAX_RADEON_LEVEL - rlevel; | ||
45 | |||
46 | if (rlevel < 0) | 43 | if (rlevel < 0) |
47 | rlevel = 0; | 44 | rlevel = 0; |
48 | else if (rlevel > MAX_RADEON_LEVEL) | 45 | else if (rlevel > MAX_RADEON_LEVEL) |
49 | rlevel = MAX_RADEON_LEVEL; | 46 | rlevel = MAX_RADEON_LEVEL; |
50 | 47 | ||
48 | if (pdata->negative) | ||
49 | rlevel = MAX_RADEON_LEVEL - rlevel; | ||
50 | |||
51 | return rlevel; | 51 | return rlevel; |
52 | } | 52 | } |
53 | 53 | ||