diff options
author | <jejb@titanic.il.steeleye.com> | 2005-04-12 17:38:09 -0400 |
---|---|---|
committer | James Bottomley <jejb@titanic> | 2005-04-16 21:10:34 -0400 |
commit | c2a9331c62216e222a08de8dd58559367fef0af6 (patch) | |
tree | f25b06ee61ffa8b000a45d0ec5f8a92ebb67f0ce /drivers | |
parent | 152587deb8903c0edf483a5b889f975bc6bea7e0 (diff) |
updates for CFQ oops fix
- add a comment to the device structure that the device_busy field
is now protected by the request_queue->queue_lock
- null out sdev->request_queue after the queue is released to trap
any (and there shouldn't be any) use after the queue is freed.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/scsi/scsi_sysfs.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index 134d3a3e4222..e75ee4671ee3 100644 --- a/drivers/scsi/scsi_sysfs.c +++ b/drivers/scsi/scsi_sysfs.c | |||
@@ -171,6 +171,9 @@ void scsi_device_dev_release(struct device *dev) | |||
171 | if (sdev->request_queue) { | 171 | if (sdev->request_queue) { |
172 | sdev->request_queue->queuedata = NULL; | 172 | sdev->request_queue->queuedata = NULL; |
173 | scsi_free_queue(sdev->request_queue); | 173 | scsi_free_queue(sdev->request_queue); |
174 | /* temporary expedient, try to catch use of queue lock | ||
175 | * after free of sdev */ | ||
176 | sdev->request_queue = NULL; | ||
174 | } | 177 | } |
175 | 178 | ||
176 | scsi_target_reap(scsi_target(sdev)); | 179 | scsi_target_reap(scsi_target(sdev)); |