diff options
author | Russell King <rmk@dyn-67.arm.linux.org.uk> | 2005-05-03 07:23:56 -0400 |
---|---|---|
committer | Russell King <rmk@dyn-67.arm.linux.org.uk> | 2005-05-03 07:23:56 -0400 |
commit | eca02b0c1dc1da374216128157747d8ed994e5ef (patch) | |
tree | d1fcc442129d13b4431686467a9ecbb50e222cfc /drivers | |
parent | 1f9c381fa3e0b9b9042e310c69df87eaf9b46ea4 (diff) |
[PATCH] ARM: Cleanup kmalloc in cyber2000fb
We use one kmalloc to allocate two structures needlessly.
Combine these two structures into one.
Signed-off-by: Russell King <rmk@arm.linux.org.uk>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/video/cyber2000fb.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/video/cyber2000fb.c b/drivers/video/cyber2000fb.c index 8b1b7c687a99..3894b2a501d6 100644 --- a/drivers/video/cyber2000fb.c +++ b/drivers/video/cyber2000fb.c | |||
@@ -90,6 +90,8 @@ struct cfb_info { | |||
90 | */ | 90 | */ |
91 | u_char ramdac_ctrl; | 91 | u_char ramdac_ctrl; |
92 | u_char ramdac_powerdown; | 92 | u_char ramdac_powerdown; |
93 | |||
94 | u32 pseudo_palette[16]; | ||
93 | }; | 95 | }; |
94 | 96 | ||
95 | static char *default_font = "Acorn8x8"; | 97 | static char *default_font = "Acorn8x8"; |
@@ -1223,9 +1225,7 @@ cyberpro_alloc_fb_info(unsigned int id, char *name) | |||
1223 | { | 1225 | { |
1224 | struct cfb_info *cfb; | 1226 | struct cfb_info *cfb; |
1225 | 1227 | ||
1226 | cfb = kmalloc(sizeof(struct cfb_info) + | 1228 | cfb = kmalloc(sizeof(struct cfb_info), GFP_KERNEL); |
1227 | sizeof(u32) * 16, GFP_KERNEL); | ||
1228 | |||
1229 | if (!cfb) | 1229 | if (!cfb) |
1230 | return NULL; | 1230 | return NULL; |
1231 | 1231 | ||
@@ -1281,7 +1281,7 @@ cyberpro_alloc_fb_info(unsigned int id, char *name) | |||
1281 | 1281 | ||
1282 | cfb->fb.fbops = &cyber2000fb_ops; | 1282 | cfb->fb.fbops = &cyber2000fb_ops; |
1283 | cfb->fb.flags = FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN; | 1283 | cfb->fb.flags = FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN; |
1284 | cfb->fb.pseudo_palette = (void *)(cfb + 1); | 1284 | cfb->fb.pseudo_palette = cfb->pseudo_palette; |
1285 | 1285 | ||
1286 | fb_alloc_cmap(&cfb->fb.cmap, NR_PALETTE, 0); | 1286 | fb_alloc_cmap(&cfb->fb.cmap, NR_PALETTE, 0); |
1287 | 1287 | ||