[PATCH] powerpc: remove bitfields from HvLpEvent

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>

4 files changed, 35 insertions, 38 deletions

diff --git a/drivers/block/viodasd.c b/drivers/block/viodasd.c
index d1aaf31bd97e..f63e07bd9f9c 100644
--- a/drivers/block/viodasd.c
+++ b/drivers/block/viodasd.c
@@ -293,6 +293,7 @@ static int send_request(struct request *req)
         u16 viocmd;
         HvLpEvent_Rc hvrc;
         struct vioblocklpevent *bevent;
+        struct HvLpEvent *hev;
         struct scatterlist sg[VIOMAXBLOCKDMA];
         int sgindex;
         int statindex;
@@ -347,22 +348,19 @@ static int send_request(struct request *req)
                  * token so we can match the response up later
                  */
                 memset(bevent, 0, sizeof(struct vioblocklpevent));
-                bevent->event.xFlags.xValid = 1;
-                bevent->event.xFlags.xFunction = HvLpEvent_Function_Int;
-                bevent->event.xFlags.xAckInd = HvLpEvent_AckInd_DoAck;
-                bevent->event.xFlags.xAckType = HvLpEvent_AckType_ImmediateAck;
-                bevent->event.xType = HvLpEvent_Type_VirtualIo;
-                bevent->event.xSubtype = viocmd;
-                bevent->event.xSourceLp = HvLpConfig_getLpIndex();
-                bevent->event.xTargetLp = viopath_hostLp;
-                bevent->event.xSizeMinus1 =
+                hev = &bevent->event;
+                hev->flags = HV_LP_EVENT_VALID | HV_LP_EVENT_DO_ACK |
+                        HV_LP_EVENT_INT;
+                hev->xType = HvLpEvent_Type_VirtualIo;
+                hev->xSubtype = viocmd;
+                hev->xSourceLp = HvLpConfig_getLpIndex();
+                hev->xTargetLp = viopath_hostLp;
+                hev->xSizeMinus1 =
                         offsetof(struct vioblocklpevent, u.rw_data.dma_info) +
                         (sizeof(bevent->u.rw_data.dma_info[0]) * nsg) - 1;
-                bevent->event.xSourceInstanceId =
-                        viopath_sourceinst(viopath_hostLp);
-                bevent->event.xTargetInstanceId =
-                        viopath_targetinst(viopath_hostLp);
-                bevent->event.xCorrelationToken = (u64)req;
+                hev->xSourceInstanceId = viopath_sourceinst(viopath_hostLp);
+                hev->xTargetInstanceId = viopath_targetinst(viopath_hostLp);
+                hev->xCorrelationToken = (u64)req;
                 bevent->version = VIOVERSION;
                 bevent->disk = DEVICE_NO(d);
                 bevent->u.rw_data.offset = start;
@@ -649,10 +647,10 @@ static void handle_block_event(struct HvLpEvent *event)
                 /* Notification that a partition went away! */
                 return;
         /* First, we should NEVER get an int here...only acks */
-        if (event->xFlags.xFunction == HvLpEvent_Function_Int) {
+        if (hvlpevent_is_int(event)) {
                 printk(VIOD_KERN_WARNING
                        "Yikes! got an int in viodasd event handler!\n");
-                if (event->xFlags.xAckInd == HvLpEvent_AckInd_DoAck) {
+                if (hvlpevent_need_ack(event)) {
                         event->xRc = HvLpEvent_Rc_InvalidSubtype;
                         HvCallEvent_ackLpEvent(event);
                 }
@@ -695,7 +693,7 @@ static void handle_block_event(struct HvLpEvent *event)
 
         default:
                 printk(VIOD_KERN_WARNING "invalid subtype!");
-                if (event->xFlags.xAckInd == HvLpEvent_AckInd_DoAck) {
+                if (hvlpevent_need_ack(event)) {
                         event->xRc = HvLpEvent_Rc_InvalidSubtype;
                         HvCallEvent_ackLpEvent(event);
                 }
diff --git a/drivers/cdrom/viocd.c b/drivers/cdrom/viocd.c
index b5191780ecca..193446e6a08a 100644
--- a/drivers/cdrom/viocd.c
+++ b/drivers/cdrom/viocd.c
@@ -542,10 +542,10 @@ static void vio_handle_cd_event(struct HvLpEvent *event)
                 /* Notification that a partition went away! */
                 return;
         /* First, we should NEVER get an int here...only acks */
-        if (event->xFlags.xFunction == HvLpEvent_Function_Int) {
+        if (hvlpevent_is_int(event)) {
                 printk(VIOCD_KERN_WARNING
                                 "Yikes! got an int in viocd event handler!\n");
-                if (event->xFlags.xAckInd == HvLpEvent_AckInd_DoAck) {
+                if (hvlpevent_need_ack(event)) {
                         event->xRc = HvLpEvent_Rc_InvalidSubtype;
                         HvCallEvent_ackLpEvent(event);
                 }
@@ -616,7 +616,7 @@ return_complete:
                 printk(VIOCD_KERN_WARNING
                                 "message with invalid subtype %0x04X!\n",
                                 event->xSubtype & VIOMINOR_SUBTYPE_MASK);
-                if (event->xFlags.xAckInd == HvLpEvent_AckInd_DoAck) {
+                if (hvlpevent_need_ack(event)) {
                         event->xRc = HvLpEvent_Rc_InvalidSubtype;
                         HvCallEvent_ackLpEvent(event);
                 }
diff --git a/drivers/char/viocons.c b/drivers/char/viocons.c
index faee5e7acaf7..4e5360388748 100644
--- a/drivers/char/viocons.c
+++ b/drivers/char/viocons.c
@@ -476,19 +476,19 @@ static struct port_info *get_port_data(struct tty_struct *tty)
  */
 static void initDataEvent(struct viocharlpevent *viochar, HvLpIndex lp)
 {
+        struct HvLpEvent *hev = &viochar->event;
+
         memset(viochar, 0, sizeof(struct viocharlpevent));
 
-        viochar->event.xFlags.xValid = 1;
-        viochar->event.xFlags.xFunction = HvLpEvent_Function_Int;
-        viochar->event.xFlags.xAckInd = HvLpEvent_AckInd_NoAck;
-        viochar->event.xFlags.xAckType = HvLpEvent_AckType_DeferredAck;
-        viochar->event.xType = HvLpEvent_Type_VirtualIo;
-        viochar->event.xSubtype = viomajorsubtype_chario | viochardata;
-        viochar->event.xSourceLp = HvLpConfig_getLpIndex();
-        viochar->event.xTargetLp = lp;
-        viochar->event.xSizeMinus1 = sizeof(struct viocharlpevent);
-        viochar->event.xSourceInstanceId = viopath_sourceinst(lp);
-        viochar->event.xTargetInstanceId = viopath_targetinst(lp);
+        hev->flags = HV_LP_EVENT_VALID | HV_LP_EVENT_DEFERRED_ACK |
+                HV_LP_EVENT_INT;
+        hev->xType = HvLpEvent_Type_VirtualIo;
+        hev->xSubtype = viomajorsubtype_chario | viochardata;
+        hev->xSourceLp = HvLpConfig_getLpIndex();
+        hev->xTargetLp = lp;
+        hev->xSizeMinus1 = sizeof(struct viocharlpevent);
+        hev->xSourceInstanceId = viopath_sourceinst(lp);
+        hev->xTargetInstanceId = viopath_targetinst(lp);
 }
 
 /*
@@ -752,7 +752,7 @@ static void vioHandleOpenEvent(struct HvLpEvent *event)
         struct port_info *pi;
         int reject = 0;
 
-        if (event->xFlags.xFunction == HvLpEvent_Function_Ack) {
+        if (hvlpevent_is_ack(event)) {
                 if (port >= VTTY_PORTS)
                         return;
 
@@ -788,7 +788,7 @@ static void vioHandleOpenEvent(struct HvLpEvent *event)
         }
 
         /* This had better require an ack, otherwise complain */
-        if (event->xFlags.xAckInd != HvLpEvent_AckInd_DoAck) {
+        if (!hvlpevent_need_ack(event)) {
                 printk(VIOCONS_KERN_WARN "viocharopen without ack bit!\n");
                 return;
         }
@@ -856,7 +856,7 @@ static void vioHandleCloseEvent(struct HvLpEvent *event)
         struct viocharlpevent *cevent = (struct viocharlpevent *)event;
         u8 port = cevent->virtual_device;
 
-        if (event->xFlags.xFunction == HvLpEvent_Function_Int) {
+        if (hvlpevent_is_int(event)) {
                 if (port >= VTTY_PORTS) {
                         printk(VIOCONS_KERN_WARN
                                         "close message from invalid virtual device.\n");
@@ -1056,8 +1056,7 @@ static void vioHandleCharEvent(struct HvLpEvent *event)
                 vioHandleConfig(event);
                 break;
         default:
-                if ((event->xFlags.xFunction == HvLpEvent_Function_Int) &&
-                    (event->xFlags.xAckInd == HvLpEvent_AckInd_DoAck)) {
+                if (hvlpevent_is_int(event) && hvlpevent_need_ack(event)) {
                         event->xRc = HvLpEvent_Rc_InvalidSubtype;
                         HvCallEvent_ackLpEvent(event);
                 }
diff --git a/drivers/net/iseries_veth.c b/drivers/net/iseries_veth.c
index 77eadf84cb2c..f0f04be989d6 100644
--- a/drivers/net/iseries_veth.c
+++ b/drivers/net/iseries_veth.c
@@ -590,9 +590,9 @@ static void veth_handle_event(struct HvLpEvent *event, struct pt_regs *regs)
 {
         struct veth_lpevent *veth_event = (struct veth_lpevent *)event;
 
-        if (event->xFlags.xFunction == HvLpEvent_Function_Ack)
+        if (hvlpevent_is_ack(event))
                 veth_handle_ack(veth_event);
-        else if (event->xFlags.xFunction == HvLpEvent_Function_Int)
+        else
                 veth_handle_int(veth_event);
 }