aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorAndrew Morton <akpm@linux-foundation.org>2007-07-31 03:38:02 -0400
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-07-31 18:39:38 -0400
commit57d4810ea0d9ca58a7bcc1336607f0cede0a2abf (patch)
tree6194ce01088fbd9852579a14bd8726d9c8eef73f /drivers
parenta583f1b54249b11ad1ffd14c6e74d28fcbc59c07 (diff)
revert "x86, serial: convert legacy COM ports to platform devices"
Revert 7e92b4fc345f5b6f57585fbe5ffdb0f24d7c9b26. It broke Sébastien Dugué's machine and Jeff said (persuasively) This seems like it will break decades-long-working stuff, in favor of breaking new ground in our favorite area, "trusting the BIOS." It's just not worth it for serial ports, IMO. Serial ports are something that just shouldn't break at this late stage in the game. My new Intel platform boxes don't even have serial ports, so I question the value of messing with serial port probing even more... because... just wait a year, and your box won't have a serial port either! :) I certainly don't object to the use of platform devices (or isa_driver), but the probe change seems questionable. That's sorta analagous to rewriting the floppy driver probe routine. Sure you could do it... but why risk all that damage and go through debugging all over again? It seems clear from this report that we cannot, should not, trust BIOS for something (a) so simple and (b) that has been working for over a decade. Much discussion ensued and we've decided to have another go at all of this. Cc: Sébastien Dugué <sebastien.dugue@bull.net> Cc: Bjorn Helgaas <bjorn.helgaas@hp.com> Cc: Len Brown <lenb@kernel.org> Cc: Adam Belay <ambx1@neo.rr.com> Cc: Matthew Garrett <mjg59@srcf.ucam.org> Cc: Russell King <rmk@arm.linux.org.uk> Cc: Jeff Garzik <jeff@garzik.org> Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk> Cc: Michal Piotrowski <michal.k.k.piotrowski@gmail.com> Cc: Sascha Sommer <saschasommer@freenet.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/serial/Kconfig14
1 files changed, 5 insertions, 9 deletions
diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index 18f629706448..819fc3efc468 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -88,21 +88,17 @@ config SERIAL_8250_PCI
88 depends on SERIAL_8250 && PCI 88 depends on SERIAL_8250 && PCI
89 default SERIAL_8250 89 default SERIAL_8250
90 help 90 help
91 Say Y here if you have PCI serial ports. 91 This builds standard PCI serial support. You may be able to
92 92 disable this feature if you only need legacy serial support.
93 To compile this driver as a module, choose M here: the module 93 Saves about 9K.
94 will be called 8250_pci.
95 94
96config SERIAL_8250_PNP 95config SERIAL_8250_PNP
97 tristate "8250/16550 PNP device support" if EMBEDDED 96 tristate "8250/16550 PNP device support" if EMBEDDED
98 depends on SERIAL_8250 && PNP 97 depends on SERIAL_8250 && PNP
99 default SERIAL_8250 98 default SERIAL_8250
100 help 99 help
101 Say Y here if you have serial ports described by PNPBIOS or ACPI. 100 This builds standard PNP serial support. You may be able to
102 These are typically ports built into the system board. 101 disable this feature if you only need legacy serial support.
103
104 To compile this driver as a module, choose M here: the module
105 will be called 8250_pnp.
106 102
107config SERIAL_8250_HP300 103config SERIAL_8250_HP300
108 tristate 104 tristate