diff options
author | Michael Holzheu <holzheu@de.ibm.com> | 2007-08-10 08:32:33 -0400 |
---|---|---|
committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2007-08-10 08:32:38 -0400 |
commit | 4eac34529bce2b4cca9be90a6903c965baa8193c (patch) | |
tree | 2a0d04aa4ed5b9c2d9a75158c6c0715456443e5f /drivers | |
parent | f2405598e0678e9c93dd780f2a12fc562ece3d13 (diff) |
[S390] vmur: add "top of queue" sanity check for reader open
If the z/VM reader is already open, it can happen that after opening the
Linux reader device, not the topmost file is processed. According the
semantics of the Linux z/VM unit record device driver, always the topmost
file has to be processed. With this fix an error is returned if that is
not the case.
Signed-off-by: Michael Holzheu <holzheu@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/s390/char/vmur.c | 7 | ||||
-rw-r--r-- | drivers/s390/char/vmur.h | 1 |
2 files changed, 7 insertions, 1 deletions
diff --git a/drivers/s390/char/vmur.c b/drivers/s390/char/vmur.c index 04395c0f99d8..a9d58629e795 100644 --- a/drivers/s390/char/vmur.c +++ b/drivers/s390/char/vmur.c | |||
@@ -565,9 +565,14 @@ static int verify_device(struct urdev *urd) | |||
565 | return -ENOMEM; | 565 | return -ENOMEM; |
566 | rc = diag_read_file(urd->dev_id.devno, buf); | 566 | rc = diag_read_file(urd->dev_id.devno, buf); |
567 | kfree(buf); | 567 | kfree(buf); |
568 | |||
569 | if ((rc != 0) && (rc != -ENODATA)) /* EOF does not hurt */ | 568 | if ((rc != 0) && (rc != -ENODATA)) /* EOF does not hurt */ |
570 | return rc; | 569 | return rc; |
570 | /* check if the file on top of the queue is open now */ | ||
571 | rc = diag_read_next_file_info(&fcb, 0); | ||
572 | if (rc) | ||
573 | return rc; | ||
574 | if (!(fcb.file_stat & FLG_IN_USE)) | ||
575 | return -EMFILE; | ||
571 | return 0; | 576 | return 0; |
572 | default: | 577 | default: |
573 | return -ENOTSUPP; | 578 | return -ENOTSUPP; |
diff --git a/drivers/s390/char/vmur.h b/drivers/s390/char/vmur.h index 522a9dfaa275..2b3c564e0472 100644 --- a/drivers/s390/char/vmur.h +++ b/drivers/s390/char/vmur.h | |||
@@ -53,6 +53,7 @@ struct file_control_block { | |||
53 | #define FLG_SYSTEM_HOLD 0x04 | 53 | #define FLG_SYSTEM_HOLD 0x04 |
54 | #define FLG_CP_DUMP 0x10 | 54 | #define FLG_CP_DUMP 0x10 |
55 | #define FLG_USER_HOLD 0x20 | 55 | #define FLG_USER_HOLD 0x20 |
56 | #define FLG_IN_USE 0x80 | ||
56 | 57 | ||
57 | /* | 58 | /* |
58 | * A struct urdev is created for each ur device that is made available | 59 | * A struct urdev is created for each ur device that is made available |