diff options
author | Marcel Holtmann <marcel@holtmann.org> | 2006-12-21 17:06:24 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.osdl.org> | 2006-12-22 17:31:24 -0500 |
commit | dab6df63086762629936e8b89a5984bae39724f6 (patch) | |
tree | 9071f108ef5451e1c95f7d682076b37950fdba95 /drivers | |
parent | f2a67a576959025549a3b6a884bdd21f4dc107da (diff) |
[PATCH] Call init_timer() for ISDN PPP CCP reset state timer
The function isdn_ppp_ccp_reset_alloc_state() sets ->timer.function
and ->timer.data and later on calls add_timer() with no init_timer()
ever done.
Noted by Al Viro.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Karsten Keil <kkeil@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/isdn/i4l/isdn_ppp.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/isdn/i4l/isdn_ppp.c b/drivers/isdn/i4l/isdn_ppp.c index 1726131b20be..4e3f127e4003 100644 --- a/drivers/isdn/i4l/isdn_ppp.c +++ b/drivers/isdn/i4l/isdn_ppp.c | |||
@@ -2339,6 +2339,7 @@ static struct ippp_ccp_reset_state *isdn_ppp_ccp_reset_alloc_state(struct ippp_s | |||
2339 | rs->state = CCPResetIdle; | 2339 | rs->state = CCPResetIdle; |
2340 | rs->is = is; | 2340 | rs->is = is; |
2341 | rs->id = id; | 2341 | rs->id = id; |
2342 | init_timer(&rs->timer); | ||
2342 | rs->timer.data = (unsigned long)rs; | 2343 | rs->timer.data = (unsigned long)rs; |
2343 | rs->timer.function = isdn_ppp_ccp_timer_callback; | 2344 | rs->timer.function = isdn_ppp_ccp_timer_callback; |
2344 | is->reset->rs[id] = rs; | 2345 | is->reset->rs[id] = rs; |