Merge ../linus/

author: Dave Jones <davej@redhat.com> 2005-11-21 09:56:52 -0500
committer: Dave Jones <davej@redhat.com> 2005-11-21 09:56:52 -0500
commit: e7e37ee9c547213d726b29c2510cbb6696050405 (patch)
tree: 50c45625de666b23f209d79eb1bfae05c64feee9 /drivers
parent: c243f1f1f6545985afcc6adf1fc085729029c3ee (diff)
parent: db93a82fa9d8b4d6e31c227922eaae829253bb88 (diff)
150 files changed, 3334 insertions, 1537 deletions
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 573b6a97bb1f..70d8a6ec0920 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -514,8 +514,6 @@ static int acpi_processor_set_power_policy(struct acpi_processor *pr)
 static int acpi_processor_get_power_info_fadt(struct acpi_processor *pr)
 {
-        int i;
        ACPI_FUNCTION_TRACE("acpi_processor_get_power_info_fadt");
        if (!pr)
@@ -524,8 +522,7 @@ static int acpi_processor_get_power_info_fadt(struct acpi_processor *pr)
        if (!pr->pblk)
                return_VALUE(-ENODEV);
-        for (i = 0; i < ACPI_PROCESSOR_MAX_POWER; i++)
+        memset(pr->power.states, 0, sizeof(pr->power.states));
-                memset(pr->power.states, 0, sizeof(struct acpi_processor_cx));
        /* if info is obtained from pblk/fadt, type equals state */
        pr->power.states[ACPI_STATE_C1].type = ACPI_STATE_C1;
@@ -555,13 +552,9 @@ static int acpi_processor_get_power_info_fadt(struct acpi_processor *pr)
 static int acpi_processor_get_power_info_default_c1(struct acpi_processor *pr)
 {
-        int i;
        ACPI_FUNCTION_TRACE("acpi_processor_get_power_info_default_c1");
-        for (i = 0; i < ACPI_PROCESSOR_MAX_POWER; i++)
+        memset(pr->power.states, 0, sizeof(pr->power.states));
-                memset(&(pr->power.states[i]), 0,
-                       sizeof(struct acpi_processor_cx));
        /* if info is obtained from pblk/fadt, type equals state */
        pr->power.states[ACPI_STATE_C1].type = ACPI_STATE_C1;
@@ -873,7 +866,8 @@ static int acpi_processor_get_power_info(struct acpi_processor *pr)
        for (i = 1; i < ACPI_PROCESSOR_MAX_POWER; i++) {
                if (pr->power.states[i].valid) {
                        pr->power.count = i;
-                        pr->flags.power = 1;
+                        if (pr->power.states[i].type >= ACPI_STATE_C2)
+                                pr->flags.power = 1;
                }
        }
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index e239a6c29230..a9e33db46e68 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1017,10 +1017,11 @@ static int cciss_ioctl(struct inode *inode, struct file *filep,
                                status = -ENOMEM;
                                goto cleanup1;
                        }
-                        if (ioc->Request.Type.Direction == XFER_WRITE &&
+                        if (ioc->Request.Type.Direction == XFER_WRITE) {
-                                copy_from_user(buff[sg_used], data_ptr, sz)) {
+                                if (copy_from_user(buff[sg_used], data_ptr, sz)) {
                                        status = -ENOMEM;
-                                        goto cleanup1;                  
+                                        goto cleanup1;
+                                }
                        } else {
                                memset(buff[sg_used], 0, sz);
                        }
@@ -1138,8 +1139,15 @@ static int revalidate_allvol(ctlr_info_t *host)
        for(i=0; i< NWD; i++) {
                struct gendisk *disk = host->gendisk[i];
-                if (disk->flags & GENHD_FL_UP)
+                if (disk) {
-                        del_gendisk(disk);
+                        request_queue_t *q = disk->queue;
+                        if (disk->flags & GENHD_FL_UP)
+                                del_gendisk(disk);
+                        if (q)
+                                blk_cleanup_queue(q);
+                        put_disk(disk);
+                }
        }
        /*
@@ -1453,10 +1461,13 @@ static int deregister_disk(struct gendisk *disk, drive_info_struct *drv,
         * allows us to delete disk zero but keep the controller registered.
        */
        if (h->gendisk[0] != disk){
-                if (disk->flags & GENHD_FL_UP){
+                if (disk) {
-                        blk_cleanup_queue(disk->queue);
+                        request_queue_t *q = disk->queue;
-                del_gendisk(disk);
+                        if (disk->flags & GENHD_FL_UP)
-                        drv->queue = NULL;
+                                del_gendisk(disk);
+                        if (q)  
+                                blk_cleanup_queue(q);
+                        put_disk(disk); 
                }
        }
@@ -3225,9 +3236,14 @@ static void __devexit cciss_remove_one (struct pci_dev *pdev)
        /* remove it from the disk list */
        for (j = 0; j < NWD; j++) {
                struct gendisk *disk = hba[i]->gendisk[j];
-                if (disk->flags & GENHD_FL_UP) {
+                if (disk) {
-                        del_gendisk(disk);
+                        request_queue_t *q = disk->queue;
-                        blk_cleanup_queue(disk->queue);
+                        if (disk->flags & GENHD_FL_UP) 
+                                del_gendisk(disk);
+                        if (q)
+                                blk_cleanup_queue(q);
+                        put_disk(disk);
                }
        }
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index ea89dca3dbb5..01a1f6badb53 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2203,7 +2203,7 @@ static void setup_xaction_handlers(struct smi_info *smi_info)
 static inline void wait_for_timer_and_thread(struct smi_info *smi_info)
 {
-        if (smi_info->thread != ERR_PTR(-ENOMEM))
+        if (smi_info->thread != NULL && smi_info->thread != ERR_PTR(-ENOMEM))
                kthread_stop(smi_info->thread);
        del_timer_sync(&smi_info->si_timer);
 }
diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index b58adfe3ed19..a6873bf89ffa 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -6,7 +6,7 @@ menu "TPM devices"
 config TCG_TPM
        tristate "TPM Hardware Support"
-        depends on EXPERIMENTAL && PCI
+        depends on EXPERIMENTAL
        ---help---
          If you have a TPM security chip in your system, which
          implements the Trusted Computing Group's specification,
diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index 0b283d246730..a9be0e8eaea5 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/tpm.c
@@ -377,6 +377,7 @@ int tpm_release(struct inode *inode, struct file *file)
        file->private_data = NULL;
        chip->num_opens--;
        del_singleshot_timer_sync(&chip->user_read_timer);
+        flush_scheduled_work();
        atomic_set(&chip->data_pending, 0);
        put_device(chip->dev);
        kfree(chip->data_buffer);
@@ -428,6 +429,7 @@ ssize_t tpm_read(struct file * file, char __user *buf,
        int ret_size;
        del_singleshot_timer_sync(&chip->user_read_timer);
+        flush_scheduled_work();
        ret_size = atomic_read(&chip->data_pending);
        atomic_set(&chip->data_pending, 0);
        if (ret_size > 0) {     /* relay data */
diff --git a/drivers/char/tpm/tpm_atmel.c b/drivers/char/tpm/tpm_atmel.c
index deb4b5c80914..ff3654964fe3 100644
--- a/drivers/char/tpm/tpm_atmel.c
+++ b/drivers/char/tpm/tpm_atmel.c
@@ -47,13 +47,12 @@ static int tpm_atml_recv(struct tpm_chip *chip, u8 *buf, size_t count)
                return -EIO;
        for (i = 0; i < 6; i++) {
-                status = atmel_getb(chip, 1);
+                status = ioread8(chip->vendor->iobase + 1);
                if ((status & ATML_STATUS_DATA_AVAIL) == 0) {
-                        dev_err(chip->dev,
+                        dev_err(chip->dev, "error reading header\n");
-                                "error reading header\n");
                        return -EIO;
                }
-                *buf++ = atmel_getb(chip, 0);
+                *buf++ = ioread8(chip->vendor->iobase);
        }
        /* size of the data received */
@@ -64,10 +63,9 @@ static int tpm_atml_recv(struct tpm_chip *chip, u8 *buf, size_t count)
                dev_err(chip->dev,
                        "Recv size(%d) less than available space\n", size);
                for (; i < size; i++) { /* clear the waiting data anyway */
-                        status = atmel_getb(chip, 1);
+                        status = ioread8(chip->vendor->iobase + 1);
                        if ((status & ATML_STATUS_DATA_AVAIL) == 0) {
-                                dev_err(chip->dev,
+                                dev_err(chip->dev, "error reading data\n");
-                                        "error reading data\n");
                                return -EIO;
                        }
                }
@@ -76,17 +74,17 @@ static int tpm_atml_recv(struct tpm_chip *chip, u8 *buf, size_t count)
        /* read all the data available */
        for (; i < size; i++) {
-                status = atmel_getb(chip, 1);
+                status = ioread8(chip->vendor->iobase + 1);
                if ((status & ATML_STATUS_DATA_AVAIL) == 0) {
-                        dev_err(chip->dev,
+                        dev_err(chip->dev, "error reading data\n");
-                                "error reading data\n");
                        return -EIO;
                }
-                *buf++ = atmel_getb(chip, 0);
+                *buf++ = ioread8(chip->vendor->iobase);
        }
        /* make sure data available is gone */
-        status = atmel_getb(chip, 1);
+        status = ioread8(chip->vendor->iobase + 1);
        if (status & ATML_STATUS_DATA_AVAIL) {
                dev_err(chip->dev, "data available is stuck\n");
                return -EIO;
@@ -102,7 +100,7 @@ static int tpm_atml_send(struct tpm_chip *chip, u8 *buf, size_t count)
        dev_dbg(chip->dev, "tpm_atml_send:\n");
        for (i = 0; i < count; i++) {
                dev_dbg(chip->dev, "%d 0x%x(%d)\n",  i, buf[i], buf[i]);
-                atmel_putb(buf[i], chip, 0);
+                iowrite8(buf[i], chip->vendor->iobase);
        }
        return count;
@@ -110,12 +108,12 @@ static int tpm_atml_send(struct tpm_chip *chip, u8 *buf, size_t count)
 static void tpm_atml_cancel(struct tpm_chip *chip)
 {
-        atmel_putb(ATML_STATUS_ABORT, chip, 1);
+        iowrite8(ATML_STATUS_ABORT, chip->vendor->iobase + 1);
 }
 static u8 tpm_atml_status(struct tpm_chip *chip)
 {
-        return atmel_getb(chip, 1);
+        return ioread8(chip->vendor->iobase + 1);
 }
 static struct file_operations atmel_ops = {
@@ -162,7 +160,8 @@ static void atml_plat_remove(void)
        if (chip) {
                if (chip->vendor->have_region)
-                        atmel_release_region(chip->vendor->base, chip->vendor->region_size);
+                        atmel_release_region(chip->vendor->base,
+                                             chip->vendor->region_size);
                atmel_put_base_addr(chip->vendor);
                tpm_remove_hardware(chip->dev);
                platform_device_unregister(pdev);
@@ -183,14 +182,19 @@ static int __init init_atmel(void)
        driver_register(&atml_drv);
-        if (atmel_get_base_addr(&tpm_atmel) != 0) {
+        if ((tpm_atmel.iobase = atmel_get_base_addr(&tpm_atmel)) == NULL) {
                rc = -ENODEV;
                goto err_unreg_drv;
        }
-        tpm_atmel.have_region = (atmel_request_region( tpm_atmel.base, tpm_atmel.region_size, "tpm_atmel0") == NULL) ? 0 : 1;
+        tpm_atmel.have_region =
+            (atmel_request_region
+             (tpm_atmel.base, tpm_atmel.region_size,
+              "tpm_atmel0") == NULL) ? 0 : 1;
-        if (IS_ERR(pdev = platform_device_register_simple("tpm_atmel", -1, NULL, 0 ))) {
+        if (IS_ERR
+            (pdev =
+             platform_device_register_simple("tpm_atmel", -1, NULL, 0))) {
                rc = PTR_ERR(pdev);
                goto err_rel_reg;
        }
@@ -202,9 +206,10 @@ static int __init init_atmel(void)
 err_unreg_dev:
        platform_device_unregister(pdev);
 err_rel_reg:
-        if (tpm_atmel.have_region)
-                atmel_release_region(tpm_atmel.base, tpm_atmel.region_size);
        atmel_put_base_addr(&tpm_atmel);
+        if (tpm_atmel.have_region)
+                atmel_release_region(tpm_atmel.base,
+                                     tpm_atmel.region_size);
 err_unreg_drv:
        driver_unregister(&atml_drv);
        return rc;
diff --git a/drivers/char/tpm/tpm_atmel.h b/drivers/char/tpm/tpm_atmel.h
index 3c5b9a8d1c49..d3478aaadd77 100644
--- a/drivers/char/tpm/tpm_atmel.h
+++ b/drivers/char/tpm/tpm_atmel.h
@@ -27,12 +27,14 @@
 #define atmel_putb(val, chip, offset) writeb(val, chip->vendor->iobase + offset)
 #define atmel_request_region request_mem_region
 #define atmel_release_region release_mem_region
-static inline void atmel_put_base_addr(struct tpm_vendor_specific *vendor)
+static inline void atmel_put_base_addr(struct tpm_vendor_specific
+                                         *vendor)
 {
        iounmap(vendor->iobase);
 }
-static int atmel_get_base_addr(struct tpm_vendor_specific *vendor)
+static void __iomem * atmel_get_base_addr(struct tpm_vendor_specific *vendor)
 {
        struct device_node *dn;
        unsigned long address, size;
@@ -44,11 +46,11 @@ static int atmel_get_base_addr(struct tpm_vendor_specific *vendor)
        dn = of_find_node_by_name(NULL, "tpm");
        if (!dn)
-                return 1;
+                return NULL;
        if (!device_is_compatible(dn, "AT97SC3201")) {
                of_node_put(dn);
-                return 1;
+                return NULL;
        }
        reg = (unsigned int *) get_property(dn, "reg", &reglen);
@@ -71,8 +73,7 @@ static int atmel_get_base_addr(struct tpm_vendor_specific *vendor)
        vendor->base = address;
        vendor->region_size = size;
-        vendor->iobase = ioremap(address, size);
+        return ioremap(vendor->base, vendor->region_size);
-        return 0;
 }
 #else
 #define atmel_getb(chip, offset) inb(chip->vendor->base + offset)
@@ -105,18 +106,19 @@ static int atmel_verify_tpm11(void)
        return 0;
 }
-static inline void atmel_put_base_addr(struct tpm_vendor_specific *vendor)
+static inline void atmel_put_base_addr(struct tpm_vendor_specific
+                                         *vendor)
 {
 }
 /* Determine where to talk to device */
-static unsigned long atmel_get_base_addr(struct tpm_vendor_specific
+static void __iomem * atmel_get_base_addr(struct tpm_vendor_specific
                                         *vendor)
 {
        int lo, hi;
        if (atmel_verify_tpm11() != 0)
-                return 1;
+                return NULL;
        lo = tpm_read_index(TPM_ADDR, TPM_ATMEL_BASE_ADDR_LO);
        hi = tpm_read_index(TPM_ADDR, TPM_ATMEL_BASE_ADDR_HI);
@@ -124,6 +126,6 @@ static unsigned long atmel_get_base_addr(struct tpm_vendor_specific
        vendor->base = (hi << 8) | lo;
        vendor->region_size = 2;
-        return 0;
+        return ioport_map(vendor->base, vendor->region_size);
 }
 #endif
diff --git a/drivers/i2c/busses/i2c-ixp2000.c b/drivers/i2c/busses/i2c-ixp2000.c
index cef024a7d048..cd6f45d186ab 100644
--- a/drivers/i2c/busses/i2c-ixp2000.c
+++ b/drivers/i2c/busses/i2c-ixp2000.c
@@ -36,8 +36,6 @@
 #include <asm/hardware.h>       /* Pick up IXP2000-specific bits */
 #include <asm/arch/gpio.h>
-static struct device_driver ixp2000_i2c_driver;
 static inline int ixp2000_scl_pin(void *data)
 {
        return ((struct ixp2000_i2c_pins*)data)->scl_pin;
@@ -120,7 +118,7 @@ static int ixp2000_i2c_probe(struct platform_device *plat_dev)
        drv_data->algo_data.timeout = 100;
        drv_data->adapter.id = I2C_HW_B_IXP2000,
-        strlcpy(drv_data->adapter.name, ixp2000_i2c_driver.name,
+        strlcpy(drv_data->adapter.name, plat_dev->dev.driver->name,
                I2C_NAME_SIZE);
        drv_data->adapter.algo_data = &drv_data->algo_data,
@@ -132,7 +130,7 @@ static int ixp2000_i2c_probe(struct platform_device *plat_dev)
        gpio_line_set(gpio->sda_pin, 0);
        if ((err = i2c_bit_add_bus(&drv_data->adapter)) != 0) {
-                dev_err(dev, "Could not install, error %d\n", err);
+                dev_err(&plat_dev->dev, "Could not install, error %d\n", err);
                kfree(drv_data);
                return err;
        } 
diff --git a/drivers/i2c/busses/i2c-ixp4xx.c b/drivers/i2c/busses/i2c-ixp4xx.c
index aa36855fa995..e422d8b2d4d6 100644
--- a/drivers/i2c/busses/i2c-ixp4xx.c
+++ b/drivers/i2c/busses/i2c-ixp4xx.c
@@ -35,8 +35,6 @@
 #include <asm/hardware.h>       /* Pick up IXP4xx-specific bits */
-static struct device_driver ixp4xx_i2c_driver;
 static inline int ixp4xx_scl_pin(void *data)
 {
        return ((struct ixp4xx_i2c_pins*)data)->scl_pin;
@@ -128,7 +126,7 @@ static int ixp4xx_i2c_probe(struct platform_device *plat_dev)
        drv_data->algo_data.timeout = 100;
        drv_data->adapter.id = I2C_HW_B_IXP4XX;
-        strlcpy(drv_data->adapter.name, ixp4xx_i2c_driver.name,
+        strlcpy(drv_data->adapter.name, plat_dev->dev.driver->name,
                I2C_NAME_SIZE);
        drv_data->adapter.algo_data = &drv_data->algo_data;
@@ -140,7 +138,7 @@ static int ixp4xx_i2c_probe(struct platform_device *plat_dev)
        gpio_line_set(gpio->sda_pin, 0);
        if ((err = i2c_bit_add_bus(&drv_data->adapter) != 0)) {
-                printk(KERN_ERR "ERROR: Could not install %s\n", dev->bus_id);
+                printk(KERN_ERR "ERROR: Could not install %s\n", plat_dev->dev.bus_id);
                kfree(drv_data);
                return err;
diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig
index 42e5b8175cbf..31e649a9ff71 100644
--- a/drivers/ide/Kconfig
+++ b/drivers/ide/Kconfig
@@ -625,7 +625,7 @@ config BLK_DEV_NS87415
        tristate "NS87415 chipset support"
        help
          This driver adds detection and support for the NS87415 chip
-          (used in SPARC64, among others).
+          (used mainly on SPARC64 and PA-RISC machines).
          Please read the comments at the top of <file:drivers/ide/pci/ns87415.c>.
@@ -787,6 +787,10 @@ config BLK_DEV_IDE_PMAC_BLINK
          This option enables the use of the sleep LED as a hard drive
          activity LED.
+config BLK_DEV_IDE_SWARM
+        tristate "IDE for Sibyte evaluation boards"
+        depends on SIBYTE_SB1xxx_SOC
 config BLK_DEV_IDE_AU1XXX
       bool "IDE for AMD Alchemy Au1200"
       depends on SOC_AU1200
diff --git a/drivers/ide/Makefile b/drivers/ide/Makefile
index cca9c075966d..569fae717503 100644
--- a/drivers/ide/Makefile
+++ b/drivers/ide/Makefile
@@ -48,6 +48,6 @@ obj-$(CONFIG_BLK_DEV_IDECD)		+= ide-cd.o
 obj-$(CONFIG_BLK_DEV_IDETAPE)           += ide-tape.o
 obj-$(CONFIG_BLK_DEV_IDEFLOPPY)         += ide-floppy.o
-obj-$(CONFIG_BLK_DEV_IDE)               += legacy/ arm/
+obj-$(CONFIG_BLK_DEV_IDE)               += legacy/ arm/ mips/
 obj-$(CONFIG_BLK_DEV_HD)                += legacy/
 obj-$(CONFIG_ETRAX_IDE)         += cris/
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index c2f47923d174..9455e42abb23 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -3328,8 +3328,8 @@ static ide_proc_entry_t idecd_proc[] = {
 #endif
 static ide_driver_t ide_cdrom_driver = {
-        .owner                  = THIS_MODULE,
        .gen_driver = {
+                .owner          = THIS_MODULE,
                .name           = "ide-cdrom",
                .bus            = &ide_bus_type,
                .probe          = ide_cd_probe,
@@ -3510,8 +3510,8 @@ static void __exit ide_cdrom_exit(void)
 {
        driver_unregister(&ide_cdrom_driver.gen_driver);
 }
- 
-static int ide_cdrom_init(void)
+static int __init ide_cdrom_init(void)
 {
        return driver_register(&ide_cdrom_driver.gen_driver);
 }
diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c
index e827b39e4b3c..f4e3d3527b0e 100644
--- a/drivers/ide/ide-disk.c
+++ b/drivers/ide/ide-disk.c
@@ -1089,8 +1089,8 @@ static void ide_device_shutdown(struct device *dev)
 }
 static ide_driver_t idedisk_driver = {
-        .owner                  = THIS_MODULE,
        .gen_driver = {
+                .owner          = THIS_MODULE,
                .name           = "ide-disk",
                .bus            = &ide_bus_type,
                .probe          = ide_disk_probe,
@@ -1266,7 +1266,7 @@ static void __exit idedisk_exit (void)
        driver_unregister(&idedisk_driver.gen_driver);
 }
-static int idedisk_init (void)
+static int __init idedisk_init(void)
 {
        return driver_register(&idedisk_driver.gen_driver);
 }
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index f615ab759962..9e293c8063dc 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
@@ -1925,8 +1925,8 @@ static ide_proc_entry_t idefloppy_proc[] = {
 static int ide_floppy_probe(struct device *);
 static ide_driver_t idefloppy_driver = {
-        .owner                  = THIS_MODULE,
        .gen_driver = {
+                .owner          = THIS_MODULE,
                .name           = "ide-floppy",
                .bus            = &ide_bus_type,
                .probe          = ide_floppy_probe,
@@ -2191,10 +2191,7 @@ static void __exit idefloppy_exit (void)
        driver_unregister(&idefloppy_driver.gen_driver);
 }
-/*
+static int __init idefloppy_init(void)
- *      idefloppy_init will register the driver for each floppy.
- */
-static int idefloppy_init (void)
 {
        printk("ide-floppy driver " IDEFLOPPY_VERSION "\n");
        return driver_register(&idefloppy_driver.gen_driver);
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index 5275cbb1afe9..ecfafcdafea4 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -1629,12 +1629,6 @@ EXPORT_SYMBOL(ide_init_drive_cmd);
 *      for the new rq to be completed.  This is VERY DANGEROUS, and is
 *      intended for careful use by the ATAPI tape/cdrom driver code.
 *
- *      If action is ide_next, then the rq is queued immediately after
- *      the currently-being-processed-request (if any), and the function
- *      returns without waiting for the new rq to be completed.  As above,
- *      This is VERY DANGEROUS, and is intended for careful use by the
- *      ATAPI tape/cdrom driver code.
- *
 *      If action is ide_end, then the rq is queued at the end of the
 *      request queue, and the function returns immediately without waiting
 *      for the new rq to be completed. This is again intended for careful
diff --git a/drivers/ide/ide-lib.c b/drivers/ide/ide-lib.c
index b09a6537c7a8..41d46dbe6c24 100644
--- a/drivers/ide/ide-lib.c
+++ b/drivers/ide/ide-lib.c
@@ -410,10 +410,10 @@ void ide_toggle_bounce(ide_drive_t *drive, int on)
 {
        u64 addr = BLK_BOUNCE_HIGH;     /* dma64_addr_t */
-        if (on && drive->media == ide_disk) {
+        if (!PCI_DMA_BUS_IS_PHYS) {
-                if (!PCI_DMA_BUS_IS_PHYS)
+                addr = BLK_BOUNCE_ANY;
-                        addr = BLK_BOUNCE_ANY;
+        } else if (on && drive->media == ide_disk) {
-                else if (HWIF(drive)->pci_dev)
+                if (HWIF(drive)->pci_dev)
                        addr = HWIF(drive)->pci_dev->dma_mask;
        }
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 0ac7eb8f40d5..7d7944ed4158 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -4748,8 +4748,8 @@ static ide_proc_entry_t idetape_proc[] = {
 static int ide_tape_probe(struct device *);
 static ide_driver_t idetape_driver = {
-        .owner                  = THIS_MODULE,
        .gen_driver = {
+                .owner          = THIS_MODULE,
                .name           = "ide-tape",
                .bus            = &ide_bus_type,
                .probe          = ide_tape_probe,
@@ -4916,10 +4916,7 @@ static void __exit idetape_exit (void)
        unregister_chrdev(IDETAPE_MAJOR, "ht");
 }
-/*
+static int __init idetape_init(void)
- *      idetape_init will register the driver for each tape.
- */
-static int idetape_init (void)
 {
        int error = 1;
        idetape_sysfs_class = class_create(THIS_MODULE, "ide_tape");
diff --git a/drivers/ide/ide-taskfile.c b/drivers/ide/ide-taskfile.c
index 54f9639c2a8c..62ebefd6394a 100644
--- a/drivers/ide/ide-taskfile.c
+++ b/drivers/ide/ide-taskfile.c
@@ -51,8 +51,6 @@
 #include <asm/uaccess.h>
 #include <asm/io.h>
-#define DEBUG_TASKFILE  0       /* unset when fixed */
 static void ata_bswap_data (void *buffer, int wcount)
 {
        u16 *p = buffer;
@@ -765,9 +763,6 @@ ide_startstop_t flagged_taskfile (ide_drive_t *drive, ide_task_t *task)
        ide_hwif_t *hwif        = HWIF(drive);
        task_struct_t *taskfile = (task_struct_t *) task->tfRegister;
        hob_struct_t *hobfile   = (hob_struct_t *) task->hobRegister;
-#if DEBUG_TASKFILE
-        u8 status;
-#endif
        if (task->data_phase == TASKFILE_MULTI_IN ||
            task->data_phase == TASKFILE_MULTI_OUT) {
@@ -778,19 +773,13 @@ ide_startstop_t flagged_taskfile (ide_drive_t *drive, ide_task_t *task)
        }
        /*
-         * (ks) Check taskfile in/out flags.
+         * (ks) Check taskfile in flags.
         * If set, then execute as it is defined.
         * If not set, then define default settings.
         * The default values are:
-         *      write and read all taskfile registers (except data) 
+         *      read all taskfile registers (except data)
-         *      write and read the hob registers (sector,nsector,lcyl,hcyl)
+         *      read the hob registers (sector, nsector, lcyl, hcyl)
         */
-        if (task->tf_out_flags.all == 0) {
-                task->tf_out_flags.all = IDE_TASKFILE_STD_OUT_FLAGS;
-                if (drive->addressing == 1)
-                        task->tf_out_flags.all |= (IDE_HOB_STD_OUT_FLAGS << 8);
-        }
        if (task->tf_in_flags.all == 0) {
                task->tf_in_flags.all = IDE_TASKFILE_STD_IN_FLAGS;
                if (drive->addressing == 1)
@@ -803,16 +792,6 @@ ide_startstop_t flagged_taskfile (ide_drive_t *drive, ide_task_t *task)
                hwif->OUTB(drive->ctl, IDE_CONTROL_REG);
        SELECT_MASK(drive, 0);
-#if DEBUG_TASKFILE
-        status = hwif->INB(IDE_STATUS_REG);
-        if (status & 0x80) {
-                printk("flagged_taskfile -> Bad status. Status = %02x. wait 100 usec ...\n", status);
-                udelay(100);
-                status = hwif->INB(IDE_STATUS_REG);
-                printk("flagged_taskfile -> Status = %02x\n", status);
-        }
-#endif
        if (task->tf_out_flags.b.data) {
                u16 data =  taskfile->data + (hobfile->data << 8);
                hwif->OUTW(data, IDE_DATA_REG);
diff --git a/drivers/ide/mips/Makefile b/drivers/ide/mips/Makefile
new file mode 100644
index 000000000000..578e52a59588
--- /dev/null
+++ b/drivers/ide/mips/Makefile
@@ -0,0 +1 @@
+obj-$(CONFIG_BLK_DEV_IDE_SWARM)         += swarm.o
diff --git a/drivers/ide/mips/swarm.c b/drivers/ide/mips/swarm.c
new file mode 100644
index 000000000000..66f6064f4640
--- /dev/null
+++ b/drivers/ide/mips/swarm.c
@@ -0,0 +1,201 @@
+/*
+ * Copyright (C) 2001, 2002, 2003 Broadcom Corporation
+ * Copyright (C) 2004 MontaVista Software Inc.
+ *      Author: Manish Lachwani, mlachwani@mvista.com
+ * Copyright (C) 2004  MIPS Technologies, Inc.  All rights reserved.
+ *      Author: Maciej W. Rozycki <macro@mips.com>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+ */
+/*
+ *  Derived loosely from ide-pmac.c, so:
+ *  Copyright (C) 1998 Paul Mackerras.
+ *  Copyright (C) 1995-1998 Mark Lord
+ */
+/*
+ * Boards with SiByte processors so far have supported IDE devices via
+ * the Generic Bus, PCI bus, and built-in PCMCIA interface.  In all
+ * cases, byte-swapping must be avoided for these devices (whereas
+ * other PCI devices, for example, will require swapping).  Any
+ * SiByte-targetted kernel including IDE support will include this
+ * file.  Probing of a Generic Bus for an IDE device is controlled by
+ * the definition of "SIBYTE_HAVE_IDE", which is provided by
+ * <asm/sibyte/board.h> for Broadcom boards.
+ */
+#include <linux/ide.h>
+#include <linux/ioport.h>
+#include <linux/kernel.h>
+#include <linux/types.h>
+#include <linux/platform_device.h>
+#include <asm/io.h>
+#include <asm/sibyte/board.h>
+#include <asm/sibyte/sb1250_genbus.h>
+#include <asm/sibyte/sb1250_regs.h>
+#define DRV_NAME "ide-swarm"
+static char swarm_ide_string[] = DRV_NAME;
+static struct resource swarm_ide_resource = {
+        .name   = "SWARM GenBus IDE",
+        .flags  = IORESOURCE_MEM,
+};
+static struct platform_device *swarm_ide_dev;
+/*
+ * swarm_ide_probe - if the board header indicates the existence of
+ * Generic Bus IDE, allocate a HWIF for it.
+ */
+static int __devinit swarm_ide_probe(struct device *dev)
+{
+        ide_hwif_t *hwif;
+        u8 __iomem *base;
+        phys_t offset, size;
+        int i;
+        if (!SIBYTE_HAVE_IDE)
+                return -ENODEV;
+        /* Find an empty slot.  */
+        for (i = 0; i < MAX_HWIFS; i++)
+                if (!ide_hwifs[i].io_ports[IDE_DATA_OFFSET])
+                        break;
+        if (i >= MAX_HWIFS) {
+                printk(KERN_ERR DRV_NAME ": no free slot for interface\n");
+                return -ENOMEM;
+        }
+        hwif = ide_hwifs + i;
+        base = ioremap(A_IO_EXT_BASE, 0x800);
+        offset = __raw_readq(base + R_IO_EXT_REG(R_IO_EXT_START_ADDR, IDE_CS));
+        size = __raw_readq(base + R_IO_EXT_REG(R_IO_EXT_MULT_SIZE, IDE_CS));
+        iounmap(base);
+        offset = G_IO_START_ADDR(offset) << S_IO_ADDRBASE;
+        size = (G_IO_MULT_SIZE(size) + 1) << S_IO_REGSIZE;
+        if (offset < A_PHYS_GENBUS || offset >= A_PHYS_GENBUS_END) {
+                printk(KERN_INFO DRV_NAME
+                       ": IDE interface at GenBus disabled\n");
+                return -EBUSY;
+        }
+        printk(KERN_INFO DRV_NAME ": IDE interface at GenBus slot %i\n",
+               IDE_CS);
+        swarm_ide_resource.start = offset;
+        swarm_ide_resource.end = offset + size - 1;
+        if (request_resource(&iomem_resource, &swarm_ide_resource)) {
+                printk(KERN_ERR DRV_NAME
+                       ": can't request I/O memory resource\n");
+                return -EBUSY;
+        }
+        base = ioremap(offset, size);
+        /* Setup MMIO ops.  */
+        default_hwif_mmiops(hwif);
+        /* Prevent resource map manipulation.  */
+        hwif->mmio = 2;
+        hwif->noprobe = 0;
+        for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; i++)
+                hwif->hw.io_ports[i] =
+                                (unsigned long)(base + ((0x1f0 + i) << 5));
+        hwif->hw.io_ports[IDE_CONTROL_OFFSET] =
+                                (unsigned long)(base + (0x3f6 << 5));
+        hwif->hw.irq = K_INT_GB_IDE;
+        memcpy(hwif->io_ports, hwif->hw.io_ports, sizeof(hwif->io_ports));
+        hwif->irq = hwif->hw.irq;
+        dev_set_drvdata(dev, hwif);
+        return 0;
+}
+static struct device_driver swarm_ide_driver = {
+        .name   = swarm_ide_string,
+        .bus    = &platform_bus_type,
+        .probe  = swarm_ide_probe,
+};
+static void swarm_ide_platform_release(struct device *device)
+{
+        struct platform_device *pldev;
+        /* free device */
+        pldev = to_platform_device(device);
+        kfree(pldev);
+}
+static int __devinit swarm_ide_init_module(void)
+{
+        struct platform_device *pldev;
+        int err;
+        printk(KERN_INFO "SWARM IDE driver\n");
+        if (driver_register(&swarm_ide_driver)) {
+                printk(KERN_ERR "Driver registration failed\n");
+                err = -ENODEV;
+                goto out;
+        }
+        if (!(pldev = kmalloc(sizeof (*pldev), GFP_KERNEL))) {
+                err = -ENOMEM;
+                goto out_unregister_driver;
+        }
+        memset (pldev, 0, sizeof (*pldev));
+        pldev->name             = swarm_ide_string;
+        pldev->id               = 0;
+        pldev->dev.release      = swarm_ide_platform_release;
+        if (platform_device_register(pldev)) {
+                err = -ENODEV;
+                goto out_free_pldev;
+        }
+        if (!pldev->dev.driver) {
+                /*
+                 * The driver was not bound to this device, there was
+                 * no hardware at this address. Unregister it, as the
+                 * release fuction will take care of freeing the
+                 * allocated structure
+                 */
+                platform_device_unregister (pldev);
+        }
+        swarm_ide_dev = pldev;
+        return 0;
+out_free_pldev:
+        kfree(pldev);
+out_unregister_driver:
+        driver_unregister(&swarm_ide_driver);
+out:
+        return err;
+}
+module_init(swarm_ide_init_module);
diff --git a/drivers/ide/pci/aec62xx.c b/drivers/ide/pci/aec62xx.c
index 52cadc005d72..a21b1e11eef4 100644
--- a/drivers/ide/pci/aec62xx.c
+++ b/drivers/ide/pci/aec62xx.c
@@ -65,23 +65,6 @@ static struct chipset_bus_clock_list_entry aec6xxx_34_base [] = {
 #define BUSCLOCK(D)     \
        ((struct chipset_bus_clock_list_entry *) pci_get_drvdata((D)))
-#if 0
-                if (dev->device == PCI_DEVICE_ID_ARTOP_ATP850UF) {
-                        (void) pci_read_config_byte(dev, 0x54, &art);
-                        p += sprintf(p, "DMA Mode:       %s(%s)",
-                                (c0&0x20)?((art&0x03)?"UDMA":" DMA"):" PIO",
-                                (art&0x02)?"2":(art&0x01)?"1":"0");
-                        p += sprintf(p, "          %s(%s)",
-                                (c0&0x40)?((art&0x0c)?"UDMA":" DMA"):" PIO",
-                                (art&0x08)?"2":(art&0x04)?"1":"0");
-                        p += sprintf(p, "         %s(%s)",
-                                (c1&0x20)?((art&0x30)?"UDMA":" DMA"):" PIO",
-                                (art&0x20)?"2":(art&0x10)?"1":"0");
-                        p += sprintf(p, "           %s(%s)\n",
-                                (c1&0x40)?((art&0xc0)?"UDMA":" DMA"):" PIO",
-                                (art&0x80)?"2":(art&0x40)?"1":"0");
-                } else {
-#endif
 /*
 * TO DO: active tuning and correction of cards without a bios.
@@ -112,13 +95,9 @@ static u8 aec62xx_ratemask (ide_drive_t *drive)
        switch(hwif->pci_dev->device) {
                case PCI_DEVICE_ID_ARTOP_ATP865:
                case PCI_DEVICE_ID_ARTOP_ATP865R:
-#if 0
-                        mode = (hwif->INB(hwif->dma_master) & 0x10) ? 4 : 3;
-#else
                        mode = (hwif->INB(((hwif->channel) ?
                                        hwif->mate->dma_status :
                                        hwif->dma_status)) & 0x10) ? 4 : 3;
-#endif
                        break;
                case PCI_DEVICE_ID_ARTOP_ATP860:
                case PCI_DEVICE_ID_ARTOP_ATP860R:
@@ -263,35 +242,9 @@ static int aec62xx_irq_timeout (ide_drive_t *drive)
                case PCI_DEVICE_ID_ARTOP_ATP865:
                case PCI_DEVICE_ID_ARTOP_ATP865R:
                        printk(" AEC62XX time out ");
-#if 0
-                        {
-                                int i = 0;
-                                u8 reg49h = 0;
-                                pci_read_config_byte(HWIF(drive)->pci_dev, 0x49, &reg49h);
-                                for (i=0;i<256;i++)
-                                        pci_write_config_byte(HWIF(drive)->pci_dev, 0x49, reg49h|0x10);
-                                pci_write_config_byte(HWIF(drive)->pci_dev, 0x49, reg49h & ~0x10);
-                        }
-                        return 0;
-#endif
                default:
                        break;
        }
-#if 0
-        {
-                ide_hwif_t *hwif        = HWIF(drive);
-                struct pci_dev *dev     = hwif->pci_dev;
-                u8 tmp1 = 0, tmp2 = 0, mode6 = 0;
-                pci_read_config_byte(dev, 0x44, &tmp1);
-                pci_read_config_byte(dev, 0x45, &tmp2);
-                printk(" AEC6280 r44=%x r45=%x ",tmp1,tmp2);
-                mode6 = HWIF(drive)->INB(((hwif->channel) ?
-                                           hwif->mate->dma_status :
-                                           hwif->dma_status));
-                printk(" AEC6280 133=%x ", (mode6 & 0x10));
-        }
-#endif
        return 0;
 }
diff --git a/drivers/ide/pci/alim15x3.c b/drivers/ide/pci/alim15x3.c
index 6cf49394a80f..cf84350efc55 100644
--- a/drivers/ide/pci/alim15x3.c
+++ b/drivers/ide/pci/alim15x3.c
@@ -876,10 +876,15 @@ static ide_pci_device_t ali15x3_chipset __devinitdata = {
 
 static int __devinit alim15x3_init_one(struct pci_dev *dev, const struct pci_device_id *id)
 {
+        static struct pci_device_id ati_rs100[] = {
+                { PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS100) },
+                { },
+        };
        ide_pci_device_t *d = &ali15x3_chipset;
-        if(pci_find_device(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS100, NULL))
+        if (pci_dev_present(ati_rs100))
-                printk(KERN_ERR "Warning: ATI Radeon IGP Northbridge is not yet fully tested.\n");
+                printk(KERN_WARNING "alim15x3: ATI Radeon IGP Northbridge is not yet fully tested.\n");
 #if defined(CONFIG_SPARC64)
        d->init_hwif = init_hwif_common_ali15x3;
diff --git a/drivers/ide/pci/cs5520.c b/drivers/ide/pci/cs5520.c
index 7dc24682d197..ea3c52cc8ac1 100644
--- a/drivers/ide/pci/cs5520.c
+++ b/drivers/ide/pci/cs5520.c
@@ -222,10 +222,9 @@ static int __devinit cs5520_init_one(struct pci_dev *dev, const struct pci_devic
        /* We must not grab the entire device, it has 'ISA' space in its
           BARS too and we will freak out other bits of the kernel */
-        if(pci_enable_device_bars(dev, 1<<2))
+        if (pci_enable_device_bars(dev, 1<<2)) {
-        {
                printk(KERN_WARNING "%s: Unable to enable 55x0.\n", d->name);
-                return 1;
+                return -ENODEV;
        }
        pci_set_master(dev);
        if (pci_set_dma_mask(dev, DMA_32BIT_MASK)) {
diff --git a/drivers/ide/pci/siimage.c b/drivers/ide/pci/siimage.c
index 022d244f2eb0..f1ca154dd52c 100644
--- a/drivers/ide/pci/siimage.c
+++ b/drivers/ide/pci/siimage.c
@@ -6,7 +6,13 @@
 *
 *  May be copied or modified under the terms of the GNU General Public License
 *
- *  Documentation available under NDA only
+ *  Documentation for CMD680:
+ *  http://gkernel.sourceforge.net/specs/sii/sii-0680a-v1.31.pdf.bz2
+ *
+ *  Documentation for SiI 3112:
+ *  http://gkernel.sourceforge.net/specs/sii/3112A_SiI-DS-0095-B2.pdf.bz2
+ *
+ *  Errata and other documentation only available under NDA.
 *
 *
 *  FAQ Items:
diff --git a/drivers/ide/pci/sis5513.c b/drivers/ide/pci/sis5513.c
index 16b3e2d8bfb1..75a2253a3e68 100644
--- a/drivers/ide/pci/sis5513.c
+++ b/drivers/ide/pci/sis5513.c
@@ -87,6 +87,7 @@ static const struct {
        u8 chipset_family;
        u8 flags;
 } SiSHostChipInfo[] = {
+        { "SiS965",     PCI_DEVICE_ID_SI_965,   ATA_133  },
        { "SiS745",     PCI_DEVICE_ID_SI_745,   ATA_100  },
        { "SiS735",     PCI_DEVICE_ID_SI_735,   ATA_100  },
        { "SiS733",     PCI_DEVICE_ID_SI_733,   ATA_100  },
diff --git a/drivers/ide/pci/via82cxxx.c b/drivers/ide/pci/via82cxxx.c
index a4d099c937ff..7161ce0ef5aa 100644
--- a/drivers/ide/pci/via82cxxx.c
+++ b/drivers/ide/pci/via82cxxx.c
@@ -79,6 +79,7 @@ static struct via_isa_bridge {
        u8 rev_max;
        u16 flags;
 } via_isa_bridges[] = {
+        { "vt6410",     PCI_DEVICE_ID_VIA_6410,     0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
        { "vt8237",     PCI_DEVICE_ID_VIA_8237,     0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
        { "vt8235",     PCI_DEVICE_ID_VIA_8235,     0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
        { "vt8233a",    PCI_DEVICE_ID_VIA_8233A,    0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
@@ -100,185 +101,14 @@ static struct via_isa_bridge {
        { NULL }
 };
-static struct via_isa_bridge *via_config;
-static unsigned int via_80w;
 static unsigned int via_clock;
 static char *via_dma[] = { "MWDMA16", "UDMA33", "UDMA66", "UDMA100", "UDMA133" };
-/*
+struct via82cxxx_dev
- * VIA /proc entry.
- */
-#if defined(DISPLAY_VIA_TIMINGS) && defined(CONFIG_PROC_FS)
-#include <linux/stat.h>
-#include <linux/proc_fs.h>
-static u8 via_proc = 0;
-static unsigned long via_base;
-static struct pci_dev *bmide_dev, *isa_dev;
-static char *via_control3[] = { "No limit", "64", "128", "192" };
-#define via_print(format, arg...) p += sprintf(p, format "\n" , ## arg)
-#define via_print_drive(name, format, arg...)\
-        p += sprintf(p, name); for (i = 0; i < 4; i++) p += sprintf(p, format, ## arg); p += sprintf(p, "\n");
-/**
- *      via_get_info            -       generate via /proc file 
- *      @buffer: buffer for data
- *      @addr: set to start of data to use
- *      @offset: current file offset
- *      @count: size of read
- *
- *      Fills in buffer with the debugging/configuration information for
- *      the VIA chipset tuning and attached drives
- */
- 
-static int via_get_info(char *buffer, char **addr, off_t offset, int count)
 {
-        int speed[4], cycle[4], setup[4], active[4], recover[4], den[4],
+        struct via_isa_bridge *via_config;
-                 uen[4], udma[4], umul[4], active8b[4], recover8b[4];
+        unsigned int via_80w;
-        struct pci_dev *dev = bmide_dev;
+};
-        unsigned int v, u, i;
-        int len;
-        u16 c, w;
-        u8 t, x;
-        char *p = buffer;
-        via_print("----------VIA BusMastering IDE Configuration"
-                "----------------");
-        via_print("Driver Version:                     3.38");
-        via_print("South Bridge:                       VIA %s",
-                via_config->name);
-        pci_read_config_byte(isa_dev, PCI_REVISION_ID, &t);
-        pci_read_config_byte(dev, PCI_REVISION_ID, &x);
-        via_print("Revision:                           ISA %#x IDE %#x", t, x);
-        via_print("Highest DMA rate:                   %s",
-                via_dma[via_config->flags & VIA_UDMA]);
-        via_print("BM-DMA base:                        %#lx", via_base);
-        via_print("PCI clock:                          %d.%dMHz",
-                via_clock / 1000, via_clock / 100 % 10);
-        pci_read_config_byte(dev, VIA_MISC_1, &t);
-        via_print("Master Read  Cycle IRDY:            %dws",
-                (t & 64) >> 6);
-        via_print("Master Write Cycle IRDY:            %dws",
-                (t & 32) >> 5);
-        via_print("BM IDE Status Register Read Retry:  %s",
-                (t & 8) ? "yes" : "no");
-        pci_read_config_byte(dev, VIA_MISC_3, &t);
-        via_print("Max DRDY Pulse Width:               %s%s",
-                via_control3[(t & 0x03)], (t & 0x03) ? " PCI clocks" : "");
-        via_print("-----------------------Primary IDE"
-                "-------Secondary IDE------");
-        via_print("Read DMA FIFO flush:   %10s%20s",
-                (t & 0x80) ? "yes" : "no", (t & 0x40) ? "yes" : "no");
-        via_print("End Sector FIFO flush: %10s%20s",
-                (t & 0x20) ? "yes" : "no", (t & 0x10) ? "yes" : "no");
-        pci_read_config_byte(dev, VIA_IDE_CONFIG, &t);
-        via_print("Prefetch Buffer:       %10s%20s",
-                (t & 0x80) ? "yes" : "no", (t & 0x20) ? "yes" : "no");
-        via_print("Post Write Buffer:     %10s%20s",
-                (t & 0x40) ? "yes" : "no", (t & 0x10) ? "yes" : "no");
-        pci_read_config_byte(dev, VIA_IDE_ENABLE, &t);
-        via_print("Enabled:               %10s%20s",
-                (t & 0x02) ? "yes" : "no", (t & 0x01) ? "yes" : "no");
-        c = inb(via_base + 0x02) | (inb(via_base + 0x0a) << 8);
-        via_print("Simplex only:          %10s%20s",
-                (c & 0x80) ? "yes" : "no", (c & 0x8000) ? "yes" : "no");
-        via_print("Cable Type:            %10s%20s",
-                (via_80w & 1) ? "80w" : "40w", (via_80w & 2) ? "80w" : "40w");
-        via_print("-------------------drive0----drive1"
-                "----drive2----drive3-----");
-        pci_read_config_byte(dev, VIA_ADDRESS_SETUP, &t);
-        pci_read_config_dword(dev, VIA_DRIVE_TIMING, &v);
-        pci_read_config_word(dev, VIA_8BIT_TIMING, &w);
-        if (via_config->flags & VIA_UDMA)
-                pci_read_config_dword(dev, VIA_UDMA_TIMING, &u);
-        else u = 0;
-        for (i = 0; i < 4; i++) {
-                setup[i]     = ((t >> ((3 - i) << 1)) & 0x3) + 1;
-                recover8b[i] = ((w >> ((1 - (i >> 1)) << 3)) & 0xf) + 1;
-                active8b[i]  = ((w >> (((1 - (i >> 1)) << 3) + 4)) & 0xf) + 1;
-                active[i]    = ((v >> (((3 - i) << 3) + 4)) & 0xf) + 1;
-                recover[i]   = ((v >> ((3 - i) << 3)) & 0xf) + 1;
-                udma[i]      = ((u >> ((3 - i) << 3)) & 0x7) + 2;
-                umul[i]      = ((u >> (((3 - i) & 2) << 3)) & 0x8) ? 1 : 2;
-                uen[i]       = ((u >> ((3 - i) << 3)) & 0x20);
-                den[i]       = (c & ((i & 1) ? 0x40 : 0x20) << ((i & 2) << 2));
-                speed[i] = 2 * via_clock / (active[i] + recover[i]);
-                cycle[i] = 1000000 * (active[i] + recover[i]) / via_clock;
-                if (!uen[i] || !den[i])
-                        continue;
-                switch (via_config->flags & VIA_UDMA) {
-                        case VIA_UDMA_33:
-                                speed[i] = 2 * via_clock / udma[i];
-                                cycle[i] = 1000000 * udma[i] / via_clock;
-                                break;
-                        case VIA_UDMA_66:
-                                speed[i] = 4 * via_clock / (udma[i] * umul[i]);
-                                cycle[i] = 500000 * (udma[i] * umul[i]) / via_clock;
-                                break;
-                        case VIA_UDMA_100:
-                                speed[i] = 6 * via_clock / udma[i];
-                                cycle[i] = 333333 * udma[i] / via_clock;
-                                break;
-                        case VIA_UDMA_133:
-                                speed[i] = 8 * via_clock / udma[i];
-                                cycle[i] = 250000 * udma[i] / via_clock;
-                                break;
-                }
-        }
-        via_print_drive("Transfer Mode: ", "%10s",
-                den[i] ? (uen[i] ? "UDMA" : "DMA") : "PIO");
-        via_print_drive("Address Setup: ", "%8dns",
-                1000000 * setup[i] / via_clock);
-        via_print_drive("Cmd Active:    ", "%8dns",
-                1000000 * active8b[i] / via_clock);
-        via_print_drive("Cmd Recovery:  ", "%8dns",
-                1000000 * recover8b[i] / via_clock);
-        via_print_drive("Data Active:   ", "%8dns",
-                1000000 * active[i] / via_clock);
-        via_print_drive("Data Recovery: ", "%8dns",
-                1000000 * recover[i] / via_clock);
-        via_print_drive("Cycle Time:    ", "%8dns",
-                cycle[i]);
-        via_print_drive("Transfer Rate: ", "%4d.%dMB/s",
-                speed[i] / 1000, speed[i] / 100 % 10);
-        /* hoping it is less than 4K... */
-        len = (p - buffer) - offset;
-        *addr = buffer + offset;
-        return len > count ? count : len;
-}
-#endif /* DISPLAY_VIA_TIMINGS && CONFIG_PROC_FS */
 /**
 *      via_set_speed                   -       write timing registers
@@ -289,11 +119,13 @@ static int via_get_info(char *buffer, char **addr, off_t offset, int count)
 *      via_set_speed writes timing values to the chipset registers
 */
-static void via_set_speed(struct pci_dev *dev, u8 dn, struct ide_timing *timing)
+static void via_set_speed(ide_hwif_t *hwif, u8 dn, struct ide_timing *timing)
 {
+        struct pci_dev *dev = hwif->pci_dev;
+        struct via82cxxx_dev *vdev = ide_get_hwifdata(hwif);
        u8 t;
-        if (~via_config->flags & VIA_BAD_AST) {
+        if (~vdev->via_config->flags & VIA_BAD_AST) {
                pci_read_config_byte(dev, VIA_ADDRESS_SETUP, &t);
                t = (t & ~(3 << ((3 - dn) << 1))) | ((FIT(timing->setup, 1, 4) - 1) << ((3 - dn) << 1));
                pci_write_config_byte(dev, VIA_ADDRESS_SETUP, t);
@@ -305,7 +137,7 @@ static void via_set_speed(struct pci_dev *dev, u8 dn, struct ide_timing *timing)
        pci_write_config_byte(dev, VIA_DRIVE_TIMING + (3 - dn),
                ((FIT(timing->active, 1, 16) - 1) << 4) | (FIT(timing->recover, 1, 16) - 1));
-        switch (via_config->flags & VIA_UDMA) {
+        switch (vdev->via_config->flags & VIA_UDMA) {
                case VIA_UDMA_33:  t = timing->udma ? (0xe0 | (FIT(timing->udma, 2, 5) - 2)) : 0x03; break;
                case VIA_UDMA_66:  t = timing->udma ? (0xe8 | (FIT(timing->udma, 2, 9) - 2)) : 0x0f; break;
                case VIA_UDMA_100: t = timing->udma ? (0xe0 | (FIT(timing->udma, 2, 9) - 2)) : 0x07; break;
@@ -329,6 +161,7 @@ static void via_set_speed(struct pci_dev *dev, u8 dn, struct ide_timing *timing)
 static int via_set_drive(ide_drive_t *drive, u8 speed)
 {
        ide_drive_t *peer = HWIF(drive)->drives + (~drive->dn & 1);
+        struct via82cxxx_dev *vdev = ide_get_hwifdata(drive->hwif);
        struct ide_timing t, p;
        unsigned int T, UT;
@@ -337,7 +170,7 @@ static int via_set_drive(ide_drive_t *drive, u8 speed)
        T = 1000000000 / via_clock;
-        switch (via_config->flags & VIA_UDMA) {
+        switch (vdev->via_config->flags & VIA_UDMA) {
                case VIA_UDMA_33:   UT = T;   break;
                case VIA_UDMA_66:   UT = T/2; break;
                case VIA_UDMA_100:  UT = T/3; break;
@@ -352,7 +185,7 @@ static int via_set_drive(ide_drive_t *drive, u8 speed)
                ide_timing_merge(&p, &t, &t, IDE_TIMING_8BIT);
        }
-        via_set_speed(HWIF(drive)->pci_dev, drive->dn, &t);
+        via_set_speed(HWIF(drive), drive->dn, &t);
        if (!drive->init_speed)
                drive->init_speed = speed;
@@ -390,20 +223,41 @@ static void via82cxxx_tune_drive(ide_drive_t *drive, u8 pio)
 
 static int via82cxxx_ide_dma_check (ide_drive_t *drive)
 {
-        u16 w80 = HWIF(drive)->udma_four;
+        ide_hwif_t *hwif = HWIF(drive);
+        struct via82cxxx_dev *vdev = ide_get_hwifdata(hwif);
+        u16 w80 = hwif->udma_four;
        u16 speed = ide_find_best_mode(drive,
                XFER_PIO | XFER_EPIO | XFER_SWDMA | XFER_MWDMA |
-                (via_config->flags & VIA_UDMA ? XFER_UDMA : 0) |
+                (vdev->via_config->flags & VIA_UDMA ? XFER_UDMA : 0) |
-                (w80 && (via_config->flags & VIA_UDMA) >= VIA_UDMA_66 ? XFER_UDMA_66 : 0) |
+                (w80 && (vdev->via_config->flags & VIA_UDMA) >= VIA_UDMA_66 ? XFER_UDMA_66 : 0) |
-                (w80 && (via_config->flags & VIA_UDMA) >= VIA_UDMA_100 ? XFER_UDMA_100 : 0) |
+                (w80 && (vdev->via_config->flags & VIA_UDMA) >= VIA_UDMA_100 ? XFER_UDMA_100 : 0) |
-                (w80 && (via_config->flags & VIA_UDMA) >= VIA_UDMA_133 ? XFER_UDMA_133 : 0));
+                (w80 && (vdev->via_config->flags & VIA_UDMA) >= VIA_UDMA_133 ? XFER_UDMA_133 : 0));
        via_set_drive(drive, speed);
        if (drive->autodma && (speed & XFER_MODE) != XFER_PIO)
-                return HWIF(drive)->ide_dma_on(drive);
+                return hwif->ide_dma_on(drive);
-        return HWIF(drive)->ide_dma_off_quietly(drive);
+        return hwif->ide_dma_off_quietly(drive);
+}
+static struct via_isa_bridge *via_config_find(struct pci_dev **isa)
+{
+        struct via_isa_bridge *via_config;
+        u8 t;
+        for (via_config = via_isa_bridges; via_config->id; via_config++)
+                if ((*isa = pci_find_device(PCI_VENDOR_ID_VIA +
+                        !!(via_config->flags & VIA_BAD_ID),
+                        via_config->id, NULL))) {
+                        pci_read_config_byte(*isa, PCI_REVISION_ID, &t);
+                        if (t >= via_config->rev_min &&
+                            t <= via_config->rev_max)
+                                break;
+                }
+        return via_config;
 }
 /**
@@ -418,82 +272,28 @@ static int via82cxxx_ide_dma_check (ide_drive_t *drive)
 static unsigned int __devinit init_chipset_via82cxxx(struct pci_dev *dev, const char *name)
 {
        struct pci_dev *isa = NULL;
+        struct via_isa_bridge *via_config;
        u8 t, v;
        unsigned int u;
-        int i;
        /*
         * Find the ISA bridge to see how good the IDE is.
         */
+        via_config = via_config_find(&isa);
-        for (via_config = via_isa_bridges; via_config->id; via_config++)
-                if ((isa = pci_find_device(PCI_VENDOR_ID_VIA +
-                        !!(via_config->flags & VIA_BAD_ID),
-                        via_config->id, NULL))) {
-                        pci_read_config_byte(isa, PCI_REVISION_ID, &t);
-                        if (t >= via_config->rev_min &&
-                            t <= via_config->rev_max)
-                                break;
-                }
        if (!via_config->id) {
                printk(KERN_WARNING "VP_IDE: Unknown VIA SouthBridge, disabling DMA.\n");
                return -ENODEV;
        }
        /*
-         * Check 80-wire cable presence and setup Clk66.
+         * Setup or disable Clk66 if appropriate
         */
-        switch (via_config->flags & VIA_UDMA) {
+        if ((via_config->flags & VIA_UDMA) == VIA_UDMA_66) {
+                /* Enable Clk66 */
-                case VIA_UDMA_66:
+                pci_read_config_dword(dev, VIA_UDMA_TIMING, &u);
-                        /* Enable Clk66 */
+                pci_write_config_dword(dev, VIA_UDMA_TIMING, u|0x80008);
-                        pci_read_config_dword(dev, VIA_UDMA_TIMING, &u);
+        } else if (via_config->flags & VIA_BAD_CLK66) {
-                        pci_write_config_dword(dev, VIA_UDMA_TIMING, u|0x80008);
-                        for (i = 24; i >= 0; i -= 8)
-                                if (((u >> (i & 16)) & 8) &&
-                                    ((u >> i) & 0x20) &&
-                                     (((u >> i) & 7) < 2)) {
-                                        /*
-                                         * 2x PCI clock and
-                                         * UDMA w/ < 3T/cycle
-                                         */
-                                        via_80w |= (1 << (1 - (i >> 4)));
-                                }
-                        break;
-                case VIA_UDMA_100:
-                        pci_read_config_dword(dev, VIA_UDMA_TIMING, &u);
-                        for (i = 24; i >= 0; i -= 8)
-                                if (((u >> i) & 0x10) ||
-                                    (((u >> i) & 0x20) &&
-                                     (((u >> i) & 7) < 4))) {
-                                        /* BIOS 80-wire bit or
-                                         * UDMA w/ < 60ns/cycle
-                                         */
-                                        via_80w |= (1 << (1 - (i >> 4)));
-                                }
-                        break;
-                case VIA_UDMA_133:
-                        pci_read_config_dword(dev, VIA_UDMA_TIMING, &u);
-                        for (i = 24; i >= 0; i -= 8)
-                                if (((u >> i) & 0x10) ||
-                                    (((u >> i) & 0x20) &&
-                                     (((u >> i) & 7) < 6))) {
-                                        /* BIOS 80-wire bit or
-                                         * UDMA w/ < 60ns/cycle
-                                         */
-                                        via_80w |= (1 << (1 - (i >> 4)));
-                                }
-                        break;
-        }
-        /* Disable Clk66 */
-        if (via_config->flags & VIA_BAD_CLK66) {
                /* Would cause trouble on 596a and 686 */
                pci_read_config_dword(dev, VIA_UDMA_TIMING, &u);
                pci_write_config_dword(dev, VIA_UDMA_TIMING, u & ~0x80008);
@@ -560,26 +360,78 @@ static unsigned int __devinit init_chipset_via82cxxx(struct pci_dev *dev, const
                via_dma[via_config->flags & VIA_UDMA],
                pci_name(dev));
-        /*
+        return 0;
-         * Setup /proc/ide/via entry.
+}
-         */
+/*
+ * Check and handle 80-wire cable presence
+ */
+static void __devinit via_cable_detect(struct pci_dev *dev, struct via82cxxx_dev *vdev)
+{
+        unsigned int u;
+        int i;
+        pci_read_config_dword(dev, VIA_UDMA_TIMING, &u);
+        switch (vdev->via_config->flags & VIA_UDMA) {
+                case VIA_UDMA_66:
+                        for (i = 24; i >= 0; i -= 8)
+                                if (((u >> (i & 16)) & 8) &&
+                                    ((u >> i) & 0x20) &&
+                                     (((u >> i) & 7) < 2)) {
+                                        /*
+                                         * 2x PCI clock and
+                                         * UDMA w/ < 3T/cycle
+                                         */
+                                        vdev->via_80w |= (1 << (1 - (i >> 4)));
+                                }
+                        break;
+                case VIA_UDMA_100:
+                        for (i = 24; i >= 0; i -= 8)
+                                if (((u >> i) & 0x10) ||
+                                    (((u >> i) & 0x20) &&
+                                     (((u >> i) & 7) < 4))) {
+                                        /* BIOS 80-wire bit or
+                                         * UDMA w/ < 60ns/cycle
+                                         */
+                                        vdev->via_80w |= (1 << (1 - (i >> 4)));
+                                }
+                        break;
+                case VIA_UDMA_133:
+                        for (i = 24; i >= 0; i -= 8)
+                                if (((u >> i) & 0x10) ||
+                                    (((u >> i) & 0x20) &&
+                                     (((u >> i) & 7) < 6))) {
+                                        /* BIOS 80-wire bit or
+                                         * UDMA w/ < 60ns/cycle
+                                         */
+                                        vdev->via_80w |= (1 << (1 - (i >> 4)));
+                                }
+                        break;
-#if defined(DISPLAY_VIA_TIMINGS) && defined(CONFIG_PROC_FS)
-        if (!via_proc) {
-                via_base = pci_resource_start(dev, 4);
-                bmide_dev = dev;
-                isa_dev = isa;
-                ide_pci_create_host_proc("via", via_get_info);
-                via_proc = 1;
        }
-#endif /* DISPLAY_VIA_TIMINGS && CONFIG_PROC_FS */
-        return 0;
 }
 static void __devinit init_hwif_via82cxxx(ide_hwif_t *hwif)
 {
+        struct via82cxxx_dev *vdev = kmalloc(sizeof(struct via82cxxx_dev),
+                GFP_KERNEL);
+        struct pci_dev *isa = NULL;
        int i;
+        if (vdev == NULL) {
+                printk(KERN_ERR "VP_IDE: out of memory :(\n");
+                return;
+        }
+        memset(vdev, 0, sizeof(struct via82cxxx_dev));
+        ide_set_hwifdata(hwif, vdev);
+        vdev->via_config = via_config_find(&isa);
+        via_cable_detect(hwif->pci_dev, vdev);
        hwif->autodma = 0;
        hwif->tuneproc = &via82cxxx_tune_drive;
@@ -594,7 +446,7 @@ static void __devinit init_hwif_via82cxxx(ide_hwif_t *hwif)
        for (i = 0; i < 2; i++) {
                hwif->drives[i].io_32bit = 1;
-                hwif->drives[i].unmask = (via_config->flags & VIA_NO_UNMASK) ? 0 : 1;
+                hwif->drives[i].unmask = (vdev->via_config->flags & VIA_NO_UNMASK) ? 0 : 1;
                hwif->drives[i].autotune = 1;
                hwif->drives[i].dn = hwif->channel * 2 + i;
        }
@@ -608,7 +460,7 @@ static void __devinit init_hwif_via82cxxx(ide_hwif_t *hwif)
        hwif->swdma_mask = 0x07;
        if (!hwif->udma_four)
-                hwif->udma_four = (via_80w >> hwif->channel) & 1;
+                hwif->udma_four = (vdev->via_80w >> hwif->channel) & 1;
        hwif->ide_dma_check = &via82cxxx_ide_dma_check;
        if (!noautodma)
                hwif->autodma = 1;
@@ -616,24 +468,35 @@ static void __devinit init_hwif_via82cxxx(ide_hwif_t *hwif)
        hwif->drives[1].autodma = hwif->autodma;
 }
-static ide_pci_device_t via82cxxx_chipset __devinitdata = {
+static ide_pci_device_t via82cxxx_chipsets[] __devinitdata = {
-        .name           = "VP_IDE",
+        {       /* 0 */
-        .init_chipset   = init_chipset_via82cxxx,
+                .name           = "VP_IDE",
-        .init_hwif      = init_hwif_via82cxxx,
+                .init_chipset   = init_chipset_via82cxxx,
-        .channels       = 2,
+                .init_hwif      = init_hwif_via82cxxx,
-        .autodma        = NOAUTODMA,
+                .channels       = 2,
-        .enablebits     = {{0x40,0x02,0x02}, {0x40,0x01,0x01}},
+                .autodma        = NOAUTODMA,
-        .bootable       = ON_BOARD,
+                .enablebits     = {{0x40,0x02,0x02}, {0x40,0x01,0x01}},
+                .bootable       = ON_BOARD
+        },{     /* 1 */
+                .name           = "VP_IDE",
+                .init_chipset   = init_chipset_via82cxxx,
+                .init_hwif      = init_hwif_via82cxxx,
+                .channels       = 2,
+                .autodma        = AUTODMA,
+                .enablebits     = {{0x00,0x00,0x00}, {0x00,0x00,0x00}},
+                .bootable       = ON_BOARD,
+        }
 };
 static int __devinit via_init_one(struct pci_dev *dev, const struct pci_device_id *id)
 {
-        return ide_setup_pci_device(dev, &via82cxxx_chipset);
+        return ide_setup_pci_device(dev, &via82cxxx_chipsets[id->driver_data]);
 }
 static struct pci_device_id via_pci_tbl[] = {
        { PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C576_1, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
        { PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_1, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
+        { PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_6410,     PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
        { 0, },
 };
 MODULE_DEVICE_TABLE(pci, via_pci_tbl);
diff --git a/drivers/ide/ppc/pmac.c b/drivers/ide/ppc/pmac.c
index 136911a86e84..16b28357885b 100644
--- a/drivers/ide/ppc/pmac.c
+++ b/drivers/ide/ppc/pmac.c
@@ -1401,20 +1401,6 @@ pmac_ide_setup_device(pmac_ide_hwif_t *pmif, ide_hwif_t *hwif)
        /* We probe the hwif now */
        probe_hwif_init(hwif);
-        /* The code IDE code will have set hwif->present if we have devices attached,
-         * if we don't, the discard the interface except if we are on a media bay slot
-         */
-        if (!hwif->present && !pmif->mediabay) {
-                printk(KERN_INFO "ide%d: Bus empty, interface released.\n",
-                        hwif->index);
-                default_hwif_iops(hwif);
-                for (i = IDE_DATA_OFFSET; i <= IDE_CONTROL_OFFSET; ++i)
-                        hwif->io_ports[i] = 0;
-                hwif->chipset = ide_unknown;
-                hwif->noprobe = 1;
-                return -ENODEV;
-        }
        return 0;
 }
diff --git a/drivers/ide/setup-pci.c b/drivers/ide/setup-pci.c
index d4f2111d4364..7ebf992e8c2f 100644
--- a/drivers/ide/setup-pci.c
+++ b/drivers/ide/setup-pci.c
@@ -787,7 +787,7 @@ static int pre_init = 1;		/* Before first ordered IDE scan */
 static LIST_HEAD(ide_pci_drivers);
 /*
- *      __ide_register_pci_driver       -       attach IDE driver
+ *      __ide_pci_register_driver       -       attach IDE driver
 *      @driver: pci driver
 *      @module: owner module of the driver
 *
diff --git a/drivers/infiniband/core/user_mad.c b/drivers/infiniband/core/user_mad.c
index 5ea741f47fc8..e73f81c22381 100644
--- a/drivers/infiniband/core/user_mad.c
+++ b/drivers/infiniband/core/user_mad.c
@@ -312,7 +312,7 @@ static ssize_t ib_umad_write(struct file *filp, const char __user *buf,
        int ret, length, hdr_len, copy_offset;
        int rmpp_active = 0;
-        if (count < sizeof (struct ib_user_mad))
+        if (count < sizeof (struct ib_user_mad) + IB_MGMT_RMPP_HDR)
                return -EINVAL;
        length = count - sizeof (struct ib_user_mad);
diff --git a/drivers/infiniband/hw/mthca/mthca_qp.c b/drivers/infiniband/hw/mthca/mthca_qp.c
index 760c418d5bc9..dd4e13303e96 100644
--- a/drivers/infiniband/hw/mthca/mthca_qp.c
+++ b/drivers/infiniband/hw/mthca/mthca_qp.c
@@ -730,15 +730,16 @@ int mthca_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, int attr_mask)
        }
        if (attr_mask & IB_QP_ACCESS_FLAGS) {
+                qp_context->params2 |=
+                        cpu_to_be32(attr->qp_access_flags & IB_ACCESS_REMOTE_WRITE ?
+                                    MTHCA_QP_BIT_RWE : 0);
                /*
-                 * Only enable RDMA/atomics if we have responder
+                 * Only enable RDMA reads and atomics if we have
-                 * resources set to a non-zero value.
+                 * responder resources set to a non-zero value.
                 */
                if (qp->resp_depth) {
                        qp_context->params2 |=
-                                cpu_to_be32(attr->qp_access_flags & IB_ACCESS_REMOTE_WRITE ?
-                                            MTHCA_QP_BIT_RWE : 0);
-                        qp_context->params2 |=
                                cpu_to_be32(attr->qp_access_flags & IB_ACCESS_REMOTE_READ ?
                                            MTHCA_QP_BIT_RRE : 0);
                        qp_context->params2 |=
@@ -759,31 +760,27 @@ int mthca_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, int attr_mask)
                if (qp->resp_depth && !attr->max_dest_rd_atomic) {
                        /*
                         * Lowering our responder resources to zero.
-                         * Turn off RDMA/atomics as responder.
+                         * Turn off reads RDMA and atomics as responder.
-                         * (RWE/RRE/RAE in params2 already zero)
+                         * (RRE/RAE in params2 already zero)
                         */
-                        qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_RWE |
+                        qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_RRE |
-                                                                MTHCA_QP_OPTPAR_RRE |
                                                                MTHCA_QP_OPTPAR_RAE);
                }
                if (!qp->resp_depth && attr->max_dest_rd_atomic) {
                        /*
                         * Increasing our responder resources from
-                         * zero.  Turn on RDMA/atomics as appropriate.
+                         * zero.  Turn on RDMA reads and atomics as
+                         * appropriate.
                         */
                        qp_context->params2 |=
-                                cpu_to_be32(qp->atomic_rd_en & IB_ACCESS_REMOTE_WRITE ?
-                                            MTHCA_QP_BIT_RWE : 0);
-                        qp_context->params2 |=
                                cpu_to_be32(qp->atomic_rd_en & IB_ACCESS_REMOTE_READ ?
                                            MTHCA_QP_BIT_RRE : 0);
                        qp_context->params2 |=
                                cpu_to_be32(qp->atomic_rd_en & IB_ACCESS_REMOTE_ATOMIC ?
                                            MTHCA_QP_BIT_RAE : 0);
-                        qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_RWE |
+                        qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_RRE |
-                                                                MTHCA_QP_OPTPAR_RRE |
                                                                MTHCA_QP_OPTPAR_RAE);
                }
@@ -921,10 +918,12 @@ static void mthca_adjust_qp_caps(struct mthca_dev *dev,
        else
                qp->max_inline_data = max_data_size - MTHCA_INLINE_HEADER_SIZE;
-        qp->sq.max_gs = max_data_size / sizeof (struct mthca_data_seg);
+        qp->sq.max_gs = min_t(int, dev->limits.max_sg,
-        qp->rq.max_gs = (min(dev->limits.max_desc_sz, 1 << qp->rq.wqe_shift) -
+                              max_data_size / sizeof (struct mthca_data_seg));
-                        sizeof (struct mthca_next_seg)) /
+        qp->rq.max_gs = min_t(int, dev->limits.max_sg,
-                        sizeof (struct mthca_data_seg);
+                               (min(dev->limits.max_desc_sz, 1 << qp->rq.wqe_shift) -
+                                sizeof (struct mthca_next_seg)) /
+                               sizeof (struct mthca_data_seg));
 }
 /*
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index 321a3a10e69b..ee9fe226ae99 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -802,13 +802,21 @@ static int srp_post_recv(struct srp_target_port *target)
 /*
 * Must be called with target->scsi_host->host_lock held to protect
- * req_lim and tx_head.
+ * req_lim and tx_head.  Lock cannot be dropped between call here and
+ * call to __srp_post_send().
 */
 static struct srp_iu *__srp_get_tx_iu(struct srp_target_port *target)
 {
        if (target->tx_head - target->tx_tail >= SRP_SQ_SIZE)
                return NULL;
+        if (unlikely(target->req_lim < 1)) {
+                if (printk_ratelimit())
+                        printk(KERN_DEBUG PFX "Target has req_lim %d\n",
+                               target->req_lim);
+                return NULL;
+        }
        return target->tx_ring[target->tx_head & SRP_SQ_SIZE];
 }
@@ -823,11 +831,6 @@ static int __srp_post_send(struct srp_target_port *target,
        struct ib_send_wr wr, *bad_wr;
        int ret = 0;
-        if (target->req_lim < 1) {
-                printk(KERN_ERR PFX "Target has req_lim %d\n", target->req_lim);
-                return -EAGAIN;
-        }
        list.addr   = iu->dma;
        list.length = len;
        list.lkey   = target->srp_host->mr->lkey;
@@ -1417,6 +1420,8 @@ static ssize_t srp_create_target(struct class_device *class_dev,
        if (!target_host)
                return -ENOMEM;
+        target_host->max_lun = SRP_MAX_LUN;
        target = host_to_target(target_host);
        memset(target, 0, sizeof *target);
diff --git a/drivers/infiniband/ulp/srp/ib_srp.h b/drivers/infiniband/ulp/srp/ib_srp.h
index 4fec28a71367..b564f18caf78 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.h
+++ b/drivers/infiniband/ulp/srp/ib_srp.h
@@ -54,6 +54,7 @@ enum {
        SRP_PORT_REDIRECT       = 1,
        SRP_DLID_REDIRECT       = 2,
+        SRP_MAX_LUN             = 512,
        SRP_MAX_IU_LEN          = 256,
        SRP_RQ_SHIFT            = 6,
diff --git a/drivers/input/gameport/gameport.c b/drivers/input/gameport/gameport.c
index 0506934244f0..caac6d63d46f 100644
--- a/drivers/input/gameport/gameport.c
+++ b/drivers/input/gameport/gameport.c
@@ -339,14 +339,20 @@ static struct gameport_event *gameport_get_event(void)
        return event;
 }
-static void gameport_handle_events(void)
+static void gameport_handle_event(void)
 {
        struct gameport_event *event;
        struct gameport_driver *gameport_drv;
        down(&gameport_sem);
-        while ((event = gameport_get_event())) {
+        /*
+         * Note that we handle only one event here to give swsusp
+         * a chance to freeze kgameportd thread. Gameport events
+         * should be pretty rare so we are not concerned about
+         * taking performance hit.
+         */
+        if ((event = gameport_get_event())) {
                switch (event->type) {
                        case GAMEPORT_REGISTER_PORT:
@@ -433,7 +439,7 @@ static struct gameport *gameport_get_pending_child(struct gameport *parent)
 static int gameport_thread(void *nothing)
 {
        do {
-                gameport_handle_events();
+                gameport_handle_event();
                wait_event_interruptible(gameport_wait,
                        kthread_should_stop() || !list_empty(&gameport_event_list));
                try_to_freeze();
diff --git a/drivers/input/input.c b/drivers/input/input.c
index c8ae2bb054e0..bdd2a7fc268d 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -536,7 +536,7 @@ static struct attribute *input_dev_attrs[] = {
        NULL
 };
-static struct attribute_group input_dev_group = {
+static struct attribute_group input_dev_attr_group = {
        .attrs  = input_dev_attrs,
 };
@@ -717,35 +717,14 @@ struct input_dev *input_allocate_device(void)
        return dev;
 }
-static void input_register_classdevice(struct input_dev *dev)
-{
-        static atomic_t input_no = ATOMIC_INIT(0);
-        const char *path;
-        __module_get(THIS_MODULE);
-        dev->dev = dev->cdev.dev;
-        snprintf(dev->cdev.class_id, sizeof(dev->cdev.class_id),
-                 "input%ld", (unsigned long) atomic_inc_return(&input_no) - 1);
-        path = kobject_get_path(&dev->cdev.class->subsys.kset.kobj, GFP_KERNEL);
-        printk(KERN_INFO "input: %s as %s/%s\n",
-                dev->name ? dev->name : "Unspecified device",
-                path ? path : "", dev->cdev.class_id);
-        kfree(path);
-        class_device_add(&dev->cdev);
-        sysfs_create_group(&dev->cdev.kobj, &input_dev_group);
-        sysfs_create_group(&dev->cdev.kobj, &input_dev_id_attr_group);
-        sysfs_create_group(&dev->cdev.kobj, &input_dev_caps_attr_group);
-}
 int input_register_device(struct input_dev *dev)
 {
+        static atomic_t input_no = ATOMIC_INIT(0);
        struct input_handle *handle;
        struct input_handler *handler;
        struct input_device_id *id;
+        const char *path;
+        int error;
        if (!dev->dynalloc) {
                printk(KERN_WARNING "input: device %s is statically allocated, will not register\n"
@@ -773,7 +752,32 @@ int input_register_device(struct input_dev *dev)
        INIT_LIST_HEAD(&dev->h_list);
        list_add_tail(&dev->node, &input_dev_list);
-        input_register_classdevice(dev);
+        dev->cdev.class = &input_class;
+        snprintf(dev->cdev.class_id, sizeof(dev->cdev.class_id),
+                 "input%ld", (unsigned long) atomic_inc_return(&input_no) - 1);
+        error = class_device_add(&dev->cdev);
+        if (error)
+                return error;
+        error = sysfs_create_group(&dev->cdev.kobj, &input_dev_attr_group);
+        if (error)
+                goto fail1;
+        error = sysfs_create_group(&dev->cdev.kobj, &input_dev_id_attr_group);
+        if (error)
+                goto fail2;
+        error = sysfs_create_group(&dev->cdev.kobj, &input_dev_caps_attr_group);
+        if (error)
+                goto fail3;
+        __module_get(THIS_MODULE);
+        path = kobject_get_path(&dev->cdev.kobj, GFP_KERNEL);
+        printk(KERN_INFO "input: %s as %s\n",
+                dev->name ? dev->name : "Unspecified device", path ? path : "N/A");
+        kfree(path);
        list_for_each_entry(handler, &input_handler_list, node)
                if (!handler->blacklist || !input_match_device(handler->blacklist, dev))
@@ -784,6 +788,11 @@ int input_register_device(struct input_dev *dev)
        input_wakeup_procfs_readers();
        return 0;
+ fail3: sysfs_remove_group(&dev->cdev.kobj, &input_dev_id_attr_group);
+ fail2: sysfs_remove_group(&dev->cdev.kobj, &input_dev_attr_group);
+ fail1: class_device_del(&dev->cdev);
+        return error;
 }
 void input_unregister_device(struct input_dev *dev)
@@ -805,7 +814,7 @@ void input_unregister_device(struct input_dev *dev)
        sysfs_remove_group(&dev->cdev.kobj, &input_dev_caps_attr_group);
        sysfs_remove_group(&dev->cdev.kobj, &input_dev_id_attr_group);
-        sysfs_remove_group(&dev->cdev.kobj, &input_dev_group);
+        sysfs_remove_group(&dev->cdev.kobj, &input_dev_attr_group);
        class_device_unregister(&dev->cdev);
        input_wakeup_procfs_readers();
diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index 820c7fd9a604..a0256f8de8ef 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -166,6 +166,9 @@ static unsigned char atkbd_unxlate_table[128] = {
 #define ATKBD_SPECIAL           248
+#define ATKBD_LED_EVENT_BIT     0
+#define ATKBD_REP_EVENT_BIT     1
 static struct {
        unsigned char keycode;
        unsigned char set2;
@@ -211,6 +214,10 @@ struct atkbd {
        unsigned char err_xl;
        unsigned int last;
        unsigned long time;
+        struct work_struct event_work;
+        struct semaphore event_sem;
+        unsigned long event_mask;
 };
 static ssize_t atkbd_attr_show_helper(struct device *dev, char *buf,
@@ -424,58 +431,86 @@ out:
 }
 /*
- * Event callback from the input module. Events that change the state of
+ * atkbd_event_work() is used to complete processing of events that
- * the hardware are processed here.
+ * can not be processed by input_event() which is often called from
+ * interrupt context.
 */
-static int atkbd_event(struct input_dev *dev, unsigned int type, unsigned int code, int value)
+static void atkbd_event_work(void *data)
 {
-        struct atkbd *atkbd = dev->private;
        const short period[32] =
                { 33,  37,  42,  46,  50,  54,  58,  63,  67,  75,  83,  92, 100, 109, 116, 125,
                 133, 149, 167, 182, 200, 217, 232, 250, 270, 303, 333, 370, 400, 435, 470, 500 };
        const short delay[4] =
                { 250, 500, 750, 1000 };
+        struct atkbd *atkbd = data;
+        struct input_dev *dev = atkbd->dev;
        unsigned char param[2];
        int i, j;
+        down(&atkbd->event_sem);
+        if (test_and_clear_bit(ATKBD_LED_EVENT_BIT, &atkbd->event_mask)) {
+                param[0] = (test_bit(LED_SCROLLL, dev->led) ? 1 : 0)
+                         | (test_bit(LED_NUML,    dev->led) ? 2 : 0)
+                         | (test_bit(LED_CAPSL,   dev->led) ? 4 : 0);
+                ps2_command(&atkbd->ps2dev, param, ATKBD_CMD_SETLEDS);
+                if (atkbd->extra) {
+                        param[0] = 0;
+                        param[1] = (test_bit(LED_COMPOSE, dev->led) ? 0x01 : 0)
+                                 | (test_bit(LED_SLEEP,   dev->led) ? 0x02 : 0)
+                                 | (test_bit(LED_SUSPEND, dev->led) ? 0x04 : 0)
+                                 | (test_bit(LED_MISC,    dev->led) ? 0x10 : 0)
+                                 | (test_bit(LED_MUTE,    dev->led) ? 0x20 : 0);
+                        ps2_command(&atkbd->ps2dev, param, ATKBD_CMD_EX_SETLEDS);
+                }
+        }
+        if (test_and_clear_bit(ATKBD_REP_EVENT_BIT, &atkbd->event_mask)) {
+                i = j = 0;
+                while (i < 31 && period[i] < dev->rep[REP_PERIOD])
+                        i++;
+                while (j < 3 && delay[j] < dev->rep[REP_DELAY])
+                        j++;
+                dev->rep[REP_PERIOD] = period[i];
+                dev->rep[REP_DELAY] = delay[j];
+                param[0] = i | (j << 5);
+                ps2_command(&atkbd->ps2dev, param, ATKBD_CMD_SETREP);
+        }
+        up(&atkbd->event_sem);
+}
+/*
+ * Event callback from the input module. Events that change the state of
+ * the hardware are processed here. If action can not be performed in
+ * interrupt context it is offloaded to atkbd_event_work.
+ */
+static int atkbd_event(struct input_dev *dev, unsigned int type, unsigned int code, int value)
+{
+        struct atkbd *atkbd = dev->private;
        if (!atkbd->write)
                return -1;
        switch (type) {
                case EV_LED:
+                        set_bit(ATKBD_LED_EVENT_BIT, &atkbd->event_mask);
-                        param[0] = (test_bit(LED_SCROLLL, dev->led) ? 1 : 0)
+                        wmb();
-                                 | (test_bit(LED_NUML,    dev->led) ? 2 : 0)
+                        schedule_work(&atkbd->event_work);
-                                 | (test_bit(LED_CAPSL,   dev->led) ? 4 : 0);
-                        ps2_schedule_command(&atkbd->ps2dev, param, ATKBD_CMD_SETLEDS);
-                        if (atkbd->extra) {
-                                param[0] = 0;
-                                param[1] = (test_bit(LED_COMPOSE, dev->led) ? 0x01 : 0)
-                                         | (test_bit(LED_SLEEP,   dev->led) ? 0x02 : 0)
-                                         | (test_bit(LED_SUSPEND, dev->led) ? 0x04 : 0)
-                                         | (test_bit(LED_MISC,    dev->led) ? 0x10 : 0)
-                                         | (test_bit(LED_MUTE,    dev->led) ? 0x20 : 0);
-                                ps2_schedule_command(&atkbd->ps2dev, param, ATKBD_CMD_EX_SETLEDS);
-                        }
                        return 0;
                case EV_REP:
-                        if (atkbd->softrepeat) return 0;
+                        if (!atkbd->softrepeat) {
+                                set_bit(ATKBD_REP_EVENT_BIT, &atkbd->event_mask);
-                        i = j = 0;
+                                wmb();
-                        while (i < 31 && period[i] < dev->rep[REP_PERIOD])
+                                schedule_work(&atkbd->event_work);
-                                i++;
+                        }
-                        while (j < 3 && delay[j] < dev->rep[REP_DELAY])
-                                j++;
-                        dev->rep[REP_PERIOD] = period[i];
-                        dev->rep[REP_DELAY] = delay[j];
-                        param[0] = i | (j << 5);
-                        ps2_schedule_command(&atkbd->ps2dev, param, ATKBD_CMD_SETREP);
                        return 0;
        }
@@ -810,6 +845,8 @@ static int atkbd_connect(struct serio *serio, struct serio_driver *drv)
        atkbd->dev = dev;
        ps2_init(&atkbd->ps2dev, serio);
+        INIT_WORK(&atkbd->event_work, atkbd_event_work, atkbd);
+        init_MUTEX(&atkbd->event_sem);
        switch (serio->id.type) {
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index b3eaac1b35b6..07813fc0523f 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -40,6 +40,16 @@ config INPUT_M68K_BEEP
        tristate "M68k Beeper support"
        depends on M68K
+config INPUT_WISTRON_BTNS
+        tristate "x86 Wistron laptop button interface"
+        depends on X86 && !X86_64
+        help
+          Say Y here for support of Winstron laptop button interface, used on
+          laptops of various brands, including Acer and Fujitsu-Siemens.
+          To compile this driver as a module, choose M here: the module will
+          be called wistron_btns.
 config INPUT_UINPUT
        tristate "User level driver support"
        help
diff --git a/drivers/input/misc/Makefile b/drivers/input/misc/Makefile
index f8d01c69f349..ce44cce01285 100644
--- a/drivers/input/misc/Makefile
+++ b/drivers/input/misc/Makefile
@@ -9,4 +9,5 @@ obj-$(CONFIG_INPUT_PCSPKR)		+= pcspkr.o
 obj-$(CONFIG_INPUT_M68K_BEEP)           += m68kspkr.o
 obj-$(CONFIG_INPUT_98SPKR)              += 98spkr.o
 obj-$(CONFIG_INPUT_UINPUT)              += uinput.o
+obj-$(CONFIG_INPUT_WISTRON_BTNS)        += wistron_btns.o
 obj-$(CONFIG_HP_SDC_RTC)                += hp_sdc_rtc.o
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
index 948c1cc01bc9..546ed9b4901d 100644
--- a/drivers/input/misc/uinput.c
+++ b/drivers/input/misc/uinput.c
@@ -92,24 +92,19 @@ static void uinput_request_done(struct uinput_device *udev, struct uinput_reques
 {
        /* Mark slot as available */
        udev->requests[request->id] = NULL;
-        wake_up_interruptible(&udev->requests_waitq);
+        wake_up(&udev->requests_waitq);
        complete(&request->done);
 }
 static int uinput_request_submit(struct input_dev *dev, struct uinput_request *request)
 {
-        int retval;
        /* Tell our userspace app about this new request by queueing an input event */
        uinput_dev_event(dev, EV_UINPUT, request->code, request->id);
        /* Wait for the request to complete */
-        retval = wait_for_completion_interruptible(&request->done);
+        wait_for_completion(&request->done);
-        if (!retval)
+        return request->retval;
-                retval = request->retval;
-        return retval;
 }
 static int uinput_dev_upload_effect(struct input_dev *dev, struct ff_effect *effect)
@@ -152,67 +147,62 @@ static int uinput_dev_erase_effect(struct input_dev *dev, int effect_id)
        return retval;
 }
-static int uinput_create_device(struct uinput_device *udev)
+static void uinput_destroy_device(struct uinput_device *udev)
 {
-        if (!udev->dev->name) {
+        const char *name, *phys;
-                printk(KERN_DEBUG "%s: write device info first\n", UINPUT_NAME);
-                return -EINVAL;
+        if (udev->dev) {
+                name = udev->dev->name;
+                phys = udev->dev->phys;
+                if (udev->state == UIST_CREATED)
+                        input_unregister_device(udev->dev);
+                else
+                        input_free_device(udev->dev);
+                kfree(name);
+                kfree(phys);
+                udev->dev = NULL;
        }
-        udev->dev->event = uinput_dev_event;
+        udev->state = UIST_NEW_DEVICE;
-        udev->dev->upload_effect = uinput_dev_upload_effect;
-        udev->dev->erase_effect = uinput_dev_erase_effect;
-        udev->dev->private = udev;
-        init_waitqueue_head(&udev->waitq);
-        input_register_device(udev->dev);
-        set_bit(UIST_CREATED, &udev->state);
-        return 0;
 }
-static int uinput_destroy_device(struct uinput_device *udev)
+static int uinput_create_device(struct uinput_device *udev)
 {
-        if (!test_bit(UIST_CREATED, &udev->state)) {
+        int error;
-                printk(KERN_WARNING "%s: create the device first\n", UINPUT_NAME);
+        if (udev->state != UIST_SETUP_COMPLETE) {
+                printk(KERN_DEBUG "%s: write device info first\n", UINPUT_NAME);
                return -EINVAL;
        }
-        input_unregister_device(udev->dev);
+        error = input_register_device(udev->dev);
+        if (error) {
+                uinput_destroy_device(udev);
+                return error;
+        }
-        clear_bit(UIST_CREATED, &udev->state);
+        udev->state = UIST_CREATED;
        return 0;
 }
 static int uinput_open(struct inode *inode, struct file *file)
 {
-        struct uinput_device    *newdev;
+        struct uinput_device *newdev;
-        struct input_dev        *newinput;
-        newdev = kmalloc(sizeof(struct uinput_device), GFP_KERNEL);
+        newdev = kzalloc(sizeof(struct uinput_device), GFP_KERNEL);
        if (!newdev)
-                goto error;
+                return -ENOMEM;
-        memset(newdev, 0, sizeof(struct uinput_device));
+        init_MUTEX(&newdev->sem);
        spin_lock_init(&newdev->requests_lock);
        init_waitqueue_head(&newdev->requests_waitq);
+        init_waitqueue_head(&newdev->waitq);
-        newinput = kmalloc(sizeof(struct input_dev), GFP_KERNEL);
+        newdev->state = UIST_NEW_DEVICE;
-        if (!newinput)
-                goto cleanup;
-        memset(newinput, 0, sizeof(struct input_dev));
-        newdev->dev = newinput;
        file->private_data = newdev;
        return 0;
-cleanup:
-        kfree(newdev);
-error:
-        return -ENOMEM;
 }
 static int uinput_validate_absbits(struct input_dev *dev)
@@ -246,34 +236,55 @@ static int uinput_validate_absbits(struct input_dev *dev)
        return retval;
 }
-static int uinput_alloc_device(struct file *file, const char __user *buffer, size_t count)
+static int uinput_allocate_device(struct uinput_device *udev)
+{
+        udev->dev = input_allocate_device();
+        if (!udev->dev)
+                return -ENOMEM;
+        udev->dev->event = uinput_dev_event;
+        udev->dev->upload_effect = uinput_dev_upload_effect;
+        udev->dev->erase_effect = uinput_dev_erase_effect;
+        udev->dev->private = udev;
+        return 0;
+}
+static int uinput_setup_device(struct uinput_device *udev, const char __user *buffer, size_t count)
 {
        struct uinput_user_dev  *user_dev;
        struct input_dev        *dev;
-        struct uinput_device    *udev;
        char                    *name;
        int                     size;
        int                     retval;
-        retval = count;
+        if (count != sizeof(struct uinput_user_dev))
+                return -EINVAL;
+        if (!udev->dev) {
+                retval = uinput_allocate_device(udev);
+                if (retval)
+                        return retval;
+        }
-        udev = file->private_data;
        dev = udev->dev;
        user_dev = kmalloc(sizeof(struct uinput_user_dev), GFP_KERNEL);
-        if (!user_dev) {
+        if (!user_dev)
-                retval = -ENOMEM;
+                return -ENOMEM;
-                goto exit;
-        }
        if (copy_from_user(user_dev, buffer, sizeof(struct uinput_user_dev))) {
                retval = -EFAULT;
                goto exit;
        }
-        kfree(dev->name);
        size = strnlen(user_dev->name, UINPUT_MAX_NAME_SIZE) + 1;
+        if (!size) {
+                retval = -EINVAL;
+                goto exit;
+        }
+        kfree(dev->name);
        dev->name = name = kmalloc(size, GFP_KERNEL);
        if (!name) {
                retval = -ENOMEM;
@@ -296,32 +307,50 @@ static int uinput_alloc_device(struct file *file, const char __user *buffer, siz
        /* check if absmin/absmax/absfuzz/absflat are filled as
         * told in Documentation/input/input-programming.txt */
        if (test_bit(EV_ABS, dev->evbit)) {
-                int err = uinput_validate_absbits(dev);
+                retval = uinput_validate_absbits(dev);
-                if (err < 0) {
+                if (retval < 0)
-                        retval = err;
+                        goto exit;
-                        kfree(dev->name);
-                }
        }
-exit:
+        udev->state = UIST_SETUP_COMPLETE;
+        retval = count;
+ exit:
        kfree(user_dev);
        return retval;
 }
+static inline ssize_t uinput_inject_event(struct uinput_device *udev, const char __user *buffer, size_t count)
+{
+        struct input_event ev;
+        if (count != sizeof(struct input_event))
+                return -EINVAL;
+        if (copy_from_user(&ev, buffer, sizeof(struct input_event)))
+                return -EFAULT;
+        input_event(udev->dev, ev.type, ev.code, ev.value);
+        return sizeof(struct input_event);
+}
 static ssize_t uinput_write(struct file *file, const char __user *buffer, size_t count, loff_t *ppos)
 {
        struct uinput_device *udev = file->private_data;
+        int retval;
+        retval = down_interruptible(&udev->sem);
+        if (retval)
+                return retval;
-        if (test_bit(UIST_CREATED, &udev->state)) {
+        retval = udev->state == UIST_CREATED ?
-                struct input_event      ev;
+                        uinput_inject_event(udev, buffer, count) :
+                        uinput_setup_device(udev, buffer, count);
-                if (copy_from_user(&ev, buffer, sizeof(struct input_event)))
+        up(&udev->sem);
-                        return -EFAULT;
-                input_event(udev->dev, ev.type, ev.code, ev.value);
-        } else
-                count = uinput_alloc_device(file, buffer, count);
-        return count;
+        return retval;
 }
 static ssize_t uinput_read(struct file *file, char __user *buffer, size_t count, loff_t *ppos)
@@ -329,28 +358,38 @@ static ssize_t uinput_read(struct file *file, char __user *buffer, size_t count,
        struct uinput_device *udev = file->private_data;
        int retval = 0;
-        if (!test_bit(UIST_CREATED, &udev->state))
+        if (udev->state != UIST_CREATED)
                return -ENODEV;
        if (udev->head == udev->tail && (file->f_flags & O_NONBLOCK))
                return -EAGAIN;
        retval = wait_event_interruptible(udev->waitq,
-                        udev->head != udev->tail || !test_bit(UIST_CREATED, &udev->state));
+                        udev->head != udev->tail || udev->state != UIST_CREATED);
        if (retval)
                return retval;
-        if (!test_bit(UIST_CREATED, &udev->state))
+        retval = down_interruptible(&udev->sem);
-                return -ENODEV;
+        if (retval)
+                return retval;
-        while ((udev->head != udev->tail) &&
+        if (udev->state != UIST_CREATED) {
-            (retval + sizeof(struct input_event) <= count)) {
+                retval = -ENODEV;
-                if (copy_to_user(buffer + retval, &udev->buff[udev->tail], sizeof(struct input_event)))
+                goto out;
-                        return -EFAULT;
+        }
+        while (udev->head != udev->tail && retval + sizeof(struct input_event) <= count) {
+                if (copy_to_user(buffer + retval, &udev->buff[udev->tail], sizeof(struct input_event))) {
+                        retval = -EFAULT;
+                        goto out;
+                }
                udev->tail = (udev->tail + 1) % UINPUT_BUFFER_SIZE;
                retval += sizeof(struct input_event);
        }
+ out:
+        up(&udev->sem);
        return retval;
 }
@@ -366,28 +405,30 @@ static unsigned int uinput_poll(struct file *file, poll_table *wait)
        return 0;
 }
-static int uinput_burn_device(struct uinput_device *udev)
+static int uinput_release(struct inode *inode, struct file *file)
 {
-        if (test_bit(UIST_CREATED, &udev->state))
+        struct uinput_device *udev = file->private_data;
-                uinput_destroy_device(udev);
-        kfree(udev->dev->name);
+        uinput_destroy_device(udev);
-        kfree(udev->dev->phys);
-        kfree(udev->dev);
        kfree(udev);
        return 0;
 }
-static int uinput_close(struct inode *inode, struct file *file)
+#define uinput_set_bit(_arg, _bit, _max)                \
+({                                                      \
+        int __ret = 0;                                  \
+        if (udev->state == UIST_CREATED)                \
+                __ret =  -EINVAL;                       \
+        else if ((_arg) > (_max))                       \
+                __ret = -EINVAL;                        \
+        else set_bit((_arg), udev->dev->_bit);          \
+        __ret;                                          \
+})
+static long uinput_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 {
-        uinput_burn_device(file->private_data);
+        int                     retval;
-        return 0;
-}
-static int uinput_ioctl(struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg)
-{
-        int                     retval = 0;
        struct uinput_device    *udev;
        void __user             *p = (void __user *)arg;
        struct uinput_ff_upload ff_up;
@@ -398,19 +439,14 @@ static int uinput_ioctl(struct inode *inode, struct file *file, unsigned int cmd
        udev = file->private_data;
-        /* device attributes can not be changed after the device is created */
+        retval = down_interruptible(&udev->sem);
-        switch (cmd) {
+        if (retval)
-                case UI_SET_EVBIT:
+                return retval;
-                case UI_SET_KEYBIT:
-                case UI_SET_RELBIT:
+        if (!udev->dev) {
-                case UI_SET_ABSBIT:
+                retval = uinput_allocate_device(udev);
-                case UI_SET_MSCBIT:
+                if (retval)
-                case UI_SET_LEDBIT:
+                        goto out;
-                case UI_SET_SNDBIT:
-                case UI_SET_FFBIT:
-                case UI_SET_PHYS:
-                        if (test_bit(UIST_CREATED, &udev->state))
-                                return -EINVAL;
        }
        switch (cmd) {
@@ -419,74 +455,50 @@ static int uinput_ioctl(struct inode *inode, struct file *file, unsigned int cmd
                        break;
                case UI_DEV_DESTROY:
-                        retval = uinput_destroy_device(udev);
+                        uinput_destroy_device(udev);
                        break;
                case UI_SET_EVBIT:
-                        if (arg > EV_MAX) {
+                        retval = uinput_set_bit(arg, evbit, EV_MAX);
-                                retval = -EINVAL;
-                                break;
-                        }
-                        set_bit(arg, udev->dev->evbit);
                        break;
                case UI_SET_KEYBIT:
-                        if (arg > KEY_MAX) {
+                        retval = uinput_set_bit(arg, keybit, KEY_MAX);
-                                retval = -EINVAL;
-                                break;
-                        }
-                        set_bit(arg, udev->dev->keybit);
                        break;
                case UI_SET_RELBIT:
-                        if (arg > REL_MAX) {
+                        retval = uinput_set_bit(arg, relbit, REL_MAX);
-                                retval = -EINVAL;
-                                break;
-                        }
-                        set_bit(arg, udev->dev->relbit);
                        break;
                case UI_SET_ABSBIT:
-                        if (arg > ABS_MAX) {
+                        retval = uinput_set_bit(arg, absbit, ABS_MAX);
-                                retval = -EINVAL;
-                                break;
-                        }
-                        set_bit(arg, udev->dev->absbit);
                        break;
                case UI_SET_MSCBIT:
-                        if (arg > MSC_MAX) {
+                        retval = uinput_set_bit(arg, mscbit, MSC_MAX);
-                                retval = -EINVAL;
-                                break;
-                        }
-                        set_bit(arg, udev->dev->mscbit);
                        break;
                case UI_SET_LEDBIT:
-                        if (arg > LED_MAX) {
+                        retval = uinput_set_bit(arg, ledbit, LED_MAX);
-                                retval = -EINVAL;
-                                break;
-                        }
-                        set_bit(arg, udev->dev->ledbit);
                        break;
                case UI_SET_SNDBIT:
-                        if (arg > SND_MAX) {
+                        retval = uinput_set_bit(arg, sndbit, SND_MAX);
-                                retval = -EINVAL;
-                                break;
-                        }
-                        set_bit(arg, udev->dev->sndbit);
                        break;
                case UI_SET_FFBIT:
-                        if (arg > FF_MAX) {
+                        retval = uinput_set_bit(arg, ffbit, FF_MAX);
-                                retval = -EINVAL;
+                        break;
-                                break;
-                        }
+                case UI_SET_SWBIT:
-                        set_bit(arg, udev->dev->ffbit);
+                        retval = uinput_set_bit(arg, swbit, SW_MAX);
                        break;
                case UI_SET_PHYS:
+                        if (udev->state == UIST_CREATED) {
+                                retval = -EINVAL;
+                                goto out;
+                        }
                        length = strnlen_user(p, 1024);
                        if (length <= 0) {
                                retval = -EFAULT;
@@ -575,23 +587,26 @@ static int uinput_ioctl(struct inode *inode, struct file *file, unsigned int cmd
                default:
                        retval = -EINVAL;
        }
+ out:
+        up(&udev->sem);
        return retval;
 }
 static struct file_operations uinput_fops = {
-        .owner =        THIS_MODULE,
+        .owner          = THIS_MODULE,
-        .open =         uinput_open,
+        .open           = uinput_open,
-        .release =      uinput_close,
+        .release        = uinput_release,
-        .read =         uinput_read,
+        .read           = uinput_read,
-        .write =        uinput_write,
+        .write          = uinput_write,
-        .poll =         uinput_poll,
+        .poll           = uinput_poll,
-        .ioctl =        uinput_ioctl,
+        .unlocked_ioctl = uinput_ioctl,
 };
 static struct miscdevice uinput_misc = {
-        .fops =         &uinput_fops,
+        .fops           = &uinput_fops,
-        .minor =        UINPUT_MINOR,
+        .minor          = UINPUT_MINOR,
-        .name =         UINPUT_NAME,
+        .name           = UINPUT_NAME,
 };
 static int __init uinput_init(void)
diff --git a/drivers/input/misc/wistron_btns.c b/drivers/input/misc/wistron_btns.c
new file mode 100644
index 000000000000..49d0416a2a9a
--- /dev/null
+++ b/drivers/input/misc/wistron_btns.c
@@ -0,0 +1,561 @@
+/*
+ * Wistron laptop button driver
+ * Copyright (C) 2005 Miloslav Trmac <mitr@volny.cz>
+ * Copyright (C) 2005 Bernhard Rosenkraenzer <bero@arklinux.org>
+ * Copyright (C) 2005 Dmitry Torokhov <dtor@mail.ru>
+ *
+ * You can redistribute and/or modify this program under the terms of the
+ * GNU General Public License version 2 as published by the Free Software
+ * Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General
+ * Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 59 Temple Place Suite 330, Boston, MA 02111-1307, USA.
+ */
+#include <asm/io.h>
+#include <linux/dmi.h>
+#include <linux/init.h>
+#include <linux/input.h>
+#include <linux/interrupt.h>
+#include <linux/kernel.h>
+#include <linux/mc146818rtc.h>
+#include <linux/module.h>
+#include <linux/preempt.h>
+#include <linux/string.h>
+#include <linux/timer.h>
+#include <linux/types.h>
+#include <linux/platform_device.h>
+/*
+ * Number of attempts to read data from queue per poll;
+ * the queue can hold up to 31 entries
+ */
+#define MAX_POLL_ITERATIONS 64
+#define POLL_FREQUENCY 10 /* Number of polls per second */
+#if POLL_FREQUENCY > HZ
+#error "POLL_FREQUENCY too high"
+#endif
+/* BIOS subsystem IDs */
+#define WIFI            0x35
+#define BLUETOOTH       0x34
+MODULE_AUTHOR("Miloslav Trmac <mitr@volny.cz>");
+MODULE_DESCRIPTION("Wistron laptop button driver");
+MODULE_LICENSE("GPL v2");
+MODULE_VERSION("0.1");
+static int force; /* = 0; */
+module_param(force, bool, 0);
+MODULE_PARM_DESC(force, "Load even if computer is not in database");
+static char *keymap_name; /* = NULL; */
+module_param_named(keymap, keymap_name, charp, 0);
+MODULE_PARM_DESC(keymap, "Keymap name, if it can't be autodetected");
+static struct platform_device *wistron_device;
+ /* BIOS interface implementation */
+static void __iomem *bios_entry_point; /* BIOS routine entry point */
+static void __iomem *bios_code_map_base;
+static void __iomem *bios_data_map_base;
+static u8 cmos_address;
+struct regs {
+        u32 eax, ebx, ecx;
+};
+static void call_bios(struct regs *regs)
+{
+        unsigned long flags;
+        preempt_disable();
+        local_irq_save(flags);
+        asm volatile ("pushl %%ebp;"
+                      "movl %7, %%ebp;"
+                      "call *%6;"
+                      "popl %%ebp"
+                      : "=a" (regs->eax), "=b" (regs->ebx), "=c" (regs->ecx)
+                      : "0" (regs->eax), "1" (regs->ebx), "2" (regs->ecx),
+                        "m" (bios_entry_point), "m" (bios_data_map_base)
+                      : "edx", "edi", "esi", "memory");
+        local_irq_restore(flags);
+        preempt_enable();
+}
+static size_t __init locate_wistron_bios(void __iomem *base)
+{
+        static const unsigned char __initdata signature[] =
+                { 0x42, 0x21, 0x55, 0x30 };
+        size_t offset;
+        for (offset = 0; offset < 0x10000; offset += 0x10) {
+                if (check_signature(base + offset, signature,
+                                    sizeof(signature)) != 0)
+                        return offset;
+        }
+        return -1;
+}
+static int __init map_bios(void)
+{
+        void __iomem *base;
+        size_t offset;
+        u32 entry_point;
+        base = ioremap(0xF0000, 0x10000); /* Can't fail */
+        offset = locate_wistron_bios(base);
+        if (offset < 0) {
+                printk(KERN_ERR "wistron_btns: BIOS entry point not found\n");
+                iounmap(base);
+                return -ENODEV;
+        }
+        entry_point = readl(base + offset + 5);
+        printk(KERN_DEBUG
+                "wistron_btns: BIOS signature found at %p, entry point %08X\n",
+                base + offset, entry_point);
+        if (entry_point >= 0xF0000) {
+                bios_code_map_base = base;
+                bios_entry_point = bios_code_map_base + (entry_point & 0xFFFF);
+        } else {
+                iounmap(base);
+                bios_code_map_base = ioremap(entry_point & ~0x3FFF, 0x4000);
+                if (bios_code_map_base == NULL) {
+                        printk(KERN_ERR
+                                "wistron_btns: Can't map BIOS code at %08X\n",
+                                entry_point & ~0x3FFF);
+                        goto err;
+                }
+                bios_entry_point = bios_code_map_base + (entry_point & 0x3FFF);
+        }
+        /* The Windows driver maps 0x10000 bytes, we keep only one page... */
+        bios_data_map_base = ioremap(0x400, 0xc00);
+        if (bios_data_map_base == NULL) {
+                printk(KERN_ERR "wistron_btns: Can't map BIOS data\n");
+                goto err_code;
+        }
+        return 0;
+err_code:
+        iounmap(bios_code_map_base);
+err:
+        return -ENOMEM;
+}
+static inline void unmap_bios(void)
+{
+        iounmap(bios_code_map_base);
+        iounmap(bios_data_map_base);
+}
+ /* BIOS calls */
+static u16 bios_pop_queue(void)
+{
+        struct regs regs;
+        memset(&regs, 0, sizeof (regs));
+        regs.eax = 0x9610;
+        regs.ebx = 0x061C;
+        regs.ecx = 0x0000;
+        call_bios(&regs);
+        return regs.eax;
+}
+static void __init bios_attach(void)
+{
+        struct regs regs;
+        memset(&regs, 0, sizeof (regs));
+        regs.eax = 0x9610;
+        regs.ebx = 0x012E;
+        call_bios(&regs);
+}
+static void bios_detach(void)
+{
+        struct regs regs;
+        memset(&regs, 0, sizeof (regs));
+        regs.eax = 0x9610;
+        regs.ebx = 0x002E;
+        call_bios(&regs);
+}
+static u8 __init bios_get_cmos_address(void)
+{
+        struct regs regs;
+        memset(&regs, 0, sizeof (regs));
+        regs.eax = 0x9610;
+        regs.ebx = 0x051C;
+        call_bios(&regs);
+        return regs.ecx;
+}
+static u16 __init bios_get_default_setting(u8 subsys)
+{
+        struct regs regs;
+        memset(&regs, 0, sizeof (regs));
+        regs.eax = 0x9610;
+        regs.ebx = 0x0200 | subsys;
+        call_bios(&regs);
+        return regs.eax;
+}
+static void bios_set_state(u8 subsys, int enable)
+{
+        struct regs regs;
+        memset(&regs, 0, sizeof (regs));
+        regs.eax = 0x9610;
+        regs.ebx = (enable ? 0x0100 : 0x0000) | subsys;
+        call_bios(&regs);
+}
+/* Hardware database */
+struct key_entry {
+        char type;              /* See KE_* below */
+        u8 code;
+        unsigned keycode;       /* For KE_KEY */
+};
+enum { KE_END, KE_KEY, KE_WIFI, KE_BLUETOOTH };
+static const struct key_entry *keymap; /* = NULL; Current key map */
+static int have_wifi;
+static int have_bluetooth;
+static int __init dmi_matched(struct dmi_system_id *dmi)
+{
+        const struct key_entry *key;
+        keymap = dmi->driver_data;
+        for (key = keymap; key->type != KE_END; key++) {
+                if (key->type == KE_WIFI) {
+                        have_wifi = 1;
+                        break;
+                } else if (key->type == KE_BLUETOOTH) {
+                        have_bluetooth = 1;
+                        break;
+                }
+        }
+        return 1;
+}
+static struct key_entry keymap_empty[] = {
+        { KE_END, 0 }
+};
+static struct key_entry keymap_fs_amilo_pro_v2000[] = {
+        { KE_KEY,  0x01, KEY_HELP },
+        { KE_KEY,  0x11, KEY_PROG1 },
+        { KE_KEY,  0x12, KEY_PROG2 },
+        { KE_WIFI, 0x30, 0 },
+        { KE_KEY,  0x31, KEY_MAIL },
+        { KE_KEY,  0x36, KEY_WWW },
+        { KE_END,  0 }
+};
+static struct key_entry keymap_wistron_ms2141[] = {
+        { KE_KEY,  0x11, KEY_PROG1 },
+        { KE_KEY,  0x12, KEY_PROG2 },
+        { KE_WIFI, 0x30, 0 },
+        { KE_KEY,  0x22, KEY_REWIND },
+        { KE_KEY,  0x23, KEY_FORWARD },
+        { KE_KEY,  0x24, KEY_PLAYPAUSE },
+        { KE_KEY,  0x25, KEY_STOPCD },
+        { KE_KEY,  0x31, KEY_MAIL },
+        { KE_KEY,  0x36, KEY_WWW },
+        { KE_END,  0 }
+};
+static struct key_entry keymap_acer_aspire_1500[] = {
+        { KE_KEY, 0x11, KEY_PROG1 },
+        { KE_KEY, 0x12, KEY_PROG2 },
+        { KE_WIFI, 0x30, 0 },
+        { KE_KEY, 0x31, KEY_MAIL },
+        { KE_KEY, 0x36, KEY_WWW },
+        { KE_BLUETOOTH, 0x44, 0 },
+        { KE_END, 0 }
+};
+/*
+ * If your machine is not here (which is currently rather likely), please send
+ * a list of buttons and their key codes (reported when loading this module
+ * with force=1) and the output of dmidecode to $MODULE_AUTHOR.
+ */
+static struct dmi_system_id dmi_ids[] = {
+        {
+                .callback = dmi_matched,
+                .ident = "Fujitsu-Siemens Amilo Pro V2000",
+                .matches = {
+                        DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
+                        DMI_MATCH(DMI_PRODUCT_NAME, "AMILO Pro V2000"),
+                },
+                .driver_data = keymap_fs_amilo_pro_v2000
+        },
+        {
+                .callback = dmi_matched,
+                .ident = "Acer Aspire 1500",
+                .matches = {
+                        DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+                        DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 1500"),
+                },
+                .driver_data = keymap_acer_aspire_1500
+        },
+        { 0, }
+};
+static int __init select_keymap(void)
+{
+        if (keymap_name != NULL) {
+                if (strcmp (keymap_name, "1557/MS2141") == 0)
+                        keymap = keymap_wistron_ms2141;
+                else {
+                        printk(KERN_ERR "wistron_btns: Keymap unknown\n");
+                        return -EINVAL;
+                }
+        }
+        dmi_check_system(dmi_ids);
+        if (keymap == NULL) {
+                if (!force) {
+                        printk(KERN_ERR "wistron_btns: System unknown\n");
+                        return -ENODEV;
+                }
+                keymap = keymap_empty;
+        }
+        return 0;
+}
+ /* Input layer interface */
+static struct input_dev *input_dev;
+static int __init setup_input_dev(void)
+{
+        const struct key_entry *key;
+        int error;
+        input_dev = input_allocate_device();
+        if (!input_dev)
+                return -ENOMEM;
+        input_dev->name = "Wistron laptop buttons";
+        input_dev->phys = "wistron/input0";
+        input_dev->id.bustype = BUS_HOST;
+        input_dev->cdev.dev = &wistron_device->dev;
+        for (key = keymap; key->type != KE_END; key++) {
+                if (key->type == KE_KEY) {
+                        input_dev->evbit[LONG(EV_KEY)] = BIT(EV_KEY);
+                        set_bit(key->keycode, input_dev->keybit);
+                }
+        }
+        error = input_register_device(input_dev);
+        if (error) {
+                input_free_device(input_dev);
+                return error;
+        }
+        return 0;
+}
+static void report_key(unsigned keycode)
+{
+        input_report_key(input_dev, keycode, 1);
+        input_sync(input_dev);
+        input_report_key(input_dev, keycode, 0);
+        input_sync(input_dev);
+}
+ /* Driver core */
+static int wifi_enabled;
+static int bluetooth_enabled;
+static void poll_bios(unsigned long);
+static struct timer_list poll_timer = TIMER_INITIALIZER(poll_bios, 0, 0);
+static void handle_key(u8 code)
+{
+        const struct key_entry *key;
+        for (key = keymap; key->type != KE_END; key++) {
+                if (code == key->code) {
+                        switch (key->type) {
+                        case KE_KEY:
+                                report_key(key->keycode);
+                                break;
+                        case KE_WIFI:
+                                if (have_wifi) {
+                                        wifi_enabled = !wifi_enabled;
+                                        bios_set_state(WIFI, wifi_enabled);
+                                }
+                                break;
+                        case KE_BLUETOOTH:
+                                if (have_bluetooth) {
+                                        bluetooth_enabled = !bluetooth_enabled;
+                                        bios_set_state(BLUETOOTH, bluetooth_enabled);
+                                }
+                                break;
+                        case KE_END:
+                        default:
+                                BUG();
+                        }
+                        return;
+                }
+        }
+        printk(KERN_NOTICE "wistron_btns: Unknown key code %02X\n", code);
+}
+static void poll_bios(unsigned long discard)
+{
+        u8 qlen;
+        u16 val;
+        for (;;) {
+                qlen = CMOS_READ(cmos_address);
+                if (qlen == 0)
+                        break;
+                val = bios_pop_queue();
+                if (val != 0 && !discard)
+                        handle_key((u8)val);
+        }
+        mod_timer(&poll_timer, jiffies + HZ / POLL_FREQUENCY);
+}
+static int wistron_suspend(struct platform_device *dev, pm_message_t state)
+{
+        del_timer_sync(&poll_timer);
+        if (have_wifi)
+                bios_set_state(WIFI, 0);
+        if (have_bluetooth)
+                bios_set_state(BLUETOOTH, 0);
+        return 0;
+}
+static int wistron_resume(struct platform_device *dev)
+{
+        if (have_wifi)
+                bios_set_state(WIFI, wifi_enabled);
+        if (have_bluetooth)
+                bios_set_state(BLUETOOTH, bluetooth_enabled);
+        poll_bios(1);
+        return 0;
+}
+static struct platform_driver wistron_driver = {
+        .suspend        = wistron_suspend,
+        .resume         = wistron_resume,
+        .driver         = {
+                .name   = "wistron-bios",
+        },
+};
+static int __init wb_module_init(void)
+{
+        int err;
+        err = select_keymap();
+        if (err)
+                return err;
+        err = map_bios();
+        if (err)
+                return err;
+        bios_attach();
+        cmos_address = bios_get_cmos_address();
+        err = platform_driver_register(&wistron_driver);
+        if (err)
+                goto err_detach_bios;
+        wistron_device = platform_device_register_simple("wistron-bios", -1, NULL, 0);
+        if (IS_ERR(wistron_device)) {
+                err = PTR_ERR(wistron_device);
+                goto err_unregister_driver;
+        }
+        if (have_wifi) {
+                u16 wifi = bios_get_default_setting(WIFI);
+                if (wifi & 1)
+                        wifi_enabled = (wifi & 2) ? 1 : 0;
+                else
+                        have_wifi = 0;
+                if (have_wifi)
+                        bios_set_state(WIFI, wifi_enabled);
+        }
+        if (have_bluetooth) {
+                u16 bt = bios_get_default_setting(BLUETOOTH);
+                if (bt & 1)
+                        bluetooth_enabled = (bt & 2) ? 1 : 0;
+                else
+                        have_bluetooth = 0;
+                if (have_bluetooth)
+                        bios_set_state(BLUETOOTH, bluetooth_enabled);
+        }
+        err = setup_input_dev();
+        if (err)
+                goto err_unregister_device;
+        poll_bios(1); /* Flush stale event queue and arm timer */
+        return 0;
+ err_unregister_device:
+        platform_device_unregister(wistron_device);
+ err_unregister_driver:
+        platform_driver_unregister(&wistron_driver);
+ err_detach_bios:
+        bios_detach();
+        unmap_bios();
+        return err;
+}
+static void __exit wb_module_exit(void)
+{
+        del_timer_sync(&poll_timer);
+        input_unregister_device(input_dev);
+        platform_device_unregister(wistron_device);
+        platform_driver_unregister(&wistron_driver);
+        bios_detach();
+        unmap_bios();
+}
+module_init(wb_module_init);
+module_exit(wb_module_exit);
diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
index edd15db17715..fbb69ef6a77b 100644
--- a/drivers/input/serio/serio.c
+++ b/drivers/input/serio/serio.c
@@ -269,14 +269,20 @@ static struct serio_event *serio_get_event(void)
        return event;
 }
-static void serio_handle_events(void)
+static void serio_handle_event(void)
 {
        struct serio_event *event;
        struct serio_driver *serio_drv;
        down(&serio_sem);
-        while ((event = serio_get_event())) {
+        /*
+         * Note that we handle only one event here to give swsusp
+         * a chance to freeze kseriod thread. Serio events should
+         * be pretty rare so we are not concerned about taking
+         * performance hit.
+         */
+        if ((event = serio_get_event())) {
                switch (event->type) {
                        case SERIO_REGISTER_PORT:
@@ -368,7 +374,7 @@ static struct serio *serio_get_pending_child(struct serio *parent)
 static int serio_thread(void *nothing)
 {
        do {
-                serio_handle_events();
+                serio_handle_event();
                wait_event_interruptible(serio_wait,
                        kthread_should_stop() || !list_empty(&serio_event_list));
                try_to_freeze();
diff --git a/drivers/isdn/hisax/Kconfig b/drivers/isdn/hisax/Kconfig
index 801c98f30e5c..c82105920d71 100644
--- a/drivers/isdn/hisax/Kconfig
+++ b/drivers/isdn/hisax/Kconfig
@@ -110,7 +110,7 @@ config HISAX_16_3
 config HISAX_TELESPCI
        bool "Teles PCI"
-        depends on PCI && (BROKEN || !(SPARC64 || PPC))
+        depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K))
        help
          This enables HiSax support for the Teles PCI.
          See <file:Documentation/isdn/README.HiSax> on how to configure it.
@@ -238,7 +238,7 @@ config HISAX_MIC
 config HISAX_NETJET
        bool "NETjet card"
-        depends on PCI && (BROKEN || !(SPARC64 || PPC))
+        depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K))
        help
          This enables HiSax support for the NetJet from Traverse
          Technologies.
@@ -249,7 +249,7 @@ config HISAX_NETJET
 config HISAX_NETJET_U
        bool "NETspider U card"
-        depends on PCI && (BROKEN || !(SPARC64 || PPC))
+        depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K))
        help
          This enables HiSax support for the Netspider U interface ISDN card
          from Traverse Technologies.
@@ -317,7 +317,7 @@ config HISAX_GAZEL
 config HISAX_HFC_PCI
        bool "HFC PCI-Bus cards"
-        depends on PCI && (BROKEN || !(SPARC64 || PPC))
+        depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K))
        help
          This enables HiSax support for the HFC-S PCI 2BDS0 based cards.
@@ -344,14 +344,14 @@ config HISAX_HFC_SX
 config HISAX_ENTERNOW_PCI
        bool "Formula-n enter:now PCI card"
-        depends on PCI && (BROKEN || !(SPARC64 || PPC))
+        depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K))
        help
          This enables HiSax support for the Formula-n enter:now PCI
          ISDN card.
 config HISAX_AMD7930
        bool "Am7930 (EXPERIMENTAL)"
-        depends on EXPERIMENTAL && (SPARC32 || SPARC64)
+        depends on EXPERIMENTAL && SPARC
        help
          This enables HiSax support for the AMD7930 chips on some SPARCs.
          This code is not finished yet.
diff --git a/drivers/isdn/pcbit/Kconfig b/drivers/isdn/pcbit/Kconfig
index f06997faef16..0933881ab0c2 100644
--- a/drivers/isdn/pcbit/Kconfig
+++ b/drivers/isdn/pcbit/Kconfig
@@ -3,7 +3,7 @@
 #
 config ISDN_DRV_PCBIT
        tristate "PCBIT-D support"
-        depends on ISDN_I4L && ISA && (BROKEN || !PPC)
+        depends on ISDN_I4L && ISA && (BROKEN || X86)
        help
          This enables support for the PCBIT ISDN-card.  This card is
          manufactured in Portugal by Octal.  For running this card,
diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
index 51315302a85e..252d55df9642 100644
--- a/drivers/md/bitmap.c
+++ b/drivers/md/bitmap.c
@@ -326,9 +326,9 @@ static int write_page(struct bitmap *bitmap, struct page *page, int wait)
                }
        }
-        ret = page->mapping->a_ops->prepare_write(NULL, page, 0, PAGE_SIZE);
+        ret = page->mapping->a_ops->prepare_write(bitmap->file, page, 0, PAGE_SIZE);
        if (!ret)
-                ret = page->mapping->a_ops->commit_write(NULL, page, 0,
+                ret = page->mapping->a_ops->commit_write(bitmap->file, page, 0,
                        PAGE_SIZE);
        if (ret) {
                unlock_page(page);
diff --git a/drivers/md/md.c b/drivers/md/md.c
index f3fed662f32e..78c7418478d6 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3846,11 +3846,20 @@ static int is_mddev_idle(mddev_t *mddev)
                curr_events = disk_stat_read(disk, sectors[0]) + 
                                disk_stat_read(disk, sectors[1]) - 
                                atomic_read(&disk->sync_io);
-                /* Allow some slack between valud of curr_events and last_events,
+                /* The difference between curr_events and last_events
-                 * as there are some uninteresting races.
+                 * will be affected by any new non-sync IO (making
+                 * curr_events bigger) and any difference in the amount of
+                 * in-flight syncio (making current_events bigger or smaller)
+                 * The amount in-flight is currently limited to
+                 * 32*64K in raid1/10 and 256*PAGE_SIZE in raid5/6
+                 * which is at most 4096 sectors.
+                 * These numbers are fairly fragile and should be made
+                 * more robust, probably by enforcing the
+                 * 'window size' that md_do_sync sort-of uses.
+                 *
                 * Note: the following is an unsigned comparison.
                 */
-                if ((curr_events - rdev->last_events + 32) > 64) {
+                if ((curr_events - rdev->last_events + 4096) > 8192) {
                        rdev->last_events = curr_events;
                        idle = 0;
                }
@@ -4109,7 +4118,7 @@ static void md_do_sync(mddev_t *mddev)
                if (currspeed > sysctl_speed_limit_min) {
                        if ((currspeed > sysctl_speed_limit_max) ||
                                        !is_mddev_idle(mddev)) {
-                                msleep(250);
+                                msleep(500);
                                goto repeat;
                        }
                }
diff --git a/drivers/media/dvb/cinergyT2/cinergyT2.c b/drivers/media/dvb/cinergyT2/cinergyT2.c
index fb394a0d838c..336fc284fa52 100644
--- a/drivers/media/dvb/cinergyT2/cinergyT2.c
+++ b/drivers/media/dvb/cinergyT2/cinergyT2.c
@@ -772,7 +772,7 @@ static int cinergyt2_register_rc(struct cinergyt2 *cinergyt2)
        input_dev->name = DRIVER_NAME " remote control";
        input_dev->phys = cinergyt2->phys;
        input_dev->evbit[0] = BIT(EV_KEY) | BIT(EV_REP);
-        for (i = 0; ARRAY_SIZE(rc_keys); i += 3)
+        for (i = 0; i < ARRAY_SIZE(rc_keys); i += 3)
                set_bit(rc_keys[i + 2], input_dev->keybit);
        input_dev->keycodesize = 0;
        input_dev->keycodemax = 0;
diff --git a/drivers/media/video/ir-kbd-gpio.c b/drivers/media/video/ir-kbd-gpio.c
index 5abfc0fbf6de..6345e29e4951 100644
--- a/drivers/media/video/ir-kbd-gpio.c
+++ b/drivers/media/video/ir-kbd-gpio.c
@@ -673,7 +673,6 @@ static int ir_probe(struct device *dev)
        snprintf(ir->phys, sizeof(ir->phys), "pci-%s/ir0",
                 pci_name(sub->core->pci));
-        ir->sub = sub;
        ir_input_init(input_dev, &ir->ir, ir_type, ir_codes);
        input_dev->name = ir->name;
        input_dev->phys = ir->phys;
@@ -688,6 +687,9 @@ static int ir_probe(struct device *dev)
        }
        input_dev->cdev.dev = &sub->core->pci->dev;
+        ir->input = input_dev;
+        ir->sub = sub;
        if (ir->polling) {
                INIT_WORK(&ir->work, ir_work, ir);
                init_timer(&ir->timer);
@@ -708,7 +710,6 @@ static int ir_probe(struct device *dev)
        /* all done */
        dev_set_drvdata(dev, ir);
        input_register_device(ir->input);
-        printk(DEVNAME ": %s detected at %s\n",ir->name,ir->phys);
        /* the remote isn't as bouncy as a keyboard */
        ir->input->rep[REP_DELAY] = repeat_delay;
diff --git a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c
index e648cc3bc96d..ab75ca5ac356 100644
--- a/drivers/media/video/saa7134/saa7134-input.c
+++ b/drivers/media/video/saa7134/saa7134-input.c
@@ -713,6 +713,8 @@ int saa7134_input_init1(struct saa7134_dev *dev)
                return -ENOMEM;
        }
+        ir->dev = input_dev;
        /* init hardware-specific stuff */
        ir->mask_keycode = mask_keycode;
        ir->mask_keydown = mask_keydown;
diff --git a/drivers/mtd/maps/ipaq-flash.c b/drivers/mtd/maps/ipaq-flash.c
index 35097c9bbf50..b8ccb0a95789 100644
--- a/drivers/mtd/maps/ipaq-flash.c
+++ b/drivers/mtd/maps/ipaq-flash.c
@@ -246,7 +246,7 @@ int __init ipaq_mtd_init(void)
                        ipaq_map[i].size = h3xxx_max_flash_size;
                        ipaq_map[i].set_vpp = h3xxx_set_vpp;
                        ipaq_map[i].phys = cs_phys[i];
-                        ipaq_map[i].virt = __ioremap(cs_phys[i], 0x04000000, 0, 1);
+                        ipaq_map[i].virt = ioremap(cs_phys[i], 0x04000000);
                        if (machine_is_h3100 () || machine_is_h1900())
                                ipaq_map[i].bankwidth = 2;
                }
@@ -280,7 +280,7 @@ int __init ipaq_mtd_init(void)
                nb_parts = ARRAY_SIZE(jornada_partitions);
                ipaq_map[0].size = jornada_max_flash_size;
                ipaq_map[0].set_vpp = jornada56x_set_vpp;
-                ipaq_map[0].virt = (__u32)__ioremap(0x0, 0x04000000, 0, 1);
+                ipaq_map[0].virt = (__u32)ioremap(0x0, 0x04000000);
        }
 #endif
 #ifdef CONFIG_SA1100_JORNADA720
@@ -442,7 +442,7 @@ static int __init h1900_special_case(void)
        ipaq_map[0].size = 0x80000;
        ipaq_map[0].set_vpp = h3xxx_set_vpp;
        ipaq_map[0].phys = 0x0;
-        ipaq_map[0].virt = __ioremap(0x0, 0x04000000, 0, 1);
+        ipaq_map[0].virt = ioremap(0x0, 0x04000000);
        ipaq_map[0].bankwidth = 2;
        printk(KERN_NOTICE "iPAQ flash: probing %d-bit flash bus, window=%lx with JEDEC.\n", ipaq_map[0].bankwidth*8, ipaq_map[0].virt);
diff --git a/drivers/mtd/maps/ixp2000.c b/drivers/mtd/maps/ixp2000.c
index fc7a78e31735..2c9cc7f37e92 100644
--- a/drivers/mtd/maps/ixp2000.c
+++ b/drivers/mtd/maps/ixp2000.c
@@ -159,12 +159,12 @@ static int ixp2000_flash_probe(struct platform_device *dev)
                return -ENODEV;
        window_size = dev->resource->end - dev->resource->start + 1;
-        dev_info(_dev, "Probe of IXP2000 flash(%d banks x %dMiB)\n",
+        dev_info(&dev->dev, "Probe of IXP2000 flash(%d banks x %dMiB)\n",
-                        ixp_data->nr_banks, ((u32)window_size >> 20));
+                 ixp_data->nr_banks, ((u32)window_size >> 20));
        if (plat->width != 1) {
-                dev_err(_dev, "IXP2000 MTD map only supports 8-bit mode, asking for %d\n",
+                dev_err(&dev->dev, "IXP2000 MTD map only supports 8-bit mode, asking for %d\n",
-                                plat->width * 8);
+                        plat->width * 8);
                return -EIO;
        }
@@ -202,7 +202,7 @@ static int ixp2000_flash_probe(struct platform_device *dev)
                        dev->resource->end - dev->resource->start + 1,
                        dev->dev.bus_id);
        if (!info->res) {
-                dev_err(_dev, "Could not reserve memory region\n");
+                dev_err(&dev->dev, "Could not reserve memory region\n");
                err = -ENOMEM;
                goto Error;
        }
@@ -210,7 +210,7 @@ static int ixp2000_flash_probe(struct platform_device *dev)
        info->map.map_priv_1 = (unsigned long) ioremap(dev->resource->start,
                                dev->resource->end - dev->resource->start + 1);
        if (!info->map.map_priv_1) {
-                dev_err(_dev, "Failed to ioremap flash region\n");
+                dev_err(&dev->dev, "Failed to ioremap flash region\n");
                err = -EIO;
                goto Error;
        }
@@ -221,13 +221,13 @@ static int ixp2000_flash_probe(struct platform_device *dev)
         */
        erratum44_workaround = ixp2000_has_broken_slowport();
-        dev_info(_dev, "Erratum 44 workaround %s\n",
+        dev_info(&dev->dev, "Erratum 44 workaround %s\n",
               erratum44_workaround ? "enabled" : "disabled");
 #endif
        info->mtd = do_map_probe(plat->map_name, &info->map);
        if (!info->mtd) {
-                dev_err(_dev, "map_probe failed\n");
+                dev_err(&dev->dev, "map_probe failed\n");
                err = -ENXIO;
                goto Error;
        }
@@ -237,7 +237,7 @@ static int ixp2000_flash_probe(struct platform_device *dev)
        if (err > 0) {
                err = add_mtd_partitions(info->mtd, info->partitions, err);
                if(err)
-                        dev_err(_dev, "Could not parse partitions\n");
+                        dev_err(&dev->dev, "Could not parse partitions\n");
        }
        if (err)
@@ -251,8 +251,8 @@ Error:
 }
 static struct platform_driver ixp2000_flash_driver = {
-        .probe          = &ixp2000_flash_probe,
+        .probe          = ixp2000_flash_probe,
-        .remove         = &ixp2000_flash_remove
+        .remove         = ixp2000_flash_remove,
        .driver         = {
                .name   = "IXP2000-Flash",
        },
diff --git a/drivers/mtd/nand/h1910.c b/drivers/mtd/nand/h1910.c
index 041e4b3358fb..f68f7a99a630 100644
--- a/drivers/mtd/nand/h1910.c
+++ b/drivers/mtd/nand/h1910.c
@@ -112,7 +112,7 @@ static int __init h1910_init (void)
        if (!machine_is_h1900())
                return -ENODEV;
-        nandaddr = __ioremap(0x08000000, 0x1000, 0, 1);
+        nandaddr = ioremap(0x08000000, 0x1000);
        if (!nandaddr) {
                printk("Failed to ioremap nand flash.\n");
                return -ENOMEM;
diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
index 332e9953c55c..cd0b1dccfb61 100644
--- a/drivers/net/au1000_eth.c
+++ b/drivers/net/au1000_eth.c
@@ -32,6 +32,7 @@
 * 
 */
+#include <linux/config.h>
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/sched.h>
diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index 7a6aeae2c9fa..22cd04556707 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
@@ -156,7 +156,7 @@
 #define DRV_NAME                "e100"
 #define DRV_EXT         "-NAPI"
-#define DRV_VERSION             "3.4.14-k2"DRV_EXT
+#define DRV_VERSION             "3.4.14-k4"DRV_EXT
 #define DRV_DESCRIPTION         "Intel(R) PRO/100 Network Driver"
 #define DRV_COPYRIGHT           "Copyright(c) 1999-2005 Intel Corporation"
 #define PFX                     DRV_NAME ": "
@@ -903,8 +903,8 @@ static void mdio_write(struct net_device *netdev, int addr, int reg, int data)
 static void e100_get_defaults(struct nic *nic)
 {
-        struct param_range rfds = { .min = 16, .max = 256, .count = 64 };
+        struct param_range rfds = { .min = 16, .max = 256, .count = 256 };
-        struct param_range cbs  = { .min = 64, .max = 256, .count = 64 };
+        struct param_range cbs  = { .min = 64, .max = 256, .count = 128 };
        pci_read_config_byte(nic->pdev, PCI_REVISION_ID, &nic->rev_id);
        /* MAC type is encoded as rev ID; exception: ICH is treated as 82559 */
@@ -1007,25 +1007,264 @@ static void e100_configure(struct nic *nic, struct cb *cb, struct sk_buff *skb)
                c[16], c[17], c[18], c[19], c[20], c[21], c[22], c[23]);
 }
+/********************************************************/
+/*  Micro code for 8086:1229 Rev 8                      */
+/********************************************************/
+/*  Parameter values for the D101M B-step  */
+#define D101M_CPUSAVER_TIMER_DWORD              78
+#define D101M_CPUSAVER_BUNDLE_DWORD             65
+#define D101M_CPUSAVER_MIN_SIZE_DWORD           126
+#define D101M_B_RCVBUNDLE_UCODE \
+{\
+0x00550215, 0xFFFF0437, 0xFFFFFFFF, 0x06A70789, 0xFFFFFFFF, 0x0558FFFF, \
+0x000C0001, 0x00101312, 0x000C0008, 0x00380216, \
+0x0010009C, 0x00204056, 0x002380CC, 0x00380056, \
+0x0010009C, 0x00244C0B, 0x00000800, 0x00124818, \
+0x00380438, 0x00000000, 0x00140000, 0x00380555, \
+0x00308000, 0x00100662, 0x00100561, 0x000E0408, \
+0x00134861, 0x000C0002, 0x00103093, 0x00308000, \
+0x00100624, 0x00100561, 0x000E0408, 0x00100861, \
+0x000C007E, 0x00222C21, 0x000C0002, 0x00103093, \
+0x00380C7A, 0x00080000, 0x00103090, 0x00380C7A, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x0010009C, 0x00244C2D, 0x00010004, 0x00041000, \
+0x003A0437, 0x00044010, 0x0038078A, 0x00000000, \
+0x00100099, 0x00206C7A, 0x0010009C, 0x00244C48, \
+0x00130824, 0x000C0001, 0x00101213, 0x00260C75, \
+0x00041000, 0x00010004, 0x00130826, 0x000C0006, \
+0x002206A8, 0x0013C926, 0x00101313, 0x003806A8, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00080600, 0x00101B10, 0x00050004, 0x00100826, \
+0x00101210, 0x00380C34, 0x00000000, 0x00000000, \
+0x0021155B, 0x00100099, 0x00206559, 0x0010009C, \
+0x00244559, 0x00130836, 0x000C0000, 0x00220C62, \
+0x000C0001, 0x00101B13, 0x00229C0E, 0x00210C0E, \
+0x00226C0E, 0x00216C0E, 0x0022FC0E, 0x00215C0E, \
+0x00214C0E, 0x00380555, 0x00010004, 0x00041000, \
+0x00278C67, 0x00040800, 0x00018100, 0x003A0437, \
+0x00130826, 0x000C0001, 0x00220559, 0x00101313, \
+0x00380559, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00130831, 0x0010090B, 0x00124813, \
+0x000CFF80, 0x002606AB, 0x00041000, 0x00010004, \
+0x003806A8, 0x00000000, 0x00000000, 0x00000000, \
+}
+/********************************************************/
+/*  Micro code for 8086:1229 Rev 9                      */
+/********************************************************/
+/*  Parameter values for the D101S  */
+#define D101S_CPUSAVER_TIMER_DWORD              78
+#define D101S_CPUSAVER_BUNDLE_DWORD             67
+#define D101S_CPUSAVER_MIN_SIZE_DWORD           128
+#define D101S_RCVBUNDLE_UCODE \
+{\
+0x00550242, 0xFFFF047E, 0xFFFFFFFF, 0x06FF0818, 0xFFFFFFFF, 0x05A6FFFF, \
+0x000C0001, 0x00101312, 0x000C0008, 0x00380243, \
+0x0010009C, 0x00204056, 0x002380D0, 0x00380056, \
+0x0010009C, 0x00244F8B, 0x00000800, 0x00124818, \
+0x0038047F, 0x00000000, 0x00140000, 0x003805A3, \
+0x00308000, 0x00100610, 0x00100561, 0x000E0408, \
+0x00134861, 0x000C0002, 0x00103093, 0x00308000, \
+0x00100624, 0x00100561, 0x000E0408, 0x00100861, \
+0x000C007E, 0x00222FA1, 0x000C0002, 0x00103093, \
+0x00380F90, 0x00080000, 0x00103090, 0x00380F90, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x0010009C, 0x00244FAD, 0x00010004, 0x00041000, \
+0x003A047E, 0x00044010, 0x00380819, 0x00000000, \
+0x00100099, 0x00206FFD, 0x0010009A, 0x0020AFFD, \
+0x0010009C, 0x00244FC8, 0x00130824, 0x000C0001, \
+0x00101213, 0x00260FF7, 0x00041000, 0x00010004, \
+0x00130826, 0x000C0006, 0x00220700, 0x0013C926, \
+0x00101313, 0x00380700, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00080600, 0x00101B10, 0x00050004, 0x00100826, \
+0x00101210, 0x00380FB6, 0x00000000, 0x00000000, \
+0x002115A9, 0x00100099, 0x002065A7, 0x0010009A, \
+0x0020A5A7, 0x0010009C, 0x002445A7, 0x00130836, \
+0x000C0000, 0x00220FE4, 0x000C0001, 0x00101B13, \
+0x00229F8E, 0x00210F8E, 0x00226F8E, 0x00216F8E, \
+0x0022FF8E, 0x00215F8E, 0x00214F8E, 0x003805A3, \
+0x00010004, 0x00041000, 0x00278FE9, 0x00040800, \
+0x00018100, 0x003A047E, 0x00130826, 0x000C0001, \
+0x002205A7, 0x00101313, 0x003805A7, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00130831, \
+0x0010090B, 0x00124813, 0x000CFF80, 0x00260703, \
+0x00041000, 0x00010004, 0x00380700  \
+}
+/********************************************************/
+/*  Micro code for the 8086:1229 Rev F/10               */
+/********************************************************/
+/*  Parameter values for the D102 E-step  */
+#define D102_E_CPUSAVER_TIMER_DWORD             42
+#define D102_E_CPUSAVER_BUNDLE_DWORD            54
+#define D102_E_CPUSAVER_MIN_SIZE_DWORD          46
+#define     D102_E_RCVBUNDLE_UCODE \
+{\
+0x007D028F, 0x0E4204F9, 0x14ED0C85, 0x14FA14E9, 0x0EF70E36, 0x1FFF1FFF, \
+0x00E014B9, 0x00000000, 0x00000000, 0x00000000, \
+0x00E014BD, 0x00000000, 0x00000000, 0x00000000, \
+0x00E014D5, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00E014C1, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00E014C8, 0x00000000, 0x00000000, 0x00000000, \
+0x00200600, 0x00E014EE, 0x00000000, 0x00000000, \
+0x0030FF80, 0x00940E46, 0x00038200, 0x00102000, \
+0x00E00E43, 0x00000000, 0x00000000, 0x00000000, \
+0x00300006, 0x00E014FB, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00906E41, 0x00800E3C, 0x00E00E39, 0x00000000, \
+0x00906EFD, 0x00900EFD, 0x00E00EF8, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+0x00000000, 0x00000000, 0x00000000, 0x00000000, \
+}
 static void e100_load_ucode(struct nic *nic, struct cb *cb, struct sk_buff *skb)
 {
-        int i;
+/* *INDENT-OFF* */
-        static const u32 ucode[UCODE_SIZE] = {
+        static struct {
-                /* NFS packets are misinterpreted as TCO packets and
+                u32 ucode[UCODE_SIZE + 1];
-                 * incorrectly routed to the BMC over SMBus.  This
+                u8 mac;
-                 * microcode patch checks the fragmented IP bit in the
+                u8 timer_dword;
-                 * NFS/UDP header to distinguish between NFS and TCO. */
+                u8 bundle_dword;
-                0x0EF70E36, 0x1FFF1FFF, 0x1FFF1FFF, 0x1FFF1FFF, 0x1FFF1FFF,
+                u8 min_size_dword;
-                0x1FFF1FFF, 0x00906E41, 0x00800E3C, 0x00E00E39, 0x00000000,
+        } ucode_opts[] = {
-                0x00906EFD, 0x00900EFD, 0x00E00EF8,
+                { D101M_B_RCVBUNDLE_UCODE,
-        };
+                  mac_82559_D101M,
+                  D101M_CPUSAVER_TIMER_DWORD,
-        if(nic->mac == mac_82551_F || nic->mac == mac_82551_10) {
+                  D101M_CPUSAVER_BUNDLE_DWORD,
-                for(i = 0; i < UCODE_SIZE; i++)
+                  D101M_CPUSAVER_MIN_SIZE_DWORD },
+                { D101S_RCVBUNDLE_UCODE,
+                  mac_82559_D101S,
+                  D101S_CPUSAVER_TIMER_DWORD,
+                  D101S_CPUSAVER_BUNDLE_DWORD,
+                  D101S_CPUSAVER_MIN_SIZE_DWORD },
+                { D102_E_RCVBUNDLE_UCODE,
+                  mac_82551_F,
+                  D102_E_CPUSAVER_TIMER_DWORD,
+                  D102_E_CPUSAVER_BUNDLE_DWORD,
+                  D102_E_CPUSAVER_MIN_SIZE_DWORD },
+                { D102_E_RCVBUNDLE_UCODE,
+                  mac_82551_10,
+                  D102_E_CPUSAVER_TIMER_DWORD,
+                  D102_E_CPUSAVER_BUNDLE_DWORD,
+                  D102_E_CPUSAVER_MIN_SIZE_DWORD },
+                { {0}, 0, 0, 0, 0}
+        }, *opts;
+/* *INDENT-ON* */
+/*************************************************************************
+*  CPUSaver parameters
+*
+*  All CPUSaver parameters are 16-bit literals that are part of a
+*  "move immediate value" instruction.  By changing the value of
+*  the literal in the instruction before the code is loaded, the
+*  driver can change the algorithm.
+*
+*  INTDELAY - This loads the dead-man timer with its inital value.
+*    When this timer expires the interrupt is asserted, and the 
+*    timer is reset each time a new packet is received.  (see
+*    BUNDLEMAX below to set the limit on number of chained packets)
+*    The current default is 0x600 or 1536.  Experiments show that
+*    the value should probably stay within the 0x200 - 0x1000.
+*
+*  BUNDLEMAX - 
+*    This sets the maximum number of frames that will be bundled.  In
+*    some situations, such as the TCP windowing algorithm, it may be
+*    better to limit the growth of the bundle size than let it go as
+*    high as it can, because that could cause too much added latency.
+*    The default is six, because this is the number of packets in the
+*    default TCP window size.  A value of 1 would make CPUSaver indicate
+*    an interrupt for every frame received.  If you do not want to put
+*    a limit on the bundle size, set this value to xFFFF.
+*
+*  BUNDLESMALL - 
+*    This contains a bit-mask describing the minimum size frame that
+*    will be bundled.  The default masks the lower 7 bits, which means
+*    that any frame less than 128 bytes in length will not be bundled,
+*    but will instead immediately generate an interrupt.  This does
+*    not affect the current bundle in any way.  Any frame that is 128
+*    bytes or large will be bundled normally.  This feature is meant
+*    to provide immediate indication of ACK frames in a TCP environment.
+*    Customers were seeing poor performance when a machine with CPUSaver
+*    enabled was sending but not receiving.  The delay introduced when
+*    the ACKs were received was enough to reduce total throughput, because
+*    the sender would sit idle until the ACK was finally seen.
+*
+*    The current default is 0xFF80, which masks out the lower 7 bits.
+*    This means that any frame which is x7F (127) bytes or smaller
+*    will cause an immediate interrupt.  Because this value must be a 
+*    bit mask, there are only a few valid values that can be used.  To
+*    turn this feature off, the driver can write the value xFFFF to the
+*    lower word of this instruction (in the same way that the other
+*    parameters are used).  Likewise, a value of 0xF800 (2047) would
+*    cause an interrupt to be generated for every frame, because all
+*    standard Ethernet frames are <= 2047 bytes in length.
+*************************************************************************/
+/* if you wish to disable the ucode functionality, while maintaining the 
+ * workarounds it provides, set the following defines to:
+ * BUNDLESMALL 0
+ * BUNDLEMAX 1
+ * INTDELAY 1
+ */
+#define BUNDLESMALL 1
+#define BUNDLEMAX (u16)6
+#define INTDELAY (u16)1536 /* 0x600 */
+        /* do not load u-code for ICH devices */
+        if (nic->flags & ich)
+                goto noloaducode;
+        /* Search for ucode match against h/w rev_id */
+        for (opts = ucode_opts; opts->mac; opts++) {
+                int i;
+                u32 *ucode = opts->ucode;
+                if (nic->mac != opts->mac)
+                        continue;
+                /* Insert user-tunable settings */
+                ucode[opts->timer_dword] &= 0xFFFF0000;
+                ucode[opts->timer_dword] |= INTDELAY;
+                ucode[opts->bundle_dword] &= 0xFFFF0000;
+                ucode[opts->bundle_dword] |= BUNDLEMAX;
+                ucode[opts->min_size_dword] &= 0xFFFF0000;
+                ucode[opts->min_size_dword] |= (BUNDLESMALL) ? 0xFFFF : 0xFF80;
+                for (i = 0; i < UCODE_SIZE; i++)
                        cb->u.ucode[i] = cpu_to_le32(ucode[i]);
                cb->command = cpu_to_le16(cb_ucode);
-        } else
+                return;
-                cb->command = cpu_to_le16(cb_nop);
+        }
+noloaducode:
+        cb->command = cpu_to_le16(cb_nop);
 }
 static void e100_setup_iaaddr(struct nic *nic, struct cb *cb,
diff --git a/drivers/net/fec_8xx/Kconfig b/drivers/net/fec_8xx/Kconfig
index 94e7a9af8705..a84c232395e3 100644
--- a/drivers/net/fec_8xx/Kconfig
+++ b/drivers/net/fec_8xx/Kconfig
@@ -1,6 +1,6 @@
 config FEC_8XX
        tristate "Motorola 8xx FEC driver"
-        depends on NET_ETHERNET && FEC
+        depends on NET_ETHERNET && 8xx
        select MII
 config FEC_8XX_GENERIC_PHY
diff --git a/drivers/net/ioc3-eth.c b/drivers/net/ioc3-eth.c
index 6a3129bc15a6..9b8295ee06ef 100644
--- a/drivers/net/ioc3-eth.c
+++ b/drivers/net/ioc3-eth.c
@@ -1360,7 +1360,7 @@ static struct pci_driver ioc3_driver = {
 static int __init ioc3_init_module(void)
 {
-        return pci_module_init(&ioc3_driver);
+        return pci_register_driver(&ioc3_driver);
 }
 static void __exit ioc3_cleanup_module(void)
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 159b56a56ef4..14a76f7cf900 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -1346,10 +1346,8 @@ rtl8169_init_board(struct pci_dev *pdev, struct net_device **dev_out,
        } else {
                if (netif_msg_probe(tp)) {
                        printk(KERN_ERR PFX
-                               "Cannot find PowerManagement capability. "
+                               "PowerManagement capability not found.\n");
-                               "Aborting.\n");
                }
-                goto err_out_mwi;
        }
        /* make sure PCI base addr 1 is MMIO */
@@ -2516,7 +2514,7 @@ rtl8169_interrupt(int irq, void *dev_instance, struct pt_regs *regs)
        } while (boguscnt > 0);
        if (boguscnt <= 0) {
-                if (net_ratelimit() && netif_msg_intr(tp)) {
+                if (netif_msg_intr(tp) && net_ratelimit() ) {
                        printk(KERN_WARNING
                               "%s: Too much work at interrupt!\n", dev->name);
                }
diff --git a/drivers/net/saa9730.h b/drivers/net/saa9730.h
index 9e9da6b4080f..a7e9d29a86a7 100644
--- a/drivers/net/saa9730.h
+++ b/drivers/net/saa9730.h
@@ -1,6 +1,7 @@
 /*
- * Carsten Langgaard, carstenl@mips.com
+ * Copyright (C) 2000, 2005  MIPS Technologies, Inc.  All rights reserved.
- * Copyright (C) 2000 MIPS Technologies, Inc.  All rights reserved.
+ *      Authors: Carsten Langgaard <carstenl@mips.com>
+ *               Maciej W. Rozycki <macro@mips.com>
 *
 * ########################################################################
 *
@@ -265,6 +266,7 @@
 /* The SAA9730 (LAN) controller register map, as seen via the PCI-bus. */
 #define SAA9730_LAN_REGS_ADDR   0x20400
+#define SAA9730_LAN_REGS_SIZE   0x00400
 struct lan_saa9730_regmap {
        volatile unsigned int TxBuffA;                  /* 0x20400 */
@@ -309,6 +311,7 @@ typedef volatile struct lan_saa9730_regmap t_lan_saa9730_regmap;
 /* The SAA9730 (EVM) controller register map, as seen via the PCI-bus. */
 #define SAA9730_EVM_REGS_ADDR   0x02000
+#define SAA9730_EVM_REGS_SIZE   0x00400
 struct evm_saa9730_regmap {
        volatile unsigned int InterruptStatus1;         /* 0x2000 */
@@ -329,16 +332,32 @@ typedef volatile struct evm_saa9730_regmap t_evm_saa9730_regmap;
 struct lan_saa9730_private {
+        /*
+         * Rx/Tx packet buffers.
+         * The Rx and Tx packets must be PACKET_SIZE aligned.
+         */
+        void            *buffer_start;
+        unsigned int    buffer_size;
+        /*
+         * DMA address of beginning of this object, returned
+         * by pci_alloc_consistent().
+         */
+        dma_addr_t      dma_addr;
+        /* Pointer to the associated pci device structure */
+        struct pci_dev  *pci_dev;
        /* Pointer for the SAA9730 LAN controller register set. */
        t_lan_saa9730_regmap *lan_saa9730_regs;
        /* Pointer to the SAA9730 EVM register. */
        t_evm_saa9730_regmap *evm_saa9730_regs;
-        /* TRUE if the next buffer to write is RxBuffA,  FALSE if RxBuffB. */
-        unsigned char NextRcvToUseIsA;
        /* Rcv buffer Index. */
        unsigned char NextRcvPacketIndex;
+        /* Next buffer index. */
+        unsigned char NextRcvBufferIndex;
        /* Index of next packet to use in that buffer. */
        unsigned char NextTxmPacketIndex;
@@ -353,13 +372,8 @@ struct lan_saa9730_private {
        unsigned char DmaRcvPackets;
        unsigned char DmaTxmPackets;
-        unsigned char RcvAIndex;        /* index into RcvBufferSpace[] for Blk A */
+        void          *TxmBuffer[LAN_SAA9730_BUFFERS][LAN_SAA9730_TXM_Q_SIZE];
-        unsigned char RcvBIndex;        /* index into RcvBufferSpace[] for Blk B */
+        void          *RcvBuffer[LAN_SAA9730_BUFFERS][LAN_SAA9730_RCV_Q_SIZE];
-        unsigned int
-            TxmBuffer[LAN_SAA9730_BUFFERS][LAN_SAA9730_TXM_Q_SIZE];
-        unsigned int
-            RcvBuffer[LAN_SAA9730_BUFFERS][LAN_SAA9730_RCV_Q_SIZE];
        unsigned int TxBufferFree[LAN_SAA9730_BUFFERS];
        unsigned char PhysicalAddress[LAN_SAA9730_CAM_ENTRIES][6];
diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c
index c91e2e81f131..28bf2e69eb5e 100644
--- a/drivers/net/smc91x.c
+++ b/drivers/net/smc91x.c
@@ -155,6 +155,12 @@ MODULE_LICENSE("GPL");
 #define MEMORY_WAIT_TIME        16
 /*
+ * The maximum number of processing loops allowed for each call to the
+ * IRQ handler.  
+ */
+#define MAX_IRQ_LOOPS           8
+/*
 * This selects whether TX packets are sent one by one to the SMC91x internal
 * memory and throttled until transmission completes.  This may prevent
 * RX overruns a litle by keeping much of the memory free for RX packets
@@ -684,7 +690,6 @@ static void smc_hardware_send_pkt(unsigned long data)
        /* queue the packet for TX */
        SMC_SET_MMU_CMD(MC_ENQUEUE);
-        SMC_ACK_INT(IM_TX_EMPTY_INT);
        smc_special_unlock(&lp->lock);
        dev->trans_start = jiffies;
@@ -1207,6 +1212,7 @@ static void smc_phy_configure(void *data)
        smc_phy_check_media(dev, 1);
 smc_phy_configure_exit:
+        SMC_SELECT_BANK(2);
        spin_unlock_irq(&lp->lock);
        lp->work_pending = 0;
 }
@@ -1305,7 +1311,7 @@ static irqreturn_t smc_interrupt(int irq, void *dev_id, struct pt_regs *regs)
        SMC_SET_INT_MASK(0);
        /* set a timeout value, so I don't stay here forever */
-        timeout = 8;
+        timeout = MAX_IRQ_LOOPS;
        do {
                status = SMC_GET_INT();
@@ -1372,10 +1378,13 @@ static irqreturn_t smc_interrupt(int irq, void *dev_id, struct pt_regs *regs)
        /* restore register states */
        SMC_SET_PTR(saved_pointer);
        SMC_SET_INT_MASK(mask);
        spin_unlock(&lp->lock);
-        DBG(3, "%s: Interrupt done (%d loops)\n", dev->name, 8-timeout);
+        if (timeout == MAX_IRQ_LOOPS)
+                PRINTK("%s: spurious interrupt (mask = 0x%02x)\n",
+                       dev->name, mask);
+        DBG(3, "%s: Interrupt done (%d loops)\n",
+               dev->name, MAX_IRQ_LOOPS - timeout);
        /*
         * We return IRQ_HANDLED unconditionally here even if there was
diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c
index a01efa6d5c62..1fd04662c4fc 100644
--- a/drivers/net/wan/hdlc_cisco.c
+++ b/drivers/net/wan/hdlc_cisco.c
@@ -192,7 +192,9 @@ static int cisco_rx(struct sk_buff *skb)
                                               "uptime %ud%uh%um%us)\n",
                                               dev->name, days, hrs,
                                               min, sec);
+#if 0
                                        netif_carrier_on(dev);
+#endif
                                        hdlc->state.cisco.up = 1;
                                }
                        }
@@ -225,7 +227,9 @@ static void cisco_timer(unsigned long arg)
                       hdlc->state.cisco.settings.timeout * HZ)) {
                hdlc->state.cisco.up = 0;
                printk(KERN_INFO "%s: Link down\n", dev->name);
+#if 0
                netif_carrier_off(dev);
+#endif
        }
        cisco_keepalive_send(dev, CISCO_KEEPALIVE_REQ,
@@ -261,8 +265,10 @@ static void cisco_stop(struct net_device *dev)
 {
        hdlc_device *hdlc = dev_to_hdlc(dev);
        del_timer_sync(&hdlc->state.cisco.timer);
+#if 0
        if (netif_carrier_ok(dev))
                netif_carrier_off(dev);
+#endif
        hdlc->state.cisco.up = 0;
        hdlc->state.cisco.request_sent = 0;
 }
diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c
index e1601d35dced..523afe17564e 100644
--- a/drivers/net/wan/hdlc_fr.c
+++ b/drivers/net/wan/hdlc_fr.c
@@ -545,8 +545,10 @@ static void fr_set_link_state(int reliable, struct net_device *dev)
        hdlc->state.fr.reliable = reliable;
        if (reliable) {
+#if 0
                if (!netif_carrier_ok(dev))
                        netif_carrier_on(dev);
+#endif
                hdlc->state.fr.n391cnt = 0; /* Request full status */
                hdlc->state.fr.dce_changed = 1;
@@ -560,8 +562,10 @@ static void fr_set_link_state(int reliable, struct net_device *dev)
                        }
                }
        } else {
+#if 0
                if (netif_carrier_ok(dev))
                        netif_carrier_off(dev);
+#endif
                while (pvc) {           /* Deactivate all PVCs */
                        pvc_carrier(0, pvc);
diff --git a/drivers/net/wan/hdlc_generic.c b/drivers/net/wan/hdlc_generic.c
index cdd4c09c2d90..46cef8f92133 100644
--- a/drivers/net/wan/hdlc_generic.c
+++ b/drivers/net/wan/hdlc_generic.c
@@ -79,11 +79,13 @@ static void __hdlc_set_carrier_on(struct net_device *dev)
        hdlc_device *hdlc = dev_to_hdlc(dev);
        if (hdlc->proto.start)
                return hdlc->proto.start(dev);
+#if 0
 #ifdef DEBUG_LINK
        if (netif_carrier_ok(dev))
                printk(KERN_ERR "hdlc_set_carrier_on(): already on\n");
 #endif
        netif_carrier_on(dev);
+#endif
 }
@@ -94,11 +96,13 @@ static void __hdlc_set_carrier_off(struct net_device *dev)
        if (hdlc->proto.stop)
                return hdlc->proto.stop(dev);
+#if 0
 #ifdef DEBUG_LINK
        if (!netif_carrier_ok(dev))
                printk(KERN_ERR "hdlc_set_carrier_off(): already off\n");
 #endif
        netif_carrier_off(dev);
+#endif
 }
@@ -294,8 +298,10 @@ int register_hdlc_device(struct net_device *dev)
        if (result != 0)
                return -EIO;
+#if 0
        if (netif_carrier_ok(dev))
                netif_carrier_off(dev); /* no carrier until DCD goes up */
+#endif
        return 0;
 }
diff --git a/drivers/net/wireless/hermes.c b/drivers/net/wireless/hermes.c
index 579480dad374..346c6febb033 100644
--- a/drivers/net/wireless/hermes.c
+++ b/drivers/net/wireless/hermes.c
@@ -398,7 +398,7 @@ static int hermes_bap_seek(hermes_t *hw, int bap, u16 id, u16 offset)
 *
 * Returns: < 0 on internal failure (errno), 0 on success, > 0 on error from firmware
 */
-int hermes_bap_pread(hermes_t *hw, int bap, void *buf, unsigned len,
+int hermes_bap_pread(hermes_t *hw, int bap, void *buf, int len,
                     u16 id, u16 offset)
 {
        int dreg = bap ? HERMES_DATA1 : HERMES_DATA0;
@@ -424,7 +424,7 @@ int hermes_bap_pread(hermes_t *hw, int bap, void *buf, unsigned len,
 *
 * Returns: < 0 on internal failure (errno), 0 on success, > 0 on error from firmware
 */
-int hermes_bap_pwrite(hermes_t *hw, int bap, const void *buf, unsigned len,
+int hermes_bap_pwrite(hermes_t *hw, int bap, const void *buf, int len,
                      u16 id, u16 offset)
 {
        int dreg = bap ? HERMES_DATA1 : HERMES_DATA0;
@@ -450,7 +450,7 @@ int hermes_bap_pwrite(hermes_t *hw, int bap, const void *buf, unsigned len,
 *
 * Returns: < 0 on internal failure (errno), 0 on success, > 0 on error from firmware
 */
-int hermes_bap_pwrite_pad(hermes_t *hw, int bap, const void *buf, unsigned data_len, unsigned len,
+int hermes_bap_pwrite_pad(hermes_t *hw, int bap, const void *buf, unsigned data_len, int len,
                      u16 id, u16 offset)
 {
        int dreg = bap ? HERMES_DATA1 : HERMES_DATA0;
diff --git a/drivers/net/wireless/hermes.h b/drivers/net/wireless/hermes.h
index a6bd472d75d4..7644f72a9f4e 100644
--- a/drivers/net/wireless/hermes.h
+++ b/drivers/net/wireless/hermes.h
@@ -372,12 +372,12 @@ int hermes_docmd_wait(hermes_t *hw, u16 cmd, u16 parm0,
                      struct hermes_response *resp);
 int hermes_allocate(hermes_t *hw, u16 size, u16 *fid);
-int hermes_bap_pread(hermes_t *hw, int bap, void *buf, unsigned len,
+int hermes_bap_pread(hermes_t *hw, int bap, void *buf, int len,
                       u16 id, u16 offset);
-int hermes_bap_pwrite(hermes_t *hw, int bap, const void *buf, unsigned len,
+int hermes_bap_pwrite(hermes_t *hw, int bap, const void *buf, int len,
                        u16 id, u16 offset);
 int hermes_bap_pwrite_pad(hermes_t *hw, int bap, const void *buf,
-                        unsigned data_len, unsigned len, u16 id, u16 offset);
+                        unsigned data_len, int len, u16 id, u16 offset);
 int hermes_read_ltv(hermes_t *hw, int bap, u16 rid, unsigned buflen,
                    u16 *length, void *buf);
 int hermes_write_ltv(hermes_t *hw, int bap, u16 rid,
diff --git a/drivers/net/wireless/i82593.h b/drivers/net/wireless/i82593.h
index 33acb8add4d6..afac5c7a323d 100644
--- a/drivers/net/wireless/i82593.h
+++ b/drivers/net/wireless/i82593.h
@@ -7,11 +7,16 @@
 *
 * Copyright 1994, Anders Klemets <klemets@it.kth.se>
 *
- * This software may be freely distributed for noncommercial purposes
- * as long as this notice is retained.
- * 
 * HISTORY
 * i82593.h,v
+ * Revision 1.4  2005/11/4  09:15:00  baroniunas
+ * Modified copyright with permission of author as follows:
+ *
+ *   "If I82539.H is the only file with my copyright statement
+ *    that is included in the Source Forge project, then you have
+ *    my approval to change the copyright statement to be a GPL
+ *    license, in the way you proposed on October 10."
+ *
 * Revision 1.1  1996/07/17 15:23:12  root
 * Initial revision
 *
diff --git a/drivers/net/wireless/ipw2100.c b/drivers/net/wireless/ipw2100.c
index a2e6214169e9..77d2a21d4cd0 100644
--- a/drivers/net/wireless/ipw2100.c
+++ b/drivers/net/wireless/ipw2100.c
@@ -6344,7 +6344,8 @@ static struct net_device *ipw2100_alloc_device(struct pci_dev *pci_dev,
        dev->ethtool_ops = &ipw2100_ethtool_ops;
        dev->tx_timeout = ipw2100_tx_timeout;
        dev->wireless_handlers = &ipw2100_wx_handler_def;
-        dev->get_wireless_stats = ipw2100_wx_wireless_stats;
+        priv->wireless_data.ieee80211 = priv->ieee;
+        dev->wireless_data = &priv->wireless_data;
        dev->set_mac_address = ipw2100_set_address;
        dev->watchdog_timeo = 3 * HZ;
        dev->irq = 0;
@@ -7178,6 +7179,11 @@ static int ipw2100_wx_get_range(struct net_device *dev,
        }
        range->num_frequency = val;
+        /* Event capability (kernel + driver) */
+        range->event_capa[0] = (IW_EVENT_CAPA_K_0 |
+                                IW_EVENT_CAPA_MASK(SIOCGIWAP));
+        range->event_capa[1] = IW_EVENT_CAPA_K_1;
        IPW_DEBUG_WX("GET Range\n");
        return 0;
@@ -8446,16 +8452,6 @@ static iw_handler ipw2100_private_handler[] = {
 #endif                          /* CONFIG_IPW2100_MONITOR */
 };
-static struct iw_handler_def ipw2100_wx_handler_def = {
-        .standard = ipw2100_wx_handlers,
-        .num_standard = sizeof(ipw2100_wx_handlers) / sizeof(iw_handler),
-        .num_private = sizeof(ipw2100_private_handler) / sizeof(iw_handler),
-        .num_private_args = sizeof(ipw2100_private_args) /
-            sizeof(struct iw_priv_args),
-        .private = (iw_handler *) ipw2100_private_handler,
-        .private_args = (struct iw_priv_args *)ipw2100_private_args,
-};
 /*
 * Get wireless statistics.
 * Called by /proc/net/wireless
@@ -8597,6 +8593,17 @@ static struct iw_statistics *ipw2100_wx_wireless_stats(struct net_device *dev)
        return (struct iw_statistics *)NULL;
 }
+static struct iw_handler_def ipw2100_wx_handler_def = {
+        .standard = ipw2100_wx_handlers,
+        .num_standard = sizeof(ipw2100_wx_handlers) / sizeof(iw_handler),
+        .num_private = sizeof(ipw2100_private_handler) / sizeof(iw_handler),
+        .num_private_args = sizeof(ipw2100_private_args) /
+            sizeof(struct iw_priv_args),
+        .private = (iw_handler *) ipw2100_private_handler,
+        .private_args = (struct iw_priv_args *)ipw2100_private_args,
+        .get_wireless_stats = ipw2100_wx_wireless_stats,
+};
 static void ipw2100_wx_event_work(struct ipw2100_priv *priv)
 {
        union iwreq_data wrqu;
diff --git a/drivers/net/wireless/ipw2100.h b/drivers/net/wireless/ipw2100.h
index 140fdf2a0a09..7c65b10bb164 100644
--- a/drivers/net/wireless/ipw2100.h
+++ b/drivers/net/wireless/ipw2100.h
@@ -571,6 +571,8 @@ struct ipw2100_priv {
        struct net_device *net_dev;
        struct iw_statistics wstats;
+        struct iw_public_data wireless_data;
        struct tasklet_struct irq_tasklet;
        struct workqueue_struct *workqueue;
diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c
index b0d195d1721a..5e7c7e944c9d 100644
--- a/drivers/net/wireless/ipw2200.c
+++ b/drivers/net/wireless/ipw2200.c
@@ -1110,8 +1110,7 @@ static struct ipw_fw_error *ipw_alloc_error_log(struct ipw_priv *priv)
        error->elem_len = elem_len;
        error->log_len = log_len;
        error->elem = (struct ipw_error_elem *)error->payload;
-        error->log = (struct ipw_event *)(error->elem +
+        error->log = (struct ipw_event *)(error->elem + elem_len);
-                                          (sizeof(*error->elem) * elem_len));
        ipw_capture_event_log(priv, log_len, error->log);
@@ -8926,6 +8925,10 @@ static int ipw_request_direct_scan(struct ipw_priv *priv, char *essid,
        struct ipw_scan_request_ext scan;
        int err = 0, scan_type;
+        if (!(priv->status & STATUS_INIT) ||
+            (priv->status & STATUS_EXIT_PENDING))
+                return 0;
        down(&priv->sem);
        if (priv->status & STATUS_RF_KILL_MASK) {
diff --git a/drivers/net/wireless/prism54/isl_38xx.c b/drivers/net/wireless/prism54/isl_38xx.c
index 109a96d90007..23deee69974b 100644
--- a/drivers/net/wireless/prism54/isl_38xx.c
+++ b/drivers/net/wireless/prism54/isl_38xx.c
@@ -164,12 +164,12 @@ isl38xx_trigger_device(int asleep, void __iomem *device_base)
                /* assert the Wakeup interrupt in the Device Interrupt Register */
                isl38xx_w32_flush(device_base, ISL38XX_DEV_INT_WAKEUP,
                                  ISL38XX_DEV_INT_REG);
+#if VERBOSE > SHOW_ERROR_MESSAGES
                udelay(ISL38XX_WRITEIO_DELAY);
                /* perform another read on the Device Status Register */
                reg = readl(device_base + ISL38XX_CTRL_STAT_REG);
-#if VERBOSE > SHOW_ERROR_MESSAGES
                do_gettimeofday(&current_time);
                DEBUG(SHOW_TRACING, "%08li.%08li Device register read %08x\n",
                      current_time.tv_sec, (long)current_time.tv_usec, reg);
diff --git a/drivers/parisc/iosapic.c b/drivers/parisc/iosapic.c
index a39fbfef789a..19657efa8dc3 100644
--- a/drivers/parisc/iosapic.c
+++ b/drivers/parisc/iosapic.c
@@ -700,6 +700,28 @@ static unsigned int iosapic_startup_irq(unsigned int irq)
        return 0;
 }
+#ifdef CONFIG_SMP
+static void iosapic_set_affinity_irq(unsigned int irq, cpumask_t dest)
+{
+        struct vector_info *vi = iosapic_get_vector(irq);
+        u32 d0, d1, dummy_d0;
+        unsigned long flags;
+        if (cpu_check_affinity(irq, &dest))
+                return;
+        vi->txn_addr = txn_affinity_addr(irq, first_cpu(dest));
+        spin_lock_irqsave(&iosapic_lock, flags);
+        /* d1 contains the destination CPU, so only want to set that
+         * entry */
+        iosapic_rd_irt_entry(vi, &d0, &d1);
+        iosapic_set_irt_data(vi, &dummy_d0, &d1);
+        iosapic_wr_irt_entry(vi, d0, d1);
+        spin_unlock_irqrestore(&iosapic_lock, flags);
+}
+#endif
 static struct hw_interrupt_type iosapic_interrupt_type = {
        .typename =     "IO-SAPIC-level",
        .startup =      iosapic_startup_irq,
@@ -708,7 +730,9 @@ static struct hw_interrupt_type iosapic_interrupt_type = {
        .disable =      iosapic_disable_irq,
        .ack =          no_ack_irq,
        .end =          iosapic_end_irq,
-//      .set_affinity = iosapic_set_affinity_irq,
+#ifdef CONFIG_SMP
+        .set_affinity = iosapic_set_affinity_irq,
+#endif
 };
 int iosapic_fixup_irq(void *isi_obj, struct pci_dev *pcidev)
diff --git a/drivers/parisc/superio.c b/drivers/parisc/superio.c
index bab3bcabcb6e..d14888e149bb 100644
--- a/drivers/parisc/superio.c
+++ b/drivers/parisc/superio.c
@@ -24,6 +24,9 @@
 *      Major changes to get basic interrupt infrastructure working to
 *      hopefully be able to support all SuperIO devices. Currently
 *      works with serial. -- John Marvin <jsm@fc.hp.com>
+ *
+ *      Converted superio_init() to be a PCI_FIXUP_FINAL callee.
+ *         -- Kyle McMartin <kyle@parisc-linux.org>
 */
@@ -141,10 +144,10 @@ superio_interrupt(int parent_irq, void *devp, struct pt_regs *regs)
 }
 /* Initialize Super I/O device */
+static void
-static void __devinit
+superio_init(struct pci_dev *pcidev)
-superio_init(struct superio_device *sio)
 {
+        struct superio_device *sio = &sio_dev;
        struct pci_dev *pdev = sio->lio_pdev;
        u16 word;
@@ -160,8 +163,8 @@ superio_init(struct superio_device *sio)
        /* ...then properly fixup the USB to point at suckyio PIC */
        sio->usb_pdev->irq = superio_fixup_irq(sio->usb_pdev);
-        printk (KERN_INFO "SuperIO: Found NS87560 Legacy I/O device at %s (IRQ %i) \n",
+        printk(KERN_INFO "SuperIO: Found NS87560 Legacy I/O device at %s (IRQ %i) \n",
-                pci_name(pdev),pdev->irq);
+               pci_name(pdev), pdev->irq);
        pci_read_config_dword (pdev, SIO_SP1BAR, &sio->sp1_base);
        sio->sp1_base &= ~1;
@@ -274,7 +277,7 @@ superio_init(struct superio_device *sio)
        sio->suckyio_irq_enabled = 1;
 }
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_87560_LIO, superio_init);
 static void superio_disable_irq(unsigned int irq)
 {
@@ -452,8 +455,10 @@ static void superio_fixup_pci(struct pci_dev *pdev)
 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_87415, superio_fixup_pci);
-static int __devinit superio_probe(struct pci_dev *dev, const struct pci_device_id *id)
+static int __devinit
+superio_probe(struct pci_dev *dev, const struct pci_device_id *id)
 {
+        struct superio_device *sio = &sio_dev;
        /*
        ** superio_probe(00:0e.0) ven 0x100b dev 0x2 sv 0x0 sd 0x0 class 0x1018a
@@ -466,7 +471,8 @@ static int __devinit superio_probe(struct pci_dev *dev, const struct pci_device_
                dev->subsystem_vendor, dev->subsystem_device,
                dev->class);
-        superio_init(&sio_dev);
+        if (!sio->suckyio_irq_enabled)
+                BUG(); /* Enabled by PCI_FIXUP_FINAL */
        if (dev->device == PCI_DEVICE_ID_NS_87560_LIO) {        /* Function 1 */
                superio_parport_init();
@@ -481,19 +487,21 @@ static int __devinit superio_probe(struct pci_dev *dev, const struct pci_device_
                DBG_INIT("superio_probe: WTF? Fire Extinguisher?\n");
        }
-        /* Let appropriate other driver claim this device. */ 
+        /* Let appropriate other driver claim this device. */
        return -ENODEV;
 }
 static struct pci_device_id superio_tbl[] = {
-        { PCI_VENDOR_ID_NS, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
+        { PCI_DEVICE(PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_87560_LIO) },
+        { PCI_DEVICE(PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_87560_USB) },
+        { PCI_DEVICE(PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_87415) },
        { 0, }
 };
 static struct pci_driver superio_driver = {
-        .name =         "SuperIO",
+        .name =         "SuperIO",
-        .id_table =     superio_tbl,
+        .id_table =     superio_tbl,
-        .probe =        superio_probe,
+        .probe =        superio_probe,
 };
 static int __init superio_modinit(void)
@@ -506,6 +514,5 @@ static void __exit superio_exit(void)
        pci_unregister_driver(&superio_driver);
 }
 module_init(superio_modinit);
 module_exit(superio_exit);
diff --git a/drivers/s390/char/raw3270.c b/drivers/s390/char/raw3270.c
index f5b7d360fc10..1026f2bc3185 100644
--- a/drivers/s390/char/raw3270.c
+++ b/drivers/s390/char/raw3270.c
@@ -1179,12 +1179,12 @@ raw3270_create_attributes(struct raw3270 *rp)
        //FIXME: check return code
        sysfs_create_group(&rp->cdev->dev.kobj, &raw3270_attr_group);
        rp->clttydev =
-                class_device_create(class3270,
+                class_device_create(class3270, NULL,
                                    MKDEV(IBM_TTY3270_MAJOR, rp->minor),
                                    &rp->cdev->dev, "tty%s",
                                    rp->cdev->dev.bus_id);
        rp->cltubdev =
-                class_device_create(class3270,
+                class_device_create(class3270, NULL,
                                    MKDEV(IBM_FS3270_MAJOR, rp->minor),
                                    &rp->cdev->dev, "tub%s",
                                    rp->cdev->dev.bus_id);
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 84c42c44e04d..20dd85a77813 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -497,7 +497,7 @@ config SCSI_ATA_PIIX
          If unsure, say N.
 config SCSI_SATA_MV
-        tristate "Marvell SATA support"
+        tristate "Marvell SATA support (HIGHLY EXPERIMENTAL)"
        depends on SCSI_SATA && PCI && EXPERIMENTAL
        help
          This option enables support for the Marvell Serial ATA family.
diff --git a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c
index 894e7113e0b3..83467a05dc8e 100644
--- a/drivers/scsi/ahci.c
+++ b/drivers/scsi/ahci.c
@@ -48,7 +48,7 @@
 #include <asm/io.h>
 #define DRV_NAME        "ahci"
-#define DRV_VERSION     "1.01"
+#define DRV_VERSION     "1.2"
 enum {
@@ -558,23 +558,25 @@ static void ahci_qc_prep(struct ata_queued_cmd *qc)
        pp->cmd_slot[0].opts |= cpu_to_le32(n_elem << 16);
 }
-static void ahci_intr_error(struct ata_port *ap, u32 irq_stat)
+static void ahci_restart_port(struct ata_port *ap, u32 irq_stat)
 {
        void __iomem *mmio = ap->host_set->mmio_base;
        void __iomem *port_mmio = ahci_port_base(mmio, ap->port_no);
        u32 tmp;
        int work;
-        printk(KERN_WARNING "ata%u: port reset, "
+        if ((ap->device[0].class != ATA_DEV_ATAPI) ||
-               "p_is %x is %x pis %x cmd %x tf %x ss %x se %x\n",
+            ((irq_stat & PORT_IRQ_TF_ERR) == 0))
-                ap->id,
+                printk(KERN_WARNING "ata%u: port reset, "
-                irq_stat,
+                       "p_is %x is %x pis %x cmd %x tf %x ss %x se %x\n",
-                readl(mmio + HOST_IRQ_STAT),
+                        ap->id,
-                readl(port_mmio + PORT_IRQ_STAT),
+                        irq_stat,
-                readl(port_mmio + PORT_CMD),
+                        readl(mmio + HOST_IRQ_STAT),
-                readl(port_mmio + PORT_TFDATA),
+                        readl(port_mmio + PORT_IRQ_STAT),
-                readl(port_mmio + PORT_SCR_STAT),
+                        readl(port_mmio + PORT_CMD),
-                readl(port_mmio + PORT_SCR_ERR));
+                        readl(port_mmio + PORT_TFDATA),
+                        readl(port_mmio + PORT_SCR_STAT),
+                        readl(port_mmio + PORT_SCR_ERR));
        /* stop DMA */
        tmp = readl(port_mmio + PORT_CMD);
@@ -632,7 +634,7 @@ static void ahci_eng_timeout(struct ata_port *ap)
                printk(KERN_ERR "ata%u: BUG: timeout without command\n",
                       ap->id);
        } else {
-                ahci_intr_error(ap, readl(port_mmio + PORT_IRQ_STAT));
+                ahci_restart_port(ap, readl(port_mmio + PORT_IRQ_STAT));
                /* hack alert!  We cannot use the supplied completion
                 * function from inside the ->eh_strategy_handler() thread.
@@ -677,7 +679,7 @@ static inline int ahci_host_intr(struct ata_port *ap, struct ata_queued_cmd *qc)
                        err_mask = AC_ERR_HOST_BUS;
                /* command processing has stopped due to error; restart */
-                ahci_intr_error(ap, status);
+                ahci_restart_port(ap, status);
                if (qc)
                        ata_qc_complete(qc, err_mask);
diff --git a/drivers/scsi/ata_piix.c b/drivers/scsi/ata_piix.c
index 855428ff37e9..333d69dd84ef 100644
--- a/drivers/scsi/ata_piix.c
+++ b/drivers/scsi/ata_piix.c
@@ -50,7 +50,7 @@
 #include <linux/libata.h>
 #define DRV_NAME        "ata_piix"
-#define DRV_VERSION     "1.04"
+#define DRV_VERSION     "1.05"
 enum {
        PIIX_IOCFG              = 0x54, /* IDE I/O configuration register */
diff --git a/drivers/scsi/ide-scsi.c b/drivers/scsi/ide-scsi.c
index e1960d69fb90..4cb1f3ed9100 100644
--- a/drivers/scsi/ide-scsi.c
+++ b/drivers/scsi/ide-scsi.c
@@ -784,8 +784,8 @@ static ide_proc_entry_t idescsi_proc[] = {
 #endif
 static ide_driver_t idescsi_driver = {
-        .owner                  = THIS_MODULE,
        .gen_driver = {
+                .owner          = THIS_MODULE,
                .name           = "ide-scsi",
                .bus            = &ide_bus_type,
                .probe          = ide_scsi_probe,
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index ba1eb8b38e00..665ae79e1fd6 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -1046,6 +1046,30 @@ static unsigned int ata_pio_modes(const struct ata_device *adev)
        return modes;
 }
+static int ata_qc_wait_err(struct ata_queued_cmd *qc,
+                           struct completion *wait)
+{
+        int rc = 0;
+        if (wait_for_completion_timeout(wait, 30 * HZ) < 1) {
+                /* timeout handling */
+                unsigned int err_mask = ac_err_mask(ata_chk_status(qc->ap));
+                if (!err_mask) {
+                        printk(KERN_WARNING "ata%u: slow completion (cmd %x)\n",
+                               qc->ap->id, qc->tf.command);
+                } else {
+                        printk(KERN_WARNING "ata%u: qc timeout (cmd %x)\n",
+                               qc->ap->id, qc->tf.command);
+                        rc = -EIO;
+                }
+                ata_qc_complete(qc, err_mask);
+        }
+        return rc;
+}
 /**
 *      ata_dev_identify - obtain IDENTIFY x DEVICE page
 *      @ap: port on which device we wish to probe resides
@@ -1125,7 +1149,7 @@ retry:
        if (rc)
                goto err_out;
        else
-                wait_for_completion(&wait);
+                ata_qc_wait_err(qc, &wait);
        spin_lock_irqsave(&ap->host_set->lock, flags);
        ap->ops->tf_read(ap, &qc->tf);
@@ -1570,11 +1594,13 @@ int ata_timing_compute(struct ata_device *adev, unsigned short speed,
        /*
         * Find the mode. 
-        */
+         */
        if (!(s = ata_timing_find_mode(speed)))
                return -EINVAL;
+        memcpy(t, s, sizeof(*s));
        /*
         * If the drive is an EIDE drive, it can tell us it needs extended
         * PIO/MW_DMA cycle timing.
@@ -1595,7 +1621,7 @@ int ata_timing_compute(struct ata_device *adev, unsigned short speed,
         * Convert the timing to bus clock counts.
         */
-        ata_timing_quantize(s, t, T, UT);
+        ata_timing_quantize(t, t, T, UT);
        /*
         * Even in DMA/UDMA modes we still use PIO access for IDENTIFY, S.M.A.R.T
@@ -2267,7 +2293,7 @@ static void ata_dev_set_xfermode(struct ata_port *ap, struct ata_device *dev)
        if (rc)
                ata_port_disable(ap);
        else
-                wait_for_completion(&wait);
+                ata_qc_wait_err(qc, &wait);
        DPRINTK("EXIT\n");
 }
@@ -2315,7 +2341,7 @@ static void ata_dev_reread_id(struct ata_port *ap, struct ata_device *dev)
        if (rc)
                goto err_out;
-        wait_for_completion(&wait);
+        ata_qc_wait_err(qc, &wait);
        swap_buf_le16(dev->id, ATA_ID_WORDS);
@@ -2371,7 +2397,7 @@ static void ata_dev_init_params(struct ata_port *ap, struct ata_device *dev)
        if (rc)
                ata_port_disable(ap);
        else
-                wait_for_completion(&wait);
+                ata_qc_wait_err(qc, &wait);
        DPRINTK("EXIT\n");
 }
diff --git a/drivers/scsi/libata.h b/drivers/scsi/libata.h
index 74a84e0ec0a4..8ebaa694d18e 100644
--- a/drivers/scsi/libata.h
+++ b/drivers/scsi/libata.h
@@ -29,7 +29,7 @@
 #define __LIBATA_H__
 #define DRV_NAME        "libata"
-#define DRV_VERSION     "1.12"  /* must be exactly four chars */
+#define DRV_VERSION     "1.20"  /* must be exactly four chars */
 struct ata_scsi_args {
        u16                     *id;
diff --git a/drivers/scsi/sata_mv.c b/drivers/scsi/sata_mv.c
index 257c128f4aaa..ab7432a5778e 100644
--- a/drivers/scsi/sata_mv.c
+++ b/drivers/scsi/sata_mv.c
@@ -1,7 +1,8 @@
 /*
 * sata_mv.c - Marvell SATA support
 *
- * Copyright 2005: EMC Corporation, all rights reserved. 
+ * Copyright 2005: EMC Corporation, all rights reserved.
+ * Copyright 2005 Red Hat, Inc.  All rights reserved.
 *
 * Please ALWAYS copy linux-ide@vger.kernel.org on emails.
 *
@@ -36,7 +37,7 @@
 #include <asm/io.h>
 #define DRV_NAME        "sata_mv"
-#define DRV_VERSION     "0.25"
+#define DRV_VERSION     "0.5"
 enum {
        /* BAR's are enumerated in terms of pci_resource_start() terms */
@@ -50,6 +51,9 @@ enum {
        MV_PCI_REG_BASE         = 0,
        MV_IRQ_COAL_REG_BASE    = 0x18000,      /* 6xxx part only */
        MV_SATAHC0_REG_BASE     = 0x20000,
+        MV_FLASH_CTL            = 0x1046c,
+        MV_GPIO_PORT_CTL        = 0x104f0,
+        MV_RESET_CFG            = 0x180d8,
        MV_PCI_REG_SZ           = MV_MAJOR_REG_AREA_SZ,
        MV_SATAHC_REG_SZ        = MV_MAJOR_REG_AREA_SZ,
@@ -72,11 +76,6 @@ enum {
        MV_SG_TBL_SZ            = (16 * MV_MAX_SG_CT),
        MV_PORT_PRIV_DMA_SZ     = (MV_CRQB_Q_SZ + MV_CRPB_Q_SZ + MV_SG_TBL_SZ),
-        /* Our DMA boundary is determined by an ePRD being unable to handle
-         * anything larger than 64KB
-         */
-        MV_DMA_BOUNDARY         = 0xffffU,
        MV_PORTS_PER_HC         = 4,
        /* == (port / MV_PORTS_PER_HC) to determine HC from 0-7 port */
        MV_PORT_HC_SHIFT        = 2,
@@ -86,16 +85,9 @@ enum {
        /* Host Flags */
        MV_FLAG_DUAL_HC         = (1 << 30),  /* two SATA Host Controllers */
        MV_FLAG_IRQ_COALESCE    = (1 << 29),  /* IRQ coalescing capability */
-        MV_FLAG_GLBL_SFT_RST    = (1 << 28),  /* Global Soft Reset support */
        MV_COMMON_FLAGS         = (ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY |
                                   ATA_FLAG_SATA_RESET | ATA_FLAG_MMIO),
-        MV_6XXX_FLAGS           = (MV_FLAG_IRQ_COALESCE | 
+        MV_6XXX_FLAGS           = MV_FLAG_IRQ_COALESCE,
-                                   MV_FLAG_GLBL_SFT_RST),
-        chip_504x               = 0,
-        chip_508x               = 1,
-        chip_604x               = 2,
-        chip_608x               = 3,
        CRQB_FLAG_READ          = (1 << 0),
        CRQB_TAG_SHIFT          = 1,
@@ -116,8 +108,19 @@ enum {
        PCI_MASTER_EMPTY        = (1 << 3),
        GLOB_SFT_RST            = (1 << 4),
-        PCI_IRQ_CAUSE_OFS       = 0x1d58,
+        MV_PCI_MODE             = 0xd00,
-        PCI_IRQ_MASK_OFS        = 0x1d5c,
+        MV_PCI_EXP_ROM_BAR_CTL  = 0xd2c,
+        MV_PCI_DISC_TIMER       = 0xd04,
+        MV_PCI_MSI_TRIGGER      = 0xc38,
+        MV_PCI_SERR_MASK        = 0xc28,
+        MV_PCI_XBAR_TMOUT       = 0x1d04,
+        MV_PCI_ERR_LOW_ADDRESS  = 0x1d40,
+        MV_PCI_ERR_HIGH_ADDRESS = 0x1d44,
+        MV_PCI_ERR_ATTRIBUTE    = 0x1d48,
+        MV_PCI_ERR_COMMAND      = 0x1d50,
+        PCI_IRQ_CAUSE_OFS               = 0x1d58,
+        PCI_IRQ_MASK_OFS                = 0x1d5c,
        PCI_UNMASK_ALL_IRQS     = 0x7fffff,     /* bits 22-0 */
        HC_MAIN_IRQ_CAUSE_OFS   = 0x1d60,
@@ -134,7 +137,7 @@ enum {
        SELF_INT                = (1 << 23),
        TWSI_INT                = (1 << 24),
        HC_MAIN_RSVD            = (0x7f << 25), /* bits 31-25 */
-        HC_MAIN_MASKED_IRQS     = (TRAN_LO_DONE | TRAN_HI_DONE | 
+        HC_MAIN_MASKED_IRQS     = (TRAN_LO_DONE | TRAN_HI_DONE |
                                   PORTS_0_7_COAL_DONE | GPIO_INT | TWSI_INT |
                                   HC_MAIN_RSVD),
@@ -153,6 +156,15 @@ enum {
        /* SATA registers */
        SATA_STATUS_OFS         = 0x300,  /* ctrl, err regs follow status */
        SATA_ACTIVE_OFS         = 0x350,
+        PHY_MODE3               = 0x310,
+        PHY_MODE4               = 0x314,
+        PHY_MODE2               = 0x330,
+        MV5_PHY_MODE            = 0x74,
+        MV5_LT_MODE             = 0x30,
+        MV5_PHY_CTL             = 0x0C,
+        SATA_INTERFACE_CTL      = 0x050,
+        MV_M2_PREAMP_MASK       = 0x7e0,
        /* Port registers */
        EDMA_CFG_OFS            = 0,
@@ -182,17 +194,16 @@ enum {
        EDMA_ERR_LNK_CTRL_TX    = (0x1f << 21),
        EDMA_ERR_LNK_DATA_TX    = (0x1f << 26),
        EDMA_ERR_TRANS_PROTO    = (1 << 31),
-        EDMA_ERR_FATAL          = (EDMA_ERR_D_PAR | EDMA_ERR_PRD_PAR | 
+        EDMA_ERR_FATAL          = (EDMA_ERR_D_PAR | EDMA_ERR_PRD_PAR |
                                   EDMA_ERR_DEV_DCON | EDMA_ERR_CRBQ_PAR |
                                   EDMA_ERR_CRPB_PAR | EDMA_ERR_INTRL_PAR |
-                                   EDMA_ERR_IORDY | EDMA_ERR_LNK_CTRL_RX_2 | 
+                                   EDMA_ERR_IORDY | EDMA_ERR_LNK_CTRL_RX_2 |
                                   EDMA_ERR_LNK_DATA_RX |
-                                   EDMA_ERR_LNK_DATA_TX | 
+                                   EDMA_ERR_LNK_DATA_TX |
                                   EDMA_ERR_TRANS_PROTO),
        EDMA_REQ_Q_BASE_HI_OFS  = 0x10,
        EDMA_REQ_Q_IN_PTR_OFS   = 0x14,         /* also contains BASE_LO */
-        EDMA_REQ_Q_BASE_LO_MASK = 0xfffffc00U,
        EDMA_REQ_Q_OUT_PTR_OFS  = 0x18,
        EDMA_REQ_Q_PTR_SHIFT    = 5,
@@ -200,7 +211,6 @@ enum {
        EDMA_RSP_Q_BASE_HI_OFS  = 0x1c,
        EDMA_RSP_Q_IN_PTR_OFS   = 0x20,
        EDMA_RSP_Q_OUT_PTR_OFS  = 0x24,         /* also contains BASE_LO */
-        EDMA_RSP_Q_BASE_LO_MASK = 0xffffff00U,
        EDMA_RSP_Q_PTR_SHIFT    = 3,
        EDMA_CMD_OFS            = 0x28,
@@ -208,14 +218,44 @@ enum {
        EDMA_DS                 = (1 << 1),
        ATA_RST                 = (1 << 2),
+        EDMA_IORDY_TMOUT        = 0x34,
+        EDMA_ARB_CFG            = 0x38,
        /* Host private flags (hp_flags) */
        MV_HP_FLAG_MSI          = (1 << 0),
+        MV_HP_ERRATA_50XXB0     = (1 << 1),
+        MV_HP_ERRATA_50XXB2     = (1 << 2),
+        MV_HP_ERRATA_60X1B2     = (1 << 3),
+        MV_HP_ERRATA_60X1C0     = (1 << 4),
+        MV_HP_50XX              = (1 << 5),
        /* Port private flags (pp_flags) */
        MV_PP_FLAG_EDMA_EN      = (1 << 0),
        MV_PP_FLAG_EDMA_DS_ACT  = (1 << 1),
 };
+#define IS_50XX(hpriv) ((hpriv)->hp_flags & MV_HP_50XX)
+#define IS_60XX(hpriv) (((hpriv)->hp_flags & MV_HP_50XX) == 0)
+enum {
+        /* Our DMA boundary is determined by an ePRD being unable to handle
+         * anything larger than 64KB
+         */
+        MV_DMA_BOUNDARY         = 0xffffU,
+        EDMA_REQ_Q_BASE_LO_MASK = 0xfffffc00U,
+        EDMA_RSP_Q_BASE_LO_MASK = 0xffffff00U,
+};
+enum chip_type {
+        chip_504x,
+        chip_508x,
+        chip_5080,
+        chip_604x,
+        chip_608x,
+};
 /* Command ReQuest Block: 32B */
 struct mv_crqb {
        u32                     sg_addr;
@@ -252,14 +292,37 @@ struct mv_port_priv {
        u32                     pp_flags;
 };
+struct mv_port_signal {
+        u32                     amps;
+        u32                     pre;
+};
+struct mv_host_priv;
+struct mv_hw_ops {
+        void (*phy_errata)(struct mv_host_priv *hpriv, void __iomem *mmio,
+                           unsigned int port);
+        void (*enable_leds)(struct mv_host_priv *hpriv, void __iomem *mmio);
+        void (*read_preamp)(struct mv_host_priv *hpriv, int idx,
+                           void __iomem *mmio);
+        int (*reset_hc)(struct mv_host_priv *hpriv, void __iomem *mmio,
+                        unsigned int n_hc);
+        void (*reset_flash)(struct mv_host_priv *hpriv, void __iomem *mmio);
+        void (*reset_bus)(struct pci_dev *pdev, void __iomem *mmio);
+};
 struct mv_host_priv {
        u32                     hp_flags;
+        struct mv_port_signal   signal[8];
+        const struct mv_hw_ops  *ops;
 };
 static void mv_irq_clear(struct ata_port *ap);
 static u32 mv_scr_read(struct ata_port *ap, unsigned int sc_reg_in);
 static void mv_scr_write(struct ata_port *ap, unsigned int sc_reg_in, u32 val);
+static u32 mv5_scr_read(struct ata_port *ap, unsigned int sc_reg_in);
+static void mv5_scr_write(struct ata_port *ap, unsigned int sc_reg_in, u32 val);
 static void mv_phy_reset(struct ata_port *ap);
+static void __mv_phy_reset(struct ata_port *ap, int can_sleep);
 static void mv_host_stop(struct ata_host_set *host_set);
 static int mv_port_start(struct ata_port *ap);
 static void mv_port_stop(struct ata_port *ap);
@@ -270,6 +333,29 @@ static irqreturn_t mv_interrupt(int irq, void *dev_instance,
 static void mv_eng_timeout(struct ata_port *ap);
 static int mv_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
+static void mv5_phy_errata(struct mv_host_priv *hpriv, void __iomem *mmio,
+                           unsigned int port);
+static void mv5_enable_leds(struct mv_host_priv *hpriv, void __iomem *mmio);
+static void mv5_read_preamp(struct mv_host_priv *hpriv, int idx,
+                           void __iomem *mmio);
+static int mv5_reset_hc(struct mv_host_priv *hpriv, void __iomem *mmio,
+                        unsigned int n_hc);
+static void mv5_reset_flash(struct mv_host_priv *hpriv, void __iomem *mmio);
+static void mv5_reset_bus(struct pci_dev *pdev, void __iomem *mmio);
+static void mv6_phy_errata(struct mv_host_priv *hpriv, void __iomem *mmio,
+                           unsigned int port);
+static void mv6_enable_leds(struct mv_host_priv *hpriv, void __iomem *mmio);
+static void mv6_read_preamp(struct mv_host_priv *hpriv, int idx,
+                           void __iomem *mmio);
+static int mv6_reset_hc(struct mv_host_priv *hpriv, void __iomem *mmio,
+                        unsigned int n_hc);
+static void mv6_reset_flash(struct mv_host_priv *hpriv, void __iomem *mmio);
+static void mv_reset_pci_bus(struct pci_dev *pdev, void __iomem *mmio);
+static void mv_channel_reset(struct mv_host_priv *hpriv, void __iomem *mmio,
+                             unsigned int port_no);
+static void mv_stop_and_reset(struct ata_port *ap);
 static struct scsi_host_template mv_sht = {
        .module                 = THIS_MODULE,
        .name                   = DRV_NAME,
@@ -278,7 +364,7 @@ static struct scsi_host_template mv_sht = {
        .eh_strategy_handler    = ata_scsi_error,
        .can_queue              = MV_USE_Q_DEPTH,
        .this_id                = ATA_SHT_THIS_ID,
-        .sg_tablesize           = MV_MAX_SG_CT,
+        .sg_tablesize           = MV_MAX_SG_CT / 2,
        .max_sectors            = ATA_MAX_SECTORS,
        .cmd_per_lun            = ATA_SHT_CMD_PER_LUN,
        .emulated               = ATA_SHT_EMULATED,
@@ -290,7 +376,34 @@ static struct scsi_host_template mv_sht = {
        .ordered_flush          = 1,
 };
-static const struct ata_port_operations mv_ops = {
+static const struct ata_port_operations mv5_ops = {
+        .port_disable           = ata_port_disable,
+        .tf_load                = ata_tf_load,
+        .tf_read                = ata_tf_read,
+        .check_status           = ata_check_status,
+        .exec_command           = ata_exec_command,
+        .dev_select             = ata_std_dev_select,
+        .phy_reset              = mv_phy_reset,
+        .qc_prep                = mv_qc_prep,
+        .qc_issue               = mv_qc_issue,
+        .eng_timeout            = mv_eng_timeout,
+        .irq_handler            = mv_interrupt,
+        .irq_clear              = mv_irq_clear,
+        .scr_read               = mv5_scr_read,
+        .scr_write              = mv5_scr_write,
+        .port_start             = mv_port_start,
+        .port_stop              = mv_port_stop,
+        .host_stop              = mv_host_stop,
+};
+static const struct ata_port_operations mv6_ops = {
        .port_disable           = ata_port_disable,
        .tf_load                = ata_tf_load,
@@ -322,37 +435,44 @@ static struct ata_port_info mv_port_info[] = {
                .sht            = &mv_sht,
                .host_flags     = MV_COMMON_FLAGS,
                .pio_mask       = 0x1f, /* pio0-4 */
-                .udma_mask      = 0,    /* 0x7f (udma0-6 disabled for now) */
+                .udma_mask      = 0x7f, /* udma0-6 */
-                .port_ops       = &mv_ops,
+                .port_ops       = &mv5_ops,
        },
        {  /* chip_508x */
                .sht            = &mv_sht,
                .host_flags     = (MV_COMMON_FLAGS | MV_FLAG_DUAL_HC),
                .pio_mask       = 0x1f, /* pio0-4 */
-                .udma_mask      = 0,    /* 0x7f (udma0-6 disabled for now) */
+                .udma_mask      = 0x7f, /* udma0-6 */
-                .port_ops       = &mv_ops,
+                .port_ops       = &mv5_ops,
+        },
+        {  /* chip_5080 */
+                .sht            = &mv_sht,
+                .host_flags     = (MV_COMMON_FLAGS | MV_FLAG_DUAL_HC),
+                .pio_mask       = 0x1f, /* pio0-4 */
+                .udma_mask      = 0x7f, /* udma0-6 */
+                .port_ops       = &mv5_ops,
        },
        {  /* chip_604x */
                .sht            = &mv_sht,
                .host_flags     = (MV_COMMON_FLAGS | MV_6XXX_FLAGS),
                .pio_mask       = 0x1f, /* pio0-4 */
                .udma_mask      = 0x7f, /* udma0-6 */
-                .port_ops       = &mv_ops,
+                .port_ops       = &mv6_ops,
        },
        {  /* chip_608x */
                .sht            = &mv_sht,
-                .host_flags     = (MV_COMMON_FLAGS | MV_6XXX_FLAGS | 
+                .host_flags     = (MV_COMMON_FLAGS | MV_6XXX_FLAGS |
                                   MV_FLAG_DUAL_HC),
                .pio_mask       = 0x1f, /* pio0-4 */
                .udma_mask      = 0x7f, /* udma0-6 */
-                .port_ops       = &mv_ops,
+                .port_ops       = &mv6_ops,
        },
 };
 static const struct pci_device_id mv_pci_tbl[] = {
        {PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5040), 0, 0, chip_504x},
        {PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5041), 0, 0, chip_504x},
-        {PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5080), 0, 0, chip_508x},
+        {PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5080), 0, 0, chip_5080},
        {PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5081), 0, 0, chip_508x},
        {PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x6040), 0, 0, chip_604x},
@@ -371,6 +491,24 @@ static struct pci_driver mv_pci_driver = {
        .remove                 = ata_pci_remove_one,
 };
+static const struct mv_hw_ops mv5xxx_ops = {
+        .phy_errata             = mv5_phy_errata,
+        .enable_leds            = mv5_enable_leds,
+        .read_preamp            = mv5_read_preamp,
+        .reset_hc               = mv5_reset_hc,
+        .reset_flash            = mv5_reset_flash,
+        .reset_bus              = mv5_reset_bus,
+};
+static const struct mv_hw_ops mv6xxx_ops = {
+        .phy_errata             = mv6_phy_errata,
+        .enable_leds            = mv6_enable_leds,
+        .read_preamp            = mv6_read_preamp,
+        .reset_hc               = mv6_reset_hc,
+        .reset_flash            = mv6_reset_flash,
+        .reset_bus              = mv_reset_pci_bus,
+};
 /*
 * Functions
 */
@@ -386,11 +524,27 @@ static inline void __iomem *mv_hc_base(void __iomem *base, unsigned int hc)
        return (base + MV_SATAHC0_REG_BASE + (hc * MV_SATAHC_REG_SZ));
 }
+static inline unsigned int mv_hc_from_port(unsigned int port)
+{
+        return port >> MV_PORT_HC_SHIFT;
+}
+static inline unsigned int mv_hardport_from_port(unsigned int port)
+{
+        return port & MV_PORT_MASK;
+}
+static inline void __iomem *mv_hc_base_from_port(void __iomem *base,
+                                                 unsigned int port)
+{
+        return mv_hc_base(base, mv_hc_from_port(port));
+}
 static inline void __iomem *mv_port_base(void __iomem *base, unsigned int port)
 {
-        return (mv_hc_base(base, port >> MV_PORT_HC_SHIFT) +
+        return  mv_hc_base_from_port(base, port) +
-                MV_SATAHC_ARBTR_REG_SZ + 
+                MV_SATAHC_ARBTR_REG_SZ +
-                ((port & MV_PORT_MASK) * MV_PORT_REG_SZ));
+                (mv_hardport_from_port(port) * MV_PORT_REG_SZ);
 }
 static inline void __iomem *mv_ap_base(struct ata_port *ap)
@@ -398,9 +552,9 @@ static inline void __iomem *mv_ap_base(struct ata_port *ap)
        return mv_port_base(ap->host_set->mmio_base, ap->port_no);
 }
-static inline int mv_get_hc_count(unsigned long hp_flags)
+static inline int mv_get_hc_count(unsigned long host_flags)
 {
-        return ((hp_flags & MV_FLAG_DUAL_HC) ? 2 : 1);
+        return ((host_flags & MV_FLAG_DUAL_HC) ? 2 : 1);
 }
 static void mv_irq_clear(struct ata_port *ap)
@@ -452,7 +606,7 @@ static void mv_stop_dma(struct ata_port *ap)
        } else {
                assert(!(EDMA_EN & readl(port_mmio + EDMA_CMD_OFS)));
        }
-        
        /* now properly wait for the eDMA to stop */
        for (i = 1000; i > 0; i--) {
                reg = readl(port_mmio + EDMA_CMD_OFS);
@@ -503,7 +657,7 @@ static void mv_dump_all_regs(void __iomem *mmio_base, int port,
                             struct pci_dev *pdev)
 {
 #ifdef ATA_DEBUG
-        void __iomem *hc_base = mv_hc_base(mmio_base, 
+        void __iomem *hc_base = mv_hc_base(mmio_base,
                                           port >> MV_PORT_HC_SHIFT);
        void __iomem *port_base;
        int start_port, num_ports, p, start_hc, num_hcs, hc;
@@ -517,7 +671,7 @@ static void mv_dump_all_regs(void __iomem *mmio_base, int port,
                start_port = port;
                num_ports = num_hcs = 1;
        }
-        DPRINTK("All registers for port(s) %u-%u:\n", start_port, 
+        DPRINTK("All registers for port(s) %u-%u:\n", start_port,
                num_ports > 1 ? num_ports - 1 : start_port);
        if (NULL != pdev) {
@@ -585,70 +739,6 @@ static void mv_scr_write(struct ata_port *ap, unsigned int sc_reg_in, u32 val)
 }
 /**
- *      mv_global_soft_reset - Perform the 6xxx global soft reset
- *      @mmio_base: base address of the HBA
- *
- *      This routine only applies to 6xxx parts.
- *
- *      LOCKING:
- *      Inherited from caller.
- */
-static int mv_global_soft_reset(void __iomem *mmio_base)
-{
-        void __iomem *reg = mmio_base + PCI_MAIN_CMD_STS_OFS;
-        int i, rc = 0;
-        u32 t;
-        /* Following procedure defined in PCI "main command and status
-         * register" table.
-         */
-        t = readl(reg);
-        writel(t | STOP_PCI_MASTER, reg);
-        for (i = 0; i < 1000; i++) {
-                udelay(1);
-                t = readl(reg);
-                if (PCI_MASTER_EMPTY & t) {
-                        break;
-                }
-        }
-        if (!(PCI_MASTER_EMPTY & t)) {
-                printk(KERN_ERR DRV_NAME ": PCI master won't flush\n");
-                rc = 1;
-                goto done;
-        }
-        /* set reset */
-        i = 5;
-        do {
-                writel(t | GLOB_SFT_RST, reg);
-                t = readl(reg);
-                udelay(1);
-        } while (!(GLOB_SFT_RST & t) && (i-- > 0));
-        if (!(GLOB_SFT_RST & t)) {
-                printk(KERN_ERR DRV_NAME ": can't set global reset\n");
-                rc = 1;
-                goto done;
-        }
-        /* clear reset and *reenable the PCI master* (not mentioned in spec) */
-        i = 5;
-        do {
-                writel(t & ~(GLOB_SFT_RST | STOP_PCI_MASTER), reg);
-                t = readl(reg);
-                udelay(1);
-        } while ((GLOB_SFT_RST & t) && (i-- > 0));
-        if (GLOB_SFT_RST & t) {
-                printk(KERN_ERR DRV_NAME ": can't clear global reset\n");
-                rc = 1;
-        }
-done:
-        return rc;
-}
-/**
 *      mv_host_stop - Host specific cleanup/stop routine.
 *      @host_set: host data structure
 *
@@ -701,7 +791,7 @@ static int mv_port_start(struct ata_port *ap)
                goto err_out;
        memset(pp, 0, sizeof(*pp));
-        mem = dma_alloc_coherent(dev, MV_PORT_PRIV_DMA_SZ, &mem_dma, 
+        mem = dma_alloc_coherent(dev, MV_PORT_PRIV_DMA_SZ, &mem_dma,
                                 GFP_KERNEL);
        if (!mem)
                goto err_out_pp;
@@ -711,7 +801,7 @@ static int mv_port_start(struct ata_port *ap)
        if (rc)
                goto err_out_priv;
-        /* First item in chunk of DMA memory: 
+        /* First item in chunk of DMA memory:
         * 32-slot command request table (CRQB), 32 bytes each in size
         */
        pp->crqb = mem;
@@ -719,7 +809,7 @@ static int mv_port_start(struct ata_port *ap)
        mem += MV_CRQB_Q_SZ;
        mem_dma += MV_CRQB_Q_SZ;
-        /* Second item: 
+        /* Second item:
         * 32-slot command response table (CRPB), 8 bytes each in size
         */
        pp->crpb = mem;
@@ -733,18 +823,18 @@ static int mv_port_start(struct ata_port *ap)
        pp->sg_tbl = mem;
        pp->sg_tbl_dma = mem_dma;
-        writelfl(EDMA_CFG_Q_DEPTH | EDMA_CFG_RD_BRST_EXT | 
+        writelfl(EDMA_CFG_Q_DEPTH | EDMA_CFG_RD_BRST_EXT |
                 EDMA_CFG_WR_BUFF_LEN, port_mmio + EDMA_CFG_OFS);
        writel((pp->crqb_dma >> 16) >> 16, port_mmio + EDMA_REQ_Q_BASE_HI_OFS);
-        writelfl(pp->crqb_dma & EDMA_REQ_Q_BASE_LO_MASK, 
+        writelfl(pp->crqb_dma & EDMA_REQ_Q_BASE_LO_MASK,
                 port_mmio + EDMA_REQ_Q_IN_PTR_OFS);
        writelfl(0, port_mmio + EDMA_REQ_Q_OUT_PTR_OFS);
        writelfl(0, port_mmio + EDMA_RSP_Q_IN_PTR_OFS);
        writel((pp->crpb_dma >> 16) >> 16, port_mmio + EDMA_RSP_Q_BASE_HI_OFS);
-        writelfl(pp->crpb_dma & EDMA_RSP_Q_BASE_LO_MASK, 
+        writelfl(pp->crpb_dma & EDMA_RSP_Q_BASE_LO_MASK,
                 port_mmio + EDMA_RSP_Q_OUT_PTR_OFS);
        pp->req_producer = pp->rsp_consumer = 0;
@@ -805,20 +895,30 @@ static void mv_fill_sg(struct ata_queued_cmd *qc)
        struct scatterlist *sg;
        ata_for_each_sg(sg, qc) {
-                u32 sg_len;
                dma_addr_t addr;
+                u32 sg_len, len, offset;
                addr = sg_dma_address(sg);
                sg_len = sg_dma_len(sg);
-                pp->sg_tbl[i].addr = cpu_to_le32(addr & 0xffffffff);
+                while (sg_len) {
-                pp->sg_tbl[i].addr_hi = cpu_to_le32((addr >> 16) >> 16);
+                        offset = addr & MV_DMA_BOUNDARY;
-                assert(0 == (sg_len & ~MV_DMA_BOUNDARY));
+                        len = sg_len;
-                pp->sg_tbl[i].flags_size = cpu_to_le32(sg_len);
+                        if ((offset + sg_len) > 0x10000)
-                if (ata_sg_is_last(sg, qc))
+                                len = 0x10000 - offset;
-                        pp->sg_tbl[i].flags_size |= cpu_to_le32(EPRD_FLAG_END_OF_TBL);
+                        pp->sg_tbl[i].addr = cpu_to_le32(addr & 0xffffffff);
+                        pp->sg_tbl[i].addr_hi = cpu_to_le32((addr >> 16) >> 16);
+                        pp->sg_tbl[i].flags_size = cpu_to_le32(len);
+                        sg_len -= len;
+                        addr += len;
+                        if (!sg_len && ata_sg_is_last(sg, qc))
+                                pp->sg_tbl[i].flags_size |= cpu_to_le32(EPRD_FLAG_END_OF_TBL);
-                i++;
+                        i++;
+                }
        }
 }
@@ -859,7 +959,7 @@ static void mv_qc_prep(struct ata_queued_cmd *qc)
        }
        /* the req producer index should be the same as we remember it */
-        assert(((readl(mv_ap_base(qc->ap) + EDMA_REQ_Q_IN_PTR_OFS) >> 
+        assert(((readl(mv_ap_base(qc->ap) + EDMA_REQ_Q_IN_PTR_OFS) >>
                 EDMA_REQ_Q_PTR_SHIFT) & MV_MAX_Q_DEPTH_MASK) ==
               pp->req_producer);
@@ -871,9 +971,9 @@ static void mv_qc_prep(struct ata_queued_cmd *qc)
        assert(MV_MAX_Q_DEPTH > qc->tag);
        flags |= qc->tag << CRQB_TAG_SHIFT;
-        pp->crqb[pp->req_producer].sg_addr = 
+        pp->crqb[pp->req_producer].sg_addr =
                cpu_to_le32(pp->sg_tbl_dma & 0xffffffff);
-        pp->crqb[pp->req_producer].sg_addr_hi = 
+        pp->crqb[pp->req_producer].sg_addr_hi =
                cpu_to_le32((pp->sg_tbl_dma >> 16) >> 16);
        pp->crqb[pp->req_producer].ctrl_flags = cpu_to_le16(flags);
@@ -896,7 +996,7 @@ static void mv_qc_prep(struct ata_queued_cmd *qc)
 #ifdef LIBATA_NCQ               /* FIXME: remove this line when NCQ added */
        case ATA_CMD_FPDMA_READ:
        case ATA_CMD_FPDMA_WRITE:
-                mv_crqb_pack_cmd(cw++, tf->hob_feature, ATA_REG_FEATURE, 0); 
+                mv_crqb_pack_cmd(cw++, tf->hob_feature, ATA_REG_FEATURE, 0);
                mv_crqb_pack_cmd(cw++, tf->feature, ATA_REG_FEATURE, 0);
                break;
 #endif                          /* FIXME: remove this line when NCQ added */
@@ -962,7 +1062,7 @@ static int mv_qc_issue(struct ata_queued_cmd *qc)
               pp->req_producer);
        /* until we do queuing, the queue should be empty at this point */
        assert(((in_ptr >> EDMA_REQ_Q_PTR_SHIFT) & MV_MAX_Q_DEPTH_MASK) ==
-               ((readl(port_mmio + EDMA_REQ_Q_OUT_PTR_OFS) >> 
+               ((readl(port_mmio + EDMA_REQ_Q_OUT_PTR_OFS) >>
                 EDMA_REQ_Q_PTR_SHIFT) & MV_MAX_Q_DEPTH_MASK));
        mv_inc_q_index(&pp->req_producer);      /* now incr producer index */
@@ -999,15 +1099,15 @@ static u8 mv_get_crpb_status(struct ata_port *ap)
        out_ptr = readl(port_mmio + EDMA_RSP_Q_OUT_PTR_OFS);
        /* the response consumer index should be the same as we remember it */
-        assert(((out_ptr >> EDMA_RSP_Q_PTR_SHIFT) & MV_MAX_Q_DEPTH_MASK) == 
+        assert(((out_ptr >> EDMA_RSP_Q_PTR_SHIFT) & MV_MAX_Q_DEPTH_MASK) ==
               pp->rsp_consumer);
        /* increment our consumer index... */
        pp->rsp_consumer = mv_inc_q_index(&pp->rsp_consumer);
-        
        /* and, until we do NCQ, there should only be 1 CRPB waiting */
-        assert(((readl(port_mmio + EDMA_RSP_Q_IN_PTR_OFS) >> 
+        assert(((readl(port_mmio + EDMA_RSP_Q_IN_PTR_OFS) >>
-                 EDMA_RSP_Q_PTR_SHIFT) & MV_MAX_Q_DEPTH_MASK) == 
+                 EDMA_RSP_Q_PTR_SHIFT) & MV_MAX_Q_DEPTH_MASK) ==
               pp->rsp_consumer);
        /* write out our inc'd consumer index so EDMA knows we're caught up */
@@ -1055,7 +1155,7 @@ static void mv_err_intr(struct ata_port *ap)
        /* check for fatal here and recover if needed */
        if (EDMA_ERR_FATAL & edma_err_cause) {
-                mv_phy_reset(ap);
+                mv_stop_and_reset(ap);
        }
 }
@@ -1120,6 +1220,10 @@ static void mv_host_intr(struct ata_host_set *host_set, u32 relevant,
                        handled++;
                }
+                if (ap &&
+                    (ap->flags & (ATA_FLAG_PORT_DISABLED | ATA_FLAG_NOINTR)))
+                        continue;
                err_mask = ac_err_mask(ata_status);
                shift = port << 1;              /* (port * 2) */
@@ -1131,14 +1235,15 @@ static void mv_host_intr(struct ata_host_set *host_set, u32 relevant,
                        err_mask |= AC_ERR_OTHER;
                        handled++;
                }
-                
                if (handled && ap) {
                        qc = ata_qc_from_tag(ap, ap->active_tag);
                        if (NULL != qc) {
                                VPRINTK("port %u IRQ found for qc, "
                                        "ata_status 0x%x\n", port,ata_status);
                                /* mark qc status appropriately */
-                                ata_qc_complete(qc, err_mask);
+                                if (!(qc->tf.ctl & ATA_NIEN))
+                                        ata_qc_complete(qc, err_mask);
                        }
                }
        }
@@ -1146,7 +1251,7 @@ static void mv_host_intr(struct ata_host_set *host_set, u32 relevant,
 }
 /**
- *      mv_interrupt - 
+ *      mv_interrupt -
 *      @irq: unused
 *      @dev_instance: private data; in this case the host structure
 *      @regs: unused
@@ -1156,7 +1261,7 @@ static void mv_host_intr(struct ata_host_set *host_set, u32 relevant,
 *      routine to handle.  Also check for PCI errors which are only
 *      reported here.
 *
- *      LOCKING: 
+ *      LOCKING:
 *      This routine holds the host_set lock while processing pending
 *      interrupts.
 */
@@ -1202,8 +1307,422 @@ static irqreturn_t mv_interrupt(int irq, void *dev_instance,
        return IRQ_RETVAL(handled);
 }
+static void __iomem *mv5_phy_base(void __iomem *mmio, unsigned int port)
+{
+        void __iomem *hc_mmio = mv_hc_base_from_port(mmio, port);
+        unsigned long ofs = (mv_hardport_from_port(port) + 1) * 0x100UL;
+        return hc_mmio + ofs;
+}
+static unsigned int mv5_scr_offset(unsigned int sc_reg_in)
+{
+        unsigned int ofs;
+        switch (sc_reg_in) {
+        case SCR_STATUS:
+        case SCR_ERROR:
+        case SCR_CONTROL:
+                ofs = sc_reg_in * sizeof(u32);
+                break;
+        default:
+                ofs = 0xffffffffU;
+                break;
+        }
+        return ofs;
+}
+static u32 mv5_scr_read(struct ata_port *ap, unsigned int sc_reg_in)
+{
+        void __iomem *mmio = mv5_phy_base(ap->host_set->mmio_base, ap->port_no);
+        unsigned int ofs = mv5_scr_offset(sc_reg_in);
+        if (ofs != 0xffffffffU)
+                return readl(mmio + ofs);
+        else
+                return (u32) ofs;
+}
+static void mv5_scr_write(struct ata_port *ap, unsigned int sc_reg_in, u32 val)
+{
+        void __iomem *mmio = mv5_phy_base(ap->host_set->mmio_base, ap->port_no);
+        unsigned int ofs = mv5_scr_offset(sc_reg_in);
+        if (ofs != 0xffffffffU)
+                writelfl(val, mmio + ofs);
+}
+static void mv5_reset_bus(struct pci_dev *pdev, void __iomem *mmio)
+{
+        u8 rev_id;
+        int early_5080;
+        pci_read_config_byte(pdev, PCI_REVISION_ID, &rev_id);
+        early_5080 = (pdev->device == 0x5080) && (rev_id == 0);
+        if (!early_5080) {
+                u32 tmp = readl(mmio + MV_PCI_EXP_ROM_BAR_CTL);
+                tmp |= (1 << 0);
+                writel(tmp, mmio + MV_PCI_EXP_ROM_BAR_CTL);
+        }
+        mv_reset_pci_bus(pdev, mmio);
+}
+static void mv5_reset_flash(struct mv_host_priv *hpriv, void __iomem *mmio)
+{
+        writel(0x0fcfffff, mmio + MV_FLASH_CTL);
+}
+static void mv5_read_preamp(struct mv_host_priv *hpriv, int idx,
+                           void __iomem *mmio)
+{
+        void __iomem *phy_mmio = mv5_phy_base(mmio, idx);
+        u32 tmp;
+        tmp = readl(phy_mmio + MV5_PHY_MODE);
+        hpriv->signal[idx].pre = tmp & 0x1800;  /* bits 12:11 */
+        hpriv->signal[idx].amps = tmp & 0xe0;   /* bits 7:5 */
+}
+static void mv5_enable_leds(struct mv_host_priv *hpriv, void __iomem *mmio)
+{
+        u32 tmp;
+        writel(0, mmio + MV_GPIO_PORT_CTL);
+        /* FIXME: handle MV_HP_ERRATA_50XXB2 errata */
+        tmp = readl(mmio + MV_PCI_EXP_ROM_BAR_CTL);
+        tmp |= ~(1 << 0);
+        writel(tmp, mmio + MV_PCI_EXP_ROM_BAR_CTL);
+}
+static void mv5_phy_errata(struct mv_host_priv *hpriv, void __iomem *mmio,
+                           unsigned int port)
+{
+        void __iomem *phy_mmio = mv5_phy_base(mmio, port);
+        const u32 mask = (1<<12) | (1<<11) | (1<<7) | (1<<6) | (1<<5);
+        u32 tmp;
+        int fix_apm_sq = (hpriv->hp_flags & MV_HP_ERRATA_50XXB0);
+        if (fix_apm_sq) {
+                tmp = readl(phy_mmio + MV5_LT_MODE);
+                tmp |= (1 << 19);
+                writel(tmp, phy_mmio + MV5_LT_MODE);
+                tmp = readl(phy_mmio + MV5_PHY_CTL);
+                tmp &= ~0x3;
+                tmp |= 0x1;
+                writel(tmp, phy_mmio + MV5_PHY_CTL);
+        }
+        tmp = readl(phy_mmio + MV5_PHY_MODE);
+        tmp &= ~mask;
+        tmp |= hpriv->signal[port].pre;
+        tmp |= hpriv->signal[port].amps;
+        writel(tmp, phy_mmio + MV5_PHY_MODE);
+}
+#undef ZERO
+#define ZERO(reg) writel(0, port_mmio + (reg))
+static void mv5_reset_hc_port(struct mv_host_priv *hpriv, void __iomem *mmio,
+                             unsigned int port)
+{
+        void __iomem *port_mmio = mv_port_base(mmio, port);
+        writelfl(EDMA_DS, port_mmio + EDMA_CMD_OFS);
+        mv_channel_reset(hpriv, mmio, port);
+        ZERO(0x028);    /* command */
+        writel(0x11f, port_mmio + EDMA_CFG_OFS);
+        ZERO(0x004);    /* timer */
+        ZERO(0x008);    /* irq err cause */
+        ZERO(0x00c);    /* irq err mask */
+        ZERO(0x010);    /* rq bah */
+        ZERO(0x014);    /* rq inp */
+        ZERO(0x018);    /* rq outp */
+        ZERO(0x01c);    /* respq bah */
+        ZERO(0x024);    /* respq outp */
+        ZERO(0x020);    /* respq inp */
+        ZERO(0x02c);    /* test control */
+        writel(0xbc, port_mmio + EDMA_IORDY_TMOUT);
+}
+#undef ZERO
+#define ZERO(reg) writel(0, hc_mmio + (reg))
+static void mv5_reset_one_hc(struct mv_host_priv *hpriv, void __iomem *mmio,
+                        unsigned int hc)
+{
+        void __iomem *hc_mmio = mv_hc_base(mmio, hc);
+        u32 tmp;
+        ZERO(0x00c);
+        ZERO(0x010);
+        ZERO(0x014);
+        ZERO(0x018);
+        tmp = readl(hc_mmio + 0x20);
+        tmp &= 0x1c1c1c1c;
+        tmp |= 0x03030303;
+        writel(tmp, hc_mmio + 0x20);
+}
+#undef ZERO
+static int mv5_reset_hc(struct mv_host_priv *hpriv, void __iomem *mmio,
+                        unsigned int n_hc)
+{
+        unsigned int hc, port;
+        for (hc = 0; hc < n_hc; hc++) {
+                for (port = 0; port < MV_PORTS_PER_HC; port++)
+                        mv5_reset_hc_port(hpriv, mmio,
+                                          (hc * MV_PORTS_PER_HC) + port);
+                mv5_reset_one_hc(hpriv, mmio, hc);
+        }
+        return 0;
+}
+#undef ZERO
+#define ZERO(reg) writel(0, mmio + (reg))
+static void mv_reset_pci_bus(struct pci_dev *pdev, void __iomem *mmio)
+{
+        u32 tmp;
+        tmp = readl(mmio + MV_PCI_MODE);
+        tmp &= 0xff00ffff;
+        writel(tmp, mmio + MV_PCI_MODE);
+        ZERO(MV_PCI_DISC_TIMER);
+        ZERO(MV_PCI_MSI_TRIGGER);
+        writel(0x000100ff, mmio + MV_PCI_XBAR_TMOUT);
+        ZERO(HC_MAIN_IRQ_MASK_OFS);
+        ZERO(MV_PCI_SERR_MASK);
+        ZERO(PCI_IRQ_CAUSE_OFS);
+        ZERO(PCI_IRQ_MASK_OFS);
+        ZERO(MV_PCI_ERR_LOW_ADDRESS);
+        ZERO(MV_PCI_ERR_HIGH_ADDRESS);
+        ZERO(MV_PCI_ERR_ATTRIBUTE);
+        ZERO(MV_PCI_ERR_COMMAND);
+}
+#undef ZERO
+static void mv6_reset_flash(struct mv_host_priv *hpriv, void __iomem *mmio)
+{
+        u32 tmp;
+        mv5_reset_flash(hpriv, mmio);
+        tmp = readl(mmio + MV_GPIO_PORT_CTL);
+        tmp &= 0x3;
+        tmp |= (1 << 5) | (1 << 6);
+        writel(tmp, mmio + MV_GPIO_PORT_CTL);
+}
+/**
+ *      mv6_reset_hc - Perform the 6xxx global soft reset
+ *      @mmio: base address of the HBA
+ *
+ *      This routine only applies to 6xxx parts.
+ *
+ *      LOCKING:
+ *      Inherited from caller.
+ */
+static int mv6_reset_hc(struct mv_host_priv *hpriv, void __iomem *mmio,
+                        unsigned int n_hc)
+{
+        void __iomem *reg = mmio + PCI_MAIN_CMD_STS_OFS;
+        int i, rc = 0;
+        u32 t;
+        /* Following procedure defined in PCI "main command and status
+         * register" table.
+         */
+        t = readl(reg);
+        writel(t | STOP_PCI_MASTER, reg);
+        for (i = 0; i < 1000; i++) {
+                udelay(1);
+                t = readl(reg);
+                if (PCI_MASTER_EMPTY & t) {
+                        break;
+                }
+        }
+        if (!(PCI_MASTER_EMPTY & t)) {
+                printk(KERN_ERR DRV_NAME ": PCI master won't flush\n");
+                rc = 1;
+                goto done;
+        }
+        /* set reset */
+        i = 5;
+        do {
+                writel(t | GLOB_SFT_RST, reg);
+                t = readl(reg);
+                udelay(1);
+        } while (!(GLOB_SFT_RST & t) && (i-- > 0));
+        if (!(GLOB_SFT_RST & t)) {
+                printk(KERN_ERR DRV_NAME ": can't set global reset\n");
+                rc = 1;
+                goto done;
+        }
+        /* clear reset and *reenable the PCI master* (not mentioned in spec) */
+        i = 5;
+        do {
+                writel(t & ~(GLOB_SFT_RST | STOP_PCI_MASTER), reg);
+                t = readl(reg);
+                udelay(1);
+        } while ((GLOB_SFT_RST & t) && (i-- > 0));
+        if (GLOB_SFT_RST & t) {
+                printk(KERN_ERR DRV_NAME ": can't clear global reset\n");
+                rc = 1;
+        }
+done:
+        return rc;
+}
+static void mv6_read_preamp(struct mv_host_priv *hpriv, int idx,
+                           void __iomem *mmio)
+{
+        void __iomem *port_mmio;
+        u32 tmp;
+        tmp = readl(mmio + MV_RESET_CFG);
+        if ((tmp & (1 << 0)) == 0) {
+                hpriv->signal[idx].amps = 0x7 << 8;
+                hpriv->signal[idx].pre = 0x1 << 5;
+                return;
+        }
+        port_mmio = mv_port_base(mmio, idx);
+        tmp = readl(port_mmio + PHY_MODE2);
+        hpriv->signal[idx].amps = tmp & 0x700;  /* bits 10:8 */
+        hpriv->signal[idx].pre = tmp & 0xe0;    /* bits 7:5 */
+}
+static void mv6_enable_leds(struct mv_host_priv *hpriv, void __iomem *mmio)
+{
+        writel(0x00000060, mmio + MV_GPIO_PORT_CTL);
+}
+static void mv6_phy_errata(struct mv_host_priv *hpriv, void __iomem *mmio,
+                           unsigned int port)
+{
+        void __iomem *port_mmio = mv_port_base(mmio, port);
+        u32 hp_flags = hpriv->hp_flags;
+        int fix_phy_mode2 =
+                hp_flags & (MV_HP_ERRATA_60X1B2 | MV_HP_ERRATA_60X1C0);
+        int fix_phy_mode4 =
+                hp_flags & (MV_HP_ERRATA_60X1B2 | MV_HP_ERRATA_60X1C0);
+        u32 m2, tmp;
+        if (fix_phy_mode2) {
+                m2 = readl(port_mmio + PHY_MODE2);
+                m2 &= ~(1 << 16);
+                m2 |= (1 << 31);
+                writel(m2, port_mmio + PHY_MODE2);
+                udelay(200);
+                m2 = readl(port_mmio + PHY_MODE2);
+                m2 &= ~((1 << 16) | (1 << 31));
+                writel(m2, port_mmio + PHY_MODE2);
+                udelay(200);
+        }
+        /* who knows what this magic does */
+        tmp = readl(port_mmio + PHY_MODE3);
+        tmp &= ~0x7F800000;
+        tmp |= 0x2A800000;
+        writel(tmp, port_mmio + PHY_MODE3);
+        if (fix_phy_mode4) {
+                u32 m4;
+                m4 = readl(port_mmio + PHY_MODE4);
+                if (hp_flags & MV_HP_ERRATA_60X1B2)
+                        tmp = readl(port_mmio + 0x310);
+                m4 = (m4 & ~(1 << 1)) | (1 << 0);
+                writel(m4, port_mmio + PHY_MODE4);
+                if (hp_flags & MV_HP_ERRATA_60X1B2)
+                        writel(tmp, port_mmio + 0x310);
+        }
+        /* Revert values of pre-emphasis and signal amps to the saved ones */
+        m2 = readl(port_mmio + PHY_MODE2);
+        m2 &= ~MV_M2_PREAMP_MASK;
+        m2 |= hpriv->signal[port].amps;
+        m2 |= hpriv->signal[port].pre;
+        m2 &= ~(1 << 16);
+        writel(m2, port_mmio + PHY_MODE2);
+}
+static void mv_channel_reset(struct mv_host_priv *hpriv, void __iomem *mmio,
+                             unsigned int port_no)
+{
+        void __iomem *port_mmio = mv_port_base(mmio, port_no);
+        writelfl(ATA_RST, port_mmio + EDMA_CMD_OFS);
+        if (IS_60XX(hpriv)) {
+                u32 ifctl = readl(port_mmio + SATA_INTERFACE_CTL);
+                ifctl |= (1 << 12) | (1 << 7);
+                writelfl(ifctl, port_mmio + SATA_INTERFACE_CTL);
+        }
+        udelay(25);             /* allow reset propagation */
+        /* Spec never mentions clearing the bit.  Marvell's driver does
+         * clear the bit, however.
+         */
+        writelfl(0, port_mmio + EDMA_CMD_OFS);
+        hpriv->ops->phy_errata(hpriv, mmio, port_no);
+        if (IS_50XX(hpriv))
+                mdelay(1);
+}
+static void mv_stop_and_reset(struct ata_port *ap)
+{
+        struct mv_host_priv *hpriv = ap->host_set->private_data;
+        void __iomem *mmio = ap->host_set->mmio_base;
+        mv_stop_dma(ap);
+        mv_channel_reset(hpriv, mmio, ap->port_no);
+        __mv_phy_reset(ap, 0);
+}
+static inline void __msleep(unsigned int msec, int can_sleep)
+{
+        if (can_sleep)
+                msleep(msec);
+        else
+                mdelay(msec);
+}
 /**
- *      mv_phy_reset - Perform eDMA reset followed by COMRESET
+ *      __mv_phy_reset - Perform eDMA reset followed by COMRESET
 *      @ap: ATA channel to manipulate
 *
 *      Part of this is taken from __sata_phy_reset and modified to
@@ -1213,41 +1732,47 @@ static irqreturn_t mv_interrupt(int irq, void *dev_instance,
 *      Inherited from caller.  This is coded to safe to call at
 *      interrupt level, i.e. it does not sleep.
 */
-static void mv_phy_reset(struct ata_port *ap)
+static void __mv_phy_reset(struct ata_port *ap, int can_sleep)
 {
+        struct mv_port_priv *pp = ap->private_data;
+        struct mv_host_priv *hpriv = ap->host_set->private_data;
        void __iomem *port_mmio = mv_ap_base(ap);
        struct ata_taskfile tf;
        struct ata_device *dev = &ap->device[0];
        unsigned long timeout;
+        int retry = 5;
+        u32 sstatus;
        VPRINTK("ENTER, port %u, mmio 0x%p\n", ap->port_no, port_mmio);
-        mv_stop_dma(ap);
+        DPRINTK("S-regs after ATA_RST: SStat 0x%08x SErr 0x%08x "
-        writelfl(ATA_RST, port_mmio + EDMA_CMD_OFS);
-        udelay(25);             /* allow reset propagation */
-        /* Spec never mentions clearing the bit.  Marvell's driver does
-         * clear the bit, however.
-         */
-        writelfl(0, port_mmio + EDMA_CMD_OFS);
-        VPRINTK("S-regs after ATA_RST: SStat 0x%08x SErr 0x%08x "
                "SCtrl 0x%08x\n", mv_scr_read(ap, SCR_STATUS),
                mv_scr_read(ap, SCR_ERROR), mv_scr_read(ap, SCR_CONTROL));
-        /* proceed to init communications via the scr_control reg */
+        /* Issue COMRESET via SControl */
+comreset_retry:
        scr_write_flush(ap, SCR_CONTROL, 0x301);
-        mdelay(1);
+        __msleep(1, can_sleep);
        scr_write_flush(ap, SCR_CONTROL, 0x300);
-        timeout = jiffies + (HZ * 1);
+        __msleep(20, can_sleep);
+        timeout = jiffies + msecs_to_jiffies(200);
        do {
-                mdelay(10);
+                sstatus = scr_read(ap, SCR_STATUS) & 0x3;
-                if ((scr_read(ap, SCR_STATUS) & 0xf) != 1)
+                if ((sstatus == 3) || (sstatus == 0))
                        break;
+                __msleep(1, can_sleep);
        } while (time_before(jiffies, timeout));
-        VPRINTK("S-regs after PHY wake: SStat 0x%08x SErr 0x%08x "
+        /* work around errata */
+        if (IS_60XX(hpriv) &&
+            (sstatus != 0x0) && (sstatus != 0x113) && (sstatus != 0x123) &&
+            (retry-- > 0))
+                goto comreset_retry;
+        DPRINTK("S-regs after PHY wake: SStat 0x%08x SErr 0x%08x "
                "SCtrl 0x%08x\n", mv_scr_read(ap, SCR_STATUS),
                mv_scr_read(ap, SCR_ERROR), mv_scr_read(ap, SCR_CONTROL));
@@ -1261,6 +1786,21 @@ static void mv_phy_reset(struct ata_port *ap)
        }
        ap->cbl = ATA_CBL_SATA;
+        /* even after SStatus reflects that device is ready,
+         * it seems to take a while for link to be fully
+         * established (and thus Status no longer 0x80/0x7F),
+         * so we poll a bit for that, here.
+         */
+        retry = 20;
+        while (1) {
+                u8 drv_stat = ata_check_status(ap);
+                if ((drv_stat != 0x80) && (drv_stat != 0x7f))
+                        break;
+                __msleep(500, can_sleep);
+                if (retry-- <= 0)
+                        break;
+        }
        tf.lbah = readb((void __iomem *) ap->ioaddr.lbah_addr);
        tf.lbam = readb((void __iomem *) ap->ioaddr.lbam_addr);
        tf.lbal = readb((void __iomem *) ap->ioaddr.lbal_addr);
@@ -1271,9 +1811,19 @@ static void mv_phy_reset(struct ata_port *ap)
                VPRINTK("Port disabled post-sig: No device present.\n");
                ata_port_disable(ap);
        }
+        writelfl(0, port_mmio + EDMA_ERR_IRQ_CAUSE_OFS);
+        pp->pp_flags &= ~MV_PP_FLAG_EDMA_EN;
        VPRINTK("EXIT\n");
 }
+static void mv_phy_reset(struct ata_port *ap)
+{
+        __mv_phy_reset(ap, 1);
+}
 /**
 *      mv_eng_timeout - Routine called by libata when SCSI times out I/O
 *      @ap: ATA channel to manipulate
@@ -1291,16 +1841,16 @@ static void mv_eng_timeout(struct ata_port *ap)
        printk(KERN_ERR "ata%u: Entering mv_eng_timeout\n",ap->id);
        DPRINTK("All regs @ start of eng_timeout\n");
-        mv_dump_all_regs(ap->host_set->mmio_base, ap->port_no, 
+        mv_dump_all_regs(ap->host_set->mmio_base, ap->port_no,
                         to_pci_dev(ap->host_set->dev));
        qc = ata_qc_from_tag(ap, ap->active_tag);
        printk(KERN_ERR "mmio_base %p ap %p qc %p scsi_cmnd %p &cmnd %p\n",
-               ap->host_set->mmio_base, ap, qc, qc->scsicmd, 
+               ap->host_set->mmio_base, ap, qc, qc->scsicmd,
               &qc->scsicmd->cmnd);
        mv_err_intr(ap);
-        mv_phy_reset(ap);
+        mv_stop_and_reset(ap);
        if (!qc) {
                printk(KERN_ERR "ata%u: BUG: timeout without command\n",
@@ -1336,17 +1886,17 @@ static void mv_port_init(struct ata_ioports *port,  void __iomem *port_mmio)
        unsigned long shd_base = (unsigned long) port_mmio + SHD_BLK_OFS;
        unsigned serr_ofs;
-        /* PIO related setup 
+        /* PIO related setup
         */
        port->data_addr = shd_base + (sizeof(u32) * ATA_REG_DATA);
-        port->error_addr = 
+        port->error_addr =
                port->feature_addr = shd_base + (sizeof(u32) * ATA_REG_ERR);
        port->nsect_addr = shd_base + (sizeof(u32) * ATA_REG_NSECT);
        port->lbal_addr = shd_base + (sizeof(u32) * ATA_REG_LBAL);
        port->lbam_addr = shd_base + (sizeof(u32) * ATA_REG_LBAM);
        port->lbah_addr = shd_base + (sizeof(u32) * ATA_REG_LBAH);
        port->device_addr = shd_base + (sizeof(u32) * ATA_REG_DEVICE);
-        port->status_addr = 
+        port->status_addr =
                port->command_addr = shd_base + (sizeof(u32) * ATA_REG_STATUS);
        /* special case: control/altstatus doesn't have ATA_REG_ address */
        port->altstatus_addr = port->ctl_addr = shd_base + SHD_CTL_AST_OFS;
@@ -1362,14 +1912,92 @@ static void mv_port_init(struct ata_ioports *port,  void __iomem *port_mmio)
        /* unmask all EDMA error interrupts */
        writelfl(~0, port_mmio + EDMA_ERR_IRQ_MASK_OFS);
-        VPRINTK("EDMA cfg=0x%08x EDMA IRQ err cause/mask=0x%08x/0x%08x\n", 
+        VPRINTK("EDMA cfg=0x%08x EDMA IRQ err cause/mask=0x%08x/0x%08x\n",
                readl(port_mmio + EDMA_CFG_OFS),
                readl(port_mmio + EDMA_ERR_IRQ_CAUSE_OFS),
                readl(port_mmio + EDMA_ERR_IRQ_MASK_OFS));
 }
+static int mv_chip_id(struct pci_dev *pdev, struct mv_host_priv *hpriv,
+                      unsigned int board_idx)
+{
+        u8 rev_id;
+        u32 hp_flags = hpriv->hp_flags;
+        pci_read_config_byte(pdev, PCI_REVISION_ID, &rev_id);
+        switch(board_idx) {
+        case chip_5080:
+                hpriv->ops = &mv5xxx_ops;
+                hp_flags |= MV_HP_50XX;
+                switch (rev_id) {
+                case 0x1:
+                        hp_flags |= MV_HP_ERRATA_50XXB0;
+                        break;
+                case 0x3:
+                        hp_flags |= MV_HP_ERRATA_50XXB2;
+                        break;
+                default:
+                        dev_printk(KERN_WARNING, &pdev->dev,
+                           "Applying 50XXB2 workarounds to unknown rev\n");
+                        hp_flags |= MV_HP_ERRATA_50XXB2;
+                        break;
+                }
+                break;
+        case chip_504x:
+        case chip_508x:
+                hpriv->ops = &mv5xxx_ops;
+                hp_flags |= MV_HP_50XX;
+                switch (rev_id) {
+                case 0x0:
+                        hp_flags |= MV_HP_ERRATA_50XXB0;
+                        break;
+                case 0x3:
+                        hp_flags |= MV_HP_ERRATA_50XXB2;
+                        break;
+                default:
+                        dev_printk(KERN_WARNING, &pdev->dev,
+                           "Applying B2 workarounds to unknown rev\n");
+                        hp_flags |= MV_HP_ERRATA_50XXB2;
+                        break;
+                }
+                break;
+        case chip_604x:
+        case chip_608x:
+                hpriv->ops = &mv6xxx_ops;
+                switch (rev_id) {
+                case 0x7:
+                        hp_flags |= MV_HP_ERRATA_60X1B2;
+                        break;
+                case 0x9:
+                        hp_flags |= MV_HP_ERRATA_60X1C0;
+                        break;
+                default:
+                        dev_printk(KERN_WARNING, &pdev->dev,
+                                   "Applying B2 workarounds to unknown rev\n");
+                        hp_flags |= MV_HP_ERRATA_60X1B2;
+                        break;
+                }
+                break;
+        default:
+                printk(KERN_ERR DRV_NAME ": BUG: invalid board index %u\n", board_idx);
+                return 1;
+        }
+        hpriv->hp_flags = hp_flags;
+        return 0;
+}
 /**
- *      mv_host_init - Perform some early initialization of the host.
+ *      mv_init_host - Perform some early initialization of the host.
+ *      @pdev: host PCI device
 *      @probe_ent: early data struct representing the host
 *
 *      If possible, do an early global reset of the host.  Then do
@@ -1378,23 +2006,48 @@ static void mv_port_init(struct ata_ioports *port,  void __iomem *port_mmio)
 *      LOCKING:
 *      Inherited from caller.
 */
-static int mv_host_init(struct ata_probe_ent *probe_ent)
+static int mv_init_host(struct pci_dev *pdev, struct ata_probe_ent *probe_ent,
+                        unsigned int board_idx)
 {
        int rc = 0, n_hc, port, hc;
        void __iomem *mmio = probe_ent->mmio_base;
-        void __iomem *port_mmio;
+        struct mv_host_priv *hpriv = probe_ent->private_data;
-        if ((MV_FLAG_GLBL_SFT_RST & probe_ent->host_flags) && 
+        /* global interrupt mask */
-            mv_global_soft_reset(probe_ent->mmio_base)) {
+        writel(0, mmio + HC_MAIN_IRQ_MASK_OFS);
-                rc = 1;
+        rc = mv_chip_id(pdev, hpriv, board_idx);
+        if (rc)
                goto done;
-        }
        n_hc = mv_get_hc_count(probe_ent->host_flags);
        probe_ent->n_ports = MV_PORTS_PER_HC * n_hc;
+        for (port = 0; port < probe_ent->n_ports; port++)
+                hpriv->ops->read_preamp(hpriv, port, mmio);
+        rc = hpriv->ops->reset_hc(hpriv, mmio, n_hc);
+        if (rc)
+                goto done;
+        hpriv->ops->reset_flash(hpriv, mmio);
+        hpriv->ops->reset_bus(pdev, mmio);
+        hpriv->ops->enable_leds(hpriv, mmio);
        for (port = 0; port < probe_ent->n_ports; port++) {
-                port_mmio = mv_port_base(mmio, port);
+                if (IS_60XX(hpriv)) {
+                        void __iomem *port_mmio = mv_port_base(mmio, port);
+                        u32 ifctl = readl(port_mmio + SATA_INTERFACE_CTL);
+                        ifctl |= (1 << 12);
+                        writelfl(ifctl, port_mmio + SATA_INTERFACE_CTL);
+                }
+                hpriv->ops->phy_errata(hpriv, mmio, port);
+        }
+        for (port = 0; port < probe_ent->n_ports; port++) {
+                void __iomem *port_mmio = mv_port_base(mmio, port);
                mv_port_init(&probe_ent->port[port], port_mmio);
        }
@@ -1418,11 +2071,12 @@ static int mv_host_init(struct ata_probe_ent *probe_ent)
        writelfl(~HC_MAIN_MASKED_IRQS, mmio + HC_MAIN_IRQ_MASK_OFS);
        VPRINTK("HC MAIN IRQ cause/mask=0x%08x/0x%08x "
-                "PCI int cause/mask=0x%08x/0x%08x\n", 
+                "PCI int cause/mask=0x%08x/0x%08x\n",
                readl(mmio + HC_MAIN_IRQ_CAUSE_OFS),
                readl(mmio + HC_MAIN_IRQ_MASK_OFS),
                readl(mmio + PCI_IRQ_CAUSE_OFS),
                readl(mmio + PCI_IRQ_MASK_OFS));
 done:
        return rc;
 }
@@ -1458,7 +2112,7 @@ static void mv_print_info(struct ata_probe_ent *probe_ent)
        dev_printk(KERN_INFO, &pdev->dev,
               "%u slots %u ports %s mode IRQ via %s\n",
-               (unsigned)MV_MAX_Q_DEPTH, probe_ent->n_ports, 
+               (unsigned)MV_MAX_Q_DEPTH, probe_ent->n_ports,
               scc_s, (MV_HP_FLAG_MSI & hpriv->hp_flags) ? "MSI" : "INTx");
 }
@@ -1528,7 +2182,7 @@ static int mv_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
        probe_ent->private_data = hpriv;
        /* initialize adapter */
-        rc = mv_host_init(probe_ent);
+        rc = mv_init_host(pdev, probe_ent, board_idx);
        if (rc) {
                goto err_out_hpriv;
        }
diff --git a/drivers/scsi/sata_promise.c b/drivers/scsi/sata_promise.c
index 242d906987ad..8a8e3e3ef0ed 100644
--- a/drivers/scsi/sata_promise.c
+++ b/drivers/scsi/sata_promise.c
@@ -46,7 +46,7 @@
 #include "sata_promise.h"
 #define DRV_NAME        "sata_promise"
-#define DRV_VERSION     "1.02"
+#define DRV_VERSION     "1.03"
 enum {
diff --git a/drivers/scsi/sata_qstor.c b/drivers/scsi/sata_qstor.c
index 4a6d3067d23c..a8987f5ff5cc 100644
--- a/drivers/scsi/sata_qstor.c
+++ b/drivers/scsi/sata_qstor.c
@@ -41,7 +41,7 @@
 #include <linux/libata.h>
 #define DRV_NAME        "sata_qstor"
-#define DRV_VERSION     "0.04"
+#define DRV_VERSION     "0.05"
 enum {
        QS_PORTS                = 4,
diff --git a/drivers/scsi/sata_sil24.c b/drivers/scsi/sata_sil24.c
index 55e744d6db88..e0d6f194f54f 100644
--- a/drivers/scsi/sata_sil24.c
+++ b/drivers/scsi/sata_sil24.c
@@ -5,17 +5,6 @@
 *
 * Based on preview driver from Silicon Image.
 *
- * NOTE: No NCQ/ATAPI support yet.  The preview driver didn't support
- * NCQ nor ATAPI, and, unfortunately, I couldn't find out how to make
- * those work.  Enabling those shouldn't be difficult.  Basic
- * structure is all there (in libata-dev tree).  If you have any
- * information about this hardware, please contact me or linux-ide.
- * Info is needed on...
- *
- * - How to issue tagged commands and turn on sactive on issue accordingly.
- * - Where to put an ATAPI command and how to tell the device to send it.
- * - How to enable/use 64bit.
- *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License as published by the
 * Free Software Foundation; either version 2, or (at your option) any
@@ -42,7 +31,7 @@
 #include <asm/io.h>
 #define DRV_NAME        "sata_sil24"
-#define DRV_VERSION     "0.22"  /* Silicon Image's preview driver was 0.10 */
+#define DRV_VERSION     "0.23"
 /*
 * Port request block (PRB) 32 bytes
@@ -139,6 +128,7 @@ enum {
        PORT_CS_DEV_RST         = (1 << 1), /* device reset */
        PORT_CS_INIT            = (1 << 2), /* port initialize */
        PORT_CS_IRQ_WOC         = (1 << 3), /* interrupt write one to clear */
+        PORT_CS_CDB16           = (1 << 5), /* 0=12b cdb, 1=16b cdb */
        PORT_CS_RESUME          = (1 << 6), /* port resume */
        PORT_CS_32BIT_ACTV      = (1 << 10), /* 32-bit activation */
        PORT_CS_PM_EN           = (1 << 13), /* port multiplier enable */
@@ -188,11 +178,29 @@ enum {
        PORT_CERR_XFR_PCIPERR   = 35, /* PSD ecode 11 - PCI prity err during transfer */
        PORT_CERR_SENDSERVICE   = 36, /* FIS received while sending service */
+        /* bits of PRB control field */
+        PRB_CTRL_PROTOCOL       = (1 << 0), /* override def. ATA protocol */
+        PRB_CTRL_PACKET_READ    = (1 << 4), /* PACKET cmd read */
+        PRB_CTRL_PACKET_WRITE   = (1 << 5), /* PACKET cmd write */
+        PRB_CTRL_NIEN           = (1 << 6), /* Mask completion irq */
+        PRB_CTRL_SRST           = (1 << 7), /* Soft reset request (ign BSY?) */
+        /* PRB protocol field */
+        PRB_PROT_PACKET         = (1 << 0),
+        PRB_PROT_TCQ            = (1 << 1),
+        PRB_PROT_NCQ            = (1 << 2),
+        PRB_PROT_READ           = (1 << 3),
+        PRB_PROT_WRITE          = (1 << 4),
+        PRB_PROT_TRANSPARENT    = (1 << 5),
        /*
         * Other constants
         */
        SGE_TRM                 = (1 << 31), /* Last SGE in chain */
-        PRB_SOFT_RST            = (1 << 7),  /* Soft reset request (ign BSY?) */
+        SGE_LNK                 = (1 << 30), /* linked list
+                                                Points to SGT, not SGE */
+        SGE_DRD                 = (1 << 29), /* discard data read (/dev/null)
+                                                data address ignored */
        /* board id */
        BID_SIL3124             = 0,
@@ -202,11 +210,22 @@ enum {
        IRQ_STAT_4PORTS         = 0xf,
 };
-struct sil24_cmd_block {
+struct sil24_ata_block {
        struct sil24_prb prb;
        struct sil24_sge sge[LIBATA_MAX_PRD];
 };
+struct sil24_atapi_block {
+        struct sil24_prb prb;
+        u8 cdb[16];
+        struct sil24_sge sge[LIBATA_MAX_PRD - 1];
+};
+union sil24_cmd_block {
+        struct sil24_ata_block ata;
+        struct sil24_atapi_block atapi;
+};
 /*
 * ap->private_data
 *
@@ -214,7 +233,7 @@ struct sil24_cmd_block {
 * here from the previous interrupt.
 */
 struct sil24_port_priv {
-        struct sil24_cmd_block *cmd_block;      /* 32 cmd blocks */
+        union sil24_cmd_block *cmd_block;       /* 32 cmd blocks */
        dma_addr_t cmd_block_dma;               /* DMA base addr for them */
        struct ata_taskfile tf;                 /* Cached taskfile registers */
 };
@@ -225,6 +244,7 @@ struct sil24_host_priv {
        void __iomem *port_base;        /* port registers (4 * 8192 bytes @BAR2) */
 };
+static void sil24_dev_config(struct ata_port *ap, struct ata_device *dev);
 static u8 sil24_check_status(struct ata_port *ap);
 static u32 sil24_scr_read(struct ata_port *ap, unsigned sc_reg);
 static void sil24_scr_write(struct ata_port *ap, unsigned sc_reg, u32 val);
@@ -278,6 +298,8 @@ static struct scsi_host_template sil24_sht = {
 static const struct ata_port_operations sil24_ops = {
        .port_disable           = ata_port_disable,
+        .dev_config             = sil24_dev_config,
        .check_status           = sil24_check_status,
        .check_altstatus        = sil24_check_status,
        .dev_select             = ata_noop_dev_select,
@@ -314,7 +336,7 @@ static struct ata_port_info sil24_port_info[] = {
        {
                .sht            = &sil24_sht,
                .host_flags     = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY |
-                                  ATA_FLAG_SATA_RESET | ATA_FLAG_MMIO |
+                                  ATA_FLAG_SRST | ATA_FLAG_MMIO |
                                  ATA_FLAG_PIO_DMA | SIL24_NPORTS2FLAG(4),
                .pio_mask       = 0x1f,                 /* pio0-4 */
                .mwdma_mask     = 0x07,                 /* mwdma0-2 */
@@ -325,7 +347,7 @@ static struct ata_port_info sil24_port_info[] = {
        {
                .sht            = &sil24_sht,
                .host_flags     = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY |
-                                  ATA_FLAG_SATA_RESET | ATA_FLAG_MMIO |
+                                  ATA_FLAG_SRST | ATA_FLAG_MMIO |
                                  ATA_FLAG_PIO_DMA | SIL24_NPORTS2FLAG(2),
                .pio_mask       = 0x1f,                 /* pio0-4 */
                .mwdma_mask     = 0x07,                 /* mwdma0-2 */
@@ -336,7 +358,7 @@ static struct ata_port_info sil24_port_info[] = {
        {
                .sht            = &sil24_sht,
                .host_flags     = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY |
-                                  ATA_FLAG_SATA_RESET | ATA_FLAG_MMIO |
+                                  ATA_FLAG_SRST | ATA_FLAG_MMIO |
                                  ATA_FLAG_PIO_DMA | SIL24_NPORTS2FLAG(1),
                .pio_mask       = 0x1f,                 /* pio0-4 */
                .mwdma_mask     = 0x07,                 /* mwdma0-2 */
@@ -345,6 +367,16 @@ static struct ata_port_info sil24_port_info[] = {
        },
 };
+static void sil24_dev_config(struct ata_port *ap, struct ata_device *dev)
+{
+        void __iomem *port = (void __iomem *)ap->ioaddr.cmd_addr;
+        if (ap->cdb_len == 16)
+                writel(PORT_CS_CDB16, port + PORT_CTRL_STAT);
+        else
+                writel(PORT_CS_CDB16, port + PORT_CTRL_CLR);
+}
 static inline void sil24_update_tf(struct ata_port *ap)
 {
        struct sil24_port_priv *pp = ap->private_data;
@@ -396,22 +428,73 @@ static void sil24_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
        *tf = pp->tf;
 }
-static void sil24_phy_reset(struct ata_port *ap)
+static int sil24_issue_SRST(struct ata_port *ap)
 {
-        __sata_phy_reset(ap);
+        void __iomem *port = (void __iomem *)ap->ioaddr.cmd_addr;
+        struct sil24_port_priv *pp = ap->private_data;
+        struct sil24_prb *prb = &pp->cmd_block[0].ata.prb;
+        dma_addr_t paddr = pp->cmd_block_dma;
+        u32 irq_enable, irq_stat;
+        int cnt;
+        /* temporarily turn off IRQs during SRST */
+        irq_enable = readl(port + PORT_IRQ_ENABLE_SET);
+        writel(irq_enable, port + PORT_IRQ_ENABLE_CLR);
        /*
-         * No ATAPI yet.  Just unconditionally indicate ATA device.
+         * XXX: Not sure whether the following sleep is needed or not.
-         * If ATAPI device is attached, it will fail ATA_CMD_ID_ATA
+         * The original driver had it.  So....
-         * and libata core will ignore the device.
         */
-        if (!(ap->flags & ATA_FLAG_PORT_DISABLED))
+        msleep(10);
-                ap->device[0].class = ATA_DEV_ATA;
+        prb->ctrl = PRB_CTRL_SRST;
+        prb->fis[1] = 0; /* no PM yet */
+        writel((u32)paddr, port + PORT_CMD_ACTIVATE);
+        for (cnt = 0; cnt < 100; cnt++) {
+                irq_stat = readl(port + PORT_IRQ_STAT);
+                writel(irq_stat, port + PORT_IRQ_STAT);         /* clear irq */
+                irq_stat >>= PORT_IRQ_RAW_SHIFT;
+                if (irq_stat & (PORT_IRQ_COMPLETE | PORT_IRQ_ERROR))
+                        break;
+                msleep(1);
+        }
+        /* restore IRQs */
+        writel(irq_enable, port + PORT_IRQ_ENABLE_SET);
+        if (!(irq_stat & PORT_IRQ_COMPLETE))
+                return -1;
+        /* update TF */
+        sil24_update_tf(ap);
+        return 0;
+}
+static void sil24_phy_reset(struct ata_port *ap)
+{
+        struct sil24_port_priv *pp = ap->private_data;
+        __sata_phy_reset(ap);
+        if (ap->flags & ATA_FLAG_PORT_DISABLED)
+                return;
+        if (sil24_issue_SRST(ap) < 0) {
+                printk(KERN_ERR DRV_NAME
+                       " ata%u: SRST failed, disabling port\n", ap->id);
+                ap->ops->port_disable(ap);
+                return;
+        }
+        ap->device->class = ata_dev_classify(&pp->tf);
 }
 static inline void sil24_fill_sg(struct ata_queued_cmd *qc,
-                                 struct sil24_cmd_block *cb)
+                                 struct sil24_sge *sge)
 {
-        struct sil24_sge *sge = cb->sge;
        struct scatterlist *sg;
        unsigned int idx = 0;
@@ -432,23 +515,47 @@ static void sil24_qc_prep(struct ata_queued_cmd *qc)
 {
        struct ata_port *ap = qc->ap;
        struct sil24_port_priv *pp = ap->private_data;
-        struct sil24_cmd_block *cb = pp->cmd_block + qc->tag;
+        union sil24_cmd_block *cb = pp->cmd_block + qc->tag;
-        struct sil24_prb *prb = &cb->prb;
+        struct sil24_prb *prb;
+        struct sil24_sge *sge;
        switch (qc->tf.protocol) {
        case ATA_PROT_PIO:
        case ATA_PROT_DMA:
        case ATA_PROT_NODATA:
+                prb = &cb->ata.prb;
+                sge = cb->ata.sge;
+                prb->ctrl = 0;
+                break;
+        case ATA_PROT_ATAPI:
+        case ATA_PROT_ATAPI_DMA:
+        case ATA_PROT_ATAPI_NODATA:
+                prb = &cb->atapi.prb;
+                sge = cb->atapi.sge;
+                memset(cb->atapi.cdb, 0, 32);
+                memcpy(cb->atapi.cdb, qc->cdb, ap->cdb_len);
+                if (qc->tf.protocol != ATA_PROT_ATAPI_NODATA) {
+                        if (qc->tf.flags & ATA_TFLAG_WRITE)
+                                prb->ctrl = PRB_CTRL_PACKET_WRITE;
+                        else
+                                prb->ctrl = PRB_CTRL_PACKET_READ;
+                } else
+                        prb->ctrl = 0;
                break;
        default:
-                /* ATAPI isn't supported yet */
+                prb = NULL;     /* shut up, gcc */
+                sge = NULL;
                BUG();
        }
        ata_tf_to_fis(&qc->tf, prb->fis, 0);
        if (qc->flags & ATA_QCFLAG_DMAMAP)
-                sil24_fill_sg(qc, cb);
+                sil24_fill_sg(qc, sge);
 }
 static int sil24_qc_issue(struct ata_queued_cmd *qc)
@@ -467,6 +574,31 @@ static void sil24_irq_clear(struct ata_port *ap)
        /* unused */
 }
+static int __sil24_restart_controller(void __iomem *port)
+{
+        u32 tmp;
+        int cnt;
+        writel(PORT_CS_INIT, port + PORT_CTRL_STAT);
+        /* Max ~10ms */
+        for (cnt = 0; cnt < 10000; cnt++) {
+                tmp = readl(port + PORT_CTRL_STAT);
+                if (tmp & PORT_CS_RDY)
+                        return 0;
+                udelay(1);
+        }
+        return -1;
+}
+static void sil24_restart_controller(struct ata_port *ap)
+{
+        if (__sil24_restart_controller((void __iomem *)ap->ioaddr.cmd_addr))
+                printk(KERN_ERR DRV_NAME
+                       " ata%u: failed to restart controller\n", ap->id);
+}
 static int __sil24_reset_controller(void __iomem *port)
 {
        int cnt;
@@ -486,7 +618,11 @@ static int __sil24_reset_controller(void __iomem *port)
        if (tmp & PORT_CS_DEV_RST)
                return -1;
-        return 0;
+        if (tmp & PORT_CS_RDY)
+                return 0;
+        return __sil24_restart_controller(port);
 }
 static void sil24_reset_controller(struct ata_port *ap)
@@ -548,9 +684,15 @@ static void sil24_error_intr(struct ata_port *ap, u32 slot_stat)
        if (serror)
                writel(serror, port + PORT_SERROR);
-        printk(KERN_ERR DRV_NAME " ata%u: error interrupt on port%d\n"
+        /*
-               "  stat=0x%x irq=0x%x cmd_err=%d sstatus=0x%x serror=0x%x\n",
+         * Don't log ATAPI device errors.  They're supposed to happen
-               ap->id, ap->port_no, slot_stat, irq_stat, cmd_err, sstatus, serror);
+         * and any serious errors will be logged using sense data by
+         * the SCSI layer.
+         */
+        if (ap->device[0].class != ATA_DEV_ATAPI || cmd_err > PORT_CERR_SDB)
+                printk("ata%u: error interrupt on port%d\n"
+                       "  stat=0x%x irq=0x%x cmd_err=%d sstatus=0x%x serror=0x%x\n",
+                       ap->id, ap->port_no, slot_stat, irq_stat, cmd_err, sstatus, serror);
        if (cmd_err == PORT_CERR_DEV || cmd_err == PORT_CERR_SDB) {
                /*
@@ -558,6 +700,7 @@ static void sil24_error_intr(struct ata_port *ap, u32 slot_stat)
                 */
                sil24_update_tf(ap);
                err_mask = ac_err_mask(pp->tf.command);
+                sil24_restart_controller(ap);
        } else {
                /*
                 * Other errors.  libata currently doesn't have any
@@ -565,12 +708,11 @@ static void sil24_error_intr(struct ata_port *ap, u32 slot_stat)
                 * ATA_ERR.
                 */
                err_mask = AC_ERR_OTHER;
+                sil24_reset_controller(ap);
        }
        if (qc)
                ata_qc_complete(qc, err_mask);
-        sil24_reset_controller(ap);
 }
 static inline void sil24_host_intr(struct ata_port *ap)
@@ -646,7 +788,7 @@ static int sil24_port_start(struct ata_port *ap)
 {
        struct device *dev = ap->host_set->dev;
        struct sil24_port_priv *pp;
-        struct sil24_cmd_block *cb;
+        union sil24_cmd_block *cb;
        size_t cb_size = sizeof(*cb);
        dma_addr_t cb_dma;
        int rc = -ENOMEM;
diff --git a/drivers/scsi/sata_svw.c b/drivers/scsi/sata_svw.c
index 57e5a9d964c3..6e7f7c83a75a 100644
--- a/drivers/scsi/sata_svw.c
+++ b/drivers/scsi/sata_svw.c
@@ -54,7 +54,7 @@
 #endif /* CONFIG_PPC_OF */
 #define DRV_NAME        "sata_svw"
-#define DRV_VERSION     "1.06"
+#define DRV_VERSION     "1.07"
 /* Taskfile registers offsets */
 #define K2_SATA_TF_CMD_OFFSET           0x00
diff --git a/drivers/scsi/sata_sx4.c b/drivers/scsi/sata_sx4.c
index b4bbe48acab0..dcc3ad9a9d6e 100644
--- a/drivers/scsi/sata_sx4.c
+++ b/drivers/scsi/sata_sx4.c
@@ -46,7 +46,7 @@
 #include "sata_promise.h"
 #define DRV_NAME        "sata_sx4"
-#define DRV_VERSION     "0.7"
+#define DRV_VERSION     "0.8"
 enum {
diff --git a/drivers/scsi/sata_vsc.c b/drivers/scsi/sata_vsc.c
index 77a6e4b9262d..fcfa486965b4 100644
--- a/drivers/scsi/sata_vsc.c
+++ b/drivers/scsi/sata_vsc.c
@@ -47,7 +47,7 @@
 #include <linux/libata.h>
 #define DRV_NAME        "sata_vsc"
-#define DRV_VERSION     "1.0"
+#define DRV_VERSION     "1.1"
 /* Interrupt register offsets (from chip base address) */
 #define VSC_SATA_INT_STAT_OFFSET        0x00
diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index ff36f0c9fdad..ad47c1b84c3f 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -507,7 +507,7 @@ config SERIAL_SUNSU_CONSOLE
 config SERIAL_MUX
        tristate "Serial MUX support"
-        depends on PARISC
+        depends on GSC
        select SERIAL_CORE
        default y
        ---help---
diff --git a/drivers/serial/amba-pl011.c b/drivers/serial/amba-pl011.c
index 938d185841c9..89d7bd3eaee3 100644
--- a/drivers/serial/amba-pl011.c
+++ b/drivers/serial/amba-pl011.c
@@ -49,7 +49,6 @@
 #include <linux/serial.h>
 #include <asm/io.h>
-#include <asm/irq.h>
 #include <asm/sizes.h>
 #include <asm/hardware/amba.h>
 #include <asm/hardware/clock.h>
@@ -63,7 +62,8 @@
 #define AMBA_ISR_PASS_LIMIT     256
-#define UART_DUMMY_RSR_RX       256
+#define UART_DR_ERROR           (UART011_DR_OE|UART011_DR_BE|UART011_DR_PE|UART011_DR_FE)
+#define UART_DUMMY_DR_RX        (1 << 16)
 /*
 * We wrap our port structure around the generic uart_port.
@@ -116,7 +116,7 @@ pl011_rx_chars(struct uart_amba_port *uap)
 #endif
 {
        struct tty_struct *tty = uap->port.info->tty;
-        unsigned int status, ch, flag, rsr, max_count = 256;
+        unsigned int status, ch, flag, max_count = 256;
        status = readw(uap->port.membase + UART01x_FR);
        while ((status & UART01x_FR_RXFE) == 0 && max_count--) {
@@ -129,7 +129,7 @@ pl011_rx_chars(struct uart_amba_port *uap)
                         */
                }
-                ch = readw(uap->port.membase + UART01x_DR);
+                ch = readw(uap->port.membase + UART01x_DR) | UART_DUMMY_DR_RX;
                flag = TTY_NORMAL;
                uap->port.icount.rx++;
@@ -137,34 +137,33 @@ pl011_rx_chars(struct uart_amba_port *uap)
                 * Note that the error handling code is
                 * out of the main execution path
                 */
-                rsr = readw(uap->port.membase + UART01x_RSR) | UART_DUMMY_RSR_RX;
+                if (unlikely(ch & UART_DR_ERROR)) {
-                if (unlikely(rsr & UART01x_RSR_ANY)) {
+                        if (ch & UART011_DR_BE) {
-                        if (rsr & UART01x_RSR_BE) {
+                                ch &= ~(UART011_DR_FE | UART011_DR_PE);
-                                rsr &= ~(UART01x_RSR_FE | UART01x_RSR_PE);
                                uap->port.icount.brk++;
                                if (uart_handle_break(&uap->port))
                                        goto ignore_char;
-                        } else if (rsr & UART01x_RSR_PE)
+                        } else if (ch & UART011_DR_PE)
                                uap->port.icount.parity++;
-                        else if (rsr & UART01x_RSR_FE)
+                        else if (ch & UART011_DR_FE)
                                uap->port.icount.frame++;
-                        if (rsr & UART01x_RSR_OE)
+                        if (ch & UART011_DR_OE)
                                uap->port.icount.overrun++;
-                        rsr &= uap->port.read_status_mask;
+                        ch &= uap->port.read_status_mask;
-                        if (rsr & UART01x_RSR_BE)
+                        if (ch & UART011_DR_BE)
                                flag = TTY_BREAK;
-                        else if (rsr & UART01x_RSR_PE)
+                        else if (ch & UART011_DR_PE)
                                flag = TTY_PARITY;
-                        else if (rsr & UART01x_RSR_FE)
+                        else if (ch & UART011_DR_FE)
                                flag = TTY_FRAME;
                }
                if (uart_handle_sysrq_char(&uap->port, ch, regs))
                        goto ignore_char;
-                uart_insert_char(&uap->port, rsr, UART01x_RSR_OE, ch, flag);
+                uart_insert_char(&uap->port, ch, UART011_DR_OE, ch, flag);
        ignore_char:
                status = readw(uap->port.membase + UART01x_FR);
@@ -476,33 +475,33 @@ pl011_set_termios(struct uart_port *port, struct termios *termios,
         */
        uart_update_timeout(port, termios->c_cflag, baud);
-        port->read_status_mask = UART01x_RSR_OE;
+        port->read_status_mask = UART011_DR_OE | 255;
        if (termios->c_iflag & INPCK)
-                port->read_status_mask |= UART01x_RSR_FE | UART01x_RSR_PE;
+                port->read_status_mask |= UART011_DR_FE | UART011_DR_PE;
        if (termios->c_iflag & (BRKINT | PARMRK))
-                port->read_status_mask |= UART01x_RSR_BE;
+                port->read_status_mask |= UART011_DR_BE;
        /*
         * Characters to ignore
         */
        port->ignore_status_mask = 0;
        if (termios->c_iflag & IGNPAR)
-                port->ignore_status_mask |= UART01x_RSR_FE | UART01x_RSR_PE;
+                port->ignore_status_mask |= UART011_DR_FE | UART011_DR_PE;
        if (termios->c_iflag & IGNBRK) {
-                port->ignore_status_mask |= UART01x_RSR_BE;
+                port->ignore_status_mask |= UART011_DR_BE;
                /*
                 * If we're ignoring parity and break indicators,
                 * ignore overruns too (for real raw support).
                 */
                if (termios->c_iflag & IGNPAR)
-                        port->ignore_status_mask |= UART01x_RSR_OE;
+                        port->ignore_status_mask |= UART011_DR_OE;
        }
        /*
         * Ignore all characters if CREAD is not set.
         */
        if ((termios->c_cflag & CREAD) == 0)
-                port->ignore_status_mask |= UART_DUMMY_RSR_RX;
+                port->ignore_status_mask |= UART_DUMMY_DR_RX;
        if (UART_ENABLE_MS(port, termios->c_cflag))
                pl011_enable_ms(port);
diff --git a/drivers/serial/mux.c b/drivers/serial/mux.c
index 660bae5ba179..7633132a10aa 100644
--- a/drivers/serial/mux.c
+++ b/drivers/serial/mux.c
@@ -65,8 +65,8 @@ static struct uart_driver mux_driver = {
 static struct timer_list mux_timer;
-#define UART_PUT_CHAR(p, c) __raw_writel((c), (unsigned long)(p)->membase + IO_DATA_REG_OFFSET)
+#define UART_PUT_CHAR(p, c) __raw_writel((c), (p)->membase + IO_DATA_REG_OFFSET)
-#define UART_GET_FIFO_CNT(p) __raw_readl((unsigned long)(p)->membase + IO_DCOUNT_REG_OFFSET)
+#define UART_GET_FIFO_CNT(p) __raw_readl((p)->membase + IO_DCOUNT_REG_OFFSET)
 #define GET_MUX_PORTS(iodc_data) ((((iodc_data)[4] & 0xf0) >> 4) * 8) + 8
 /**
@@ -79,10 +79,7 @@ static struct timer_list mux_timer;
 */
 static unsigned int mux_tx_empty(struct uart_port *port)
 {
-        unsigned int cnt = __raw_readl((unsigned long)port->membase 
+        return UART_GET_FIFO_CNT(port) ? 0 : TIOCSER_TEMT;
-                                + IO_DCOUNT_REG_OFFSET);
-        return cnt ? 0 : TIOCSER_TEMT;
 } 
 /**
@@ -218,8 +215,7 @@ static void mux_read(struct uart_port *port)
        __u32 start_count = port->icount.rx;
        while(1) {
-                data = __raw_readl((unsigned long)port->membase
+                data = __raw_readl(port->membase + IO_DATA_REG_OFFSET);
-                                                + IO_DATA_REG_OFFSET);
                if (MUX_STATUS(data))
                        continue;
@@ -481,6 +477,13 @@ static int __init mux_probe(struct parisc_device *dev)
                port->ops       = &mux_pops;
                port->flags     = UPF_BOOT_AUTOCONF;
                port->line      = port_cnt;
+                /* The port->timeout needs to match what is present in
+                 * uart_wait_until_sent in serial_core.c.  Otherwise
+                 * the time spent in msleep_interruptable will be very
+                 * long, causing the appearance of a console hang.
+                 */
+                port->timeout   = HZ / 50;
                spin_lock_init(&port->lock);
                status = uart_add_one_port(&mux_driver, port);
                BUG_ON(status);
diff --git a/drivers/serial/sa1100.c b/drivers/serial/sa1100.c
index 0e3daf6d7b50..25a086458ab9 100644
--- a/drivers/serial/sa1100.c
+++ b/drivers/serial/sa1100.c
@@ -161,7 +161,6 @@ static void sa1100_stop_tx(struct uart_port *port)
 static void sa1100_start_tx(struct uart_port *port)
 {
        struct sa1100_port *sport = (struct sa1100_port *)port;
-        unsigned long flags;
        u32 utcr3;
        utcr3 = UART_GET_UTCR3(sport);
diff --git a/drivers/tc/zs.c b/drivers/tc/zs.c
index c52af73a251b..6756d0fab6fe 100644
--- a/drivers/tc/zs.c
+++ b/drivers/tc/zs.c
@@ -6,7 +6,7 @@
 *
 * DECstation changes
 * Copyright (C) 1998-2000 Harald Koerfgen
- * Copyright (C) 2000, 2001, 2002, 2003, 2004  Maciej W. Rozycki
+ * Copyright (C) 2000, 2001, 2002, 2003, 2004, 2005  Maciej W. Rozycki
 *
 * For the rest of the code the original Copyright applies:
 * Copyright (C) 1996 Paul Mackerras (Paul.Mackerras@cs.anu.edu.au)
@@ -55,6 +55,7 @@
 #include <linux/delay.h>
 #include <linux/init.h>
 #include <linux/ioport.h>
+#include <linux/spinlock.h>
 #ifdef CONFIG_SERIAL_DEC_CONSOLE
 #include <linux/console.h>
 #endif
@@ -63,7 +64,6 @@
 #include <asm/pgtable.h>
 #include <asm/irq.h>
 #include <asm/system.h>
-#include <asm/uaccess.h>
 #include <asm/bootinfo.h>
 #include <asm/dec/interrupts.h>
@@ -128,6 +128,8 @@ static struct zs_parms ds_parms = {
 #define BUS_PRESENT (DS_BUS_PRESENT)
+DEFINE_SPINLOCK(zs_lock);
 struct dec_zschannel zs_channels[NUM_CHANNELS];
 struct dec_serial zs_soft[NUM_CHANNELS];
 int zs_channels_found;
@@ -159,8 +161,6 @@ static unsigned char zs_init_regs[16] __initdata = {
        0                               /* write 15 */
 };
-DECLARE_TASK_QUEUE(tq_zs_serial);
 static struct tty_driver *serial_driver;
 /* serial subtype definitions */
@@ -294,8 +294,7 @@ static inline void zs_rtsdtr(struct dec_serial *info, int which, int set)
 {
        unsigned long flags;
+        spin_lock_irqsave(&zs_lock, flags);
-        save_flags(flags); cli();
        if (info->zs_channel != info->zs_chan_a) {
                if (set) {
                        info->zs_chan_a->curregs[5] |= (which & (RTS | DTR));
@@ -304,7 +303,7 @@ static inline void zs_rtsdtr(struct dec_serial *info, int which, int set)
                }
                write_zsreg(info->zs_chan_a, 5, info->zs_chan_a->curregs[5]);
        }
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 /* Utility routines for the Zilog */
@@ -345,12 +344,10 @@ static inline void rs_recv_clear(struct dec_zschannel *zsc)
 * This routine is used by the interrupt handler to schedule
 * processing in the software interrupt portion of the driver.
 */
-static _INLINE_ void rs_sched_event(struct dec_serial *info,
+static _INLINE_ void rs_sched_event(struct dec_serial *info, int event)
-                                  int event)
 {
        info->event |= 1 << event;
-        queue_task(&info->tqueue, &tq_zs_serial);
+        tasklet_schedule(&info->tlet);
-        mark_bh(SERIAL_BH);
 }
 static _INLINE_ void receive_chars(struct dec_serial *info,
@@ -497,9 +494,10 @@ static _INLINE_ void status_handle(struct dec_serial *info)
 /*
 * This is the serial driver's generic interrupt routine
 */
-void rs_interrupt(int irq, void *dev_id, struct pt_regs * regs)
+static irqreturn_t rs_interrupt(int irq, void *dev_id, struct pt_regs *regs)
 {
        struct dec_serial *info = (struct dec_serial *) dev_id;
+        irqreturn_t status = IRQ_NONE;
        unsigned char zs_intreg;
        int shift;
@@ -521,6 +519,8 @@ void rs_interrupt(int irq, void *dev_id, struct pt_regs * regs)
                if ((zs_intreg & CHAN_IRQMASK) == 0)
                        break;
+                status = IRQ_HANDLED;
                if (zs_intreg & CHBRxIP) {
                        receive_chars(info, regs);
                }
@@ -534,6 +534,8 @@ void rs_interrupt(int irq, void *dev_id, struct pt_regs * regs)
        /* Why do we need this ? */
        write_zsreg(info->zs_channel, 0, RES_H_IUS);
+        return status;
 }
 #ifdef ZS_DEBUG_REGS
@@ -578,12 +580,12 @@ static void rs_stop(struct tty_struct *tty)
                return;
 #if 1
-        save_flags(flags); cli();
+        spin_lock_irqsave(&zs_lock, flags);
        if (info->zs_channel->curregs[5] & TxENAB) {
                info->zs_channel->curregs[5] &= ~TxENAB;
                write_zsreg(info->zs_channel, 5, info->zs_channel->curregs[5]);
        }
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 #endif
 }
@@ -595,7 +597,7 @@ static void rs_start(struct tty_struct *tty)
        if (serial_paranoia_check(info, tty->name, "rs_start"))
                return;
-        save_flags(flags); cli();
+        spin_lock_irqsave(&zs_lock, flags);
 #if 1
        if (info->xmit_cnt && info->xmit_buf && !(info->zs_channel->curregs[5] & TxENAB)) {
                info->zs_channel->curregs[5] |= TxENAB;
@@ -606,7 +608,7 @@ static void rs_start(struct tty_struct *tty)
                transmit_chars(info);
        }
 #endif
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 /*
@@ -618,12 +620,8 @@ static void rs_start(struct tty_struct *tty)
 * interrupt driver proper are done; the interrupt driver schedules
 * them using rs_sched_event(), and they get done here.
 */
-static void do_serial_bh(void)
-{
-        run_task_queue(&tq_zs_serial);
-}
-static void do_softint(void *private_)
+static void do_softint(unsigned long private_)
 {
        struct dec_serial       *info = (struct dec_serial *) private_;
        struct tty_struct       *tty;
@@ -634,10 +632,11 @@ static void do_softint(void *private_)
        if (test_and_clear_bit(RS_EVENT_WRITE_WAKEUP, &info->event)) {
                tty_wakeup(tty);
+                wake_up_interruptible(&tty->write_wait);
        }
 }
-int zs_startup(struct dec_serial * info)
+static int zs_startup(struct dec_serial * info)
 {
        unsigned long flags;
@@ -650,7 +649,7 @@ int zs_startup(struct dec_serial * info)
                        return -ENOMEM;
        }
-        save_flags(flags); cli();
+        spin_lock_irqsave(&zs_lock, flags);
 #ifdef SERIAL_DEBUG_OPEN
        printk("starting up ttyS%d (irq %d)...", info->line, info->irq);
@@ -706,7 +705,7 @@ int zs_startup(struct dec_serial * info)
        info->xmit_cnt = info->xmit_head = info->xmit_tail = 0;
        info->flags |= ZILOG_INITIALIZED;
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
        return 0;
 }
@@ -726,7 +725,7 @@ static void shutdown(struct dec_serial * info)
               info->irq);
 #endif
-        save_flags(flags); cli(); /* Disable interrupts */
+        spin_lock_irqsave(&zs_lock, flags);
        if (info->xmit_buf) {
                free_page((unsigned long) info->xmit_buf);
@@ -749,7 +748,7 @@ static void shutdown(struct dec_serial * info)
                set_bit(TTY_IO_ERROR, &info->tty->flags);
        info->flags &= ~ZILOG_INITIALIZED;
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 /*
@@ -785,7 +784,7 @@ static void change_speed(struct dec_serial *info)
                        i += 15;
        }
-        save_flags(flags); cli();
+        spin_lock_irqsave(&zs_lock, flags);
        info->zs_baud = baud_table[i];
        if (info->zs_baud) {
                brg = BPS_TO_BRG(info->zs_baud, zs_parms->clock/info->clk_divisor);
@@ -858,7 +857,7 @@ static void change_speed(struct dec_serial *info)
        /* Load up the new values */
        load_zsregs(info->zs_channel, info->zs_channel->curregs);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 static void rs_flush_chars(struct tty_struct *tty)
@@ -874,9 +873,9 @@ static void rs_flush_chars(struct tty_struct *tty)
                return;
        /* Enable transmitter */
-        save_flags(flags); cli();
+        spin_lock_irqsave(&zs_lock, flags);
        transmit_chars(info);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 static int rs_write(struct tty_struct * tty,
@@ -892,26 +891,17 @@ static int rs_write(struct tty_struct * tty,
        if (!tty || !info->xmit_buf)
                return 0;
-        save_flags(flags);
        while (1) {
-                cli();
+                spin_lock_irqsave(&zs_lock, flags);
                c = min(count, min(SERIAL_XMIT_SIZE - info->xmit_cnt - 1,
                                   SERIAL_XMIT_SIZE - info->xmit_head));
                if (c <= 0)
                        break;
-                if (from_user) {
+                memcpy(info->xmit_buf + info->xmit_head, buf, c);
-                        down(&tmp_buf_sem);
-                        copy_from_user(tmp_buf, buf, c);
-                        c = min(c, min(SERIAL_XMIT_SIZE - info->xmit_cnt - 1,
-                                       SERIAL_XMIT_SIZE - info->xmit_head));
-                        memcpy(info->xmit_buf + info->xmit_head, tmp_buf, c);
-                        up(&tmp_buf_sem);
-                } else
-                        memcpy(info->xmit_buf + info->xmit_head, buf, c);
                info->xmit_head = (info->xmit_head + c) & (SERIAL_XMIT_SIZE-1);
                info->xmit_cnt += c;
-                restore_flags(flags);
+                spin_unlock_irqrestore(&zs_lock, flags);
                buf += c;
                count -= c;
                total += c;
@@ -920,7 +910,7 @@ static int rs_write(struct tty_struct * tty,
        if (info->xmit_cnt && !tty->stopped && !info->tx_stopped
            && !info->tx_active)
                transmit_chars(info);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
        return total;
 }
@@ -952,9 +942,9 @@ static void rs_flush_buffer(struct tty_struct *tty)
        if (serial_paranoia_check(info, tty->name, "rs_flush_buffer"))
                return;
-        cli();
+        spin_lock_irq(&zs_lock);
        info->xmit_cnt = info->xmit_head = info->xmit_tail = 0;
-        sti();
+        spin_unlock_irq(&zs_lock);
        tty_wakeup(tty);
 }
@@ -982,11 +972,11 @@ static void rs_throttle(struct tty_struct * tty)
                return;
        if (I_IXOFF(tty)) {
-                save_flags(flags); cli();
+                spin_lock_irqsave(&zs_lock, flags);
                info->x_char = STOP_CHAR(tty);
                if (!info->tx_active)
                        transmit_chars(info);
-                restore_flags(flags);
+                spin_unlock_irqrestore(&zs_lock, flags);
        }
        if (C_CRTSCTS(tty)) {
@@ -1010,7 +1000,7 @@ static void rs_unthrottle(struct tty_struct * tty)
                return;
        if (I_IXOFF(tty)) {
-                save_flags(flags); cli();
+                spin_lock_irqsave(&zs_lock, flags);
                if (info->x_char)
                        info->x_char = 0;
                else {
@@ -1018,7 +1008,7 @@ static void rs_unthrottle(struct tty_struct * tty)
                        if (!info->tx_active)
                                transmit_chars(info);
                }
-                restore_flags(flags);
+                spin_unlock_irqrestore(&zs_lock, flags);
        }
        if (C_CRTSCTS(tty)) {
@@ -1111,9 +1101,9 @@ static int get_lsr_info(struct dec_serial * info, unsigned int *value)
 {
        unsigned char status;
-        cli();
+        spin_lock(&zs_lock);
        status = read_zsreg(info->zs_channel, 0);
-        sti();
+        spin_unlock_irq(&zs_lock);
        put_user(status,value);
        return 0;
 }
@@ -1136,11 +1126,11 @@ static int rs_tiocmget(struct tty_struct *tty, struct file *file)
        if (info->zs_channel == info->zs_chan_a)
                result = 0;
        else {
-                cli();
+                spin_lock(&zs_lock);
                control = info->zs_chan_a->curregs[5];
                status_a = read_zsreg(info->zs_chan_a, 0);
                status_b = read_zsreg(info->zs_channel, 0);
-                sti();
+                spin_unlock_irq(&zs_lock);
                result =  ((control  & RTS) ? TIOCM_RTS: 0)
                        | ((control  & DTR) ? TIOCM_DTR: 0)
                        | ((status_b & DCD) ? TIOCM_CAR: 0)
@@ -1155,8 +1145,6 @@ static int rs_tiocmset(struct tty_struct *tty, struct file *file,
                       unsigned int set, unsigned int clear)
 {
        struct dec_serial * info = (struct dec_serial *)tty->driver_data;
-        int error;
-        unsigned int arg, bits;
        if (info->hook)
                return -ENODEV;
@@ -1170,8 +1158,7 @@ static int rs_tiocmset(struct tty_struct *tty, struct file *file,
        if (info->zs_channel == info->zs_chan_a)
                return 0;
-        get_user(arg, value);
+        spin_lock(&zs_lock);
-        cli();
        if (set & TIOCM_RTS)
                info->zs_chan_a->curregs[5] |= RTS;
        if (set & TIOCM_DTR)
@@ -1181,7 +1168,7 @@ static int rs_tiocmset(struct tty_struct *tty, struct file *file,
        if (clear & TIOCM_DTR)
                info->zs_chan_a->curregs[5] &= ~DTR;
        write_zsreg(info->zs_chan_a, 5, info->zs_chan_a->curregs[5]);
-        sti();
+        spin_unlock_irq(&zs_lock);
        return 0;
 }
@@ -1198,19 +1185,18 @@ static void rs_break(struct tty_struct *tty, int break_state)
        if (!info->port)
                return;
-        save_flags(flags); cli();
+        spin_lock_irqsave(&zs_lock, flags);
        if (break_state == -1)
                info->zs_channel->curregs[5] |= SND_BRK;
        else
                info->zs_channel->curregs[5] &= ~SND_BRK;
        write_zsreg(info->zs_channel, 5, info->zs_channel->curregs[5]);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 static int rs_ioctl(struct tty_struct *tty, struct file * file,
                    unsigned int cmd, unsigned long arg)
 {
-        int error;
        struct dec_serial * info = (struct dec_serial *)tty->driver_data;
        if (info->hook)
@@ -1287,10 +1273,10 @@ static void rs_close(struct tty_struct *tty, struct file * filp)
        if (!info || serial_paranoia_check(info, tty->name, "rs_close"))
                return;
-        save_flags(flags); cli();
+        spin_lock_irqsave(&zs_lock, flags);
        if (tty_hung_up_p(filp)) {
-                restore_flags(flags);
+                spin_unlock_irqrestore(&zs_lock, flags);
                return;
        }
@@ -1315,7 +1301,7 @@ static void rs_close(struct tty_struct *tty, struct file * filp)
                info->count = 0;
        }
        if (info->count) {
-                restore_flags(flags);
+                spin_unlock_irqrestore(&zs_lock, flags);
                return;
        }
        info->flags |= ZILOG_CLOSING;
@@ -1358,7 +1344,7 @@ static void rs_close(struct tty_struct *tty, struct file * filp)
        }
        info->flags &= ~(ZILOG_NORMAL_ACTIVE|ZILOG_CLOSING);
        wake_up_interruptible(&info->close_wait);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 /*
@@ -1398,7 +1384,7 @@ static void rs_wait_until_sent(struct tty_struct *tty, int timeout)
 /*
 * rs_hangup() --- called by tty_hangup() when a hangup is signaled.
 */
-void rs_hangup(struct tty_struct *tty)
+static void rs_hangup(struct tty_struct *tty)
 {
        struct dec_serial * info = (struct dec_serial *)tty->driver_data;
@@ -1466,16 +1452,16 @@ static int block_til_ready(struct tty_struct *tty, struct file * filp,
        printk("block_til_ready before block: ttyS%d, count = %d\n",
               info->line, info->count);
 #endif
-        cli();
+        spin_lock(&zs_lock);
        if (!tty_hung_up_p(filp))
                info->count--;
-        sti();
+        spin_unlock_irq(&zs_lock);
        info->blocked_open++;
        while (1) {
-                cli();
+                spin_lock(&zs_lock);
                if (tty->termios->c_cflag & CBAUD)
                        zs_rtsdtr(info, RTS | DTR, 1);
-                sti();
+                spin_unlock_irq(&zs_lock);
                set_current_state(TASK_INTERRUPTIBLE);
                if (tty_hung_up_p(filp) ||
                    !(info->flags & ZILOG_INITIALIZED)) {
@@ -1523,7 +1509,7 @@ static int block_til_ready(struct tty_struct *tty, struct file * filp,
 * the IRQ chain.   It also performs the serial-specific
 * initialization for the tty structure.
 */
-int rs_open(struct tty_struct *tty, struct file * filp)
+static int rs_open(struct tty_struct *tty, struct file * filp)
 {
        struct dec_serial       *info;
        int                     retval, line;
@@ -1706,7 +1692,7 @@ static void __init probe_sccs(void)
                }
        }
-        save_and_cli(flags);
+        spin_lock_irqsave(&zs_lock, flags);
        for (n = 0; n < zs_channels_found; n++) {
                if (n % 2 == 0) {
                        write_zsreg(zs_soft[n].zs_chan_a, R9, FHWRES);
@@ -1716,7 +1702,7 @@ static void __init probe_sccs(void)
                load_zsregs(zs_soft[n].zs_channel,
                            zs_soft[n].zs_channel->curregs);
        }
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
 }
 static struct tty_operations serial_ops = {
@@ -1749,9 +1735,6 @@ int __init zs_init(void)
        if(!BUS_PRESENT)
                return -ENODEV;
-        /* Setup base handler, and timer table. */
-        init_bh(SERIAL_BH, do_serial_bh);
        /* Find out how many Z8530 SCCs we have */
        if (zs_chain == 0)
                probe_sccs();
@@ -1800,8 +1783,7 @@ int __init zs_init(void)
                info->event = 0;
                info->count = 0;
                info->blocked_open = 0;
-                info->tqueue.routine = do_softint;
+                tasklet_init(&info->tlet, do_softint, (unsigned long)info);
-                info->tqueue.data = info;
                init_waitqueue_head(&info->open_wait);
                init_waitqueue_head(&info->close_wait);
                printk("ttyS%02d at 0x%08x (irq = %d) is a Z85C30 SCC\n",
@@ -1833,8 +1815,7 @@ int __init zs_init(void)
 /*
 * polling I/O routines
 */
-static int
+static int zs_poll_tx_char(void *handle, unsigned char ch)
-zs_poll_tx_char(void *handle, unsigned char ch)
 {
        struct dec_serial *info = handle;
        struct dec_zschannel *chan = info->zs_channel;
@@ -1857,8 +1838,7 @@ zs_poll_tx_char(void *handle, unsigned char ch)
                return -ENODEV;
 }
-static int
+static int zs_poll_rx_char(void *handle)
-zs_poll_rx_char(void *handle)
 {
        struct dec_serial *info = handle;
        struct dec_zschannel *chan = info->zs_channel;
@@ -2037,7 +2017,7 @@ static int __init serial_console_setup(struct console *co, char *options)
        }
        co->cflag = cflag;
-        save_and_cli(flags);
+        spin_lock_irqsave(&zs_lock, flags);
        /*
         * Set up the baud rate generator.
@@ -2092,7 +2072,7 @@ static int __init serial_console_setup(struct console *co, char *options)
        zs_soft[co->index].clk_divisor = clk_divisor;
        zs_soft[co->index].zs_baud = get_zsbaud(&zs_soft[co->index]);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&zs_lock, flags);
        return 0;
 }
@@ -2229,5 +2209,3 @@ void __init zs_kgdb_hook(int tty_num)
        set_debug_traps(); /* init stub */
 }
 #endif /* ifdef CONFIG_KGDB */
diff --git a/drivers/tc/zs.h b/drivers/tc/zs.h
index c52edffa6049..13512200ceba 100644
--- a/drivers/tc/zs.h
+++ b/drivers/tc/zs.h
@@ -6,14 +6,14 @@
 *
 * Copyright (C) 1996 Paul Mackerras (Paul.Mackerras@cs.anu.edu.au)
 * Copyright (C) 1995 David S. Miller (davem@caip.rutgers.edu)
- * Copyright (C) 2004  Maciej W. Rozycki
+ * Copyright (C) 2004, 2005  Maciej W. Rozycki
 */
 #ifndef _DECSERIAL_H
 #define _DECSERIAL_H
 #include <asm/dec/serial.h>
-#define NUM_ZSREGS    16
+#define NUM_ZSREGS 16
 struct serial_struct {
        int     type;
@@ -139,8 +139,7 @@ struct dec_serial {
        int                     xmit_head;
        int                     xmit_tail;
        int                     xmit_cnt;
-        struct tq_struct        tqueue;
+        struct tasklet_struct   tlet;
-        struct tq_struct        tqueue_hangup;
        wait_queue_head_t       open_wait;
        wait_queue_head_t       close_wait;
 };
@@ -282,7 +281,7 @@ struct dec_serial {
 #define DLC     4       /* Disable Lower Chain */
 #define MIE     8       /* Master Interrupt Enable */
 #define STATHI  0x10    /* Status high */
-#define SOFTACK 0x20    /* Software Interrupt Acknowledge */
+#define SOFTACK 0x20    /* Software Interrupt Acknowledge */
 #define NORESET 0       /* No reset on write to R9 */
 #define CHRB    0x40    /* Reset channel B */
 #define CHRA    0x80    /* Reset channel A */
@@ -395,8 +394,8 @@ struct dec_serial {
 /* Read Register 15 (value of WR 15) */
 /* Misc macros */
-#define ZS_CLEARERR(channel)    (write_zsreg(channel, 0, ERR_RES))
+#define ZS_CLEARERR(channel)    (write_zsreg(channel, 0, ERR_RES))
-#define ZS_CLEARFIFO(channel)   do { volatile unsigned char garbage; \
+#define ZS_CLEARFIFO(channel)   do { volatile unsigned char garbage; \
                                     garbage = read_zsdata(channel); \
                                     garbage = read_zsdata(channel); \
                                     garbage = read_zsdata(channel); \
diff --git a/drivers/usb/atm/Makefile b/drivers/usb/atm/Makefile
index 751f297be2ef..85099718c683 100644
--- a/drivers/usb/atm/Makefile
+++ b/drivers/usb/atm/Makefile
@@ -6,3 +6,7 @@ obj-$(CONFIG_USB_CXACRU)	+= cxacru.o
 obj-$(CONFIG_USB_SPEEDTOUCH)    += speedtch.o
 obj-$(CONFIG_USB_ATM)           += usbatm.o
 obj-$(CONFIG_USB_XUSBATM)       += xusbatm.o
+ifeq ($(CONFIG_USB_DEBUG),y)
+EXTRA_CFLAGS += -DDEBUG
+endif
diff --git a/drivers/usb/atm/usbatm.h b/drivers/usb/atm/usbatm.h
index 936646457935..1adacd60d713 100644
--- a/drivers/usb/atm/usbatm.h
+++ b/drivers/usb/atm/usbatm.h
@@ -27,14 +27,9 @@
 #include <linux/config.h>
 /*
-#define DEBUG
 #define VERBOSE_DEBUG
 */
-#if !defined (DEBUG) && defined (CONFIG_USB_DEBUG)
-#       define DEBUG
-#endif
 #include <asm/semaphore.h>
 #include <linux/atm.h>
 #include <linux/atmdev.h>
diff --git a/drivers/usb/core/Makefile b/drivers/usb/core/Makefile
index dd1c4d2a0c31..86d5c380892d 100644
--- a/drivers/usb/core/Makefile
+++ b/drivers/usb/core/Makefile
@@ -14,3 +14,7 @@ ifeq ($(CONFIG_USB_DEVICEFS),y)
 endif
 obj-$(CONFIG_USB)       += usbcore.o
+ifeq ($(CONFIG_USB_DEBUG),y)
+EXTRA_CFLAGS += -DDEBUG
+endif
diff --git a/drivers/usb/core/buffer.c b/drivers/usb/core/buffer.c
index 57e800ac3cee..419c9943a7cb 100644
--- a/drivers/usb/core/buffer.c
+++ b/drivers/usb/core/buffer.c
@@ -15,14 +15,6 @@
 #include <asm/scatterlist.h>
 #include <linux/dma-mapping.h>
 #include <linux/dmapool.h>
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/usb.h>
 #include "hcd.h"
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
index 993019500cc3..a9d89c78cc20 100644
--- a/drivers/usb/core/config.c
+++ b/drivers/usb/core/config.c
@@ -1,9 +1,4 @@
 #include <linux/config.h>
-#ifdef CONFIG_USB_DEBUG
-#define DEBUG
-#endif
 #include <linux/usb.h>
 #include <linux/module.h>
 #include <linux/init.h>
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 942cd437dc48..b1d6e9af732d 100644
--- a/drivers/usb/core/devio.c
+++ b/drivers/usb/core/devio.c
@@ -1392,13 +1392,13 @@ static int proc_ioctl_default(struct dev_state *ps, void __user *arg)
 }
 #ifdef CONFIG_COMPAT
-static int proc_ioctl_compat(struct dev_state *ps, void __user *arg)
+static int proc_ioctl_compat(struct dev_state *ps, compat_uptr_t arg)
 {
        struct usbdevfs_ioctl32 __user *uioc;
        struct usbdevfs_ioctl ctrl;
        u32 udata;
-        uioc = compat_ptr(arg);
+        uioc = compat_ptr((long)arg);
        if (get_user(ctrl.ifno, &uioc->ifno) ||
            get_user(ctrl.ioctl_code, &uioc->ioctl_code) ||
            __get_user(udata, &uioc->data))
@@ -1511,7 +1511,7 @@ static int usbdev_ioctl(struct inode *inode, struct file *file, unsigned int cmd
        case USBDEVFS_IOCTL32:
                snoop(&dev->dev, "%s: IOCTL\n", __FUNCTION__);
-                ret = proc_ioctl_compat(ps, p);
+                ret = proc_ioctl_compat(ps, (compat_uptr_t)(long)p);
                break;
 #endif
diff --git a/drivers/usb/core/file.c b/drivers/usb/core/file.c
index e695308095ae..37b13368c814 100644
--- a/drivers/usb/core/file.c
+++ b/drivers/usb/core/file.c
@@ -19,12 +19,6 @@
 #include <linux/module.h>
 #include <linux/spinlock.h>
 #include <linux/errno.h>
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/usb.h>
 #include "usb.h"
diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c
index 84d9e69329bb..7feb829362d6 100644
--- a/drivers/usb/core/hcd-pci.c
+++ b/drivers/usb/core/hcd-pci.c
@@ -17,13 +17,6 @@
 */
 #include <linux/config.h>
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/pci.h>
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 6c7ca5b08cd6..5e5f65a475ab 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -23,11 +23,6 @@
 */
 #include <linux/config.h>
-#ifdef CONFIG_USB_DEBUG
-#define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/version.h>
 #include <linux/kernel.h>
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 256d9f698715..840727948d84 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -9,11 +9,6 @@
 */
 #include <linux/config.h>
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/module.h>
diff --git a/drivers/usb/core/inode.c b/drivers/usb/core/inode.c
index 12f490fdee8f..c44bbedec817 100644
--- a/drivers/usb/core/inode.c
+++ b/drivers/usb/core/inode.c
@@ -46,7 +46,6 @@
 static struct super_operations usbfs_ops;
 static struct file_operations default_file_operations;
-static struct inode_operations usbfs_dir_inode_operations;
 static struct vfsmount *usbfs_mount;
 static int usbfs_mount_count;   /* = 0 */
 static int ignore_mount = 0;
@@ -262,7 +261,7 @@ static struct inode *usbfs_get_inode (struct super_block *sb, int mode, dev_t de
                        inode->i_fop = &default_file_operations;
                        break;
                case S_IFDIR:
-                        inode->i_op = &usbfs_dir_inode_operations;
+                        inode->i_op = &simple_dir_inode_operations;
                        inode->i_fop = &simple_dir_operations;
                        /* directory inodes start off with i_nlink == 2 (for "." entry) */
@@ -417,10 +416,6 @@ static struct file_operations default_file_operations = {
        .llseek =       default_file_lseek,
 };
-static struct inode_operations usbfs_dir_inode_operations = {
-        .lookup =       simple_lookup,
-};
 static struct super_operations usbfs_ops = {
        .statfs =       simple_statfs,
        .drop_inode =   generic_delete_inode,
diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
index 644a3d4f12aa..fe74f99ca5f4 100644
--- a/drivers/usb/core/message.c
+++ b/drivers/usb/core/message.c
@@ -3,13 +3,6 @@
 */
 #include <linux/config.h>
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/pci.h>  /* for scatterlist macros */
 #include <linux/usb.h>
 #include <linux/module.h>
@@ -1457,12 +1450,11 @@ free_interfaces:
                 */
                for (i = 0; i < nintf; ++i) {
                        struct usb_interface *intf = cp->interface[i];
-                        struct usb_host_interface *alt = intf->cur_altsetting;
                        dev_dbg (&dev->dev,
                                "adding %s (config #%d, interface %d)\n",
                                intf->dev.bus_id, configuration,
-                                alt->desc.bInterfaceNumber);
+                                intf->cur_altsetting->desc.bInterfaceNumber);
                        ret = device_add (&intf->dev);
                        if (ret != 0) {
                                dev_err(&dev->dev,
diff --git a/drivers/usb/core/notify.c b/drivers/usb/core/notify.c
index 37da059eced7..fbbebab52fbd 100644
--- a/drivers/usb/core/notify.c
+++ b/drivers/usb/core/notify.c
@@ -12,13 +12,7 @@
 #include <linux/config.h>
 #include <linux/kernel.h>
 #include <linux/notifier.h>
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/usb.h>
 #include "usb.h"
diff --git a/drivers/usb/core/sysfs.c b/drivers/usb/core/sysfs.c
index edd83e014452..71d881327e88 100644
--- a/drivers/usb/core/sysfs.c
+++ b/drivers/usb/core/sysfs.c
@@ -12,14 +12,7 @@
 #include <linux/config.h>
 #include <linux/kernel.h>
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/usb.h>
 #include "usb.h"
 /* endpoint stuff */
diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c
index f2a1fed2a802..081796726b95 100644
--- a/drivers/usb/core/urb.c
+++ b/drivers/usb/core/urb.c
@@ -4,12 +4,6 @@
 #include <linux/bitops.h>
 #include <linux/slab.h>
 #include <linux/init.h>
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/usb.h>
 #include "hcd.h"
diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
index 0eefff7bcb3c..e197ce9353de 100644
--- a/drivers/usb/core/usb.c
+++ b/drivers/usb/core/usb.c
@@ -22,13 +22,6 @@
 */
 #include <linux/config.h>
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/string.h>
 #include <linux/bitops.h>
diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
index 1e407745c115..c655d46c8aed 100644
--- a/drivers/usb/gadget/dummy_hcd.c
+++ b/drivers/usb/gadget/dummy_hcd.c
@@ -944,7 +944,7 @@ static int dummy_udc_suspend (struct platform_device *dev, pm_message_t state)
        set_link_state (dum);
        spin_unlock_irq (&dum->lock);
-        dev->power.power_state = state;
+        dev->dev.power.power_state = state;
        usb_hcd_poll_rh_status (dummy_to_hcd (dum));
        return 0;
 }
@@ -1904,7 +1904,7 @@ static int dummy_hcd_probe (struct platform_device *dev)
        struct usb_hcd          *hcd;
        int                     retval;
-        dev_info (dev, "%s, driver " DRIVER_VERSION "\n", driver_desc);
+        dev_info(&dev->dev, "%s, driver " DRIVER_VERSION "\n", driver_desc);
        hcd = usb_create_hcd (&dummy_hcd, &dev->dev, dev->dev.bus_id);
        if (!hcd)
diff --git a/drivers/usb/host/ohci-lh7a404.c b/drivers/usb/host/ohci-lh7a404.c
index 081ec3f5cff4..3959ccc88332 100644
--- a/drivers/usb/host/ohci-lh7a404.c
+++ b/drivers/usb/host/ohci-lh7a404.c
@@ -219,7 +219,7 @@ static int ohci_hcd_lh7a404_drv_probe(struct platform_device *pdev)
 static int ohci_hcd_lh7a404_drv_remove(struct platform_device *pdev)
 {
-        struct usb_hcd *hcd = platform_get_drvdata(dev);
+        struct usb_hcd *hcd = platform_get_drvdata(pdev);
        usb_hcd_lh7a404_remove(hcd, pdev);
        return 0;
diff --git a/drivers/usb/host/ohci-ppc-soc.c b/drivers/usb/host/ohci-ppc-soc.c
index 18755766e406..2ec6a78bd65e 100644
--- a/drivers/usb/host/ohci-ppc-soc.c
+++ b/drivers/usb/host/ohci-ppc-soc.c
@@ -185,7 +185,7 @@ static int ohci_hcd_ppc_soc_drv_probe(struct platform_device *pdev)
 static int ohci_hcd_ppc_soc_drv_remove(struct platform_device *pdev)
 {
-        struct usb_hcd *hcd = platform_get_drvdata(dev);
+        struct usb_hcd *hcd = platform_get_drvdata(pdev);
        usb_hcd_ppc_soc_remove(hcd, pdev);
        return 0;
diff --git a/drivers/usb/image/microtek.c b/drivers/usb/image/microtek.c
index 61a2604cce4f..950543aa5ac7 100644
--- a/drivers/usb/image/microtek.c
+++ b/drivers/usb/image/microtek.c
@@ -327,6 +327,18 @@ static inline void mts_urb_abort(struct mts_desc* desc) {
        usb_kill_urb( desc->urb );
 }
+static int mts_slave_alloc (struct scsi_device *s)
+{
+        s->inquiry_len = 0x24;
+        return 0;
+}
+static int mts_slave_configure (struct scsi_device *s)
+{
+        blk_queue_dma_alignment(s->request_queue, (512 - 1));
+        return 0;
+}
 static int mts_scsi_abort (Scsi_Cmnd *srb)
 {
        struct mts_desc* desc = (struct mts_desc*)(srb->device->host->hostdata[0]);
@@ -411,7 +423,7 @@ static void mts_transfer_done( struct urb *transfer, struct pt_regs *regs )
        MTS_INT_INIT();
        context->srb->result &= MTS_SCSI_ERR_MASK;
-        context->srb->result |= (unsigned)context->status<<1;
+        context->srb->result |= (unsigned)(*context->scsi_status)<<1;
        mts_transfer_cleanup(transfer);
@@ -427,7 +439,7 @@ static void mts_get_status( struct urb *transfer )
        mts_int_submit_urb(transfer,
                           usb_rcvbulkpipe(context->instance->usb_dev,
                                           context->instance->ep_response),
-                           &context->status,
+                           context->scsi_status,
                           1,
                           mts_transfer_done );
 }
@@ -481,7 +493,7 @@ static void mts_command_done( struct urb *transfer, struct pt_regs *regs )
                                           context->data_pipe,
                                           context->data,
                                           context->data_length,
-                                           context->srb->use_sg ? mts_do_sg : mts_data_done);
+                                           context->srb->use_sg > 1 ? mts_do_sg : mts_data_done);
                } else {
                        mts_get_status(transfer);
                }
@@ -627,7 +639,6 @@ int mts_scsi_queuecommand( Scsi_Cmnd *srb, mts_scsi_cmnd_callback callback )
                        callback(srb);
        }
 out:
        return err;
 }
@@ -645,6 +656,9 @@ static struct scsi_host_template mts_scsi_host_template = {
        .cmd_per_lun =          1,
        .use_clustering =       1,
        .emulated =             1,
+        .slave_alloc =          mts_slave_alloc,
+        .slave_configure =      mts_slave_configure,
+        .max_sectors=           256, /* 128 K */
 };
 struct vendor_product
@@ -771,8 +785,8 @@ static int mts_usb_probe(struct usb_interface *intf,
                MTS_WARNING( "couldn't find an output bulk endpoint. Bailing out.\n" );
                return -ENODEV;
        }
-        
-        
        new_desc = kzalloc(sizeof(struct mts_desc), GFP_KERNEL);
        if (!new_desc)
                goto out;
@@ -781,6 +795,10 @@ static int mts_usb_probe(struct usb_interface *intf,
        if (!new_desc->urb)
                goto out_kfree;
+        new_desc->context.scsi_status = kmalloc(1, GFP_KERNEL);
+        if (!new_desc->context.scsi_status)
+                goto out_kfree2;
        new_desc->usb_dev = dev;
        new_desc->usb_intf = intf;
        init_MUTEX(&new_desc->lock);
@@ -817,6 +835,8 @@ static int mts_usb_probe(struct usb_interface *intf,
        usb_set_intfdata(intf, new_desc);
        return 0;
+ out_kfree2:
+        kfree(new_desc->context.scsi_status);
 out_free_urb:
        usb_free_urb(new_desc->urb);
 out_kfree:
@@ -836,6 +856,7 @@ static void mts_usb_disconnect (struct usb_interface *intf)
        scsi_host_put(desc->host);
        usb_free_urb(desc->urb);
+        kfree(desc->context.scsi_status);
        kfree(desc);
 }
@@ -856,5 +877,3 @@ module_exit(microtek_drv_exit);
 MODULE_AUTHOR( DRIVER_AUTHOR );
 MODULE_DESCRIPTION( DRIVER_DESC );
 MODULE_LICENSE("GPL");
diff --git a/drivers/usb/image/microtek.h b/drivers/usb/image/microtek.h
index 3271deb8c001..926d4bdc6746 100644
--- a/drivers/usb/image/microtek.h
+++ b/drivers/usb/image/microtek.h
@@ -22,7 +22,7 @@ struct mts_transfer_context
        int data_pipe;
        int fragment;
-        u8 status; /* status returned from ep_response after command completion */
+        u8 *scsi_status; /* status returned from ep_response after command completion */
 };
diff --git a/drivers/usb/input/Makefile b/drivers/usb/input/Makefile
index 5e03b93f29f6..07cb17db42fc 100644
--- a/drivers/usb/input/Makefile
+++ b/drivers/usb/input/Makefile
@@ -42,3 +42,7 @@ obj-$(CONFIG_USB_ACECAD)	+= acecad.o
 obj-$(CONFIG_USB_YEALINK)       += yealink.o
 obj-$(CONFIG_USB_XPAD)          += xpad.o
 obj-$(CONFIG_USB_APPLETOUCH)    += appletouch.o
+ifeq ($(CONFIG_USB_DEBUG),y)
+EXTRA_CFLAGS += -DDEBUG
+endif
diff --git a/drivers/usb/input/hid-core.c b/drivers/usb/input/hid-core.c
index 79ddce4555ab..45f3130fadea 100644
--- a/drivers/usb/input/hid-core.c
+++ b/drivers/usb/input/hid-core.c
@@ -1318,6 +1318,7 @@ void hid_init_reports(struct hid_device *hid)
 #define USB_DEVICE_ID_WACOM_PTU         0x0003
 #define USB_DEVICE_ID_WACOM_INTUOS3     0x00B0
 #define USB_DEVICE_ID_WACOM_CINTIQ      0x003F
+#define USB_DEVICE_ID_WACOM_DTF         0x00C0
 #define USB_VENDOR_ID_ACECAD            0x0460
 #define USB_DEVICE_ID_ACECAD_FLAIR      0x0004
@@ -1524,6 +1525,9 @@ static struct hid_blacklist {
        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_PL + 3, HID_QUIRK_IGNORE },
        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_PL + 4, HID_QUIRK_IGNORE },
        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_PL + 5, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_PL + 7, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_PL + 8, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_PL + 9, HID_QUIRK_IGNORE },
        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS2 + 1, HID_QUIRK_IGNORE },
        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS2 + 2, HID_QUIRK_IGNORE },
        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS2 + 3, HID_QUIRK_IGNORE },
@@ -1531,11 +1535,19 @@ static struct hid_blacklist {
        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS2 + 5, HID_QUIRK_IGNORE },
        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS2 + 7, HID_QUIRK_IGNORE },
        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_VOLITO, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_VOLITO + 1, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_VOLITO + 2, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_VOLITO + 3, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_VOLITO + 4, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_GRAPHIRE + 5, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_GRAPHIRE + 6, HID_QUIRK_IGNORE },
        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_PTU, HID_QUIRK_IGNORE },
        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS3, HID_QUIRK_IGNORE },
        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS3 + 1, HID_QUIRK_IGNORE },
        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS3 + 2, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_INTUOS3 + 5, HID_QUIRK_IGNORE },
        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_CINTIQ, HID_QUIRK_IGNORE },
+        { USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_DTF, HID_QUIRK_IGNORE },
        { USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_4_PHIDGETSERVO_20, HID_QUIRK_IGNORE },
        { USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_1_PHIDGETSERVO_20, HID_QUIRK_IGNORE },
diff --git a/drivers/usb/input/itmtouch.c b/drivers/usb/input/itmtouch.c
index 3b581853cf10..4a50acb39d29 100644
--- a/drivers/usb/input/itmtouch.c
+++ b/drivers/usb/input/itmtouch.c
@@ -40,13 +40,6 @@
 *****************************************************************************/
 #include <linux/config.h>
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/input.h>
diff --git a/drivers/usb/input/keyspan_remote.c b/drivers/usb/input/keyspan_remote.c
index 5b8d65f62abf..a32cfe51b77d 100644
--- a/drivers/usb/input/keyspan_remote.c
+++ b/drivers/usb/input/keyspan_remote.c
@@ -160,7 +160,8 @@ static int keyspan_load_tester(struct usb_keyspan* dev, int bits_needed)
         * though so it's not too big a deal
         */
        if (dev->data.pos >= dev->data.len) {
-                dev_dbg(&dev->udev, "%s - Error ran out of data. pos: %d, len: %d\n",
+                dev_dbg(&dev->udev->dev,
+                        "%s - Error ran out of data. pos: %d, len: %d\n",
                        __FUNCTION__, dev->data.pos, dev->data.len);
                return -1;
        }
@@ -306,7 +307,7 @@ static void keyspan_check_data(struct usb_keyspan *remote, struct pt_regs *regs)
                        err("Bad message recieved, no stop bit found.\n");
                }
-                dev_dbg(&remote->udev,
+                dev_dbg(&remote->udev->dev,
                        "%s found valid message: system: %d, button: %d, toggle: %d\n",
                        __FUNCTION__, message.system, message.button, message.toggle);
diff --git a/drivers/usb/input/mtouchusb.c b/drivers/usb/input/mtouchusb.c
index 7fce526560ca..52cc18cd247d 100644
--- a/drivers/usb/input/mtouchusb.c
+++ b/drivers/usb/input/mtouchusb.c
@@ -40,13 +40,6 @@
 *****************************************************************************/
 #include <linux/config.h>
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG
-#else
-        #undef DEBUG
-#endif
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/input.h>
diff --git a/drivers/usb/input/pid.c b/drivers/usb/input/pid.c
index dca5ee93a4ef..19e015d171aa 100644
--- a/drivers/usb/input/pid.c
+++ b/drivers/usb/input/pid.c
@@ -37,8 +37,6 @@
 #include "hid.h"
 #include "pid.h"
-#define DEBUG
 #define CHECK_OWNERSHIP(i, hid_pid)     \
        ((i) < FF_EFFECTS_MAX && i >= 0 && \
        test_bit(FF_PID_FLAGS_USED, &hid_pid->effects[(i)].flags) && \
diff --git a/drivers/usb/input/touchkitusb.c b/drivers/usb/input/touchkitusb.c
index 0043e6ebcd1f..7420c6b84284 100644
--- a/drivers/usb/input/touchkitusb.c
+++ b/drivers/usb/input/touchkitusb.c
@@ -30,10 +30,6 @@
 #include <linux/input.h>
 #include <linux/module.h>
 #include <linux/init.h>
-#if !defined(DEBUG) && defined(CONFIG_USB_DEBUG)
-#define DEBUG
-#endif
 #include <linux/usb.h>
 #include <linux/usb_input.h>
diff --git a/drivers/usb/input/wacom.c b/drivers/usb/input/wacom.c
index ea0f75773ae1..aea1cfae34cc 100644
--- a/drivers/usb/input/wacom.c
+++ b/drivers/usb/input/wacom.c
@@ -52,8 +52,10 @@
 *    v1.30.1 (pi) - Added Graphire3 support
 *      v1.40 (pc) - Add support for several new devices, fix eraser reporting, ...
 *      v1.43 (pc) - Added support for Cintiq 21UX
-                   - Fixed a Graphire bug
+ *                 - Fixed a Graphire bug
-                   - Merged wacom_intuos3_irq into wacom_intuos_irq
+ *                 - Merged wacom_intuos3_irq into wacom_intuos_irq
+ *      v1.44 (pc) - Added support for Graphire4, Cintiq 710, Intuos3 6x11, etc.
+ *                 - Report Device IDs
 */
 /*
@@ -76,7 +78,7 @@
 /*
 * Version Information
 */
-#define DRIVER_VERSION "v1.43"
+#define DRIVER_VERSION "v1.44"
 #define DRIVER_AUTHOR "Vojtech Pavlik <vojtech@ucw.cz>"
 #define DRIVER_DESC "USB Wacom Graphire and Wacom Intuos tablet driver"
 #define DRIVER_LICENSE "GPL"
@@ -86,10 +88,14 @@ MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE(DRIVER_LICENSE);
 #define USB_VENDOR_ID_WACOM     0x056a
+#define STYLUS_DEVICE_ID        0x02
+#define CURSOR_DEVICE_ID        0x06
+#define ERASER_DEVICE_ID        0x0A
 enum {
        PENPARTNER = 0,
        GRAPHIRE,
+        G4,
        PL,
        INTUOS,
        INTUOS3,
@@ -116,6 +122,7 @@ struct wacom {
        struct urb *irq;
        struct wacom_features *features;
        int tool[2];
+        int id[2];
        __u32 serial[2];
        char phys[32];
 };
@@ -136,7 +143,7 @@ static void wacom_pl_irq(struct urb *urb, struct pt_regs *regs)
        struct wacom *wacom = urb->context;
        unsigned char *data = wacom->data;
        struct input_dev *dev = wacom->dev;
-        int prox, pressure;
+        int prox, pressure, id;
        int retval;
        switch (urb->status) {
@@ -163,6 +170,7 @@ static void wacom_pl_irq(struct urb *urb, struct pt_regs *regs)
        input_regs(dev, regs);
+        id = ERASER_DEVICE_ID;
        if (prox) {
                pressure = (signed char)((data[7] << 1) | ((data[4] >> 2) & 1));
@@ -177,11 +185,15 @@ static void wacom_pl_irq(struct urb *urb, struct pt_regs *regs)
                 * an out of proximity for previous tool then a in for new tool.
                 */
                if (!wacom->tool[0]) {
-                        /* Going into proximity select tool */
+                        /* Eraser bit set for DTF */
-                        wacom->tool[1] = (data[4] & 0x20)? BTN_TOOL_RUBBER : BTN_TOOL_PEN;
+                        if (data[1] & 0x10)
+                                wacom->tool[1] = BTN_TOOL_RUBBER;
+                        else
+                                /* Going into proximity select tool */
+                                wacom->tool[1] = (data[4] & 0x20) ? BTN_TOOL_RUBBER : BTN_TOOL_PEN;
                } else {
                        /* was entered with stylus2 pressed */
-                        if (wacom->tool[1] == BTN_TOOL_RUBBER && !(data[4] & 0x20) ) {
+                        if (wacom->tool[1] == BTN_TOOL_RUBBER && !(data[4] & 0x20)) {
                                /* report out proximity for previous tool */
                                input_report_key(dev, wacom->tool[1], 0);
                                input_sync(dev);
@@ -192,8 +204,9 @@ static void wacom_pl_irq(struct urb *urb, struct pt_regs *regs)
                if (wacom->tool[1] != BTN_TOOL_RUBBER) {
                        /* Unknown tool selected default to pen tool */
                        wacom->tool[1] = BTN_TOOL_PEN;
+                        id = STYLUS_DEVICE_ID;
                }
-                input_report_key(dev, wacom->tool[1], prox); /* report in proximity for tool */
+                input_report_key(dev, wacom->tool[1], id); /* report in proximity for tool */
                input_report_abs(dev, ABS_X, data[3] | (data[2] << 7) | ((data[1] & 0x03) << 14));
                input_report_abs(dev, ABS_Y, data[6] | (data[5] << 7) | ((data[4] & 0x03) << 14));
                input_report_abs(dev, ABS_PRESSURE, pressure);
@@ -250,10 +263,10 @@ static void wacom_ptu_irq(struct urb *urb, struct pt_regs *regs)
        input_regs(dev, regs);
        if (data[1] & 0x04) {
-                input_report_key(dev, BTN_TOOL_RUBBER, data[1] & 0x20);
+                input_report_key(dev, BTN_TOOL_RUBBER, (data[1] & 0x20) ? ERASER_DEVICE_ID : 0);
                input_report_key(dev, BTN_TOUCH, data[1] & 0x08);
        } else {
-                input_report_key(dev, BTN_TOOL_PEN, data[1] & 0x20);
+                input_report_key(dev, BTN_TOOL_PEN, (data[1] & 0x20) ? STYLUS_DEVICE_ID : 0);
                input_report_key(dev, BTN_TOUCH, data[1] & 0x01);
        }
        input_report_abs(dev, ABS_X, le16_to_cpu(*(__le16 *) &data[2]));
@@ -299,7 +312,7 @@ static void wacom_penpartner_irq(struct urb *urb, struct pt_regs *regs)
        }
        input_regs(dev, regs);
-        input_report_key(dev, BTN_TOOL_PEN, 1);
+        input_report_key(dev, BTN_TOOL_PEN, STYLUS_DEVICE_ID);
        input_report_abs(dev, ABS_X, le16_to_cpu(*(__le16 *) &data[1]));
        input_report_abs(dev, ABS_Y, le16_to_cpu(*(__le16 *) &data[3]));
        input_report_abs(dev, ABS_PRESSURE, (signed char)data[6] + 127);
@@ -319,7 +332,7 @@ static void wacom_graphire_irq(struct urb *urb, struct pt_regs *regs)
        struct wacom *wacom = urb->context;
        unsigned char *data = wacom->data;
        struct input_dev *dev = wacom->dev;
-        int x, y;
+        int x, y, id, rw;
        int retval;
        switch (urb->status) {
@@ -344,6 +357,7 @@ static void wacom_graphire_irq(struct urb *urb, struct pt_regs *regs)
        input_regs(dev, regs);
+        id = STYLUS_DEVICE_ID;
        if (data[1] & 0x10) { /* in prox */
                switch ((data[1] >> 5) & 3) {
@@ -354,18 +368,27 @@ static void wacom_graphire_irq(struct urb *urb, struct pt_regs *regs)
                        case 1: /* Rubber */
                                wacom->tool[0] = BTN_TOOL_RUBBER;
+                                id = ERASER_DEVICE_ID;
                                break;
                        case 2: /* Mouse with wheel */
                                input_report_key(dev, BTN_MIDDLE, data[1] & 0x04);
-                                input_report_rel(dev, REL_WHEEL, (signed char) data[6]);
+                                if (wacom->features->type == G4) {
+                                        rw = data[7] & 0x04 ? -(data[7] & 0x03) : (data[7] & 0x03);
+                                        input_report_rel(dev, REL_WHEEL, rw);
+                                } else
+                                        input_report_rel(dev, REL_WHEEL, (signed char) data[6]);
                                /* fall through */
                        case 3: /* Mouse without wheel */
                                wacom->tool[0] = BTN_TOOL_MOUSE;
+                                id = CURSOR_DEVICE_ID;
                                input_report_key(dev, BTN_LEFT, data[1] & 0x01);
                                input_report_key(dev, BTN_RIGHT, data[1] & 0x02);
-                                input_report_abs(dev, ABS_DISTANCE, data[7]);
+                                if (wacom->features->type == G4)
+                                        input_report_abs(dev, ABS_DISTANCE, data[6]);
+                                else
+                                        input_report_abs(dev, ABS_DISTANCE, data[7]);
                                break;
                }
        }
@@ -376,16 +399,50 @@ static void wacom_graphire_irq(struct urb *urb, struct pt_regs *regs)
                input_report_abs(dev, ABS_X, x);
                input_report_abs(dev, ABS_Y, y);
                if (wacom->tool[0] != BTN_TOOL_MOUSE) {
-                        input_report_abs(dev, ABS_PRESSURE, le16_to_cpu(*(__le16 *) &data[6]));
+                        input_report_abs(dev, ABS_PRESSURE, data[6] | ((data[7] & 0x01) << 8));
                        input_report_key(dev, BTN_TOUCH, data[1] & 0x01);
                        input_report_key(dev, BTN_STYLUS, data[1] & 0x02);
                        input_report_key(dev, BTN_STYLUS2, data[1] & 0x04);
                }
        }
-        input_report_key(dev, wacom->tool[0], data[1] & 0x10);
+        input_report_key(dev, wacom->tool[0], (data[1] & 0x10) ? id : 0);
        input_sync(dev);
+        /* send pad data */
+        if (wacom->features->type == G4) {
+                /* fist time sending pad data */
+                if (wacom->tool[1] != BTN_TOOL_FINGER) {
+                        wacom->id[1] = 0;
+                        wacom->serial[1] = (data[7] & 0x38) >> 2;
+                }
+                if (data[7] & 0xf8) {
+                        input_report_key(dev, BTN_0, (data[7] & 0x40));
+                        input_report_key(dev, BTN_4, (data[7] & 0x80));
+                        if (((data[7] & 0x38) >> 2) == (wacom->serial[1] & 0x0e))
+                                /* alter REL_WHEEL value so X apps can get it */
+                                wacom->serial[1] += (wacom->serial[1] & 0x01) ? -1 : 1;
+                        else
+                                 wacom->serial[1] = (data[7] & 0x38 ) >> 2;
+                        /* don't alter the value when there is no wheel event */
+                        if (wacom->serial[1] == 1)
+                                wacom->serial[1] = 0;
+                        rw = wacom->serial[1];
+                        rw = (rw & 0x08) ? -(rw & 0x07) : (rw & 0x07);
+                        input_report_rel(dev, REL_WHEEL, rw);
+                        wacom->tool[1] = BTN_TOOL_FINGER;
+                        wacom->id[1] = data[7] & 0xf8;
+                        input_report_key(dev, wacom->tool[1], 0xf0);
+                        input_event(dev, EV_MSC, MSC_SERIAL, 0xf0);
+                } else if (wacom->id[1]) {
+                        wacom->id[1] = 0;
+                        wacom->serial[1] = 0;
+                        input_report_key(dev, wacom->tool[1], 0);
+                        input_event(dev, EV_MSC, MSC_SERIAL, 0xf0);
+                }
+                input_sync(dev);
+        }
 exit:
        retval = usb_submit_urb (urb, GFP_ATOMIC);
        if (retval)
@@ -410,7 +467,8 @@ static int wacom_intuos_inout(struct urb *urb)
                        (data[4] << 20) + (data[5] << 12) +
                        (data[6] << 4) + (data[7] >> 4);
-                switch ((data[2] << 4) | (data[3] >> 4)) {
+                wacom->id[idx] = (data[2] << 4) | (data[3] >> 4);
+                switch (wacom->id[idx]) {
                        case 0x812: /* Inking pen */
                        case 0x801: /* Intuos3 Inking pen */
                        case 0x012:
@@ -458,7 +516,7 @@ static int wacom_intuos_inout(struct urb *urb)
                        default: /* Unknown tool */
                                wacom->tool[idx] = BTN_TOOL_PEN;
                }
-                input_report_key(dev, wacom->tool[idx], 1);
+                input_report_key(dev, wacom->tool[idx], wacom->id[idx]);
                input_event(dev, EV_MSC, MSC_SERIAL, wacom->serial[idx]);
                input_sync(dev);
                return 1;
@@ -637,7 +695,7 @@ static void wacom_intuos_irq(struct urb *urb, struct pt_regs *regs)
                }
        }
-        input_report_key(dev, wacom->tool[idx], 1);
+        input_report_key(dev, wacom->tool[idx], wacom->id[idx]);
        input_event(dev, EV_MSC, MSC_SERIAL, wacom->serial[idx]);
        input_sync(dev);
@@ -655,6 +713,13 @@ static struct wacom_features wacom_features[] = {
        { "Wacom Graphire2 5x7", 8,  13918, 10206,  511, 32, GRAPHIRE,   wacom_graphire_irq },
        { "Wacom Graphire3",     8,  10208,  7424,  511, 32, GRAPHIRE,   wacom_graphire_irq },
        { "Wacom Graphire3 6x8", 8,  16704, 12064,  511, 32, GRAPHIRE,   wacom_graphire_irq },
+        { "Wacom Graphire4 4x5", 8,  10208,  7424,  511, 32, G4,         wacom_graphire_irq },
+        { "Wacom Graphire4 6x8", 8,  16704, 12064,  511, 32, G4,         wacom_graphire_irq },
+        { "Wacom Volito",        8,   5104,  3712,  511, 32, GRAPHIRE,   wacom_graphire_irq },
+        { "Wacom PenStation2",   8,   3250,  2320,  255, 32, GRAPHIRE,   wacom_graphire_irq },
+        { "Wacom Volito2 4x5",   8,   5104,  3712,  511, 32, GRAPHIRE,   wacom_graphire_irq },
+        { "Wacom Volito2 2x3",   8,   3248,  2320,  511, 32, GRAPHIRE,   wacom_graphire_irq },
+        { "Wacom PenPartner2",   8,   3250,  2320,  255, 32, GRAPHIRE,   wacom_graphire_irq },
        { "Wacom Intuos 4x5",   10,  12700, 10600, 1023, 15, INTUOS,     wacom_intuos_irq },
        { "Wacom Intuos 6x8",   10,  20320, 16240, 1023, 15, INTUOS,     wacom_intuos_irq },
        { "Wacom Intuos 9x12",  10,  30480, 24060, 1023, 15, INTUOS,     wacom_intuos_irq },
@@ -666,16 +731,20 @@ static struct wacom_features wacom_features[] = {
        { "Wacom PL600SX",       8,   6260,  5016,  255, 32, PL,         wacom_pl_irq },
        { "Wacom PL550",         8,   6144,  4608,  511, 32, PL,         wacom_pl_irq },
        { "Wacom PL800",         8,   7220,  5780,  511, 32, PL,         wacom_pl_irq },
+        { "Wacom PL700",         8,   6758,  5406,  511, 32, PL,         wacom_pl_irq },
+        { "Wacom PL510",         8,   6282,  4762,  511, 32, PL,         wacom_pl_irq },
+        { "Wacom PL710",         8,  34080, 27660,  511, 32, PL,         wacom_pl_irq },
+        { "Wacom DTF720",        8,   6858,  5506,  511, 32, PL,         wacom_pl_irq },
+        { "Wacom Cintiq Partner",8,  20480, 15360,  511, 32, PL,         wacom_ptu_irq },
        { "Wacom Intuos2 4x5",   10, 12700, 10600, 1023, 15, INTUOS,     wacom_intuos_irq },
        { "Wacom Intuos2 6x8",   10, 20320, 16240, 1023, 15, INTUOS,     wacom_intuos_irq },
        { "Wacom Intuos2 9x12",  10, 30480, 24060, 1023, 15, INTUOS,     wacom_intuos_irq },
        { "Wacom Intuos2 12x12", 10, 30480, 31680, 1023, 15, INTUOS,     wacom_intuos_irq },
        { "Wacom Intuos2 12x18", 10, 45720, 31680, 1023, 15, INTUOS,     wacom_intuos_irq },
-        { "Wacom Volito",        8,   5104,  3712,  511, 32, GRAPHIRE,   wacom_graphire_irq },
-        { "Wacom Cintiq Partner",8,  20480, 15360,  511, 32, PL,         wacom_ptu_irq },
        { "Wacom Intuos3 4x5",   10, 25400, 20320, 1023, 15, INTUOS3,    wacom_intuos_irq },
        { "Wacom Intuos3 6x8",   10, 40640, 30480, 1023, 15, INTUOS3,    wacom_intuos_irq },
        { "Wacom Intuos3 9x12",  10, 60960, 45720, 1023, 15, INTUOS3,    wacom_intuos_irq },
+        { "Wacom Intuos3 6x11",  10, 54204, 31750, 1023, 15, INTUOS3,    wacom_intuos_irq },
        { "Wacom Cintiq 21UX",   10, 87200, 65600, 1023, 15, CINTIQ,     wacom_intuos_irq },
        { "Wacom Intuos2 6x8",   10, 20320, 16240, 1023, 15, INTUOS,     wacom_intuos_irq },
        { }
@@ -688,6 +757,13 @@ static struct usb_device_id wacom_ids[] = {
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x12) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x13) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x14) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x15) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x16) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x60) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x61) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x62) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x63) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x64) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x20) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x21) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x22) },
@@ -699,16 +775,20 @@ static struct usb_device_id wacom_ids[] = {
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x33) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x34) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x35) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x37) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x38) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x39) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xC0) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x03) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x41) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x42) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x43) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x44) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x45) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x60) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x03) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB0) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB1) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB2) },
+        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB5) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x3F) },
        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x47) },
        { }
@@ -779,6 +859,13 @@ static int wacom_probe(struct usb_interface *intf, const struct usb_device_id *i
        input_set_abs_params(input_dev, ABS_PRESSURE, 0, wacom->features->pressure_max, 0, 0);
        switch (wacom->features->type) {
+                case G4:
+                        input_dev->evbit[0] |= BIT(EV_MSC);
+                        input_dev->mscbit[0] |= BIT(MSC_SERIAL);
+                        input_dev->keybit[LONG(BTN_DIGI)] |= BIT(BTN_TOOL_FINGER);
+                        input_dev->keybit[LONG(BTN_LEFT)] |= BIT(BTN_0) | BIT(BTN_1) | BIT(BTN_2) | BIT(BTN_3) | BIT(BTN_4) | BIT(BTN_5) | BIT(BTN_6) | BIT(BTN_7);
+                        /* fall through */
                case GRAPHIRE:
                        input_dev->evbit[0] |= BIT(EV_REL);
                        input_dev->relbit[0] |= BIT(REL_WHEEL);
diff --git a/drivers/usb/misc/Makefile b/drivers/usb/misc/Makefile
index 862e40a83689..6c693bc68e2e 100644
--- a/drivers/usb/misc/Makefile
+++ b/drivers/usb/misc/Makefile
@@ -18,4 +18,8 @@ obj-$(CONFIG_USB_RIO500)	+= rio500.o
 obj-$(CONFIG_USB_TEST)          += usbtest.o
 obj-$(CONFIG_USB_USS720)        += uss720.o
-obj-$(CONFIG_USB_SISUSBVGA)     += sisusbvga/
-\ No newline at end of file
+obj-$(CONFIG_USB_SISUSBVGA)     += sisusbvga/
+ifeq ($(CONFIG_USB_DEBUG),y)
+EXTRA_CFLAGS += -DDEBUG
+endif
diff --git a/drivers/usb/misc/auerswald.c b/drivers/usb/misc/auerswald.c
index 5f33f7c64885..2a28ceeaa66a 100644
--- a/drivers/usb/misc/auerswald.c
+++ b/drivers/usb/misc/auerswald.c
@@ -30,7 +30,6 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/wait.h>
-#undef DEBUG            /* include debug macros until it's done */
 #include <linux/usb.h>
 /*-------------------------------------------------------------------*/
diff --git a/drivers/usb/misc/phidgetservo.c b/drivers/usb/misc/phidgetservo.c
index b84eda631ab5..a30d4a6ee824 100644
--- a/drivers/usb/misc/phidgetservo.c
+++ b/drivers/usb/misc/phidgetservo.c
@@ -26,9 +26,6 @@
 */
 #include <linux/config.h>
-#ifdef CONFIG_USB_DEBUG
-#define DEBUG   1
-#endif
 #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/init.h>
diff --git a/drivers/usb/misc/rio500.c b/drivers/usb/misc/rio500.c
index 7d02d8ec6b1a..9590dbac5d9a 100644
--- a/drivers/usb/misc/rio500.c
+++ b/drivers/usb/misc/rio500.c
@@ -393,7 +393,7 @@ read_rio(struct file *file, char __user *buffer, size_t count, loff_t * ppos)
                                      ibuf, this_read, &partial,
                                      8000);
-                dbg(KERN_DEBUG "read stats: result:%d this_read:%u partial:%u",
+                dbg("read stats: result:%d this_read:%u partial:%u",
                       result, this_read, partial);
                if (partial) {
diff --git a/drivers/usb/misc/usbled.c b/drivers/usb/misc/usbled.c
index f6ba4c788dbc..3c93921cb6b3 100644
--- a/drivers/usb/misc/usbled.c
+++ b/drivers/usb/misc/usbled.c
@@ -10,9 +10,6 @@
 */
 #include <linux/config.h>
-#ifdef CONFIG_USB_DEBUG
-        #define DEBUG   1
-#endif
 #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/init.h>
diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c
index 2997f558159b..605a2afe34ed 100644
--- a/drivers/usb/misc/usbtest.c
+++ b/drivers/usb/misc/usbtest.c
@@ -1,7 +1,4 @@
 #include <linux/config.h>
-#if !defined (DEBUG) && defined (CONFIG_USB_DEBUG)
-#   define DEBUG
-#endif
 #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/init.h>
diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
index 0592cb5e6c4d..1cabe7ed91f5 100644
--- a/drivers/usb/misc/uss720.c
+++ b/drivers/usb/misc/uss720.c
@@ -41,8 +41,6 @@
 /*****************************************************************************/
-#define DEBUG
 #include <linux/module.h>
 #include <linux/socket.h>
 #include <linux/parport.h>
diff --git a/drivers/usb/net/Makefile b/drivers/usb/net/Makefile
index 222c0495f791..a21e6eaabaf6 100644
--- a/drivers/usb/net/Makefile
+++ b/drivers/usb/net/Makefile
@@ -16,3 +16,7 @@ obj-$(CONFIG_USB_NET_CDC_SUBSET)	+= cdc_subset.o
 obj-$(CONFIG_USB_NET_ZAURUS)    += zaurus.o
 obj-$(CONFIG_USB_USBNET)        += usbnet.o
 obj-$(CONFIG_USB_ZD1201)        += zd1201.o
+ifeq ($(CONFIG_USB_DEBUG),y)
+EXTRA_CFLAGS += -DDEBUG
+endif
diff --git a/drivers/usb/net/asix.c b/drivers/usb/net/asix.c
index 252a34fbb42c..542120ef1fd2 100644
--- a/drivers/usb/net/asix.c
+++ b/drivers/usb/net/asix.c
@@ -23,9 +23,6 @@
 // #define      VERBOSE                 // more; success messages
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/kmod.h>
 #include <linux/sched.h>
diff --git a/drivers/usb/net/cdc_ether.c b/drivers/usb/net/cdc_ether.c
index 652b04bbf6af..c008c981862b 100644
--- a/drivers/usb/net/cdc_ether.c
+++ b/drivers/usb/net/cdc_ether.c
@@ -21,9 +21,6 @@
 // #define      VERBOSE                 // more; success messages
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/init.h>
diff --git a/drivers/usb/net/cdc_subset.c b/drivers/usb/net/cdc_subset.c
index f1730b685fd2..f05cfb83c82d 100644
--- a/drivers/usb/net/cdc_subset.c
+++ b/drivers/usb/net/cdc_subset.c
@@ -18,9 +18,6 @@
 */
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/kmod.h>
 #include <linux/sched.h>
diff --git a/drivers/usb/net/gl620a.c b/drivers/usb/net/gl620a.c
index c0f263b202a6..2455e9a85674 100644
--- a/drivers/usb/net/gl620a.c
+++ b/drivers/usb/net/gl620a.c
@@ -22,9 +22,6 @@
 // #define      VERBOSE                 // more; success messages
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/init.h>
diff --git a/drivers/usb/net/kaweth.c b/drivers/usb/net/kaweth.c
index 6bef1be6b36c..b5776518020f 100644
--- a/drivers/usb/net/kaweth.c
+++ b/drivers/usb/net/kaweth.c
@@ -219,7 +219,6 @@ struct kaweth_device
        __u32 status;
        int end;
-        int removed;
        int suspend_lowmem_rx;
        int suspend_lowmem_ctrl;
        int linkstate;
@@ -699,6 +698,7 @@ static int kaweth_close(struct net_device *net)
        usb_kill_urb(kaweth->irq_urb);
        usb_kill_urb(kaweth->rx_urb);
+        usb_kill_urb(kaweth->tx_urb);
        flush_scheduled_work();
@@ -750,13 +750,6 @@ static int kaweth_start_xmit(struct sk_buff *skb, struct net_device *net)
        spin_lock(&kaweth->device_lock);
-        if (kaweth->removed) {
-        /* our device is undergoing disconnection - we bail out */
-                spin_unlock(&kaweth->device_lock);
-                dev_kfree_skb_irq(skb);
-                return 0;
-        }
        kaweth_async_set_rx_mode(kaweth);
        netif_stop_queue(net);
@@ -1136,10 +1129,6 @@ static void kaweth_disconnect(struct usb_interface *intf)
                return;
        }
        netdev = kaweth->net;
-        kaweth->removed = 1;
-        usb_kill_urb(kaweth->irq_urb);
-        usb_kill_urb(kaweth->rx_urb);
-        usb_kill_urb(kaweth->tx_urb);
        kaweth_dbg("Unregistering net device");
        unregister_netdev(netdev);
diff --git a/drivers/usb/net/net1080.c b/drivers/usb/net/net1080.c
index cee55f8cf64f..b3799b1a2b0d 100644
--- a/drivers/usb/net/net1080.c
+++ b/drivers/usb/net/net1080.c
@@ -21,9 +21,6 @@
 // #define      VERBOSE                 // more; success messages
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/init.h>
diff --git a/drivers/usb/net/pegasus.c b/drivers/usb/net/pegasus.c
index 537eb181d985..683e3df5d607 100644
--- a/drivers/usb/net/pegasus.c
+++ b/drivers/usb/net/pegasus.c
@@ -28,8 +28,6 @@
 *                      is out of the interrupt routine.
 */
-#undef  DEBUG
 #include <linux/sched.h>
 #include <linux/slab.h>
 #include <linux/init.h>
diff --git a/drivers/usb/net/plusb.c b/drivers/usb/net/plusb.c
index 74c2b3581c76..89856aa0e3b8 100644
--- a/drivers/usb/net/plusb.c
+++ b/drivers/usb/net/plusb.c
@@ -21,9 +21,6 @@
 // #define      VERBOSE                 // more; success messages
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/init.h>
diff --git a/drivers/usb/net/rndis_host.c b/drivers/usb/net/rndis_host.c
index b5a925dc1beb..c0ecbab6f6ba 100644
--- a/drivers/usb/net/rndis_host.c
+++ b/drivers/usb/net/rndis_host.c
@@ -21,9 +21,6 @@
 // #define      VERBOSE                 // more; success messages
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/init.h>
diff --git a/drivers/usb/net/usbnet.c b/drivers/usb/net/usbnet.c
index 74f05c9c84d5..362d6907c9bb 100644
--- a/drivers/usb/net/usbnet.c
+++ b/drivers/usb/net/usbnet.c
@@ -34,9 +34,6 @@
 // #define      VERBOSE                 // more; success messages
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/init.h>
diff --git a/drivers/usb/net/zaurus.c b/drivers/usb/net/zaurus.c
index 5d4b7d55b097..680d13957af4 100644
--- a/drivers/usb/net/zaurus.c
+++ b/drivers/usb/net/zaurus.c
@@ -21,9 +21,6 @@
 // #define      VERBOSE                 // more; success messages
 #include <linux/config.h>
-#ifdef  CONFIG_USB_DEBUG
-#   define DEBUG
-#endif
 #include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/init.h>
diff --git a/drivers/usb/serial/ChangeLog.old b/drivers/usb/serial/ChangeLog.history
index c1b279939bbf..52c4f7bd7a80 100644
--- a/drivers/usb/serial/ChangeLog.old
+++ b/drivers/usb/serial/ChangeLog.history
@@ -400,7 +400,7 @@ visor.c Change Log comments:
 (11/11/2001) gkh
        Added support for the m125 devices, and added check to prevent oopses
-        for Clié devices that lie about the number of ports they have.
+        for Cli� devices that lie about the number of ports they have.
 (08/30/2001) gkh
        Added support for the Clie devices, both the 3.5 and 4.0 os versions.
diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig
index 7b5e8e4ee2bb..14f55fd26a64 100644
--- a/drivers/usb/serial/Kconfig
+++ b/drivers/usb/serial/Kconfig
@@ -62,6 +62,15 @@ config USB_SERIAL_AIRPRIME
          To compile this driver as a module, choose M here: the
          module will be called airprime.
+config USB_SERIAL_ANYDATA
+        tristate "USB AnyData CDMA Wireless Driver"
+        depends on USB_SERIAL
+        help
+          Say Y here if you want to use a AnyData CDMA device.
+          To compile this driver as a module, choose M here: the
+          module will be called anydata.
 config USB_SERIAL_BELKIN
        tristate "USB Belkin and Peracom Single Port Serial Driver"
        depends on USB_SERIAL
@@ -394,15 +403,6 @@ config USB_SERIAL_MCT_U232
          To compile this driver as a module, choose M here: the
          module will be called mct_u232.
-config USB_SERIAL_NOKIA_DKU2
-        tristate "USB Nokia DKU2 Driver"
-        depends on USB_SERIAL
-        help
-          Say Y here if you want to use a Nokia DKU2 device.
-          To compile this driver as a module, choose M here: the
-          module will be called nokia_dku2.
 config USB_SERIAL_PL2303
        tristate "USB Prolific 2303 Single Port Serial Driver"
        depends on USB_SERIAL
diff --git a/drivers/usb/serial/Makefile b/drivers/usb/serial/Makefile
index 55fd461793b7..f0b04420cea1 100644
--- a/drivers/usb/serial/Makefile
+++ b/drivers/usb/serial/Makefile
@@ -12,6 +12,7 @@ usbserial-obj-$(CONFIG_USB_EZUSB)		+= ezusb.o
 usbserial-objs  := usb-serial.o generic.o bus.o $(usbserial-obj-y)
 obj-$(CONFIG_USB_SERIAL_AIRPRIME)               += airprime.o
+obj-$(CONFIG_USB_SERIAL_ANYDATA)                += anydata.o
 obj-$(CONFIG_USB_SERIAL_BELKIN)                 += belkin_sa.o
 obj-$(CONFIG_USB_SERIAL_CP2101)                 += cp2101.o
 obj-$(CONFIG_USB_SERIAL_CYBERJACK)              += cyberjack.o
@@ -31,7 +32,6 @@ obj-$(CONFIG_USB_SERIAL_KEYSPAN_PDA)		+= keyspan_pda.o
 obj-$(CONFIG_USB_SERIAL_KLSI)                   += kl5kusb105.o
 obj-$(CONFIG_USB_SERIAL_KOBIL_SCT)              += kobil_sct.o
 obj-$(CONFIG_USB_SERIAL_MCT_U232)               += mct_u232.o
-obj-$(CONFIG_USB_SERIAL_NOKIA_DKU2)             += nokia_dku2.o
 obj-$(CONFIG_USB_SERIAL_OMNINET)                += omninet.o
 obj-$(CONFIG_USB_SERIAL_OPTION)                 += option.o
 obj-$(CONFIG_USB_SERIAL_PL2303)                 += pl2303.o
diff --git a/drivers/usb/serial/anydata.c b/drivers/usb/serial/anydata.c
new file mode 100644
index 000000000000..18022a74a3dc
--- /dev/null
+++ b/drivers/usb/serial/anydata.c
@@ -0,0 +1,123 @@
+/*
+ * AnyData CDMA Serial USB driver
+ *
+ * Copyright (C) 2005 Greg Kroah-Hartman <gregkh@suse.de>
+ *
+ *      This program is free software; you can redistribute it and/or
+ *      modify it under the terms of the GNU General Public License version
+ *      2 as published by the Free Software Foundation.
+ */
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/tty.h>
+#include <linux/module.h>
+#include <linux/usb.h>
+#include "usb-serial.h"
+static struct usb_device_id id_table [] = {
+        { USB_DEVICE(0x16d5, 0x6501) }, /* AirData CDMA device */
+        { },
+};
+MODULE_DEVICE_TABLE(usb, id_table);
+/* if overridden by the user, then use their value for the size of the
+ * read and write urbs */
+static int buffer_size;
+static int debug;
+static struct usb_driver anydata_driver = {
+        .owner =        THIS_MODULE,
+        .name =         "anydata",
+        .probe =        usb_serial_probe,
+        .disconnect =   usb_serial_disconnect,
+        .id_table =     id_table,
+};
+static int anydata_open(struct usb_serial_port *port, struct file *filp)
+{
+        char *buffer;
+        int result = 0;
+        dbg("%s - port %d", __FUNCTION__, port->number);
+        if (buffer_size) {
+                /* override the default buffer sizes */
+                buffer = kmalloc(buffer_size, GFP_KERNEL);
+                if (!buffer) {
+                        dev_err(&port->dev, "%s - out of memory.\n",
+                                __FUNCTION__);
+                        return -ENOMEM;
+                }
+                kfree (port->read_urb->transfer_buffer);
+                port->read_urb->transfer_buffer = buffer;
+                port->read_urb->transfer_buffer_length = buffer_size;
+                buffer = kmalloc(buffer_size, GFP_KERNEL);
+                if (!buffer) {
+                        dev_err(&port->dev, "%s - out of memory.\n",
+                                __FUNCTION__);
+                        return -ENOMEM;
+                }
+                kfree (port->write_urb->transfer_buffer);
+                port->write_urb->transfer_buffer = buffer;
+                port->write_urb->transfer_buffer_length = buffer_size;
+                port->bulk_out_size = buffer_size;
+        }
+        /* Start reading from the device */
+        usb_fill_bulk_urb(port->read_urb, port->serial->dev,
+                          usb_rcvbulkpipe(port->serial->dev,
+                                          port->bulk_in_endpointAddress),
+                          port->read_urb->transfer_buffer,
+                          port->read_urb->transfer_buffer_length,
+                          usb_serial_generic_write_bulk_callback, port);
+        result = usb_submit_urb(port->read_urb, GFP_KERNEL);
+        if (result)
+                dev_err(&port->dev,
+                        "%s - failed submitting read urb, error %d\n",
+                        __FUNCTION__, result);
+        return result;
+}
+static struct usb_serial_driver anydata_device = {
+        .driver = {
+                .owner =        THIS_MODULE,
+                .name =         "anydata",
+        },
+        .id_table =             id_table,
+        .num_interrupt_in =     NUM_DONT_CARE,
+        .num_bulk_in =          NUM_DONT_CARE,
+        .num_bulk_out =         NUM_DONT_CARE,
+        .num_ports =            1,
+        .open =                 anydata_open,
+};
+static int __init anydata_init(void)
+{
+        int retval;
+        retval = usb_serial_register(&anydata_device);
+        if (retval)
+                return retval;
+        retval = usb_register(&anydata_driver);
+        if (retval)
+                usb_serial_deregister(&anydata_device);
+        return retval;
+}
+static void __exit anydata_exit(void)
+{
+        usb_deregister(&anydata_driver);
+        usb_serial_deregister(&anydata_device);
+}
+module_init(anydata_init);
+module_exit(anydata_exit);
+MODULE_LICENSE("GPL");
+module_param(debug, bool, S_IRUGO | S_IWUSR);
+MODULE_PARM_DESC(debug, "Debug enabled or not");
+module_param(buffer_size, int, 0);
+MODULE_PARM_DESC(buffer_size, "Size of the transfer buffers");
diff --git a/drivers/usb/serial/cp2101.c b/drivers/usb/serial/cp2101.c
index c5334dd89b12..c9787001cf2a 100644
--- a/drivers/usb/serial/cp2101.c
+++ b/drivers/usb/serial/cp2101.c
@@ -60,6 +60,7 @@ static struct usb_device_id id_table [] = {
        { USB_DEVICE(0x10C4, 0x80F6) }, /* Suunto sports instrument */
        { USB_DEVICE(0x10A6, 0xAA26) }, /* Knock-off DCU-11 cable */
        { USB_DEVICE(0x10AB, 0x10C5) }, /* Siemens MC60 Cable */
+        { USB_DEVICE(0x16D6, 0x0001) }, /* Jablotron serial interface */
        { } /* Terminating Entry */
 };
diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
index 8909208f506a..53a47c31cd0e 100644
--- a/drivers/usb/serial/generic.c
+++ b/drivers/usb/serial/generic.c
@@ -309,6 +309,7 @@ void usb_serial_generic_write_bulk_callback (struct urb *urb, struct pt_regs *re
        schedule_work(&port->work);
 }
+EXPORT_SYMBOL_GPL(usb_serial_generic_write_bulk_callback);
 void usb_serial_generic_shutdown (struct usb_serial *serial)
 {
diff --git a/drivers/usb/serial/nokia_dku2.c b/drivers/usb/serial/nokia_dku2.c
deleted file mode 100644
index fad01bef3a64..000000000000
--- a/drivers/usb/serial/nokia_dku2.c
+++ /dev/null
@@ -1,142 +0,0 @@
-/*
- *  Nokia DKU2 USB driver
- *
- *  Copyright (C) 2004
- *  Author: C Kemp
- *
- *  This program is largely derived from work by the linux-usb group
- *  and associated source files.  Please see the usb/serial files for
- *  individual credits and copyrights.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License as published by
- *  the Free Software Foundation; either version 2 of the License, or
- *  (at your option) any later version.
- *
- *  20.09.2005 - Matthias Blaesing <matthias.blaesing@rwth-aachen.de>
- *  Added short name to device structure to make driver load into kernel 2.6.13
- *
- *  20.09.2005 - Matthias Blaesing <matthias.blaesing@rwth-aachen.de>
- *  Added usb_deregister to exit code - to allow remove and reinsert of module
- */
-#include <linux/config.h>
-#include <linux/kernel.h>
-#include <linux/errno.h>
-#include <linux/init.h>
-#include <linux/slab.h>
-#include <linux/tty.h>
-#include <linux/tty_driver.h>
-#include <linux/tty_flip.h>
-#include <linux/module.h>
-#include <linux/usb.h>
-#include "usb-serial.h"
-#define NOKIA_VENDOR_ID         0x0421
-#define NOKIA7600_PRODUCT_ID    0x0400
-#define NOKIA6230_PRODUCT_ID    0x040f
-#define NOKIA6170_PRODUCT_ID    0x0416
-#define NOKIA6670_PRODUCT_ID    0x041d
-#define NOKIA6680_PRODUCT_ID    0x041e
-#define NOKIA6230i_PRODUCT_ID   0x0428
-#define NOKIA_AT_PORT   0x82
-#define NOKIA_FBUS_PORT 0x86
-/*
- * Version Information
- */
-#define DRIVER_VERSION  "v0.2"
-#define DRIVER_AUTHOR   "C Kemp"
-#define DRIVER_DESC     "Nokia DKU2 Driver"
-static struct usb_device_id id_table [] = {
-        { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA7600_PRODUCT_ID) },
-        { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA6230_PRODUCT_ID) },
-        { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA6170_PRODUCT_ID) },
-        { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA6670_PRODUCT_ID) },
-        { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA6680_PRODUCT_ID) },
-        { USB_DEVICE(NOKIA_VENDOR_ID, NOKIA6230i_PRODUCT_ID) },
-        { }                     /* Terminating entry */
-};
-MODULE_DEVICE_TABLE(usb, id_table);
-/* The only thing which makes this device different from a generic
- * device is that we have to set an alternative configuration to make
- * the relevant endpoints available. In 2.6 this is really easy... */
-static int nokia_probe(struct usb_serial *serial,
-                       const struct usb_device_id *id)
-{
-        int retval = -ENODEV;
-        if (serial->interface->altsetting[0].endpoint[0].desc.bEndpointAddress == NOKIA_AT_PORT) {
-                /* the AT port */
-                dev_info(&serial->dev->dev, "Nokia AT Port:\n");
-                retval = 0;
-        } else if (serial->interface->num_altsetting == 2 &&
-                   serial->interface->altsetting[1].endpoint[0].desc.bEndpointAddress == NOKIA_FBUS_PORT) {
-                /* the FBUS port */
-                dev_info(&serial->dev->dev, "Nokia FBUS Port:\n");
-                usb_set_interface(serial->dev, 10, 1);
-                retval = 0;
-        }
-        return retval;
-}
-static struct usb_driver nokia_driver = {
-        .owner =        THIS_MODULE,
-        .name =         "nokia_dku2",
-        .probe =        usb_serial_probe,
-        .disconnect =   usb_serial_disconnect,
-        .id_table =     id_table,
-};
-static struct usb_serial_driver nokia_serial_driver = {
-        .driver = {
-                .owner =        THIS_MODULE,
-                .name =         "nokia_dku2",
-        },
-        .description =          "Nokia 7600/6230(i)/6170/66x0 DKU2 driver",
-        .id_table =             id_table,
-        .num_interrupt_in =     1,
-        .num_bulk_in =          1,
-        .num_bulk_out =         1,
-        .num_ports =            1,
-        .probe =                nokia_probe,
-};
-static int __init nokia_init(void)
-{
-        int retval;
-        retval = usb_serial_register(&nokia_serial_driver);
-        if (retval)
-                return retval;
-        retval = usb_register(&nokia_driver);
-        if (retval) {
-                usb_serial_deregister(&nokia_serial_driver);
-                return retval;
-        }
-        info(DRIVER_VERSION " " DRIVER_AUTHOR);
-        info(DRIVER_DESC);
-        return retval;
-}
-static void __exit nokia_exit(void)
-{
-        usb_deregister(&nokia_driver);
-        usb_serial_deregister(&nokia_serial_driver);
-}
-module_init(nokia_init);
-module_exit(nokia_exit);
-MODULE_AUTHOR(DRIVER_AUTHOR);
-MODULE_DESCRIPTION(DRIVER_DESC);
-MODULE_LICENSE("GPL");
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 165c119bf10e..41a45a5025b2 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -71,7 +71,9 @@ static struct usb_device_id id_table [] = {
        { USB_DEVICE(SITECOM_VENDOR_ID, SITECOM_PRODUCT_ID) },
        { USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_ID) },
        { USB_DEVICE(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_ID) },
+        { USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_SX1) },
        { USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_X65) },
+        { USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_X75) },
        { USB_DEVICE(SYNTECH_VENDOR_ID, SYNTECH_PRODUCT_ID) },
        { USB_DEVICE( NOKIA_CA42_VENDOR_ID, NOKIA_CA42_PRODUCT_ID ) },
        { }                                     /* Terminating entry */
@@ -811,7 +813,9 @@ static void pl2303_update_line_status(struct usb_serial_port *port,
        u8 length = UART_STATE;
        if ((le16_to_cpu(port->serial->dev->descriptor.idVendor) == SIEMENS_VENDOR_ID) &&
-            (le16_to_cpu(port->serial->dev->descriptor.idProduct) == SIEMENS_PRODUCT_ID_X65)) {
+            (le16_to_cpu(port->serial->dev->descriptor.idProduct) == SIEMENS_PRODUCT_ID_X65 ||
+             le16_to_cpu(port->serial->dev->descriptor.idProduct) == SIEMENS_PRODUCT_ID_SX1 ||
+             le16_to_cpu(port->serial->dev->descriptor.idProduct) == SIEMENS_PRODUCT_ID_X75)) {
                length = 1;
                status_idx = 0;
        }
diff --git a/drivers/usb/serial/pl2303.h b/drivers/usb/serial/pl2303.h
index 7be9644f5a03..21d434d81813 100644
--- a/drivers/usb/serial/pl2303.h
+++ b/drivers/usb/serial/pl2303.h
@@ -54,7 +54,9 @@
 #define SAMSUNG_PRODUCT_ID      0x8001
 #define SIEMENS_VENDOR_ID       0x11f5
+#define SIEMENS_PRODUCT_ID_SX1  0x0001
 #define SIEMENS_PRODUCT_ID_X65  0x0003
+#define SIEMENS_PRODUCT_ID_X75  0x0004
 #define SYNTECH_VENDOR_ID       0x0745
 #define SYNTECH_PRODUCT_ID      0x0001
diff --git a/drivers/usb/storage/Kconfig b/drivers/usb/storage/Kconfig
index 1a9679f76f5a..c41d64dbb0f0 100644
--- a/drivers/usb/storage/Kconfig
+++ b/drivers/usb/storage/Kconfig
@@ -115,7 +115,7 @@ config USB_STORAGE_JUMPSHOT
 config USB_STORAGE_ONETOUCH
        bool "Support OneTouch Button on Maxtor Hard Drives (EXPERIMENTAL)"
-        depends on USB_STORAGE && INPUT_EVDEV && EXPERIMENTAL
+        depends on USB_STORAGE && INPUT_EVDEV && EXPERIMENTAL && !PM
        help
          Say Y here to include additional code to support the Maxtor OneTouch
          USB hard drive's onetouch button.
diff --git a/drivers/usb/storage/shuttle_usbat.c b/drivers/usb/storage/shuttle_usbat.c
index 33c55a6261bb..fea176d7e79a 100644
--- a/drivers/usb/storage/shuttle_usbat.c
+++ b/drivers/usb/storage/shuttle_usbat.c
@@ -853,7 +853,7 @@ static int usbat_identify_device(struct us_data *us,
        rc = usbat_device_reset(us);
        if (rc != USB_STOR_TRANSPORT_GOOD)
                return rc;
-        msleep(25);
+        msleep(500);
        /*
         * In attempt to distinguish between HP CDRW's and Flash readers, we now
diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 9e926a8f2116..0a9858f69a9b 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -710,11 +710,6 @@ UNUSUAL_DEV(  0x0686, 0x4017, 0x0001, 0x0001,
                "DIMAGE E223",
                US_SC_SCSI, US_PR_DEVICE, NULL, 0 ),
-UNUSUAL_DEV(  0x0693, 0x0002, 0x0100, 0x0100, 
-                "Hagiwara",
-                "FlashGate SmartMedia",
-                US_SC_SCSI, US_PR_BULK, NULL, 0 ),
 UNUSUAL_DEV(  0x0693, 0x0005, 0x0100, 0x0100,
                "Hagiwara",
                "Flashgate",
@@ -1008,6 +1003,11 @@ UNUSUAL_DEV( 0x0c0b, 0xa109, 0x0000, 0xffff,
 *
 */
 #ifdef CONFIG_USB_STORAGE_ONETOUCH
+        UNUSUAL_DEV(  0x0d49, 0x7000, 0x0000, 0x9999,
+                        "Maxtor",
+                        "OneTouch External Harddrive",
+                        US_SC_DEVICE, US_PR_DEVICE, onetouch_connect_input,
+                        0),
        UNUSUAL_DEV(  0x0d49, 0x7010, 0x0000, 0x9999,
                        "Maxtor",
                        "OneTouch External Harddrive",
diff --git a/drivers/video/offb.c b/drivers/video/offb.c
index 2c856838694e..00d87f5bb7be 100644
--- a/drivers/video/offb.c
+++ b/drivers/video/offb.c
@@ -26,6 +26,7 @@
 #include <linux/fb.h>
 #include <linux/init.h>
 #include <linux/ioport.h>
+#include <linux/pci.h>
 #include <asm/io.h>
 #include <asm/prom.h>
@@ -325,8 +326,8 @@ static void __init offb_init_nodriver(struct device_node *dp)
        int *pp, i;
        unsigned int len;
        int width = 640, height = 480, depth = 8, pitch;
-        unsigned *up;
+        unsigned int rsize, *up;
-        unsigned long address;
+        unsigned long address = 0;
        if ((pp = (int *) get_property(dp, "depth", &len)) != NULL
            && len == sizeof(int))
@@ -344,10 +345,40 @@ static void __init offb_init_nodriver(struct device_node *dp)
                        pitch = 0x1000;
        } else
                pitch = width;
-        if ((up = (unsigned *) get_property(dp, "address", &len)) != NULL
-            && len == sizeof(unsigned))
+       rsize = (unsigned long)pitch * (unsigned long)height *
+               (unsigned long)(depth / 8);
+       /* Try to match device to a PCI device in order to get a properly
+        * translated address rather then trying to decode the open firmware
+        * stuff in various incorrect ways
+        */
+#ifdef CONFIG_PCI
+       /* First try to locate the PCI device if any */
+       {
+               struct pci_dev *pdev = NULL;
+               for_each_pci_dev(pdev) {
+                       if (dp == pci_device_to_OF_node(pdev))
+                               break;
+               }
+               if (pdev) {
+                       for (i = 0; i < 6 && address == 0; i++) {
+                               if ((pci_resource_flags(pdev, i) &
+                                    IORESOURCE_MEM) &&
+                                   (pci_resource_len(pdev, i) >= rsize))
+                                       address = pci_resource_start(pdev, i);
+                       }
+                       pci_dev_put(pdev);
+               }
+        }
+#endif /* CONFIG_PCI */
+        if (address == 0 &&
+            (up = (unsigned *) get_property(dp, "address", &len)) != NULL &&
+            len == sizeof(unsigned))
                address = (u_long) * up;
-        else {
+        if (address == 0) {
                for (i = 0; i < dp->n_addrs; ++i)
                        if (dp->addrs[i].size >=
                            pitch * height * depth / 8)
author	Dave Jones <davej@redhat.com>	2005-11-21 09:56:52 -0500
committer	Dave Jones <davej@redhat.com>	2005-11-21 09:56:52 -0500
commit	e7e37ee9c547213d726b29c2510cbb6696050405 (patch)
tree	50c45625de666b23f209d79eb1bfae05c64feee9 /drivers
parent	c243f1f1f6545985afcc6adf1fc085729029c3ee (diff)
parent	db93a82fa9d8b4d6e31c227922eaae829253bb88 (diff)