aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-09-18 12:09:00 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-09-18 12:09:00 -0400
commitf378dfe4bef8d77dbd420a12bd75fd09395bc3d8 (patch)
tree4c0fdb37b4f692a723116a3c052133222e4c3d30 /drivers
parent93ba0f037bfc7d6c6431c0db767f2244ac583578 (diff)
USB: serial: ti_usb_3410_5052: fix up noisy printk() usage
The driver should not be sending any printk() messages when it is loaded, as no other USB serial driver does. This fixes that, and also removes the useless version number from the driver. Cc: Johan Hovold <jhovold@gmail.com> Cc: Rusty Russell <rusty@rustcorp.com.au> Cc: Adhir Ramjiawan <adhirramjiawan0@gmail.com> Cc: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/usb/serial/ti_usb_3410_5052.c9
1 files changed, 1 insertions, 8 deletions
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
index e6f492d3d366..648249e74125 100644
--- a/drivers/usb/serial/ti_usb_3410_5052.c
+++ b/drivers/usb/serial/ti_usb_3410_5052.c
@@ -40,7 +40,6 @@
40 40
41/* Defines */ 41/* Defines */
42 42
43#define TI_DRIVER_VERSION "v0.10"
44#define TI_DRIVER_AUTHOR "Al Borchers <alborchers@steinerpoint.com>" 43#define TI_DRIVER_AUTHOR "Al Borchers <alborchers@steinerpoint.com>"
45#define TI_DRIVER_DESC "TI USB 3410/5052 Serial Driver" 44#define TI_DRIVER_DESC "TI USB 3410/5052 Serial Driver"
46 45
@@ -276,7 +275,6 @@ static struct usb_serial_driver * const serial_drivers[] = {
276 275
277MODULE_AUTHOR(TI_DRIVER_AUTHOR); 276MODULE_AUTHOR(TI_DRIVER_AUTHOR);
278MODULE_DESCRIPTION(TI_DRIVER_DESC); 277MODULE_DESCRIPTION(TI_DRIVER_DESC);
279MODULE_VERSION(TI_DRIVER_VERSION);
280MODULE_LICENSE("GPL"); 278MODULE_LICENSE("GPL");
281 279
282MODULE_FIRMWARE("ti_3410.fw"); 280MODULE_FIRMWARE("ti_3410.fw");
@@ -312,7 +310,6 @@ MODULE_DEVICE_TABLE(usb, ti_id_table_combined);
312static int __init ti_init(void) 310static int __init ti_init(void)
313{ 311{
314 int i, j, c; 312 int i, j, c;
315 int ret;
316 313
317 /* insert extra vendor and product ids */ 314 /* insert extra vendor and product ids */
318 c = ARRAY_SIZE(ti_id_table_combined) - 2 * TI_EXTRA_VID_PID_COUNT - 1; 315 c = ARRAY_SIZE(ti_id_table_combined) - 2 * TI_EXTRA_VID_PID_COUNT - 1;
@@ -335,11 +332,7 @@ static int __init ti_init(void)
335 ti_id_table_combined[c].match_flags = USB_DEVICE_ID_MATCH_DEVICE; 332 ti_id_table_combined[c].match_flags = USB_DEVICE_ID_MATCH_DEVICE;
336 } 333 }
337 334
338 ret = usb_serial_register_drivers(serial_drivers, KBUILD_MODNAME, ti_id_table_combined); 335 return usb_serial_register_drivers(serial_drivers, KBUILD_MODNAME, ti_id_table_combined);
339 if (ret == 0)
340 printk(KERN_INFO KBUILD_MODNAME ": " TI_DRIVER_VERSION ":"
341 TI_DRIVER_DESC "\n");
342 return ret;
343} 336}
344 337
345static void __exit ti_exit(void) 338static void __exit ti_exit(void)