diff options
author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2012-09-21 01:57:31 -0400 |
---|---|---|
committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-09-22 19:29:52 -0400 |
commit | b659f4b4ff52b14dcef4848e3f434b3582842960 (patch) | |
tree | 2cec6d6a4da99e2dbd572432ee4c0386544fb504 /drivers | |
parent | e4b11b89f9039ca97b2ed1b6efeb6749fbdeb252 (diff) |
sbp-target: fix return value check in sbp_register_configfs()
In case of error, the function target_fabric_configfs_init() returns
ERR_PTR() not NULL pointer. The NULL test in the return value check
should be replaced with IS_ERR().
dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/target/sbp/sbp_target.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c index 0ce44cd3488e..0d6d7c1f025e 100644 --- a/drivers/target/sbp/sbp_target.c +++ b/drivers/target/sbp/sbp_target.c | |||
@@ -2543,9 +2543,9 @@ static int sbp_register_configfs(void) | |||
2543 | int ret; | 2543 | int ret; |
2544 | 2544 | ||
2545 | fabric = target_fabric_configfs_init(THIS_MODULE, "sbp"); | 2545 | fabric = target_fabric_configfs_init(THIS_MODULE, "sbp"); |
2546 | if (!fabric) { | 2546 | if (IS_ERR(fabric)) { |
2547 | pr_err("target_fabric_configfs_init() failed\n"); | 2547 | pr_err("target_fabric_configfs_init() failed\n"); |
2548 | return -ENOMEM; | 2548 | return PTR_ERR(fabric); |
2549 | } | 2549 | } |
2550 | 2550 | ||
2551 | fabric->tf_ops = sbp_ops; | 2551 | fabric->tf_ops = sbp_ops; |