diff options
author | Ben Collins <bcollins@ubuntu.com> | 2006-06-12 18:13:11 -0400 |
---|---|---|
committer | Ben Collins <bcollins@ubuntu.com> | 2006-06-12 18:13:11 -0400 |
commit | 20f4578156995e95613497baf16d5b2d54921e5d (patch) | |
tree | 65e6431950cda92aa16bd587c5a05d5acbc7beff /drivers | |
parent | fe42b05a9929e159355bde6025ae46db2ac88658 (diff) |
sbp2: log number of supported concurrent logins
Since this is useful information, promote it from a debug macro to
a regular log message. The message appears only if the user set
exclusive_login=0, therefore won't clutter the logs in normal use.
Also update the comment on exclusive_login.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Jody McIntyre <scjody@modernduck.com>
Signed-off-by: Ben Collins <bcollins@ubuntu.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/ieee1394/sbp2.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c index 11c353a4653b..18996efdf1a3 100644 --- a/drivers/ieee1394/sbp2.c +++ b/drivers/ieee1394/sbp2.c | |||
@@ -127,10 +127,12 @@ MODULE_PARM_DESC(max_sectors, "Change max sectors per I/O supported (default = " | |||
127 | * talking to a single sbp2 device at the same time (filesystem coherency, | 127 | * talking to a single sbp2 device at the same time (filesystem coherency, |
128 | * etc.). If you're running an sbp2 device that supports multiple logins, | 128 | * etc.). If you're running an sbp2 device that supports multiple logins, |
129 | * and you're either running read-only filesystems or some sort of special | 129 | * and you're either running read-only filesystems or some sort of special |
130 | * filesystem supporting multiple hosts (one such filesystem is OpenGFS, | 130 | * filesystem supporting multiple hosts, e.g. OpenGFS, Oracle Cluster |
131 | * see opengfs.sourceforge.net for more info), then set exclusive_login | 131 | * File System, or Lustre, then set exclusive_login to zero. |
132 | * to zero. Note: The Oxsemi OXFW911 sbp2 chipset supports up to four | 132 | * |
133 | * concurrent logins. | 133 | * So far only bridges from Oxford Semiconductor are known to support |
134 | * concurrent logins. Depending on firmware, four or two concurrent logins | ||
135 | * are possible on OXFW911 and newer Oxsemi bridges. | ||
134 | */ | 136 | */ |
135 | static int exclusive_login = 1; | 137 | static int exclusive_login = 1; |
136 | module_param(exclusive_login, int, 0644); | 138 | module_param(exclusive_login, int, 0644); |
@@ -1214,13 +1216,11 @@ static int sbp2_query_logins(struct scsi_id_instance_data *scsi_id) | |||
1214 | SBP2_DEBUG("length_max_logins = %x", | 1216 | SBP2_DEBUG("length_max_logins = %x", |
1215 | (unsigned int)scsi_id->query_logins_response->length_max_logins); | 1217 | (unsigned int)scsi_id->query_logins_response->length_max_logins); |
1216 | 1218 | ||
1217 | SBP2_DEBUG("Query logins to SBP-2 device successful"); | ||
1218 | |||
1219 | max_logins = RESPONSE_GET_MAX_LOGINS(scsi_id->query_logins_response->length_max_logins); | 1219 | max_logins = RESPONSE_GET_MAX_LOGINS(scsi_id->query_logins_response->length_max_logins); |
1220 | SBP2_DEBUG("Maximum concurrent logins supported: %d", max_logins); | 1220 | SBP2_INFO("Maximum concurrent logins supported: %d", max_logins); |
1221 | 1221 | ||
1222 | active_logins = RESPONSE_GET_ACTIVE_LOGINS(scsi_id->query_logins_response->length_max_logins); | 1222 | active_logins = RESPONSE_GET_ACTIVE_LOGINS(scsi_id->query_logins_response->length_max_logins); |
1223 | SBP2_DEBUG("Number of active logins: %d", active_logins); | 1223 | SBP2_INFO("Number of active logins: %d", active_logins); |
1224 | 1224 | ||
1225 | if (active_logins >= max_logins) { | 1225 | if (active_logins >= max_logins) { |
1226 | return -EIO; | 1226 | return -EIO; |