diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2009-03-31 15:05:31 -0400 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2009-03-30 22:35:32 -0400 |
commit | a6e6abd575fcbe6572ebc7a70ad616406d206fa8 (patch) | |
tree | 3909d2be063116936179bb4da85d5cb4aed32ce6 /drivers | |
parent | e610499e2656e61975affd0af56b26eb73964c84 (diff) |
module: remove module_text_address()
Impact: Replace and remove risky (non-EXPORTed) API
module_text_address() returns a pointer to the module, which given locking
improvements in module.c, is useless except to test for NULL:
1) If the module can't go away, use __module_text_address.
2) Otherwise, just use is_module_text_address().
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/mtd/nand/nand_base.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index 0c3afccde8a2..5f71371eb1b0 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c | |||
@@ -2720,14 +2720,14 @@ int nand_scan_tail(struct mtd_info *mtd) | |||
2720 | return chip->scan_bbt(mtd); | 2720 | return chip->scan_bbt(mtd); |
2721 | } | 2721 | } |
2722 | 2722 | ||
2723 | /* module_text_address() isn't exported, and it's mostly a pointless | 2723 | /* is_module_text_address() isn't exported, and it's mostly a pointless |
2724 | test if this is a module _anyway_ -- they'd have to try _really_ hard | 2724 | test if this is a module _anyway_ -- they'd have to try _really_ hard |
2725 | to call us from in-kernel code if the core NAND support is modular. */ | 2725 | to call us from in-kernel code if the core NAND support is modular. */ |
2726 | #ifdef MODULE | 2726 | #ifdef MODULE |
2727 | #define caller_is_module() (1) | 2727 | #define caller_is_module() (1) |
2728 | #else | 2728 | #else |
2729 | #define caller_is_module() \ | 2729 | #define caller_is_module() \ |
2730 | module_text_address((unsigned long)__builtin_return_address(0)) | 2730 | is_module_text_address((unsigned long)__builtin_return_address(0)) |
2731 | #endif | 2731 | #endif |
2732 | 2732 | ||
2733 | /** | 2733 | /** |