aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>2010-09-08 22:47:49 -0400
committerMark Brown <broonie@opensource.wolfsonmicro.com>2010-09-10 11:07:40 -0400
commitf4363b7d88e99497e4241397efee09b106d802c4 (patch)
tree668a3b3cebc4b4efe9e6b89a28993d1ee2acfe13 /drivers
parent5fbdedf072500859601705fa6f07a9e895d5e3a8 (diff)
fbdev: sh_mobile_hdmi: modify noisy comment out
This patch solve below report from Guennadi 1) > - hdmi_write(hdmi, 0x00, HDMI_AUDIO_SETTING_1); > + switch (pdata->flags & HDMI_SRC_MASK) { > + default: > + /* FALL THROUGH */ I'm not sure I like the capitalisation here - no reason to shout;) 2) > +/************************************************************************ > + > + > + HDMI sound > + > + > +************************************************************************/ I don't think this comment deserves 7 lines of text, besides breaking the multiline comment style. If you think, one line like /* HDMI sound */ is not enough how about just /* * HDMI sound */ 3) > +/************************************************************************ > + > + > + HDMI video > + > + > +************************************************************************/ See above - 7 lines seem to be an overkill to me. Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/video/sh_mobile_hdmi.c21
1 files changed, 7 insertions, 14 deletions
diff --git a/drivers/video/sh_mobile_hdmi.c b/drivers/video/sh_mobile_hdmi.c
index 16187d66255c..0acd850f73b5 100644
--- a/drivers/video/sh_mobile_hdmi.c
+++ b/drivers/video/sh_mobile_hdmi.c
@@ -224,13 +224,9 @@ static u8 hdmi_read(struct sh_hdmi *hdmi, u8 reg)
224 return ioread8(hdmi->base + reg); 224 return ioread8(hdmi->base + reg);
225} 225}
226 226
227/************************************************************************ 227/*
228 228 * HDMI sound
229 229 */
230 HDMI sound
231
232
233************************************************************************/
234static unsigned int sh_hdmi_snd_read(struct snd_soc_codec *codec, 230static unsigned int sh_hdmi_snd_read(struct snd_soc_codec *codec,
235 unsigned int reg) 231 unsigned int reg)
236{ 232{
@@ -273,13 +269,10 @@ static struct snd_soc_codec_driver soc_codec_dev_sh_hdmi = {
273 .write = sh_hdmi_snd_write, 269 .write = sh_hdmi_snd_write,
274}; 270};
275 271
276/************************************************************************ 272/*
277 273 * HDMI video
278 274 */
279 HDMI video
280
281 275
282************************************************************************/
283/* External video parameter settings */ 276/* External video parameter settings */
284static void hdmi_external_video_param(struct sh_hdmi *hdmi) 277static void hdmi_external_video_param(struct sh_hdmi *hdmi)
285{ 278{
@@ -398,7 +391,7 @@ static void sh_hdmi_audio_config(struct sh_hdmi *hdmi)
398 */ 391 */
399 switch (pdata->flags & HDMI_SRC_MASK) { 392 switch (pdata->flags & HDMI_SRC_MASK) {
400 default: 393 default:
401 /* FALL THROUGH */ 394 /* fall through */
402 case HDMI_SRC_I2S: 395 case HDMI_SRC_I2S:
403 data = (0x0 << 3); 396 data = (0x0 << 3);
404 break; 397 break;