diff options
author | Selvan Mani <smani@micron.com> | 2012-11-07 08:03:53 -0500 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2012-11-23 08:32:55 -0500 |
commit | eda45314922f500f3547d36d317efc05ed823e3e (patch) | |
tree | 8486c7d169c4166511cae5b39abe6191016cfeef /drivers | |
parent | 3208795e612406df04a32b46eb5ea5fccfa51d69 (diff) |
mtip32xx: Fix to make lba address correct in big-endian systems
Earlier lba address was assigned directly to lba_low and lba_low_ex,
which would result in a different number (bytes reversed) in
big-endian systems. Now assigning lba address byte-by-byte to fis.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Selvan Mani <smani@micron.com>
Signed-off-by: Asai Thambi S P <asamymuthupa@micron.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/block/mtip32xx/mtip32xx.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c index dfb7196bbde9..df46b5a3f56f 100644 --- a/drivers/block/mtip32xx/mtip32xx.c +++ b/drivers/block/mtip32xx/mtip32xx.c | |||
@@ -2465,8 +2465,12 @@ static void mtip_hw_submit_io(struct driver_data *dd, sector_t start, | |||
2465 | fis->opts = 1 << 7; | 2465 | fis->opts = 1 << 7; |
2466 | fis->command = | 2466 | fis->command = |
2467 | (dir == READ ? ATA_CMD_FPDMA_READ : ATA_CMD_FPDMA_WRITE); | 2467 | (dir == READ ? ATA_CMD_FPDMA_READ : ATA_CMD_FPDMA_WRITE); |
2468 | *((unsigned int *) &fis->lba_low) = (start & 0xFFFFFF); | 2468 | fis->lba_low = start & 0xFF; |
2469 | *((unsigned int *) &fis->lba_low_ex) = ((start >> 24) & 0xFFFFFF); | 2469 | fis->lba_mid = (start >> 8) & 0xFF; |
2470 | fis->lba_hi = (start >> 16) & 0xFF; | ||
2471 | fis->lba_low_ex = (start >> 24) & 0xFF; | ||
2472 | fis->lba_mid_ex = (start >> 32) & 0xFF; | ||
2473 | fis->lba_hi_ex = (start >> 40) & 0xFF; | ||
2470 | fis->device = 1 << 6; | 2474 | fis->device = 1 << 6; |
2471 | fis->features = nsect & 0xFF; | 2475 | fis->features = nsect & 0xFF; |
2472 | fis->features_ex = (nsect >> 8) & 0xFF; | 2476 | fis->features_ex = (nsect >> 8) & 0xFF; |